November 2022 - U-Boot

[PATCH] usb: Add 1ms delay after first Get Descriptor request
by Marek Vasut 03 Nov '22

03 Nov '22

Logitech Unifying Receiver 046d:c52b bcdDevice 12.10 seems sensitive about the first Get Descriptor request. If there are any other requests in the same microframe, the device reports bogus data, first of the descriptor parts is not sent to the host. Wait over one microframe duration before issuing subsequent requests to avoid probe failure with this device, since it can be used to connect USB keyboards. Signed-off-by: Marek Vasut <marex(a)denx.de> --- Cc: Janne Grunau <j(a)jannau.net> Cc: Mark Kettenis <kettenis(a)openbsd.org> --- common/usb.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/common/usb.c b/common/usb.c index 6fcf1e8428e..ae9253dfc0e 100644 --- a/common/usb.c +++ b/common/usb.c @@ -999,6 +999,17 @@ static int usb_setup_descriptor(struct usb_device *dev, bool do_read) err = get_descriptor_len(dev, 64, 8); if (err) return err; + + /* + * Logitech Unifying Receiver 046d:c52b bcdDevice 12.10 seems + * sensitive about the first Get Descriptor request. If there + * are any other requests in the same microframe, the device + * reports bogus data, first of the descriptor parts is not + * sent to the host. Wait over one microframe duration here + * (1mS for USB 1.x , 125uS for USB 2.0) to avoid triggering + * the issue. + */ + mdelay(1); } dev->epmaxpacketin[0] = dev->descriptor.bMaxPacketSize0; -- 2.35.1

3 4

[PATCH v2 0/4] cmd: source: Support specifying config name
by Sean Anderson 03 Nov '22

03 Nov '22

This series adds support for using configs with the source command. See the third patch for details. Changes in v2: - Add test for source command Sean Anderson (4): test: Add test for source command treewide: Use NULL for script image name cmd: source: Clean up a few lines cmd: source: Support specifying config name .../cmd_stm32prog/cmd_stm32prog.c | 2 +- boot/bootmeth_script.c | 2 +- cmd/source.c | 83 +++++++++++++------ doc/uImage.FIT/source_file_format.txt | 3 + drivers/usb/gadget/f_sdp.c | 2 +- include/image.h | 19 +++-- test/py/tests/source.its | 43 ++++++++++ test/py/tests/test_source.py | 37 +++++++++ 8 files changed, 156 insertions(+), 35 deletions(-) create mode 100644 test/py/tests/source.its create mode 100644 test/py/tests/test_source.py -- 2.35.1.1320.gc452695387.dirty

4 15

[PATCH] docs: Add a basic security document
by Tom Rini 03 Nov '22

03 Nov '22

Based loosely on the Linux kernel Documentation/admin-guide/security-bugs.rst file, create a basic security document for U-Boot. In sum, security issues should be disclosed in public on the mailing list if at all possible as an initial position. Signed-off-by: Tom Rini <trini(a)konsulko.com> --- doc/develop/index.rst | 1 + doc/develop/security.rst | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+) create mode 100644 doc/develop/security.rst diff --git a/doc/develop/index.rst b/doc/develop/index.rst index 5934d9ffb115..04322efe59fd 100644 --- a/doc/develop/index.rst +++ b/doc/develop/index.rst @@ -15,6 +15,7 @@ General process release_cycle system_configuration + security sending_patches Implementation diff --git a/doc/develop/security.rst b/doc/develop/security.rst new file mode 100644 index 000000000000..84b130646f31 --- /dev/null +++ b/doc/develop/security.rst @@ -0,0 +1,32 @@ +.. SPDX-License-Identifier: GPL-2.0+: + +Handling of security vulnerabilities +==================================== + +The U-Boot project takes security very seriously. As such, we'd like to know +when a security bug is found so that it can be fixed and disclosed as quickly +as possible. + +Contact +------- + +The preferred initial point of contact is to send email to +`u-boot(a)lists.denx.de` and use `scripts/get_maintainers.pl` to also include any +relevant custodians. In addition, Tom Rini should be contacted at +`trini(a)konsulko.com`. + +CVE assignment +-------------- + +The U-Boot project cannot directly assign CVEs, nor do we require them for +reports or fixes, as this can needlessly complicate the process and may delay +the bug handling. If a reporter wishes to have a CVE identifier assigned ahead +of public disclosure, they will need to coordinate this on their own. When +such a CVE identifier is known before a patch is provided, it is desirable to +mention it in the commit message if the reporter agrees. + +Non-disclosure agreements +------------------------- + +The U-Boot project is not a formal body and therefore unable to enter any +non-disclosure agreements. -- 2.25.1

3 3

[PATCH 00/24] bootstd: Add a boot menu
by Simon Glass 03 Nov '22

03 Nov '22

So far standard boot lacks a boot menu, although it is possible to create a rudimentary one using the existing 'bootmenu' command. Even then, this text-based menu offer only basic functionality and does not take full advantage of the displays which are common on many devices. This series provides a 'bootflow menu' command which allows the user to select from the available bootflows. An attempt is made to show the name of the available operating systems, by reading more information into the bootflow. A logo can be read also, where supported, so that this can be presented to the user when an option is highlighted. Full use is made of TrueType fonts, if enabled. For cases where only a serial console is available, it falls back to a simple text-based menu. All of this is implementing using a new 'expo' construct, a collection of scenes (like menu screens) which can be navigated by the user to view information and select option. This is fairly general and should be able to cope with a wider array of use cases, with less hacking of the menu code, such as is currently needed for CMD_BOOTEFI_BOOTMGR. Of course it would be possible to enhance the existing menu rather than creating a new setup. Instead it seems better to make the existing menu use expo, if code space permits. It avoids the event-loop problem and should be more extensible, given its loosely coupled components and use of IDs instead of pointers. Further motivation is provided in the documentation. For now the CLI keypress-decoding code is split out to be used by the new menu. The key codes defined by menu.h are reused also. This is of course just a starting point. Some ideas for future work are included in the documentation. Simon Glass (24): sandbox: Enable mmc command and legacy images cli: Move readline character-processing to a state machine bootmenu: Add a few comments menu: Rename KEY_... to BKEY_... menu: Update bootmenu_autoboot_loop() to return the code menu: Update bootmenu_loop() to return the code menu: Use a switch statement menu: Make use of CLI character processing image: Add a function to find a script in an image video: Enable VIDEO_ANSI by default only with EFI video: truetype: Rename the metrics function video: Fix unchnaged typo video: Add font functions to the vidconsole API bootstd: Read the Operating System name for distro/scripts bootstd: Allow reading a logo for the OS menu: Factor out menu-keypress decoding expo: Add basic implementation expo: Add support for scenes expo: Add support for scene menus expo: Add basic tests bootstd: Support creating a boot menu bootstd: Add a test for the bootstd menu bootstd: Support setting a theme for the menu expo: Add documentation arch/sandbox/dts/test.dts | 11 + boot/Kconfig | 12 + boot/Makefile | 3 + boot/bootflow.c | 1 + boot/bootflow_internal.h | 37 ++ boot/bootflow_menu.c | 281 ++++++++++++++ boot/bootmeth-uclass.c | 69 +++- boot/bootmeth_distro.c | 36 ++ boot/bootmeth_script.c | 38 ++ boot/bootstd-uclass.c | 2 + boot/expo.c | 133 +++++++ boot/scene.c | 385 +++++++++++++++++++ boot/scene_internal.h | 123 ++++++ boot/scene_menu.c | 372 ++++++++++++++++++ cmd/bootflow.c | 44 ++- cmd/bootmenu.c | 19 +- cmd/eficonfig.c | 38 +- cmd/font.c | 6 +- cmd/source.c | 173 +++++---- common/Makefile | 6 +- common/cli_getch.c | 208 ++++++++++ common/cli_readline.c | 150 ++------ common/menu.c | 157 ++++---- configs/sandbox_defconfig | 2 + configs/sandbox_flattree_defconfig | 2 + configs/snow_defconfig | 4 + configs/tools-only_defconfig | 2 + doc/develop/expo.rst | 184 +++++++++ doc/develop/index.rst | 1 + drivers/video/Kconfig | 7 +- drivers/video/console_truetype.c | 35 +- drivers/video/vidconsole-uclass.c | 33 ++ include/bootflow.h | 40 ++ include/bootmeth.h | 16 + include/bootstd.h | 4 + include/cli.h | 74 ++++ include/expo.h | 474 +++++++++++++++++++++++ include/image.h | 13 + include/menu.h | 77 +++- include/video.h | 2 +- include/video_console.h | 63 ++- test/boot/Makefile | 2 + test/boot/bootflow.c | 130 +++++++ test/boot/expo.c | 510 +++++++++++++++++++++++++ test/py/tests/bootstd/armbian.bmp.xz | Bin 0 -> 1384 bytes test/py/tests/bootstd/mmc4.img.xz | Bin 0 -> 7072 bytes test/py/tests/test_android/test_avb.py | 2 + test/py/tests/test_ut.py | 216 ++++++++++- 48 files changed, 3813 insertions(+), 384 deletions(-) create mode 100644 boot/bootflow_internal.h create mode 100644 boot/bootflow_menu.c create mode 100644 boot/expo.c create mode 100644 boot/scene.c create mode 100644 boot/scene_internal.h create mode 100644 boot/scene_menu.c create mode 100644 common/cli_getch.c create mode 100644 doc/develop/expo.rst create mode 100644 include/expo.h create mode 100644 test/boot/expo.c create mode 100644 test/py/tests/bootstd/armbian.bmp.xz create mode 100644 test/py/tests/bootstd/mmc4.img.xz -- 2.38.0.413.g74048e4d9e-goog

2 41

[PATCH] led: led_pwm: typo 'iverted' on code comment
by Nylon Chen 03 Nov '22

03 Nov '22

change iverted to inverted. Signed-off-by: Nylon Chen <nylon.chen(a)sifive.com> --- drivers/led/led_pwm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/led/led_pwm.c b/drivers/led/led_pwm.c index 0ebae358eb..7c8eae9337 100644 --- a/drivers/led/led_pwm.c +++ b/drivers/led/led_pwm.c @@ -123,7 +123,7 @@ static int led_pwm_of_to_plat(struct udevice *dev) priv->enabled = !!def_brightness; /* - * No need to handle pwm iverted case (active_low) + * No need to handle pwm inverted case (active_low) * because of pwm_set_invert function */ if (def_brightness < max_brightness) -- 2.36.1

2 1

[PATCH 0/4] configs: evb-ast2500: defconfig adjustments
by Cédric Le Goater 03 Nov '22

03 Nov '22

Hello, Here are small adjustments to the evb-ast2500 defconfig to match the flash layout of openbmc/upstream Linux. With these, one can boot a system from a flash image containing an upstream U-Boot, an upstream kernel and an upstream buildroot using the default configs provided by each component. Thanks, C. Cédric Le Goater (4): configs: evb-ast2500: Remove MMC support from default settings configs: evb-ast2500: Adjust boot command configs: evb-ast2500: Add support for FIT format configs: evb-ast2500: Set environment in SPI flash configs/evb-ast2500_defconfig | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) -- 2.37.3

3 13

[PATCH] treewide: Remove the unnecessary space before semicolon
by Bin Meng 03 Nov '22

03 Nov '22

%s/return ;/return; Signed-off-by: Bin Meng <bmeng(a)tinylab.org> --- arch/powerpc/cpu/mpc85xx/cpu_init.c | 2 +- arch/powerpc/cpu/mpc85xx/cpu_init_early.c | 2 +- arch/powerpc/cpu/mpc85xx/fdt.c | 6 +++--- arch/powerpc/cpu/mpc85xx/liodn.c | 4 ++-- arch/powerpc/cpu/mpc85xx/mpc8548_serdes.c | 2 +- arch/powerpc/cpu/mpc85xx/portals.c | 8 ++++---- arch/powerpc/cpu/mpc85xx/tlb.c | 2 +- arch/powerpc/cpu/mpc8xxx/fdt.c | 2 +- arch/powerpc/cpu/mpc8xxx/law.c | 2 +- arch/powerpc/lib/bootm.c | 4 ++-- board/ti/evm/evm.c | 2 +- drivers/ddr/fsl/util.c | 2 +- drivers/net/fm/init.c | 4 ++-- 13 files changed, 21 insertions(+), 21 deletions(-) diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init.c b/arch/powerpc/cpu/mpc85xx/cpu_init.c index 92a7e608ce..90f024d0a7 100644 --- a/arch/powerpc/cpu/mpc85xx/cpu_init.c +++ b/arch/powerpc/cpu/mpc85xx/cpu_init.c @@ -446,7 +446,7 @@ ulong cpu_init_f(void) /* Implement a dummy function for those platforms w/o SERDES */ static void __fsl_serdes__init(void) { - return ; + return; } __attribute__((weak, alias("__fsl_serdes__init"))) void fsl_serdes_init(void); diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c index 1bba216371..e6347cfd2d 100644 --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c @@ -76,7 +76,7 @@ void setup_ifc(void) ifc_out32(&(ifc_regs.gregs->csor_cs[0].csor), CONFIG_SYS_CSOR0); ifc_out32(&(ifc_regs.gregs->amask_cs[0].amask), CONFIG_SYS_AMASK0); - return ; + return; } #endif diff --git a/arch/powerpc/cpu/mpc85xx/fdt.c b/arch/powerpc/cpu/mpc85xx/fdt.c index c8ad6a1b01..61d8aa7f4c 100644 --- a/arch/powerpc/cpu/mpc85xx/fdt.c +++ b/arch/powerpc/cpu/mpc85xx/fdt.c @@ -271,13 +271,13 @@ static inline void ft_fixup_l2cache(void *blob) if (ph == NULL) { debug("no next-level-cache property\n"); - return ; + return; } off = fdt_node_offset_by_phandle(blob, *ph); if (off < 0) { printf("%s: %s\n", __func__, fdt_strerror(off)); - return ; + return; } ft_fixup_l2cache_compatible(blob, off); @@ -373,7 +373,7 @@ next: l3_off = fdt_node_offset_by_phandle(blob, l3_off); if (l3_off < 0) { printf("%s: %s\n", __func__, fdt_strerror(off)); - return ; + return; } ft_fixup_l3cache(blob, l3_off); } diff --git a/arch/powerpc/cpu/mpc85xx/liodn.c b/arch/powerpc/cpu/mpc85xx/liodn.c index a084002494..34974c92bd 100644 --- a/arch/powerpc/cpu/mpc85xx/liodn.c +++ b/arch/powerpc/cpu/mpc85xx/liodn.c @@ -111,7 +111,7 @@ static void setup_fman_liodn_base(enum fsl_dpaa_dev dev, #endif default: printf("Error: Invalid device type to %s\n", __FUNCTION__); - return ; + return; } base = (liodn_bases[dev].id[0] << 16) | liodn_bases[dev].id[0]; @@ -232,7 +232,7 @@ static void fdt_fixup_srio_liodn(void *blob, struct srio_liodn_id_table *tbl) /* search for srio node, if doesn't exist just return - nothing todo */ srio_off = fdt_node_offset_by_compatible(blob, -1, "fsl,srio"); if (srio_off < 0) - return ; + return; for (i = 0; i < srio_liodn_tbl_sz; i++) { int off, portid = tbl[i].portid; diff --git a/arch/powerpc/cpu/mpc85xx/mpc8548_serdes.c b/arch/powerpc/cpu/mpc85xx/mpc8548_serdes.c index 2a5c3e3200..38f30afdfc 100644 --- a/arch/powerpc/cpu/mpc85xx/mpc8548_serdes.c +++ b/arch/powerpc/cpu/mpc85xx/mpc8548_serdes.c @@ -45,7 +45,7 @@ void fsl_serdes_init(void) if (srds1_cfg >= ARRAY_SIZE(serdes1_cfg_tbl)) { printf("Invalid PORDEVSR[IO_SEL] = %d\n", srds1_cfg); - return ; + return; } for (lane = 0; lane < SRDS1_MAX_LANES; lane++) { diff --git a/arch/powerpc/cpu/mpc85xx/portals.c b/arch/powerpc/cpu/mpc85xx/portals.c index 52e2124fb9..6b4cbddcdf 100644 --- a/arch/powerpc/cpu/mpc85xx/portals.c +++ b/arch/powerpc/cpu/mpc85xx/portals.c @@ -21,7 +21,7 @@ void fdt_portal(void *blob, const char *compat, const char *container, off = fdt_node_offset_by_compatible(blob, -1, compat); if (off < 0) - return ; + return; off = fdt_parent_offset(blob, off); /* if non-zero assume we have a container */ @@ -35,7 +35,7 @@ void fdt_portal(void *blob, const char *compat, const char *container, range = fdt_getprop_w(blob, off, "ranges", &len); if (range == NULL) { printf("ERROR: container for %s has no ranges", compat); - return ; + return; } range[0] = 0; @@ -61,13 +61,13 @@ void fdt_portal(void *blob, const char *compat, const char *container, if (container && (memcmp(container, name, len))) { printf("WARNING: container names didn't match %s %s\n", container, name); - return ; + return; } memcpy(&buf, name, len); len += sprintf(&buf[len], "@%llx", addr); fdt_set_name(blob, off, buf); - return ; + return; } printf("ERROR: %s isn't in a container. Not supported\n", compat); diff --git a/arch/powerpc/cpu/mpc85xx/tlb.c b/arch/powerpc/cpu/mpc85xx/tlb.c index e39fe14382..81e60722f9 100644 --- a/arch/powerpc/cpu/mpc85xx/tlb.c +++ b/arch/powerpc/cpu/mpc85xx/tlb.c @@ -41,7 +41,7 @@ __weak void init_tlbs(void) tlb_table[i].mas7); } - return ; + return; } #if !defined(CONFIG_NAND_SPL) && \ diff --git a/arch/powerpc/cpu/mpc8xxx/fdt.c b/arch/powerpc/cpu/mpc8xxx/fdt.c index 871554a7f4..3004290248 100644 --- a/arch/powerpc/cpu/mpc8xxx/fdt.c +++ b/arch/powerpc/cpu/mpc8xxx/fdt.c @@ -128,7 +128,7 @@ void ft_srio_setup(void *blob) /* search for srio node, if doesn't exist just return - nothing todo */ srio_off = fdt_node_offset_by_compatible(blob, -1, "fsl,srio"); if (srio_off < 0) - return ; + return; #ifdef CONFIG_SRIO1 if (is_serdes_configured(SRIO1)) diff --git a/arch/powerpc/cpu/mpc8xxx/law.c b/arch/powerpc/cpu/mpc8xxx/law.c index 198b5b10a5..24bbe3b45f 100644 --- a/arch/powerpc/cpu/mpc8xxx/law.c +++ b/arch/powerpc/cpu/mpc8xxx/law.c @@ -353,5 +353,5 @@ void init_laws(void) } #endif - return ; + return; } diff --git a/arch/powerpc/lib/bootm.c b/arch/powerpc/lib/bootm.c index 512787854c..8ae8d8a3e7 100644 --- a/arch/powerpc/lib/bootm.c +++ b/arch/powerpc/lib/bootm.c @@ -113,7 +113,7 @@ static void boot_jump_linux(struct bootm_headers *images) cmd_start, cmd_end, 0, 0); /* does not return */ } - return ; + return; } void arch_lmb_reserve(struct lmb *lmb) @@ -148,7 +148,7 @@ void arch_lmb_reserve(struct lmb *lmb) cpu_mp_lmb_reserve(lmb); #endif - return ; + return; } static void boot_prep_linux(struct bootm_headers *images) diff --git a/board/ti/evm/evm.c b/board/ti/evm/evm.c index 39b5c706a9..a7f9a7eca1 100644 --- a/board/ti/evm/evm.c +++ b/board/ti/evm/evm.c @@ -234,7 +234,7 @@ static void reset_net_chip(void) ret = gpio_request(rst_gpio, ""); if (ret < 0) { printf("Unable to get GPIO %d\n", rst_gpio); - return ; + return; } /* Configure as output */ diff --git a/drivers/ddr/fsl/util.c b/drivers/ddr/fsl/util.c index 43cb01804b..589d7df731 100644 --- a/drivers/ddr/fsl/util.c +++ b/drivers/ddr/fsl/util.c @@ -147,7 +147,7 @@ __fsl_ddr_set_lawbar(const common_timing_params_t *memctl_common_params, if (set_ddr_laws(base, size, law_memctl) < 0) { printf("%s: ERROR (ctrl #%d, TRGT ID=%x)\n", __func__, ctrl_num, law_memctl); - return ; + return; } debug("setup ddr law base = 0x%llx, size 0x%llx, TRGT_ID 0x%x\n", base, size, law_memctl); diff --git a/drivers/net/fm/init.c b/drivers/net/fm/init.c index af94dabe29..43d2000d24 100644 --- a/drivers/net/fm/init.c +++ b/drivers/net/fm/init.c @@ -149,7 +149,7 @@ void fman_enet_init(void) } } - return ; + return; } void fm_disable_port(enum fm_port port) @@ -233,7 +233,7 @@ static void __def_board_ft_fman_fixup_port(void *blob, char * prop, phys_addr_t pa, enum fm_port port, int offset) { - return ; + return; } void board_ft_fman_fixup_port(void *blob, char * prop, phys_addr_t pa, -- 2.34.1

3 2

[PATCH] cmd: eeprom: don't truncate target address at 32-bit
by Baruch Siach 03 Nov '22

03 Nov '22

On 64-bit platforms where int is 32-bit wide, the eeprom command parse_numeric_param() routine truncates the memory address parameter to the lower 32-bit. Make parse_numeric_param() return long to allow read/write of addresses beyond the lower 4GB. Signed-off-by: Baruch Siach <baruch(a)tkos.co.il> --- cmd/eeprom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/eeprom.c b/cmd/eeprom.c index cdd65af763b0..614263fd8edb 100644 --- a/cmd/eeprom.c +++ b/cmd/eeprom.c @@ -200,10 +200,10 @@ int eeprom_write(unsigned dev_addr, unsigned offset, return ret; } -static int parse_numeric_param(char *str) +static long parse_numeric_param(char *str) { char *endptr; - int value = simple_strtol(str, &endptr, 16); + long value = simple_strtol(str, &endptr, 16); return (*endptr != '\0') ? -1 : value; } -- 2.35.1

3 2

[PATCH] xen: pvblock: Use uclass_probe_all
by Michal Suchanek 03 Nov '22

03 Nov '22

Also eliminate useless code and variables. Signed-off-by: Michal Suchanek <msuchanek(a)suse.de> --- drivers/xen/pvblock.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/xen/pvblock.c b/drivers/xen/pvblock.c index 95e298d7dd..4ad548d599 100644 --- a/drivers/xen/pvblock.c +++ b/drivers/xen/pvblock.c @@ -818,8 +818,6 @@ static void print_pvblock_devices(void) void pvblock_init(void) { struct driver_info info; - struct udevice *udev; - struct uclass *uc; int ret; /* @@ -828,15 +826,12 @@ void pvblock_init(void) * virtual block devices. */ info.name = DRV_NAME; - ret = device_bind_by_name(gd->dm_root, false, &info, &udev); + ret = device_bind_by_name(gd->dm_root, false, &info, NULL); if (ret < 0) printf("Failed to bind " DRV_NAME ", ret: %d\n", ret); /* Bootstrap virtual block devices class driver */ - ret = uclass_get(UCLASS_PVBLOCK, &uc); - if (ret) - return; - uclass_foreach_dev_probe(UCLASS_PVBLOCK, udev); + uclass_probe_all(UCLASS_PVBLOCK); print_pvblock_devices(); } -- 2.38.0

3 2

[PATCH 0/3] timer: add SP804 DM_TIMER driver (and use it)
by Andre Przywara 03 Nov '22

03 Nov '22

Some boards were using an ARM SP804 timer IP, but were driving that using hardcoded addresses and input frequencies, using the CONFIG_SYS_TIMER_* macros. This is deprecated and scheduled for removal. This series adds a DM_TIMER compliant SP804 driver in patch 1, and lets the Highbank board use that (patch 3). Since the Highbank DT somewhat hides the timer base fixed-clock inside a subnode, we need some simple-bus like driver in patch 2 to help the driver find the timer frequency. The SP804 driver should be usable by other SoCs using the SP804 timer, but I don't have any to test it there. Cheers, Andre Andre Przywara (3): timer: add SP804 UCLASS timer driver highbank: scan into hb_sregs DT subnodes highbank: switch to use the Arm SP804 DM_TIMER driver arch/arm/Kconfig | 2 + board/highbank/Makefile | 2 +- board/highbank/hb_sregs.c | 45 +++++++++++++++ drivers/timer/Kconfig | 6 ++ drivers/timer/Makefile | 1 + drivers/timer/sp804_timer.c | 108 ++++++++++++++++++++++++++++++++++++ include/configs/highbank.h | 4 -- 7 files changed, 163 insertions(+), 5 deletions(-) create mode 100644 board/highbank/hb_sregs.c create mode 100644 drivers/timer/sp804_timer.c -- 2.25.1

2 6