October 2022 - U-Boot

Bad Data CRC
by momo aubin 13 Oct '22

13 Oct '22

Hello Simon, My board boots well . When I added the second partition into my kernel I got this message *Verifying Checksum ... Bad Data CRC* what could be the root cause ? Which data is talking about ? u boot data or kernel data ? Thanks in advance.

3 6

[PATCH] sunxi: defconfig: Add X96 Mate TV box
by Andre Przywara 12 Oct '22

12 Oct '22

The X96 Mate TV box is a TV box with the Allwinner H616 SoC. It is available with up to 4GB of DRAM and 64GB eMMC. The DRAM chips require a different configuration when compared to the OrangePi Zero2, we must not use read/write training and write leveling. Add a defconfig for the box, so that we can easily build U-Boot for it. We synced the .dts file already from the kernel tree. Signed-off-by: Andre Przywara <andre.przywara(a)arm.com> --- configs/x96_mate_defconfig | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 configs/x96_mate_defconfig diff --git a/configs/x96_mate_defconfig b/configs/x96_mate_defconfig new file mode 100644 index 00000000000..4276f4f543b --- /dev/null +++ b/configs/x96_mate_defconfig @@ -0,0 +1,15 @@ +CONFIG_ARM=y +CONFIG_ARCH_SUNXI=y +CONFIG_DEFAULT_DEVICE_TREE="sun50i-h616-x96-mate" +CONFIG_SPL=y +CONFIG_DRAM_SUN50I_H616_READ_CALIBRATION=y +CONFIG_MACH_SUN50I_H616=y +CONFIG_MMC0_CD_PIN="PF6" +CONFIG_R_I2C_ENABLE=y +# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set +CONFIG_SPL_I2C=y +CONFIG_SPL_SYS_I2C_LEGACY=y +CONFIG_SYS_I2C_MVTWSI=y +CONFIG_SYS_I2C_SLAVE=0x7f +CONFIG_SYS_I2C_SPEED=400000 +CONFIG_SUPPORT_EMMC_BOOT=y -- 2.25.1

2 1

[PATCH] Nokia RX-51: Fix double space key press
by Pali Rohár 12 Oct '22

12 Oct '22

Space key is indicated by two different bits. Some HW models indicate press of space key only by the first bit. Qemu indicates it by both bits at the same time, which is currently interpreted by u-boot as double key press. Fix this issue by setting first bit when only second is set (to support HW models which indicate press only by second bit) and always clearing second bit before processing to not report double space key press. Signed-off-by: Pali Rohár <pali(a)kernel.org> --- board/nokia/rx51/rx51.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/board/nokia/rx51/rx51.c b/board/nokia/rx51/rx51.c index 9548c3c7be71..c1b4b91b6070 100644 --- a/board/nokia/rx51/rx51.c +++ b/board/nokia/rx51/rx51.c @@ -561,7 +561,7 @@ static const char keymap[] = { 'q', 'o', 'p', ',', '\b', 0, 'a', 's', 'w', 'd', 'f', 'g', 'h', 'j', 'k', 'l', 'e', '.', 0, '\r', 0, 'z', 'x', 'c', - 'r', 'v', 'b', 'n', 'm', ' ', ' ', 0, + 'r', 'v', 'b', 'n', 'm', ' ', 0, 0, 't', 0, 0, 0, 0, 0, 0, 0, 'y', 0, 0, 0, 0, 0, 0, 0, 'u', 0, 0, 0, 0, 0, 0, 0, @@ -691,6 +691,10 @@ static int rx51_kp_tstc(struct udevice *dev) mods = keys[4] >> 4; keys[4] &= 0x0f; + /* space key is indicated by two different bits */ + keys[3] |= (keys[3] & (1 << 6)) >> 1; + keys[3] &= ~(1 << 6); + for (c = 0; c < 8; c++) { /* get newly pressed keys only */ -- 2.20.1

2 1

[PATCH] Nokia RX-51: Remove CONFIG_UBI_SIZE
by Pali Rohár 12 Oct '22

12 Oct '22

CONFIG_UBI_SIZE option is not used, so remove it. Signed-off-by: Pali Rohár <pali(a)kernel.org> --- include/configs/nokia_rx51.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/configs/nokia_rx51.h b/include/configs/nokia_rx51.h index 97aafc5f7250..a88cfe77d50c 100644 --- a/include/configs/nokia_rx51.h +++ b/include/configs/nokia_rx51.h @@ -31,8 +31,6 @@ #define V_OSCK 26000000 /* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1) -#define CONFIG_UBI_SIZE (512 << 10) - /* * Hardware drivers */ -- 2.20.1

2 1

[PATCH] Fix typo in CONFIG_USBNET_DEVADDR
by nachopitt 12 Oct '22

12 Oct '22

From: Ignacio Zamora <nachopitt(a)gmail.com> Fix typo that was causing the same feature to be splitted into 2 different configuration options Replacing CONFIG_USBNET_DEVADDR with CONFIG_USBNET_DEV_ADDR Signed-off-by: Ignacio Zamora <nachopitt(a)gmail.com> --- drivers/usb/gadget/Kconfig | 2 +- drivers/usb/gadget/ether.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index da9c9e3f10..e8da73c788 100644 --- a/drivers/usb/gadget/Kconfig +++ b/drivers/usb/gadget/Kconfig @@ -241,7 +241,7 @@ config USB_ETH_RNDIS endchoice -config USBNET_DEVADDR +config USBNET_DEV_ADDR string "USB Gadget Ethernet device mac address" default "de:ad:be:ef:00:01" help diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c index abb5332f13..6ce389de9f 100644 --- a/drivers/usb/gadget/ether.c +++ b/drivers/usb/gadget/ether.c @@ -2620,7 +2620,7 @@ static int usb_eth_probe(struct udevice *dev) priv->netdev = dev; l_priv = priv; - get_ether_addr(CONFIG_USBNET_DEVADDR, pdata->enetaddr); + get_ether_addr(CONFIG_USBNET_DEV_ADDR, pdata->enetaddr); eth_env_set_enetaddr("usbnet_devaddr", pdata->enetaddr); return 0; -- 2.30.2.windows.1

2 1

[PATCH] tools: k3_gen_x509_cert: Do not print SWRV on build
by Andrew Davis 12 Oct '22

12 Oct '22

This matches the others here. Signed-off-by: Andrew Davis <afd(a)ti.com> --- tools/k3_gen_x509_cert.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/k3_gen_x509_cert.sh b/tools/k3_gen_x509_cert.sh index 029247c105..d9cde07417 100755 --- a/tools/k3_gen_x509_cert.sh +++ b/tools/k3_gen_x509_cert.sh @@ -238,7 +238,7 @@ gen_cert() { #echo " IMAGE_SIZE = $BIN_SIZE" #echo " CERT_TYPE = $CERTTYPE" #echo " DEBUG_TYPE = $DEBUG_TYPE" - echo " SWRV = $SWRV" + #echo " SWRV = $SWRV" sed -e "s/TEST_IMAGE_LENGTH/$BIN_SIZE/" \ -e "s/TEST_IMAGE_SHA_VAL/$SHA_VAL/" \ -e "s/TEST_CERT_TYPE/$CERTTYPE/" \ -- 2.37.3

2 1

[PATCH] smem: msm: add missing <linux/sizes.h>
by Robert Marko 12 Oct '22

12 Oct '22

MSM SMEM driver is currently missing <linux/sizes.h> header and throws the following compile error: drivers/smem/msm_smem.c: In function ‘qcom_smem_get_ptable’: drivers/smem/msm_smem.c:635:71: error: ‘SZ_4K’ undeclared (first use in this function) 635 | ptable = smem->regions[0].virt_base + smem->regions[0].size - SZ_4K; Signed-off-by: Robert Marko <robert.marko(a)sartura.hr> Cc: luka.perkov(a)sartura.hr --- drivers/smem/msm_smem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/smem/msm_smem.c b/drivers/smem/msm_smem.c index 6395b61b0d..17ee6c837c 100644 --- a/drivers/smem/msm_smem.c +++ b/drivers/smem/msm_smem.c @@ -18,6 +18,7 @@ #include <linux/err.h> #include <linux/ioport.h> #include <linux/io.h> +#include <linux/sizes.h> #include <smem.h> DECLARE_GLOBAL_DATA_PTR; -- 2.37.3

2 1

[PATCH 1/1] test: run setexpr test only on sandbox
by Heinrich Schuchardt 12 Oct '22

12 Oct '22

The test relies on memory being available at 0x0. This in not valid for many boards. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- test/cmd/Makefile | 2 ++ test/cmd_ut.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/test/cmd/Makefile b/test/cmd/Makefile index c331757425..d084494bd5 100644 --- a/test/cmd/Makefile +++ b/test/cmd/Makefile @@ -12,4 +12,6 @@ obj-$(CONFIG_CMD_LOADM) += loadm.o obj-$(CONFIG_CMD_MEM_SEARCH) += mem_search.o obj-$(CONFIG_CMD_PINMUX) += pinmux.o obj-$(CONFIG_CMD_PWM) += pwm.o +ifdef CONFIG_SANDBOX obj-$(CONFIG_CMD_SETEXPR) += setexpr.o +endif diff --git a/test/cmd_ut.c b/test/cmd_ut.c index 63443cfa6f..634dc193fb 100644 --- a/test/cmd_ut.c +++ b/test/cmd_ut.c @@ -55,7 +55,7 @@ static struct cmd_tbl cmd_ut_sub[] = { U_BOOT_CMD_MKENT(log, CONFIG_SYS_MAXARGS, 1, do_ut_log, "", ""), #endif U_BOOT_CMD_MKENT(mem, CONFIG_SYS_MAXARGS, 1, do_ut_mem, "", ""), -#ifdef CONFIG_CMD_SETEXPR +#if defined(CONFIG_SANDBOX) && defined(CONFIG_CMD_SETEXPR) U_BOOT_CMD_MKENT(setexpr, CONFIG_SYS_MAXARGS, 1, do_ut_setexpr, "", ""), #endif -- 2.37.2

3 2

[PATCH] firmware: scmi: fix the multi channel support with CCF
by Patrick Delaunay 12 Oct '22

12 Oct '22

When the CCF is activated, the dev->parent is not necessary the reference to SCMI transport and the function devm_scmi_of_get_channel failed for the registered SCMI clock, child for protocol@14, the channel is null and the SCMI clock driver crash for any operations. This patch changes the first parameter of the ops of_get_channel(), aligned with other process_msg() to pass directly the good reference, i.e. parent result of find_scmi_transport_device(dev) which return the reference of the scmi transport device. Fixes: 8e96801aa6a ("firmware: scmi: add multi-channel support") Signed-off-by: Patrick Delaunay <patrick.delaunay(a)foss.st.com> --- drivers/firmware/scmi/mailbox_agent.c | 2 +- drivers/firmware/scmi/optee_agent.c | 2 +- drivers/firmware/scmi/scmi_agent-uclass.c | 2 +- drivers/firmware/scmi/smccc_agent.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/scmi/mailbox_agent.c b/drivers/firmware/scmi/mailbox_agent.c index 3efdab9e723..8277c186060 100644 --- a/drivers/firmware/scmi/mailbox_agent.c +++ b/drivers/firmware/scmi/mailbox_agent.c @@ -96,7 +96,7 @@ static int setup_channel(struct udevice *dev, struct scmi_mbox_channel *chan) static int scmi_mbox_get_channel(struct udevice *dev, struct scmi_channel **channel) { - struct scmi_mbox_channel *base_chan = dev_get_plat(dev->parent); + struct scmi_mbox_channel *base_chan = dev_get_plat(dev); struct scmi_mbox_channel *chan; int ret; diff --git a/drivers/firmware/scmi/optee_agent.c b/drivers/firmware/scmi/optee_agent.c index 2b2b8c1670a..db927fb2140 100644 --- a/drivers/firmware/scmi/optee_agent.c +++ b/drivers/firmware/scmi/optee_agent.c @@ -326,7 +326,7 @@ static int setup_channel(struct udevice *dev, struct scmi_optee_channel *chan) static int scmi_optee_get_channel(struct udevice *dev, struct scmi_channel **channel) { - struct scmi_optee_channel *base_chan = dev_get_plat(dev->parent); + struct scmi_optee_channel *base_chan = dev_get_plat(dev); struct scmi_optee_channel *chan; u32 channel_id; int ret; diff --git a/drivers/firmware/scmi/scmi_agent-uclass.c b/drivers/firmware/scmi/scmi_agent-uclass.c index 2b6211c4e6a..5c98a304a22 100644 --- a/drivers/firmware/scmi/scmi_agent-uclass.c +++ b/drivers/firmware/scmi/scmi_agent-uclass.c @@ -137,7 +137,7 @@ int devm_scmi_of_get_channel(struct udevice *dev, struct scmi_channel **channel) return -ENODEV; if (transport_dev_ops(parent)->of_get_channel) - return transport_dev_ops(parent)->of_get_channel(dev, channel); + return transport_dev_ops(parent)->of_get_channel(parent, channel); /* Drivers without a get_channel operator don't need a channel ref */ *channel = NULL; diff --git a/drivers/firmware/scmi/smccc_agent.c b/drivers/firmware/scmi/smccc_agent.c index bc2eb67335b..6a52cd75d67 100644 --- a/drivers/firmware/scmi/smccc_agent.c +++ b/drivers/firmware/scmi/smccc_agent.c @@ -83,7 +83,7 @@ static int setup_channel(struct udevice *dev, struct scmi_smccc_channel *chan) static int scmi_smccc_get_channel(struct udevice *dev, struct scmi_channel **channel) { - struct scmi_smccc_channel *base_chan = dev_get_plat(dev->parent); + struct scmi_smccc_channel *base_chan = dev_get_plat(dev); struct scmi_smccc_channel *chan; u32 func_id; int ret; -- 2.25.1

2 1

[PATCH 1/1] regmap: fix range checks
by Heinrich Schuchardt 12 Oct '22

12 Oct '22

On the 32bit ARM sandbox 'dm ut dm_test_devm_regmap' fails with an abort. This is due to incorrect range checks. On 32-bit systems the size of size_t and int is both 32 bit. The expression (offset + val_len) is bound to overflow if offset == -1. Add an overflow check. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- drivers/core/regmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/core/regmap.c b/drivers/core/regmap.c index 5f98f85cfc..5ccbf9abb8 100644 --- a/drivers/core/regmap.c +++ b/drivers/core/regmap.c @@ -399,7 +399,7 @@ int regmap_raw_read_range(struct regmap *map, uint range_num, uint offset, range = &map->ranges[range_num]; offset <<= map->reg_offset_shift; - if (offset + val_len > range->size) { + if (offset + val_len > range->size || offset + val_len < offset) { debug("%s: offset/size combination invalid\n", __func__); return -ERANGE; } @@ -538,7 +538,7 @@ int regmap_raw_write_range(struct regmap *map, uint range_num, uint offset, range = &map->ranges[range_num]; offset <<= map->reg_offset_shift; - if (offset + val_len > range->size) { + if (offset + val_len > range->size || offset + val_len < offset) { debug("%s: offset/size combination invalid\n", __func__); return -ERANGE; } -- 2.34.1

3 2