October 2022 - U-Boot

[PATCH 0/3] arm: smh: Fix and improve semihosting traps
by Andre Przywara 03 Nov '22

03 Nov '22

While playing around with QEMU's semihosting implementation, I stared at our semihosting trap code, and found some issues, that this mini-series fixes. Please have a look! Cheers, Andre Andre Przywara (3): arm: smh: specify Thumb trap instruction arm: smh: Make semihosting trap calls more robust arm: smh: Allow semihosting trap calls to be inlined arch/arm/lib/semihosting.c | 44 +++++++++++++++++++++++++++----------- 1 file changed, 31 insertions(+), 13 deletions(-) -- 2.25.1

3 8

Adapteva Parallella board
by Martin Husemann 03 Nov '22

03 Nov '22

Hey folks, the other day I was asked to test some changes on my Adapteva Parallella board, which I hadn't used for ages. I noticed it has an ancient u-boot: U-Boot 2012.10-00003-g792c31c (Jan 03 2014 - 12:24:08) I2C: ready DRAM: 992 MiB WARNING: Caches not enabled MMC: SDHCI: 0 SF: Detected N25Q128 with page size 64 KiB, total 16 MiB In: serial Out: serial Err: serial Net: zynq_gem Hit any key to stop autoboot: ... and a quick search turned up lots of supported similar boards in u-boot mainline under board/xilinx/zynq - but no concrete instructions or test results for the Parallella. Anyone know what would be missing or is it just something simple like "take u-boot for z702 and replace the dtb"? Martin

2 4

Re: question about uboot mt7620 RAM_VERSION
by Stefan Roese 03 Nov '22

03 Nov '22

Hi Kang-sen, On 25.10.22 15:25, Kang-sen Lu wrote: > Thanks for your reply. > > I cloned the uboot source code from here: > https://github.com/tessel/uboot-mt7620 > <https://github.com/tessel/uboot-mt7620> > > I built the uboot.bin for RAM_VERSION. If I select option 8 at power up > with the uboot from zbtlink, the new uboot.bin will hang. But if I > caused saveenv() to happen, by changing tftp filename artificially, the > uboot.bin for RAM_VERSION will start and run properly, by the uboot from > zbtlink. Sorry, this is the ancient U-Boot version. I thought you were talking about the mainline U-Boot version, which I ported for MT7620/80 some years ago (with many extensions and fixes by Weijie later on). I don't remember the details of this ancient MT7620 U-Boot version and frankly don't want to dig into this (again). > Maybe Weijie can comment on the experimental result? Maybe. > Thanks. > > Kang-sen > > BTW: How does uboot developer usually run the RAM_VERSION uboot.bin, I > am curious. Is it loaded with tftp server, or something else? Yes. This is very handy and frequently done. Load the RAM version into RAM to the TEXT_BASE address and start it from there via the "go" command. BTW: Please keep the ML on Cc. It might be that someone else has some answers. Or that this topic is interesting for other people as well. Thanks, Stefan > On Tue, Oct 25, 2022 at 12:46 AM Stefan Roese <sr(a)denx.de > <mailto:sr@denx.de>> wrote: > > Hi Kang-sen, > > On 24.10.22 19:58, Kang-sen Lu wrote: > > I am wondering if you have read my reply on 10/18. It is very > strange to > > find that unless I had uboot to do a saveenv, the RAM_VERSION > uboot.bin > > would not run properly in DRAM. > > Frankly, I don't really understand this message. It's not clear to > me, what you are doing and what is working and what is failing. > > I thought you were trying to boot the current mainline U-Boot RAM > version u-boot.bin. If yes, which build target did you use? What > does it show on the serial console? > > Thanks, > Stefan > > > Thanks. > > > > Kang-sen > > > > On Tue, Oct 18, 2022 at 10:05 AM Kang-sen Lu <klu(a)waav.com > <mailto:klu@waav.com> > > <mailto:klu@waav.com <mailto:klu@waav.com>>> wrote: > > > > Hi, Stefan: > > > > Thanks for your reply. > > > > The uboot in the zbtlink mt7620 router has the signatures > follows: > > > > U-Boot 1.1.3 (Nov 9 2016 - 15:34:50) > > > > SoC:MediaTek MT7620 > > DRAM: Memory Testing..131072K OK. is 128 MB > > relocate_code Pointer at: 87fb0000 > > enable ephy clock...done. rf reg 29 = 5 > > SSC disabled. > > spi_wait_nsec: 29 > > spi device id: ef 40 18 0 0 (40180000) > > Flash: W25Q128BV > > > > I would like to share my strange experience about RAM version > uboot > > for mt7620. By pure luck, I found that when I tried to load a > newly > > built uboot with startup menu option 8, unless I change the > > filename, say, from uboot.bin to uboot1.bin, the newly loaded > uboot > > would not startup properly in RAM. > > > > I don't have the knowledge to find out why this variable > "modifies" > > to be none-zero is so important to the execution of uboot in RAM. > > Maybe some expert in this group can easily figure that out. > > > > Thanks. > > > > Kang-sen > > > > On Tue, Oct 18, 2022 at 7:53 AM Stefan Roese <sr(a)denx.de > <mailto:sr@denx.de> > > <mailto:sr@denx.de <mailto:sr@denx.de>>> wrote: > > > > Hi Kang-sen, > > > > (added Weijie Gao to Cc) > > > > On 17.10.22 14:11, Kang-sen Lu wrote: > > > I am building uboot.bin for mt7620 router. > > > > > > I used start menu option 8, a hidden one choice, to load > > uboot.bin through > > > tftp. > > > > > > The tftp transfer is OK. But when the new uboot > starts, it hang. > > > > So which mainline U-Boot build target did you use? Don't > you see > > any output on the serial console at all? > > > > > I am wondering if the RAM_VERSION for mt7620 still works. > > > > In mainline U-Boot this is usually handled this way. The > SPL U-Boot > > version is responsible for the low-level HW init, like > DRAM/DDR init > > etc. It's hard to impossible to chainload this SPL part > from a > > running U-Boot version. > > > > The "RAM_VERSION" is usually the main U-Boot proper image > > "u-boot.bin". > > So in general you are using the correct file here. Even > though I > > have > > not idea, if the build target is correct for your "mt7620 > router". > > > > Thanks, > > Stefan > > > > Viele Grüße, > Stefan Roese > > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: > sr(a)denx.de <mailto:sr@denx.de> > Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr(a)denx.de

2 4

[PATCH v4 0/5] arm: mvebu: Support for 98DX25xx/98DX35xx (AlleyCat5)
by Chris Packham 03 Nov '22

03 Nov '22

These patches are based on Marvell's bootloader for the AlleyCat5/5X which was based on u-boot 2018.03. I've split that code into consumable chunks and dropped as much unnecessary stuff as I can. I've also tried to sync the device trees as much as possible with the support that will land in Linux 6.0 although there are still some differences Changes in v4: - Collect r-by from Stefan - Remove unused mvebu_get_nand_clock() (will return in a later series) - Remove unnecessary #ifdefs - Misc style cleanups - Replace CONFIG_MVEBU_SAR with simpler code implemented directly in soc.c based around get_sar_freq which the 32-bit platforms already use. - Move CONFIG_DISPLAY_BOARDINFO_LATE and CONFIG_ENV_OVERWRITE to the defconfig. - Remove CONFIG_BAUDRATE as this is already set in the default config - Remove CONFIG_USB_MAX_CONTROLLER_COUNT as this is not needed with DM_USB - Remove CONFIG_PREBOOT as we don't have anything to run - Remove commented out CONFIG_BOARD_EARLY_INIT_R - Remove DEBUG_UART configuration - Remove unnecessary console environment variable - Remove CONFIG_MVEBU_SAR Changes in v3: - Remove unnecessary changes to RX descriptor handling - Use dev_get_dma_range() to parse dma-ranges property from parent device. - Remove unnecessary dma-ranges property from ethernet nodes (mvneta now correctly parses the property from the parent node). - Keep soc_print_clock_info and soc_print_device_info local to alleycat5. - Remove MMC and UBIFS distroboot options (MMC driver is not currently functional, NAND is not populated on the RD-AC5X board) - Remove unnecessary Ethernet configuration - Remove unnecessary NAND configuration - Remove memory node from dts so the value passed by the DDR FW will be used Changes in v2: - Use distro boot by default - remove unnecessary SPI-NOR partitions Chris Packham (5): net: mvneta: Add support for AlleyCat5 usb: ehci: ehci-marvell: Support for marvell,ac5-ehci pinctrl: mvebu: Add AlleyCat5 support arm: mvebu: Support for 98DX25xx/98DX35xx SoC arm: mvebu: Add RD-AC5X board arch/arm/dts/Makefile | 3 +- arch/arm/dts/ac5-98dx25xx.dtsi | 277 +++++++++++++++++++ arch/arm/dts/ac5-98dx35xx-rd.dts | 129 +++++++++ arch/arm/dts/ac5-98dx35xx.dtsi | 17 ++ arch/arm/mach-mvebu/Kconfig | 13 +- arch/arm/mach-mvebu/Makefile | 1 + arch/arm/mach-mvebu/alleycat5/Makefile | 8 + arch/arm/mach-mvebu/alleycat5/cpu.c | 124 +++++++++ arch/arm/mach-mvebu/alleycat5/soc.c | 298 +++++++++++++++++++++ arch/arm/mach-mvebu/alleycat5/soc.h | 7 + arch/arm/mach-mvebu/arm64-common.c | 5 + arch/arm/mach-mvebu/include/mach/cpu.h | 4 + board/Marvell/mvebu_alleycat-5/MAINTAINERS | 6 + board/Marvell/mvebu_alleycat-5/Makefile | 3 + board/Marvell/mvebu_alleycat-5/board.c | 28 ++ configs/mvebu_ac5_rd_defconfig | 84 ++++++ drivers/net/Kconfig | 2 +- drivers/net/mvneta.c | 43 ++- drivers/pinctrl/mvebu/Kconfig | 2 +- drivers/usb/host/Kconfig | 1 + drivers/usb/host/ehci-marvell.c | 57 +++- include/configs/mvebu_alleycat-5.h | 42 +++ 22 files changed, 1139 insertions(+), 15 deletions(-) create mode 100644 arch/arm/dts/ac5-98dx25xx.dtsi create mode 100644 arch/arm/dts/ac5-98dx35xx-rd.dts create mode 100644 arch/arm/dts/ac5-98dx35xx.dtsi create mode 100644 arch/arm/mach-mvebu/alleycat5/Makefile create mode 100644 arch/arm/mach-mvebu/alleycat5/cpu.c create mode 100644 arch/arm/mach-mvebu/alleycat5/soc.c create mode 100644 arch/arm/mach-mvebu/alleycat5/soc.h create mode 100644 board/Marvell/mvebu_alleycat-5/MAINTAINERS create mode 100644 board/Marvell/mvebu_alleycat-5/Makefile create mode 100644 board/Marvell/mvebu_alleycat-5/board.c create mode 100644 configs/mvebu_ac5_rd_defconfig create mode 100644 include/configs/mvebu_alleycat-5.h -- 2.37.3

3 14

[PATCH] mips: mtmips: spl/Kconfig: Set CONFIG_SPL_PAD_TO to 0x0 for ARCH_MTMIPS
by Stefan Roese 02 Nov '22

02 Nov '22

It was noticed that while converting CONFIG_SPL_PAD_TO to Kconfig its value for the MIPS MT762x/8x targets got not ported correctly. Its default is not 0x10000 instead of 0x0. This patch fixes this issue. Fixes: ca8a329a1b7f ("Convert CONFIG_SPL_PAD_TO et al to Kconfig") Signed-off-by: Stefan Roese <sr(a)denx.de> Cc: Ruben Winters <Ruben.Winters(a)gooiland-elektro.nl> Cc: Weijie Gao <weijie.gao(a)mediatek.com> Cc: Daniel Schwierzeck <daniel.schwierzeck(a)gmail.com> Cc: Tom Rini <trini(a)konsulko.com> --- common/spl/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/common/spl/Kconfig b/common/spl/Kconfig index b738c749fff4..05181bdba3e1 100644 --- a/common/spl/Kconfig +++ b/common/spl/Kconfig @@ -98,6 +98,7 @@ config SPL_PAD_TO default 0x11000 if ARCH_MX7 || (ARCH_MX6 && !MX6_OCRAM_256KB) default 0x10000 if ARCH_KEYSTONE default 0x8000 if ARCH_SUNXI && !MACH_SUN50I_H616 + default 0x0 if ARCH_MTMIPS default TPL_MAX_SIZE if TPL_MAX_SIZE > SPL_MAX_SIZE default SPL_MAX_SIZE help -- 2.38.1

2 1

[PATCH v1 0/6] clk: microchip: mpfs: incremental fixes
by Conor Dooley 02 Nov '22

02 Nov '22

Hey All, When trying to sync the Linux device tree with U-Boot, the clock driver's expectation that the input clock it gets is the mss pll presented itself as a problem. The mss pll is not a fixed frequency clock and the Linux devicetree has the actual off-chip oscillator & the clock driver there uses that. This had gone un-noticed in the original dt upstreaming to Linux and I noticed it while upstreaming the clock driver there. I order to switch the clock driver over to using the real reference, we first need to switch over from reading a property of what we assume to be a fixed-frequency clock in the device tree to using clk_get_rate() and fix the parentage of the "periph" clocks to represent their actual relationships to their parents rather than using this fixed-frequency clock in the devicetree to determine their rates. With that done, we can then introduce a small driver for the msspll itself, which we will use if the corrected devicetree node for the clock controller is present. There are some more fixes required, specifically handling of the mtimer clock and of the refclk for the rtc which I have not addressed here, but will deal with in a follow-up series. I've omitted these fixes here to do just what is needed to unblock the dt sync. Thanks, Conor. Conor Dooley (6): dt-bindings: clk: add missing clk ids for microchip mpfs clk: microchip: mpfs: convert parent rate acquistion to get_get_rate() clk: microchip: mpfs: fix reference clock handling clk: microchip: mpfs: fix periph clk parentage clk: microchip: mpfs: fix criticality of peripheral clocks riscv: dts: fix the mpfs's reference clock frequency arch/riscv/dts/microchip-mpfs-icicle-kit.dts | 4 + arch/riscv/dts/microchip-mpfs.dtsi | 14 +-- drivers/clk/microchip/Makefile | 2 +- drivers/clk/microchip/mpfs_clk.c | 37 ++++-- drivers/clk/microchip/mpfs_clk.h | 20 +-- drivers/clk/microchip/mpfs_clk_cfg.c | 7 +- drivers/clk/microchip/mpfs_clk_msspll.c | 119 ++++++++++++++++++ drivers/clk/microchip/mpfs_clk_periph.c | 96 +++++++------- .../dt-bindings/clock/microchip-mpfs-clock.h | 3 + 9 files changed, 229 insertions(+), 73 deletions(-) create mode 100644 drivers/clk/microchip/mpfs_clk_msspll.c -- 2.38.0

4 19

Wolfgang Denk
by Stefano Babic 02 Nov '22

02 Nov '22

Dear U-Boot community, it is my very sad duty to inform you that Wolfgang Denk, the father of U-Boot, passed away last week. We have lost a great developer and a very good friend. I met Wolfgang the first time quite 25 years ago, when we worked for the same company. I was hired as consultant for a (at the time very frequently used) RTOS. I had no time to introduce me, because Wolfgang interrupted me with : "Just install Linux !". Well, of course I did. It was the first good suggestion he gave me. Many others followed. Wolfgang was a pioneer and strong supporter of Open Source, in the time when Linux for Embedded System started its first steps. In many occasions he had strong discussions with customers to explain the advantages of Open Source, and he rejected business contracts if customer was going against his principles. We will miss him. Rest in peace, my friend Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, 82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic(a)denx.de =====================================================================

10 9

[PATCH v4] imx: imx8qm-rom7720: switch to binman
by Oliver Graute 02 Nov '22

02 Nov '22

Switch to use binman to pack images Signed-off-by: Oliver Graute <oliver.graute(a)kococonnector.com> --- Changes for v4 - remove hardcoded dtb filename - added CONFIG_FIT_EXTERNAL_OFFSET Changes for v3 - just rebased to master Changes for v2 - just rebased to master arch/arm/dts/imx8qm-rom7720-a1.dts | 1 + arch/arm/dts/imx8qm-u-boot.dtsi | 131 ++++++++++++++++++ arch/arm/mach-imx/imx8/Kconfig | 1 + .../advantech/imx8qm_rom7720_a1/imximage.cfg | 4 +- configs/imx8qm_rom7720_a1_4G_defconfig | 3 +- doc/board/advantech/imx8qm-rom7720-a1.rst | 3 +- 6 files changed, 138 insertions(+), 5 deletions(-) create mode 100644 arch/arm/dts/imx8qm-u-boot.dtsi diff --git a/arch/arm/dts/imx8qm-rom7720-a1.dts b/arch/arm/dts/imx8qm-rom7720-a1.dts index d1f2fff869..332d441c6d 100644 --- a/arch/arm/dts/imx8qm-rom7720-a1.dts +++ b/arch/arm/dts/imx8qm-rom7720-a1.dts @@ -10,6 +10,7 @@ /memreserve/ 0x80000000 0x00020000; #include "fsl-imx8qm.dtsi" +#include "imx8qm-u-boot.dtsi" / { model = "Advantech iMX8QM Qseven series"; diff --git a/arch/arm/dts/imx8qm-u-boot.dtsi b/arch/arm/dts/imx8qm-u-boot.dtsi new file mode 100644 index 0000000000..9b382f4d11 --- /dev/null +++ b/arch/arm/dts/imx8qm-u-boot.dtsi @@ -0,0 +1,131 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright 2021 NXP + */ + +/ { + binman: binman { + multiple-images; + }; +}; + +&binman { + u-boot-spl-ddr { + align = <4>; + align-size = <4>; + filename = "u-boot-spl-ddr.bin"; + pad-byte = <0xff>; + + u-boot-spl { + align-end = <4>; + filename = "u-boot-spl.bin"; + }; + }; + + spl { + filename = "spl.bin"; + + mkimage { + args = "-n spl/u-boot-spl.cfgout -T imx8image -e 0x100000"; + + blob { + filename = "u-boot-spl-ddr.bin"; + }; + }; + }; + + itb { + filename = "u-boot.itb"; + + fit { + description = "Configuration to load ATF before U-Boot"; + fit,external-offset = <CONFIG_FIT_EXTERNAL_OFFSET>; + fit,fdt-list = "of-list"; + #address-cells = <1>; + + images { + uboot { + arch = "arm64"; + compression = "none"; + description = "U-Boot (64-bit)"; + load = <CONFIG_SYS_TEXT_BASE>; + type = "standalone"; + + uboot-blob { + filename = "u-boot-nodtb.bin"; + type = "blob-ext"; + }; + }; + + atf { + arch = "arm64"; + compression = "none"; + description = "ARM Trusted Firmware"; + entry = <0x00910000>; + load = <0x00091000>; + type = "firmware"; + + atf-blob { + filename = "bl31.bin"; + type = "atf-bl31"; + }; + }; + + scfw { + arch = "arm64"; + compression = "none"; + description = "System Controler Firmware"; + type = "firmware"; + + scfw_blob { + filename = "mx8qm-val-scfw-tcm.bin"; + type = "blob-ext"; + }; + }; + + seco { + arch = "arm64"; + compression = "none"; + description = "Seco Firmware"; + type = "firmware"; + + seco_blob { + filename = "mx8qm-ahab-container.img"; + type = "blob-ext"; + }; + }; + + fdt { + type = "flat_dt"; + compression = "none"; + + uboot-fdt-blob { + filename = "u-boot.dtb"; + type = "blob-ext"; + }; + }; + }; + + configurations { + default = "conf"; + + conf { + fdt = "fdt"; + firmware = "uboot"; + loadables = "atf"; + }; + }; + }; + }; + + imx-boot { + filename = "flash.bin"; + pad-byte = <0x00>; + + spl { + filename = "spl.bin"; + offset = <0x0>; + type = "blob-ext"; + }; + }; +}; diff --git a/arch/arm/mach-imx/imx8/Kconfig b/arch/arm/mach-imx/imx8/Kconfig index abb03340d8..71abbb33ea 100644 --- a/arch/arm/mach-imx/imx8/Kconfig +++ b/arch/arm/mach-imx/imx8/Kconfig @@ -82,6 +82,7 @@ config TARGET_CONGA_QMX8 config TARGET_IMX8QM_ROM7720_A1 bool "Support i.MX8QM ROM-7720-A1" + select BINMAN select BOARD_LATE_INIT select SUPPORT_SPL select IMX8QM diff --git a/board/advantech/imx8qm_rom7720_a1/imximage.cfg b/board/advantech/imx8qm_rom7720_a1/imximage.cfg index 5ecde0c530..43035088e3 100644 --- a/board/advantech/imx8qm_rom7720_a1/imximage.cfg +++ b/board/advantech/imx8qm_rom7720_a1/imximage.cfg @@ -4,8 +4,8 @@ */ -/* Boot from SD, sector size 0x400 */ -BOOT_FROM SD 0x400 +BOOT_FROM sd + /* SoC type IMX8QM */ SOC_TYPE IMX8QM /* Append seco container image */ diff --git a/configs/imx8qm_rom7720_a1_4G_defconfig b/configs/imx8qm_rom7720_a1_4G_defconfig index 3b099761a9..4b7ed6df01 100644 --- a/configs/imx8qm_rom7720_a1_4G_defconfig +++ b/configs/imx8qm_rom7720_a1_4G_defconfig @@ -20,8 +20,9 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80200000 CONFIG_REMAKE_ELF=y CONFIG_FIT=y +CONFIG_FIT_EXTERNAL_OFFSET=0x3000 CONFIG_SPL_LOAD_FIT=y -CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-imx/mkimage_fit_atf.sh" +# CONFIG_USE_SPL_FIT_GENERATOR is not set CONFIG_BOOTDELAY=3 CONFIG_USE_BOOTCOMMAND=y CONFIG_BOOTCOMMAND="mmc dev ${mmcdev}; if mmc rescan; then if run loadbootscript; then run bootscript; else if run loadimage; then run mmcboot; else run netboot; fi; fi; else booti ${loadaddr} - ${fdt_addr}; fi" diff --git a/doc/board/advantech/imx8qm-rom7720-a1.rst b/doc/board/advantech/imx8qm-rom7720-a1.rst index bd4be1dbeb..953cf01fde 100644 --- a/doc/board/advantech/imx8qm-rom7720-a1.rst +++ b/doc/board/advantech/imx8qm-rom7720-a1.rst @@ -57,8 +57,7 @@ Build U-Boot $ export ATF_LOAD_ADDR=0x80000000 $ export BL33_LOAD_ADDR=0x80020000 $ make imx8qm_rom7720_a1_4G_defconfig - $ make u-boot.bin - $ make flash.bin + $ make Flash the binary into the SD card --------------------------------- -- 2.17.1

3 6

[PATCH 0/5] cyclic: get rid of (the need for) cyclic_init()
by Rasmus Villemoes 02 Nov '22

02 Nov '22

I have only compile-tested each of these for sandbox_defconfig and imx8mq_cm_defconfig. I couldn't even figure out how to run the cyclic test inside sandbox by itself, and I don't have any hardware here at home. So perhaps just consider these a POC of the overall idea, namely to use a list abstraction which doesn't need initialization other than what we already guarantee to do for all of struct global_data. As positive side effects, the generated code will be a little smaller, we reduce the use of the early malloc() pool, and the diffstat below is also nice. I don't know if we ever do anything in SPL that would require a call to cyclic_unregister_all(). Rasmus Villemoes (5): cyclic: use a flag in gd->flags for recursion protection cyclic: drop redundant cyclic_ready flag list.h: synchronize hlist_for_each_entry* iterators with linux cyclic: switch to using hlist instead of list cyclic: get rid of cyclic_init() cmd/cyclic.c | 5 +-- common/board_f.c | 2 +- common/board_r.c | 1 - common/cyclic.c | 50 ++++++++++------------------- include/asm-generic/global_data.h | 8 +++-- include/cyclic.h | 35 +++----------------- include/linux/list.h | 53 +++++++++++++++---------------- test/test-main.c | 3 +- 8 files changed, 57 insertions(+), 100 deletions(-) -- 2.37.2

3 15

Broken commit d2e64d29c44dee6d455f7705dd1cf1af8674ad9a
by Pali Rohár 02 Nov '22

02 Nov '22

Hello! Your commit d2e64d29c44dee6d455f7705dd1cf1af8674ad9a ("cli_readline: Only insert printable chars") broke support for pound sign (£) and euro sign (€) keys on Nokia N900 keypad. When I press either of those two keys, nothing is displayed on the N900 screen. On the other hand key for dollar sign ($) is working fine. After reverting that commit those two keys are working again. So I can type "echo 40 €" and U-Boot console will print "40 €" on the screen. Commit message of that commit says to insert only printable characters but instead it started dropping some printable characters. It would be a wise idea to not censor usage of non-dollar currency symbols in U-Boot :-) Hehe I know that issue is probably with non-7-bit characters, but funny things is that on N900 keypad are only two non-ASCII characters: £ and €. Could you please look at it, what can be done with it?

2 2