August 2021 - U-Boot

[PATCH v4 0/7] Arasan sdhci driver updates
by Ashok Reddy Soma 03 Aug '21

03 Aug '21

This patch series updates/fixes below things: - Handle errors from tapdelay functions and return to set_delay() - Add ZynqMP firmware related enums which are used in sdhci driver - Replace mmio_write() with firmware call xilinx_pm_request() - Move tapdelay setting code from tap_delays.c to driver and remove tap_dealy.c and zynqmp_tap_delay.h - Change variable name from deviceid to node_id in couple of functions for consistancy - Add a workaround for sd card detect stable issue for Versal platforms - Use set_control_reg from sdhci.c These patches are based on below microblaze U-Boot 'next' branch. https://source.denx.de/u-boot/custodians/u-boot-microblaze/-/commits/next Changes in v4: - Rebase to latest u-boot-microblaze custodian 'next' branch - Initialized all enum pm_ioctl_id elements with explicit values Changes in v3: - Added new line after return at two places - As we are seeing issues with SPL flow, keep zynqmp_mmio_write method to set tapdelay's and DLL resets. Add xilinx_pm_request on top of it for regular flow. - Changed the patch title to reflect these changes - Make the changes on top of patch 4/7 to move the code to zynq_sdhci.c Changes in v2: - Split patch 1/7 to two patches, one for zynq_sdhci and other one for sdhci - This is the second patch that has been split from 1/7 - This covers changes for sdhci driver separately - Added a debug print in case of error from set_delay() - Added comment for why 1ms delay is needed between DLL assert and release - Remove mmc->dev->seq_ and use priv->deviceid instead - Changed return error from -EIO to -ETIMEDOUT in arasan_sdhci_probe() in card detect state stable workaround Ashok Reddy Soma (5): mmc: zynq_sdhci: Return errors from arasan_sdhci_set_tapdelay mmc: sdhci: Change prototype of set_delay to return errors mmc: zynq_sdhci: Add xilinx_pm_request() method to set tapdelays mmc: zynq_sdhci: Move setting tapdelay code to driver mmc: zynq_sdhci: Use set_control_reg from sdhci.c T Karthik Reddy (2): zynqmp_firmware: Add zynqmp firmware related enums mmc: zynq_sdhci: Wait till sd card detect state is stable board/xilinx/zynqmp/Makefile | 2 - board/xilinx/zynqmp/tap_delays.c | 101 ------------- drivers/mmc/sdhci.c | 10 +- drivers/mmc/zynq_sdhci.c | 242 ++++++++++++++++++++++++++----- include/sdhci.h | 2 +- include/zynqmp_firmware.h | 127 ++++++++++++++++ include/zynqmp_tap_delay.h | 21 --- 7 files changed, 338 insertions(+), 167 deletions(-) delete mode 100644 board/xilinx/zynqmp/tap_delays.c delete mode 100644 include/zynqmp_tap_delay.h -- 2.17.1

3 10

Re: [PATCH] riscv: cpu: fu740: Fix typo of date
by Rick Chen 03 Aug '21

03 Aug '21

> From: U-Boot <u-boot-bounces(a)lists.denx.de> On Behalf Of Zong Li > Sent: Monday, August 02, 2021 3:34 PM > To: u-boot(a)lists.denx.de > Cc: Zong Li <zong.li(a)sifive.com> > Subject: [PATCH] riscv: cpu: fu740: Fix typo of date > > Fixed the typo of date of copyright declaration. > > Signed-off-by: Zong Li <zong.li(a)sifive.com> > --- > arch/riscv/cpu/fu740/spl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Rick Chen <rick(a)andestech.com>

1 0

[PATCH 1/2] arm: mach-snapdragon: misc: Initialize eMMC if necessary
by Stephan Gerhold 03 Aug '21

03 Aug '21

At the moment U-Boot produces an empty MAC address (02:00:00:00:00:00) if the eMMC is not used by anything in U-Boot (e.g. with CONFIG_ENV_IS_NOWHERE=y instead of having the environment on eMMC). This happens because then there is nothing that actually initializes the eMMC and reads the "cid" that is later accessed. To fix this, call mmc_init() to ensure the eMMC is initialized. There is no functional difference if the eMMC is already initialized since then mmc_init() will just return without doing anything. Cc: Ramon Fried <rfried.dev(a)gmail.com> Signed-off-by: Stephan Gerhold <stephan(a)gerhold.net> --- arch/arm/mach-snapdragon/misc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-snapdragon/misc.c b/arch/arm/mach-snapdragon/misc.c index aaa561c2c6..5c062e9636 100644 --- a/arch/arm/mach-snapdragon/misc.c +++ b/arch/arm/mach-snapdragon/misc.c @@ -33,6 +33,9 @@ u32 msm_board_serial(void) if (!mmc_dev) return 0; + if (mmc_init(mmc_dev)) + return 0; + return UNSTUFF_BITS(mmc_dev->cid, 16, 32); } -- 2.32.0

2 3

New Arch For Mkimage
by Randy Yates 03 Aug '21

03 Aug '21

I am attempting to use mkimage to build a uImage for a new architecture: csky. This architecture is already in the mainline kernel. It appears the only thing to do is to added a new enumeration after IH_ARCH_RISCV in u-boot/include/image.h and to add a corresponding entry into uimage_arch in u-boot/common/image.c. Is this correct? Randy Yates Apex Semiconductors (USA) Company Limited 984-368-8148 (cell, work) 919-412-8994 (cell, personal) Randy Yates randyy(a)scc-inc.com Apex Semiconductors (USA) Company Limited http://www.apexsemi-usa.com 984-368-8148 (cell, work) 919-412-8994 (cell, personal) This message contains confidential information. If you are not the intended recipient, notify the sender immediately and delete this e-mail from your system. You should always check e-mail for viruses. Sender does not accept liability for any viruses that may be inadvertently transmitted.

2 3

[PATCH] Revert "spi: spi-uclass: Add support to manually relocate spi memory ops"
by Peter Robinson 02 Aug '21

02 Aug '21

This reverts commit 346df7d4fa62afc578d820b3a18815eec765074f. This patch broke booting Rockchip systems from U-Boot residing on SPI flash, for at least the Pinebook Pro and Rockpro64, and also confirmed with the not yet upstream Helios64. Signed-off-by: Peter Robinson <pbrobinson(a)gmail.com> Cc: T Karthik Reddy <t.karthik.reddy(a)xilinx.com> Cc: Ashok Reddy Soma <ashok.reddy.soma(a)xilinx.com> Cc: Michal Simek <michal.simek(a)xilinx.com> Cc: Pratyush Yadav <p.yadav(a)ti.com> --- drivers/spi/spi-uclass.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/spi/spi-uclass.c b/drivers/spi/spi-uclass.c index d867b27806..ec7f4652b3 100644 --- a/drivers/spi/spi-uclass.c +++ b/drivers/spi/spi-uclass.c @@ -11,7 +11,6 @@ #include <log.h> #include <malloc.h> #include <spi.h> -#include <spi-mem.h> #include <dm/device_compat.h> #include <asm/global_data.h> #include <dm/device-internal.h> @@ -200,16 +199,6 @@ static int spi_post_probe(struct udevice *bus) ops->set_mode += gd->reloc_off; if (ops->cs_info) ops->cs_info += gd->reloc_off; - if (ops->mem_ops) { - struct spi_controller_mem_ops *mem_ops = - (struct spi_controller_mem_ops *)ops->mem_ops; - if (mem_ops->adjust_op_size) - mem_ops->adjust_op_size += gd->reloc_off; - if (mem_ops->supports_op) - mem_ops->supports_op += gd->reloc_off; - if (mem_ops->exec_op) - mem_ops->exec_op += gd->reloc_off; - } reloc_done++; } #endif -- 2.31.1

4 8

[PATCH v2 0/5] Fix compiler warnings for 32-bit ARM
by Simon Glass 02 Aug '21

02 Aug '21

These were noticed when building sandbox on a Raspberry Pi 400, which uses 32-bit linux. To make this work, I enabled CONFIG_HOST_32BIT in 'make menuconfig'. It would be nice if that were automatic, since we have the logic already in arch/sandbox/config.mk So this series adds that. It also fixes the unicode warnings of the form: /usr/bin/ld: warning: arch/sandbox/cpu/start.o uses 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of wchar_t values across objects may fail as suggested by Heinrich. Changes in v2: - Add new patch to reduce checkpatch unicode-string spam - Update commit message to indicate that things work now - Add python3-pycryptodome also, for test_fit_ecdsa.py - Drop patches previously applied - Put all the packages in gcc.rst Joe Perches (1): checkpatch: Support wide strings Simon Glass (4): pci: swap_case: Allow compilation on 32-bit machines doc: sandbox: Fix up dependencies efi: Use 16-bit unicode strings sandbox: Detect the host bit size automatically Makefile | 11 +- arch/sandbox/Kconfig | 13 ++- doc/arch/sandbox.rst | 6 +- doc/build/gcc.rst | 6 +- drivers/misc/swap_case.c | 13 ++- include/efi_loader.h | 2 +- lib/efi_loader/efi_bootmgr.c | 12 +- lib/efi_loader/efi_boottime.c | 2 +- lib/efi_loader/efi_capsule.c | 20 ++-- lib/efi_loader/efi_helper.c | 2 +- lib/efi_loader/efi_image_loader.c | 8 +- lib/efi_loader/efi_setup.c | 20 ++-- lib/efi_loader/efi_signature.c | 4 +- lib/efi_loader/efi_string.c | 2 +- lib/efi_loader/efi_var_common.c | 14 +-- lib/efi_loader/efi_variable.c | 6 +- lib/efi_loader/efi_variable_tee.c | 2 +- lib/efi_loader/helloworld.c | 40 +++---- lib/efi_selftest/dtbdump.c | 82 +++++++------- lib/efi_selftest/efi_selftest.c | 2 +- lib/efi_selftest/efi_selftest_block_device.c | 6 +- lib/efi_selftest/efi_selftest_devicepath.c | 2 +- lib/efi_selftest/efi_selftest_exception.c | 2 +- lib/efi_selftest/efi_selftest_fdt.c | 6 +- lib/efi_selftest/efi_selftest_hii.c | 8 +- lib/efi_selftest/efi_selftest_load_file.c | 4 +- lib/efi_selftest/efi_selftest_loadimage.c | 4 +- .../efi_selftest_miniapp_exception.c | 4 +- lib/efi_selftest/efi_selftest_miniapp_exit.c | 8 +- .../efi_selftest_miniapp_return.c | 2 +- lib/efi_selftest/efi_selftest_reset.c | 2 +- lib/efi_selftest/efi_selftest_textoutput.c | 12 +- .../efi_selftest_unicode_collation.c | 38 +++---- lib/efi_selftest/efi_selftest_util.c | 106 +++++++++--------- lib/efi_selftest/efi_selftest_variables.c | 22 ++-- .../efi_selftest_variables_runtime.c | 4 +- lib/efi_selftest/initrddump.c | 60 +++++----- scripts/checkpatch.pl | 7 +- scripts/kconfig/Makefile | 14 ++- 39 files changed, 305 insertions(+), 273 deletions(-) -- 2.32.0.402.g57bb445576-goog

3 19

[PATCH 1/1] doc: add pkg-config to the build dependencies
by Heinrich Schuchardt 02 Aug '21

02 Aug '21

tools/Makefile uses pkg-config. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- doc/build/gcc.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/build/gcc.rst b/doc/build/gcc.rst index e03e0b9460..0cdc307d57 100644 --- a/doc/build/gcc.rst +++ b/doc/build/gcc.rst @@ -26,8 +26,8 @@ Depending on the build targets further packages maybe needed sudo apt-get install bc bison build-essential coccinelle \ device-tree-compiler dfu-util efitools flex gdisk graphviz imagemagick \ liblz4-tool libguestfs-tools libncurses-dev libpython3-dev libsdl2-dev \ - libssl-dev lz4 lzma lzma-alone openssl python3 python3-coverage \ - python3-pycryptodome python3-pyelftools python3-pytest \ + libssl-dev lz4 lzma lzma-alone openssl pkg-config python3 \ + python3-coverage python3-pycryptodome python3-pyelftools python3-pytest \ python3-sphinxcontrib.apidoc python3-sphinx-rtd-theme python3-virtualenv \ swig -- 2.30.2

1 0

U-boot
by Roman Kopytin 02 Aug '21

02 Aug '21

Hello, dear U-boot team I have question about your old feature: U-boot patch for adding of the public key to dtb file. https://patchwork.ozlabs.org/project/uboot/patch/1363650725-30459-37-git-se… I can’t understand, can we work only with public key? Why do we need to have private key for adding step? In documentation it is not very clear for me. Thanks a lot.

5 13

[PATCH v2 0/9] efi_loader: capsule: improve capsule authentication support
by AKASHI Takahiro 02 Aug '21

02 Aug '21

As I proposed and discussed in [1] and [2], I have made a couple of improvements on the current implementation of capsule update in this patch set. * add signing feature to mkeficapsule * add "--guid" option to mkeficapsule * add man page of mkeficapsule * add pytest for capsule authentication (on sandbox) NOTE: Due to Ilias's commit[3], we need to have a customized configuration for sandbox to properly set up and run capsule authentication test. See patch#5,#6 and #7. [1] https://lists.denx.de/pipermail/u-boot/2021-April/447918.html [2] https://lists.denx.de/pipermail/u-boot/2021-July/455292.html [3] commit ddf67daac39d ("efi_capsule: Move signature from DTB to .rodata") Prerequisite patches ==================== None Test ==== * locally passed the pytest which is included in this patch series on sandbox built. Todo ==== * Confirm that the change in .gitlab-ci.yml works. * Azure support(?) Changes ======= v2 (July 28, 2021) * rebased on v2021.10-rc* * removed dependency on target's configuration * removed fdtsig.sh and others * add man page * update the UEFI document * add dedicate defconfig for testing on sandbox * add gitlab CI support * add "--guid" option to mkeficapsule (yet rather RFC) Initial release (May 12, 2021) * based on v2021.07-rc2 AKASHI Takahiro (9): tools: mkeficapsule: add firmwware image signing tools: mkeficapsule: add man page doc: update UEFI document for usage of mkeficapsule efi_loader: ease the file path check for public key test/py: efi_capsule: add image authentication test sandbox: add config for efi capsule authentication test GitLab: add a test rule for efi capsule authentication test tools: mkeficapsule: allow for specifying GUID explicitly test/py: efi_capsule: align with the syntax change of mkeficapsule .gitlab-ci.yml | 6 + MAINTAINERS | 1 + configs/sandbox_capsule_auth_defconfig | 307 +++++++++++++++ doc/develop/uefi/uefi.rst | 31 +- doc/mkeficapsule.1 | 98 +++++ lib/efi_loader/Makefile | 5 +- test/py/tests/test_efi_capsule/SIGNER.crt | 19 + test/py/tests/test_efi_capsule/SIGNER.esl | Bin 0 -> 829 bytes test/py/tests/test_efi_capsule/SIGNER.key | 28 ++ test/py/tests/test_efi_capsule/SIGNER2.crt | 19 + test/py/tests/test_efi_capsule/SIGNER2.key | 28 ++ .../py/tests/test_efi_capsule/capsule_defs.py | 5 + test/py/tests/test_efi_capsule/conftest.py | 39 +- .../test_capsule_firmware_signed.py | 228 +++++++++++ tools/Kconfig | 7 + tools/Makefile | 8 +- tools/mkeficapsule.c | 368 ++++++++++++++++-- 17 files changed, 1129 insertions(+), 68 deletions(-) create mode 100644 configs/sandbox_capsule_auth_defconfig create mode 100644 doc/mkeficapsule.1 create mode 100644 test/py/tests/test_efi_capsule/SIGNER.crt create mode 100644 test/py/tests/test_efi_capsule/SIGNER.esl create mode 100644 test/py/tests/test_efi_capsule/SIGNER.key create mode 100644 test/py/tests/test_efi_capsule/SIGNER2.crt create mode 100644 test/py/tests/test_efi_capsule/SIGNER2.key create mode 100644 test/py/tests/test_efi_capsule/test_capsule_firmware_signed.py -- 2.31.0

4 29

[PATCH v2 00/14] lib: Add support for a decimal 0t prefix for numbers
by Simon Glass 02 Aug '21

02 Aug '21

2 25