May 2021 - U-Boot

[PATCH 1/5] rut: disable video after DM_VIDEO conversion deadline
by Anatolij Gustschin 26 May '21

26 May '21

The board was not converted to DM_VIDEO before deadline, so disable video support for now. Signed-off-by: Anatolij Gustschin <agust(a)denx.de> Cc: Samuel Egli <samuel.egli(a)siemens.com> --- configs/rut_defconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configs/rut_defconfig b/configs/rut_defconfig index 6fc06f1ed9..5b15789100 100644 --- a/configs/rut_defconfig +++ b/configs/rut_defconfig @@ -101,10 +101,10 @@ CONFIG_USB_GADGET_VENDOR_NUM=0x0908 CONFIG_USB_GADGET_PRODUCT_NUM=0x02d2 CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_USB_ETHER=y -CONFIG_VIDEO=y +# CONFIG_VIDEO is not set # CONFIG_VIDEO_SW_CURSOR is not set CONFIG_SYS_CONSOLE_BG_COL=0xff CONFIG_SYS_CONSOLE_FG_COL=0x00 CONFIG_SPLASH_SCREEN=y CONFIG_SPLASH_SCREEN_ALIGN=y -CONFIG_VIDEO_BMP_RLE8=y +# CONFIG_VIDEO_BMP_RLE8 is not set -- 2.17.1

1 5

[PATCH] efi_loader: Fix coverity warnings for efi tcg2 protocol
by Ilias Apalodimas 26 May '21

26 May '21

Coverity reported 3 warnings on the current code. CID 331856, 331855, 331854 on the latest scan. Fix the rest of the warnings by initializing the variables before passing them to tpm2_get_pcr_info(). In order to avoid future warnings and errors initialize them to 0 within the function as well, since the values are always OR'ed after querying the hardware. Signed-off-by: Ilias Apalodimas <ilias.apalodimas(a)linaro.org> --- lib/efi_loader/efi_tcg2.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg2.c index 39074f754772..ee743f5951fb 100644 --- a/lib/efi_loader/efi_tcg2.c +++ b/lib/efi_loader/efi_tcg2.c @@ -403,6 +403,9 @@ static int tpm2_get_pcr_info(struct udevice *dev, u32 *supported_pcr, size_t i; int tpm_ret; + *supported_pcr = 0; + *active_pcr = 0; + *pcr_banks = 0; memset(response, 0, sizeof(response)); ret = tpm2_get_capability(dev, TPM2_CAP_PCRS, 0, response, 1); if (ret) @@ -481,7 +484,7 @@ out: static efi_status_t __get_active_pcr_banks(u32 *active_pcr_banks) { struct udevice *dev; - u32 active, supported, pcr_banks; + u32 active = 0, supported = 0, pcr_banks = 0; efi_status_t ret; int err; @@ -900,7 +903,7 @@ static efi_status_t create_specid_event(struct udevice *dev, void *buffer, struct tcg_efi_spec_id_event *spec_event; size_t spec_event_size; efi_status_t ret = EFI_DEVICE_ERROR; - u32 active, supported; + u32 active = 0, supported = 0; int err; size_t i; -- 2.31.1

1 0

IRC server access
by Tom Rini 26 May '21

26 May '21

Hey all, As you might have seen elsewhere, the Freenode IRC network is undergoing some changes. As such, I've moved over to Libera.Chat (irc.libera.chat) and updated the wiki page to note this. Thanks all. -- Tom

1 0

[scan-admin@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]
by Tom Rini 26 May '21

26 May '21

----- Forwarded message from scan-admin(a)coverity.com ----- Date: Tue, 25 May 2021 01:05:20 +0000 (UTC) From: scan-admin(a)coverity.com To: tom.rini(a)gmail.com Subject: New Defects reported by Coverity Scan for Das U-Boot Hi, Please find the latest report on new defect(s) introduced to Das U-Boot found with Coverity Scan. 3 new defect(s) introduced to Das U-Boot found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 331856: Uninitialized variables (UNINIT) ________________________________________________________________________________________________________ *** CID 331856: Uninitialized variables (UNINIT) /lib/efi_loader/efi_tcg2.c: 921 in create_specid_event() 915 spec_event->spec_version_major = 916 TCG_EFI_SPEC_ID_EVENT_SPEC_VERSION_MAJOR_TPM2; 917 spec_event->spec_errata = 918 TCG_EFI_SPEC_ID_EVENT_SPEC_VERSION_ERRATA_TPM2; 919 spec_event->uintn_size = sizeof(efi_uintn_t) / sizeof(u32); 920 >>> CID 331856: Uninitialized variables (UNINIT) >>> Using uninitialized value "supported" when calling "tpm2_get_pcr_info". 921 err = tpm2_get_pcr_info(dev, &supported, &active, 922 &spec_event->number_of_algorithms); 923 if (err) 924 goto out; 925 if (spec_event->number_of_algorithms > MAX_HASH_COUNT || 926 spec_event->number_of_algorithms < 1) ** CID 331855: Uninitialized variables (UNINIT) ________________________________________________________________________________________________________ *** CID 331855: Uninitialized variables (UNINIT) /lib/efi_loader/efi_tcg2.c: 921 in create_specid_event() 915 spec_event->spec_version_major = 916 TCG_EFI_SPEC_ID_EVENT_SPEC_VERSION_MAJOR_TPM2; 917 spec_event->spec_errata = 918 TCG_EFI_SPEC_ID_EVENT_SPEC_VERSION_ERRATA_TPM2; 919 spec_event->uintn_size = sizeof(efi_uintn_t) / sizeof(u32); 920 >>> CID 331855: Uninitialized variables (UNINIT) >>> Using uninitialized value "active" when calling "tpm2_get_pcr_info". 921 err = tpm2_get_pcr_info(dev, &supported, &active, 922 &spec_event->number_of_algorithms); 923 if (err) 924 goto out; 925 if (spec_event->number_of_algorithms > MAX_HASH_COUNT || 926 spec_event->number_of_algorithms < 1) ** CID 331854: Control flow issues (NO_EFFECT) /lib/efi_loader/efi_tcg2.c: 752 in efi_tcg2_hash_log_extend_event() ________________________________________________________________________________________________________ *** CID 331854: Control flow issues (NO_EFFECT) /lib/efi_loader/efi_tcg2.c: 752 in efi_tcg2_hash_log_extend_event() 746 if (efi_tcg_event->size < efi_tcg_event->header.header_size + 747 sizeof(u32)) { 748 ret = EFI_INVALID_PARAMETER; 749 goto out; 750 } 751 >>> CID 331854: Control flow issues (NO_EFFECT) >>> This less-than-zero comparison of an unsigned value is never true. "efi_tcg_event->header.pcr_index < 0U". 752 if (efi_tcg_event->header.pcr_index < 0 || 753 efi_tcg_event->header.pcr_index > TPM2_MAX_PCRS) { 754 ret = EFI_INVALID_PARAMETER; 755 goto out; 756 } 757 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P… To manage Coverity Scan email notifications for "tom.rini(a)gmail.com", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P… ----- End forwarded message ----- -- Tom

1 0

problems with boards with CONFIG_DM disabled
by Marek Behun 26 May '21

26 May '21

Tom, Simon, now that LTO is merged I am working on Support SPI NORs and OF partitions in `mtd list` but CI fails for some boards, see https://github.com/u-boot/u-boot/pull/55 The reason is that there are still several boards which do not use CONFIG_DM. On the previous version Simon commented that I should use if (IS_ENABLED(...)) instead of #if but this does not currently work for those boards with CONFIG_DM disabled (struct udevice's members are not visible at all, and functions from dm/device.h do not exist). There are multiple possible workarounds: - use #if (until all boards are at CONFIG_DM) - create static inline versions of functions from dm/device.h returning failures when CONFIG_DM is not set (this would be rather big :( ) - wait till all those boards with CONFIG_DM disabled are removed - ... What should I do? Thanks, Marek

3 3

[PULL] u-boot-mips
by Daniel Schwierzeck 26 May '21

26 May '21

Hi Tom, please pull a minor bugfix for MIPS64 Octeon and the removal of qemu_mips boards. Gitlab: https://source.denx.de/u-boot/custodians/u-boot-mips/-/pipelines/7625 Azure: https://dev.azure.com/danielschwierzeck/u-boot/_build/results?buildId=24&vi… The following changes since commit e1bf0336a58cfe873a34c36ff53e5e3806f2d263: Prepare v2021.07-rc3 (2021-05-24 20:53:13 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-mips.git/ tags/mips-pull-2021-05-25 for you to fetch changes up to 835b4fdf3bf5ec778e1fb7610f00707754454974: doc: update and fix Qemu MIPS documentation (2021-05-25 15:35:06 +0200) ---------------------------------------------------------------- - MIPS: octeon: fix CFI flash setup - MIPS: remove qemu_mips boards ---------------------------------------------------------------- Daniel Schwierzeck (2): MIPS: remove deprecated qemu_mips board doc: update and fix Qemu MIPS documentation Stefan Roese (1): mips: octeon: octeon_ebb7304_defconfig: Fix CFI flash setup .azure-pipelines.yml | 12 -- .gitlab-ci.yml | 24 ---- arch/mips/Kconfig | 11 -- board/qemu-mips/Kconfig | 26 ---- board/qemu-mips/MAINTAINERS | 14 -- board/qemu-mips/Makefile | 7 - board/qemu-mips/lowlevel_init.S | 40 ------ board/qemu-mips/qemu-mips.c | 85 ------------ configs/octeon_ebb7304_defconfig | 5 +- configs/qemu_mips64_defconfig | 29 ---- configs/qemu_mips64el_defconfig | 30 ----- configs/qemu_mips_defconfig | 27 ---- configs/qemu_mipsel_defconfig | 28 ---- doc/board/emulation/qemu-mips.rst | 273 +++++++++++--------------------------- include/configs/qemu-mips.h | 89 ------------- include/configs/qemu-mips64.h | 89 ------------- scripts/config_whitelist.txt | 1 - 17 files changed, 81 insertions(+), 709 deletions(-) delete mode 100644 board/qemu-mips/Kconfig delete mode 100644 board/qemu-mips/MAINTAINERS delete mode 100644 board/qemu-mips/Makefile delete mode 100644 board/qemu-mips/lowlevel_init.S delete mode 100644 board/qemu-mips/qemu-mips.c delete mode 100644 configs/qemu_mips64_defconfig delete mode 100644 configs/qemu_mips64el_defconfig delete mode 100644 configs/qemu_mips_defconfig delete mode 100644 configs/qemu_mipsel_defconfig delete mode 100644 include/configs/qemu-mips.h delete mode 100644 include/configs/qemu-mips64.h

2 5

Pull request for efi-2021-07-rc4
by Heinrich Schuchardt 26 May '21

26 May '21

Dear Tom, The following changes since commit e1bf0336a58cfe873a34c36ff53e5e3806f2d263: Prepare v2021.07-rc3 (2021-05-24 20:53:13 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-efi.git tags/efi-2021-07-rc4 for you to fetch changes up to 1f6871df40d6ad94a00a2dcd46f3cc91b232c4d6: efi_loader: Fix -Wextra warning for EFI TCG2 (2021-05-25 14:33:22 +0200) Gitlab reported no problems: https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/7623 ---------------------------------------------------------------- Pull request for efi-2021-07-rc4 Documentation: * correct mmc man-page Bug fixes: * reduce code size of efidebug command * remove 31 character limit for file paths in efidebug command * fix build warning in the TCG2 protocol implementation ---------------------------------------------------------------- Heinrich Schuchardt (6): efi_loader: remove weak efi_get_public_key_data() efi_loader: path length in efi_dp_from_name() efi_loader: simplify show_efi_boot_opt_data() efi_loader: simplify show_efi_boot_order() efi_loader: use efi_create_indexed_name() efi_loader: simplify accessing variables Ilias Apalodimas (1): efi_loader: Fix -Wextra warning for EFI TCG2 Jaehoon Chung (1): doc: usage: modify mmc man-page Masahisa Kojima (1): efi_loader: expose efi_image_parse() even if UEFI Secure Boot is disabled cmd/efidebug.c | 96 ++++++++++++++------------------------- doc/usage/mmc.rst | 3 +- lib/efi_loader/Kconfig | 5 ++ lib/efi_loader/Makefile | 2 +- lib/efi_loader/efi_capsule.c | 10 ---- lib/efi_loader/efi_device_path.c | 9 +++- lib/efi_loader/efi_image_loader.c | 64 +++++++++++++++++++++++++- lib/efi_loader/efi_signature.c | 67 +-------------------------- lib/efi_loader/efi_tcg2.c | 40 ++++++++-------- lib/efi_loader/efi_var_common.c | 3 ++ 10 files changed, 137 insertions(+), 162 deletions(-)

2 1

[PATCH] spi: zynqmp_gqspi: Fix write issue
by Ashok Reddy Soma 26 May '21

26 May '21

Enable manual start in zynqmp_qspi_fill_gen_fifo(). Also enable GQSPI_IXR_GFNFULL_MASK and check for it instead of GQSPI_IXR_GFEMTY_MASK. Add dummy write to genfifo register in chipselect. Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma(a)xilinx.com> --- drivers/spi/zynqmp_gqspi.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/spi/zynqmp_gqspi.c b/drivers/spi/zynqmp_gqspi.c index 17780066ae..fc81b07343 100644 --- a/drivers/spi/zynqmp_gqspi.c +++ b/drivers/spi/zynqmp_gqspi.c @@ -39,6 +39,7 @@ #define GQSPI_IXR_TXFULL_MASK 0x00000008 /* QSPI TX FIFO is full */ #define GQSPI_IXR_RXNEMTY_MASK 0x00000010 /* QSPI RX FIFO Not Empty */ #define GQSPI_IXR_GFEMTY_MASK 0x00000080 /* QSPI Generic FIFO Empty */ +#define GQSPI_IXR_GFNFULL_MASK 0x00000200 /* QSPI GENFIFO not full */ #define GQSPI_IXR_ALL_MASK (GQSPI_IXR_TXNFULL_MASK | \ GQSPI_IXR_RXNEMTY_MASK) @@ -238,9 +239,21 @@ static void zynqmp_qspi_fill_gen_fifo(struct zynqmp_qspi_priv *priv, u32 gqspi_fifo_reg) { struct zynqmp_qspi_regs *regs = priv->regs; + u32 config_reg, ier; int ret = 0; - ret = wait_for_bit_le32(&regs->isr, GQSPI_IXR_GFEMTY_MASK, 1, + config_reg = readl(&regs->confr); + /* Manual start if needed */ + config_reg |= GQSPI_STRT_GEN_FIFO; + writel(config_reg, &regs->confr); + + /* Enable interrupts */ + ier = readl(&regs->ier); + ier |= GQSPI_IXR_GFNFULL_MASK; + writel(ier, &regs->ier); + + /* Wait until the fifo is not full to write the new command */ + ret = wait_for_bit_le32(&regs->isr, GQSPI_IXR_GFNFULL_MASK, 1, GQSPI_TIMEOUT, 1); if (ret) printf("%s Timeout\n", __func__); @@ -263,6 +276,9 @@ static void zynqmp_qspi_chipselect(struct zynqmp_qspi_priv *priv, int is_on) debug("GFIFO_CMD_CS: 0x%x\n", gqspi_fifo_reg); + /* Dummy generic FIFO entry */ + zynqmp_qspi_fill_gen_fifo(priv, 0); + zynqmp_qspi_fill_gen_fifo(priv, gqspi_fifo_reg); } -- 2.17.1

2 1

Uboot raspberry pi watchdog disabled by mistake
by Laurentiu-Cristian Duca 26 May '21

26 May '21

Hello uboot community, In 2019, commit [1] deleted commit [2]. Commit [2] implemented the watchdog feature for raspberry pi. The delete reason is, I quote, "The BCM2835/2836 watchdog is not used in mainline U-Boot at all". I am using commit [2] in conjunction with bootlimit: - uboot increments bootcount, enables watchdog and boots linux using bootcmd - if linux hangs, the watchdog resets the board - in uboot, if bootcount > bootlimit then boot using altbootcmd and boots another partition with linux So, there is use of commit [2] and I consider that commit [1] is a mistake. [1] https://lists.denx.de/pipermail/u-boot/2019-May/369007.html [2] https://lists.denx.de/pipermail/u-boot/2017-January/279573.html Thank you, L-C. Duca

1 0

[PATCH] net: ravb: Add additional refclk
by Adam Ford 26 May '21

26 May '21

The ethernet requires an external reference clock, and the driver currently assumes the clock is always running. For devices using a programmable clock, this may not be true. Add an optional clock called 'refclk' to open and enable the refclk for hardware running with programmable clocks. Signed-off-by: Adam Ford <aford173(a)gmail.com> --- This was also done in the Linux kernel, see: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/d… diff --git a/drivers/net/ravb.c b/drivers/net/ravb.c index 6953b7286a..ced80485de 100644 --- a/drivers/net/ravb.c +++ b/drivers/net/ravb.c @@ -130,6 +130,7 @@ struct ravb_priv { struct mii_dev *bus; void __iomem *iobase; struct clk clk; + struct clk *refclk; struct gpio_desc reset_gpio; }; @@ -489,6 +490,8 @@ static int ravb_probe(struct udevice *dev) if (ret < 0) goto err_mdio_alloc; + eth->refclk = devm_clk_get_optional(dev, "refclk"); + ret = dev_read_phandle_with_args(dev, "phy-handle", NULL, 0, 0, &phandle_args); if (!ret) { gpio_request_by_name_nodev(phandle_args.node, "reset-gpios", 0, @@ -522,6 +525,10 @@ static int ravb_probe(struct udevice *dev) if (ret) goto err_mdio_register; + ret = clk_enable(eth->refclk); + if (ret) + goto err_disable_clk; + ret = ravb_reset(dev); if (ret) goto err_mdio_reset; @@ -533,6 +540,8 @@ static int ravb_probe(struct udevice *dev) return 0; err_mdio_reset: + clk_disable(eth->refclk); +err_disable_clk: clk_disable(&eth->clk); err_mdio_register: mdio_free(mdiodev); @@ -545,6 +554,7 @@ static int ravb_remove(struct udevice *dev) { struct ravb_priv *eth = dev_get_priv(dev); + clk_disable(eth->refclk); clk_disable(&eth->clk); free(eth->phydev); -- 2.25.1

2 1