May 2021 - U-Boot

[PATCH 0/5] assorted printf-related patches
by Rasmus Villemoes 19 Jun '21

19 Jun '21

The first patch ensures that vsnprintf() never returns a negative value. Finding (indirect) callers and having them all handle that would be a whack-a-mole game for no real gain. Even if the callers don't directly use the return value, they might rely on vsnprintf() always producing a nul-terminated string, which is not the case if we do an early "return -Esomething". The last fixes a bug I found while looking for impact of %pD returning a negative value. The second and fourth reduce the size of vsprintf.o a little. Rasmus Villemoes (5): lib/vsprintf.c: make sure vsnprintf() never returns a negative value lib/vsprintf.c: implement printf() in terms of vprintf() lib/vsprintf.c: remove stale comment lib/vsprintf.c: remove unused ip6_addr_string() common/log.c: use vscnprintf() in log_dispatch() common/log.c | 2 +- lib/vsprintf.c | 28 ++++++---------------------- 2 files changed, 7 insertions(+), 23 deletions(-) -- 2.29.2

5 21

[PATCH 0/2] reset: Fix the behavior of optional reset
by Kishon Vijay Abraham I 19 Jun '21

19 Jun '21

This series is a result of discussion in [1] This series does not return NULL for optional resets so that the client driver knows whether it had obtained a reset or not. If it returns -ENODATA, that would mean reset controller is not obtained. However the reset API's wil not abort or throw error and handle gracefully if it's passed -ENODATA. [1] -> https://patchwork.ozlabs.org/project/uboot/patch/20210504104155.19222-4-kis… Kishon Vijay Abraham I (2): reset: Do not return NULL on error for devm_reset_control_get_optional() reset: Let reset API's handle gracefully if reset_ctl is -ENODATA drivers/reset/reset-uclass.c | 51 ++++++++++++++++++------------ drivers/reset/sandbox-reset-test.c | 2 +- 2 files changed, 32 insertions(+), 21 deletions(-) -- 2.17.1

3 13

Multi-Soc binary support for i.MX8M Mini/Nano/Plus/? in single boot firmware binary
by Tim Harvey 18 Jun '21

18 Jun '21

Greetings, I support various iMX8M PCB's via board/gateworks/venice that are SOM based and we are starting to add SOM's that have different IMX8M variant SoC's on them which for various reasons are not binary compatible. I'm very interested in coming up with a way to make them binary compatible to reduce the number of disk images and boot firmware binaries our users work with (along with the confusion of which one they need to use). >From what I see in working thus far with the IMX8M Mini, Nano, and Plus boot firmware differs in the following ways: - different primary image offsets - different dram config (phy training blob, phy cfg, cfg; which total about 3KiB for each config which varies based on dram type, soc variant, dram topology and bit-mapping) - different OCRAM sizes (compat binary would have to use the minimum size ie 256K) - different ATF binaries - different ATF load address - different pinmux/padconf/inputsel registers - different clk config The primary image offsets should be able to be dealt with by placing jumps at the various offsets and I believe the rest could be dealt with via runtime code if the SPL could load soc-specific blobs including dram config, ATF, binary firmware blobs from a nice indexed image such as FIT or binman. Currently imx8m SPL's use FIT images that are loaded entirely into OCRAM which becomes an issue when you have enough dram configs that they no longer fit in the OCRAM. Does anyone agree this is doable or is there something they see that would be a show-stopper? I'm not all that familiar with the merits of binman fs FIT images... I think they were developed for different things. I'm not sure if either/both are suited for what I'm talking about regarding having the SPL raw load binary blobs vs having them tacked onto a FIT image. I'm not sure if the imx8mq has enough in common to be able to do this with either, in fact I'm not even clear with SoC that is (is it what NXP calls i.MX 8M?) Best regards, Tim

4 4

[PATCH] cmd: pxe_utils: sysboot: fix crash if either board or soc are not set.
by Dimitri John Ledkov 18 Jun '21

18 Jun '21

If the environment does not have "soc" or "board" set, and fdtdir option is specified in extlinux.conf, the bootloader will crash whilst dereferencing a null pointer. Add a guard against null soc or board. Fixes a crash of qemu-riscv64_smode configuration, which does not have CONFIG_SYS_SOC defined. Signed-off-by: Dimitri John Ledkov <xnox(a)ubuntu.com> --- cmd/pxe_utils.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/cmd/pxe_utils.c b/cmd/pxe_utils.c index 71c5af4c25..9a30629e26 100644 --- a/cmd/pxe_utils.c +++ b/cmd/pxe_utils.c @@ -587,6 +587,14 @@ static int label_boot(struct cmd_tbl *cmdtp, struct pxe_label *label) f2 = "-"; f3 = env_get("board"); f4 = ".dtb"; + if (!f1) { + f1 = ""; + f2 = ""; + } + if (!f3) { + f2 = ""; + f3 = ""; + } } len = strlen(label->fdtdir); -- 2.27.0

3 4

[PATCH] dfu: dfu_mtd: set max_buf_size to erasesize also for NOR devices
by Patrick Delaunay 18 Jun '21

18 Jun '21

For NOR devices the logical DFU buffer size is the sector_size, as it is done in dfu_sf.c or in spi/sf_mtd.c (sf_mtd_info.erasesize = flash->sector_size) For NAND the DFU size was already limited to erasesize as has_pages = true. So the mtd dfu backend can use this erasesize for all the MTD devices, NOR and NAND with dfu->max_buf_size = mtd->erasesize This difference was initially copied from MTD command, where data is fully available in RAM without size limitation. This patch avoids to have many sector write in dfu_mtd.c at the end of the DFU transfer and avoids issues with USB timeout or WATCHDOG. Signed-off-by: Patrick Delaunay <patrick.delaunay(a)foss.st.com> --- drivers/dfu/dfu_mtd.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dfu/dfu_mtd.c b/drivers/dfu/dfu_mtd.c index ca67585a7e..7efb3cbd79 100644 --- a/drivers/dfu/dfu_mtd.c +++ b/drivers/dfu/dfu_mtd.c @@ -252,7 +252,6 @@ int dfu_fill_entity_mtd(struct dfu_entity *dfu, char *devstr, char *s) { char *st; struct mtd_info *mtd; - bool has_pages; int ret, part; mtd = get_mtd_device_nm(devstr); @@ -262,9 +261,7 @@ int dfu_fill_entity_mtd(struct dfu_entity *dfu, char *devstr, char *s) dfu->dev_type = DFU_DEV_MTD; dfu->data.mtd.info = mtd; - - has_pages = mtd->type == MTD_NANDFLASH || mtd->type == MTD_MLCNANDFLASH; - dfu->max_buf_size = has_pages ? mtd->erasesize : 0; + dfu->max_buf_size = mtd->erasesize; st = strsep(&s, " "); if (!strcmp(st, "raw")) { -- 2.17.1

4 4

[PATCH] net: dwc_eth_qos: Fix needless phy auto-negotiation restarts
by Daniil Stas 18 Jun '21

18 Jun '21

Disabling clk_ck clock leads to link up status loss in phy, which leads to auto-negotiation restart before each network command execution. This issue is especially big for PXE boot protocol because of auto-negotiation restarts before each configuration filename trial. To avoid this issue don't disable clk_ck clock after it was enabled. Signed-off-by: Daniil Stas <daniil.stas(a)posteo.net> Cc: Ramon Fried <rfried.dev(a)gmail.com> Cc: Joe Hershberger <joe.hershberger(a)ni.com> Cc: Patrick Delaunay <patrick.delaunay(a)foss.st.com> Cc: Patrice Chotard <patrice.chotard(a)foss.st.com> --- drivers/net/dwc_eth_qos.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c index e8242ca4e1..2f088c758f 100644 --- a/drivers/net/dwc_eth_qos.c +++ b/drivers/net/dwc_eth_qos.c @@ -321,6 +321,7 @@ struct eqos_priv { void *rx_pkt; bool started; bool reg_access_ok; + bool clk_ck_enabled; }; /* @@ -591,12 +592,13 @@ static int eqos_start_clks_stm32(struct udevice *dev) goto err_disable_clk_rx; } - if (clk_valid(&eqos->clk_ck)) { + if (clk_valid(&eqos->clk_ck) && !eqos->clk_ck_enabled) { ret = clk_enable(&eqos->clk_ck); if (ret < 0) { pr_err("clk_enable(clk_ck) failed: %d", ret); goto err_disable_clk_tx; } + eqos->clk_ck_enabled = true; } #endif @@ -648,8 +650,6 @@ static void eqos_stop_clks_stm32(struct udevice *dev) clk_disable(&eqos->clk_tx); clk_disable(&eqos->clk_rx); clk_disable(&eqos->clk_master_bus); - if (clk_valid(&eqos->clk_ck)) - clk_disable(&eqos->clk_ck); #endif debug("%s: OK\n", __func__); -- 2.31.0

4 10

[PATCH 00/10] stm32mp: stm32prog: several features and fixes
by Patrick Delaunay 18 Jun '21

18 Jun '21

This serie provides several evolution and patches for the command stm32prog used on STM32MP platform to communicate with the STMicroelectonics tools STM32CubeProgrammer. Patrick Delaunay (10): stm32mp: stm32prog: remove all the header check for UART download stm32mp: stm32prog: add timeout in stm32prog_serial_get_buffer stm32mp: stm32prog: add support of initrd in flashlayout stm32mp: stm32prog: solve compilation with CONFIG_FIT_SIGNATURE stm32mp: stm32prog: handle the next phase after USB re-enumeration stm32mp: stm32prog: correctly handle DM_PMIC stm32mp: stm32prog: use get_cpu_dev for GetID command stm32mp: stm32prog: change one message level to debug dfu: add error callback stm32mp: stm32prog: handle dfu error .../cmd_stm32prog/cmd_stm32prog.c | 26 ++- .../mach-stm32mp/cmd_stm32prog/stm32prog.c | 43 +++-- .../mach-stm32mp/cmd_stm32prog/stm32prog.h | 7 +- .../cmd_stm32prog/stm32prog_serial.c | 173 ++++-------------- .../cmd_stm32prog/stm32prog_usb.c | 7 +- drivers/dfu/dfu.c | 12 ++ include/dfu.h | 11 ++ 7 files changed, 108 insertions(+), 171 deletions(-) -- 2.17.1

3 31

[PATCH] clk: cosmetic change in uclass
by Patrick Delaunay 18 Jun '21

18 Jun '21

Remove the tab in clk_get_bulk to respect the coding rules. Signed-off-by: Patrick Delaunay <patrick.delaunay(a)foss.st.com> --- drivers/clk/clk-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c index 4ab3c402ed..b126c5ed60 100644 --- a/drivers/clk/clk-uclass.c +++ b/drivers/clk/clk-uclass.c @@ -159,7 +159,7 @@ int clk_get_by_index_nodev(ofnode node, int index, struct clk *clk) int clk_get_bulk(struct udevice *dev, struct clk_bulk *bulk) { int i, ret, err, count; - + bulk->count = 0; count = dev_count_phandle_with_args(dev, "clocks", "#clock-cells", 0); -- 2.17.1

2 2

u-boot on RPi4 32bit - issue after upgrading the firmware
by Marek Szyprowski 17 Jun '21

17 Jun '21

Hi! Recently I've upgraded a video core firmware on my RPi4 and I've noticed that u-boot in ARM 32bit mode stopped working properly or even randomly crashes. I've bisected the firmware releases and the issue appears for the first time in the commit 63b1922311 ("firmware: arm_loader: Update armstubs with those from PR 117 See: https://github.com/raspberrypi/tools/pull/117"). This issue can be easily observed as a failure of the xhci. See the attached log: Read start4x.elf bytes 2984808 hnd 0x000006e2 sha256 d21bf9d3954fea04 Read fixup4x.dat bytes 8432 hnd 0x000006dd sha256 10d3b073ab232613 0x00a03111 0x00000000 0x0000001f MEM GPU: 76 ARM: 948 TOTAL: 1024 Starting start4x.elf @ 0xfec00200 partition 0 PCI reset + MESS:00:00:04.800023:0: arasan: arasan_emmc_open MESS:00:00:04.975752:0: brfs: File read: /mfs/sd/config.txt MESS:00:00:04.979162:0: brfs: File read: 2153 bytes MESS:00:00:05.046081:0: brfs: File read: /mfs/sd/config.txt MESS:00:00:06.121174:0: gpioman: gpioman_get_pin_num: pin DISPLAY_DSI_PORT not defined MESS:00:00:06.128433:0: *** Restart logging MESS:00:00:06.129897:0: brfs: File read: 2153 bytes MESS:00:00:06.148533:0: hdmi: HDMI:hdmi_get_state is deprecated, use hdmi_get_display_state instead MESS:00:00:06.154474:0: HDMI0: hdmi_pixel_encoding: 300000000 MESS:00:00:06.159948:0: HDMI1: hdmi_pixel_encoding: 300000000 MESS:00:00:06.166901:0: dtb_file 'bcm2711-rpi-4-b.dtb' MESS:00:00:06.178359:0: brfs: File read: /mfs/sd/bcm2711-rpi-4-b.dtb MESS:00:00:06.181601:0: Loading 'bcm2711-rpi-4-b.dtb' to 0x100 size 0xc901 MESS:00:00:06.201386:0: brfs: File read: 51457 bytes MESS:00:00:06.267975:0: brfs: File read: /mfs/sd/config.txt MESS:00:00:06.270915:0: dtparam: audio=on MESS:00:00:06.283974:0: brfs: File read: 2153 bytes MESS:00:00:06.286148:0: Failed to load overlay 'vc4-fkms-v3d' MESS:00:00:06.291378:0: brfs: File read: /mfs/sd/overlays/vc4-fkms-v3d.dtbo MESS:00:00:06.304096:0: Failed to open command line file 'cmdline.txt' MESS:00:00:07.484256:0: brfs: File read: /mfs/sd/u-boot.bin MESS:00:00:07.486726:0: Loading 'u-boot.bin' to 0x8000 size 0x84cf4 MESS:00:00:07.492726:0: Device tree loaded to 0x2eff3100 (size 0xce24) MESS:00:00:07.500863:0: uart: Set PL011 baud rate to 103448.300000 Hz MESS:00:00:07.508031:0: uart: Baud rate change done... MESS:00:00:07.510053:0: U-Boot 2021.04-rc2 (Feb 25 2021 - 11:21:44 +0100) DRAM: 948 MiB RPI 4 Model B (0xa03111) MMC: mmcnr@7e300000: 1, emmc2@7e340000: 0 Loading Environment from FAT... OK In: serial Out: serial Err: serial Net: eth0: ethernet@7d580000 Hit any key to stop autoboot: 0 U-Boot> pci enum PCIe BRCM: link up, 5.0 Gbps x1 (SSC) U-Boot> usb start starting USB... Bus xhci_pci: Host not halted after 16000 microseconds. probe failed, error -16 No working controllers found U-Boot> Is it a known issue? In ARM64 mode everything works fine, but this not very surprising, because the firmware change in the mentioned commit is related to the ARM 32bit mode. Does anyone have an idea how to fix this issue? I've checked also the latest version of the RPi firmware, but the issue is still there. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

3 4

[PATCH v2 0/4] board: fsl: lx2160ardb: add networking support for RevC
by Ioana Ciornei 17 Jun '21

17 Jun '21

This patch set adds networking support for the LX2160A-RDB revC board. The main difference is that the 10G Aquantia PHYs are at different MDIO bus addresses. To address this, the u-boot's DTS (in case of DM_ETH) and the kernel's DTS need to undergo a fixup. This patch set applies cleanly on top of the following, yet unnaccepted, patch: https://patchwork.ozlabs.org/project/uboot/patch/20210417180332.1164345-1-w… Changes in v2: - in 1/4: trigger the i2c node fixup if the board rev is 'C' or greater Florin Chiculita (3): board: fsl: lx2160ardb: add api for obtaining board revision board: fsl: lx2160ardb: add support for lx2160ardb revC board board: fsl: lx2160ardb: add dts fixup function for RevC Ioana Ciornei (1): board: fsl: lx2160ardb: add dts fixup for RevC board/freescale/lx2160a/eth_lx2160ardb.c | 160 ++++++++++++++++++++++- board/freescale/lx2160a/lx2160a.c | 21 ++- board/freescale/lx2160a/lx2160a.h | 7 +- include/configs/lx2160ardb.h | 5 +- 4 files changed, 186 insertions(+), 7 deletions(-) -- 2.17.1

2 6