March 2021 - U-Boot

U-boot : Request for support - Adding more u-boot environment variables to /inlcude/configs/<board>.h does not allow u-boot to start
by Kumar, Naveen AVL/DE 16 Mar '21

16 Mar '21

Dear Denx Team, I was facing an issue with uboot when I add more environment variables to #define CONFIG_EXTRA_ENV_SETTINGS in the file /inlcude/configs/<board>.h CASE 1: WORKING When I add fewer env variables CASE 2: HANGS at BL31 before the u-boot is loaded. See logs below: >[ 0.000147] NOTICE: BL2: R-Car H3 Initial Program Loader(CA57) [ 0.004586] NOTICE: BL2: Initial Program Loader(Rev.2.0.4) [ 0.010119] NOTICE: BL2: PRR is R-Car H3 Ver.2.0 [ 0.014787] NOTICE: BL2: Board is Starter Kit Rev.2.0 [ 0.019900] NOTICE: BL2: Boot device is HyperFlash(80MHz) [ 0.025325] NOTICE: BL2: LCM state is CM [ 0.029365] NOTICE: BL2: AVS setting succeeded. DVFS_SetVID=0x53 [ 0.035354] NOTICE: BL2: DDR3200(rev.0.37) [ 0.050622] NOTICE: BL2: [COLD_BOOT] [ 0.059403] NOTICE: BL2: DRAM Split is 4ch [ 0.062098] NOTICE: BL2: QoS is default setting(rev.0.21) [ 0.067541] NOTICE: BL2: DRAM refresh interval 1.95 usec [ 0.072898] NOTICE: BL2: Periodic Write DQ Training [ 0.077927] NOTICE: BL2: Lossy Decomp areas [ 0.082057] NOTICE: Entry 0: DCMPAREACRAx:0x80000540 DCMPAREACRBx:0x570 [ 0.089142] NOTICE: Entry 1: DCMPAREACRAx:0x40000000 DCMPAREACRBx:0x0 [ 0.096054] NOTICE: Entry 2: DCMPAREACRAx:0x20000000 DCMPAREACRBx:0x0 [ 0.102968] NOTICE: BL2: v1.5(release):236f8fb-dirty [ 0.107977] NOTICE: BL2: Built : 20:32:45, Mar 3 2020 [ 0.113164] NOTICE: BL2: Normal boot [ 0.116804] NOTICE: BL2: dst=0xe6325100 src=0x8180000 len=512(0x200) [ 0.123192] NOTICE: BL2: dst=0x43f00000 src=0x8180400 len=6144(0x1800) [ 0.129813] NOTICE: BL2: dst=0x44000000 src=0x81c0000 len=65536(0x10000) [ 0.137038] NOTICE: BL2: dst=0x44100000 src=0x8200000 len=1048576(0x100000) [ 0.151863] NOTICE: BL2: dst=0x50000000 src=0x8640000 len=1048576(0x100000) [ 0.165837] NOTICE: BL2: Booting BL31 FYI, I am using Renesas h3ulcb board for my work. Can you please check why am I facing this issue ? Kind regards, Naveen KUMAR Software & Functions Engineer naveen.kumar(a)avl.com<mailto:Naveen.Kumar@avl.com> AVL Software and Functions GmbH Im Gewerbepark B29, 93059 Regensburg Germany www.avl-functions.com [cid:image001.png@01D71A4B.3F558E80]<https://www.linkedin.com/company/avl-software-and-functions-gmbh> [cid:image002.png@01D71A4B.3F558E80]<https://www.xing.com/companies/avlsoftwareandfunctionsgmbh>

1 0

[PATCH v2 1/2] this: patman: Update documentation to match new usage
by Simon Glass 16 Mar '21

16 Mar '21

With the subcommands some of the documentation examples are no-longer correct. Fix all of them, so it is consistent. Signed-off-by: Simon Glass <sjg(a)chromium.org> --- (no changes since v1) tools/patman/README | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/patman/README b/tools/patman/README index 6b806632f8c..53f55ce95d4 100644 --- a/tools/patman/README +++ b/tools/patman/README @@ -136,17 +136,17 @@ How to run it First do a dry run: -$ ./tools/patman/patman -n +$ ./tools/patman/patman send -n If it can't detect the upstream branch, try telling it how many patches there are in your series: -$ ./tools/patman/patman -n -c5 +$ ./tools/patman/patman -c5 send -n This will create patch files in your current directory and tell you who it is thinking of sending them to. Take a look at the patch files. -$ ./tools/patman/patman -n -c5 -s1 +$ ./tools/patman/patman -c5 -s1 send -n Similar to the above, but skip the first commit and take the next 5. This is useful if your top commit is for setting up testing. @@ -433,12 +433,12 @@ but that you don't want to submit because there is an existing patch for it on the list. So you can tell patman to create and check some patches (skipping the first patch) with: - patman -s1 -n + patman -s1 send -n If you want to do all of them including the work-in-progress one, then (if you are tracking an upstream branch): - patman -n + patman send -n Let's say that patman reports an error in the second patch. Then: @@ -450,7 +450,7 @@ Let's say that patman reports an error in the second patch. Then: Now you have an updated patch series. To check it: - patman -s1 -n + patman -s1 send -n Let's say it is now clean and you want to send it. Now you need to set up the destination. So amend the top commit with: @@ -485,7 +485,7 @@ mmc and sparc, and the last one to sandbox. Now to send the patches, take off the -n flag: - patman -s1 + patman -s1 send The patches will be created, shown in your editor, and then sent along with the cover letter. Note that patman's tags are automatically removed so that -- 2.30.0.280.ga3ce27912f-goog

1 3

[PATCH v2 1/1] sandbox: allow cross-compiling sandbox
by Heinrich Schuchardt 16 Mar '21

16 Mar '21

UEFI test files like helloworld.efi require an architecture specific PE-COFF header. Currently this does not work for cross compiling. If $CROSS_COMPILE is set, use the first part of the architecture triplet from the variable to choose the PE-COFF header. Now we can cross-compile the sandbox, e.g. make sandbox_defconfig NO_SDL=1 CROSS_COMPILE=/opt/bin/aarch64-linux-gnu- NO_SDL=1 MK_ARCH=aarch64 make Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- v2: use $CROSS_COMPILE instead of an extra environment variable --- Makefile | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index ebbedb1fb1..6c256a23b6 100644 --- a/Makefile +++ b/Makefile @@ -17,9 +17,13 @@ NAME = # o Look for make include files relative to root of kernel src MAKEFLAGS += -rR --include-dir=$(CURDIR) -# Determine host architecture +# Determine target architecture for the sandbox include include/host_arch.h -MK_ARCH="${shell uname -m}" +ifeq ("", "$(CROSS_COMPILE)") + MK_ARCH="${shell uname -m}" +else + MK_ARCH="${shell echo $(CROSS_COMPILE) | sed -n 's/^\s*$[^\/]*\/$*$[^-]*$-\S*/\2/p'}" +endif unexport HOST_ARCH ifeq ("x86_64", $(MK_ARCH)) export HOST_ARCH=$(HOST_ARCH_X86_64) @@ -27,7 +31,7 @@ else ifneq (,$(findstring $(MK_ARCH), "i386" "i486" "i586" "i686")) export HOST_ARCH=$(HOST_ARCH_X86) else ifneq (,$(findstring $(MK_ARCH), "aarch64" "armv8l")) export HOST_ARCH=$(HOST_ARCH_AARCH64) -else ifeq ("armv7l", $(MK_ARCH)) +else ifneq (,$(findstring $(MK_ARCH), "arm" "armv7" "armv7l")) export HOST_ARCH=$(HOST_ARCH_ARM) else ifeq ("riscv32", $(MK_ARCH)) export HOST_ARCH=$(HOST_ARCH_RISCV32) -- 2.30.0

3 5

[PATCH] tools: fdtgrep: Use unsigned chars for arrays
by Samuel Dionne-Riel 16 Mar '21

16 Mar '21

Otherwise, values over 127 end up prefixed with ffffff. Signed-off-by: Samuel Dionne-Riel <samuel(a)dionne-riel.com> Cc: Simon Glass <sjg(a)chromium.org> --- Minimal reproduction: ``` // repro.dts /dts-v1/; / { ra = [ 7f ]; rb = [ 80 ]; }; ``` Steps used to compile: $ dtc repro.dts > repro.dtb Without the fix: $ fdtgrep --include-node / repro.dtb / { ra = [7f]; rb = [ffffff80]; }; With the fix: $ fdtgrep --include-node / repro.dtb / { ra = [7f]; rb = [80]; }; --- tools/fdtgrep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/fdtgrep.c b/tools/fdtgrep.c index e4112b8f69..db512465db 100644 --- a/tools/fdtgrep.c +++ b/tools/fdtgrep.c @@ -213,7 +213,7 @@ static void utilfdt_print_data(const char *data, int len) } else { printf(" = ["); for (i = 0; i < len; i++) - printf("%02x%s", *p++, i < len - 1 ? " " : ""); + printf("%02x%s", (unsigned char)*p++, i < len - 1 ? " " : ""); printf("]"); } } -- 2.29.2

2 2

[PATCH] mmc: pci: Fix Kconfig dependency
by Bin Meng 16 Mar '21

16 Mar '21

The PCI MMC driver depends on the generic MMC SDHCI driver, otherwise it does not compile. Signed-off-by: Bin Meng <bmeng.cn(a)gmail.com> --- drivers/mmc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig index f8ea921..3adee0a 100644 --- a/drivers/mmc/Kconfig +++ b/drivers/mmc/Kconfig @@ -304,6 +304,7 @@ config MMC_MXS config MMC_PCI bool "Support for MMC controllers on PCI" + depends on MMC_SDHCI help This selects PCI-based MMC controllers. If you have an MMC controller on a PCI bus, say Y here. -- 2.7.4

3 2

[PATCH] test: cmd: setexpr: Fix a typo
by Bin Meng 16 Mar '21

16 Mar '21

SETEXPR_TEST is for a new setexpr test, not mem. Signed-off-by: Bin Meng <bmeng.cn(a)gmail.com> --- test/cmd/setexpr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/cmd/setexpr.c b/test/cmd/setexpr.c index fd6d869..7067e1f 100644 --- a/test/cmd/setexpr.c +++ b/test/cmd/setexpr.c @@ -15,7 +15,7 @@ #define BUF_SIZE 0x100 -/* Declare a new mem test */ +/* Declare a new setexpr test */ #define SETEXPR_TEST(_name, _flags) UNIT_TEST(_name, _flags, setexpr_test) /* Test 'setexpr' command with simply setting integers */ -- 2.7.4

2 2

[PATCH] test: print_ut: Fix potential build error
by Bin Meng 16 Mar '21

16 Mar '21

This files uses the macro U_BOOT_CMD which is defined in command.h, but command.h is conditionally included. Fix it. Signed-off-by: Bin Meng <bmeng.cn(a)gmail.com> --- test/print_ut.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/print_ut.c b/test/print_ut.c index a456a44..61ea432 100644 --- a/test/print_ut.c +++ b/test/print_ut.c @@ -6,8 +6,8 @@ #define DEBUG #include <common.h> -#if CONFIG_IS_ENABLED(EFI_LOADER) && !defined(API_BUILD) #include <command.h> +#if CONFIG_IS_ENABLED(EFI_LOADER) && !defined(API_BUILD) #include <efi_api.h> #endif #include <display_options.h> -- 2.7.4

2 2

[PATCH] patman: Use less for help file, if available
by Nicolas Boichat 16 Mar '21

16 Mar '21

It's convenient to be able to scroll up in `patman -H`. Signed-off-by: Nicolas Boichat <drinkcat(a)chromium.org> --- tools/patman/main.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/patman/main.py b/tools/patman/main.py index c4e4d80d4250..5830c5a5e24f 100755 --- a/tools/patman/main.py +++ b/tools/patman/main.py @@ -9,6 +9,7 @@ from argparse import ArgumentParser import os import re +import shutil import sys import traceback import unittest @@ -169,6 +170,8 @@ elif args.cmd == 'send': elif args.full_help: pager = os.getenv('PAGER') + if not pager: + pager = shutil.which('less') if not pager: pager = 'more' fname = os.path.join(os.path.dirname(os.path.realpath(sys.argv[0])), -- 2.30.0.478.g8a0d178c01-goog

2 2

[PATCH 1/1] sandbox: enable cros-ec-keyb in test.dtb
by Heinrich Schuchardt 16 Mar '21

16 Mar '21

Currently keyboard input fails in the GUI window opened by ./u-boot -T -l Add the missing include to test.dts. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- arch/sandbox/dts/test.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts index e95f4631bf..8ffdb14e08 100644 --- a/arch/sandbox/dts/test.dts +++ b/arch/sandbox/dts/test.dts @@ -1355,3 +1355,4 @@ }; #include "sandbox_pmic.dtsi" +#include "cros-ec-keyboard.dtsi" -- 2.30.0

2 2

[PATCH 1/1] dm: error handling dev_get_dma_range()
by Heinrich Schuchardt 16 Mar '21

16 Mar '21

goto after return has not effect. Calling of_node_put() in case of some errors and not for others is inconsistent. Fixes: 51bdb50904b ("dm: Introduce xxx_get_dma_range()") Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- drivers/core/of_addr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/core/of_addr.c b/drivers/core/of_addr.c index 5bc6ca1de0..b3e384d2ee 100644 --- a/drivers/core/of_addr.c +++ b/drivers/core/of_addr.c @@ -372,7 +372,7 @@ int of_get_dma_range(const struct device_node *dev, phys_addr_t *cpu, bus_node->count_cells(dev, &na, &ns); if (!OF_CHECK_COUNTS(na, ns)) { printf("Bad cell count for %s\n", of_node_full_name(dev)); - return -EINVAL; + ret = -EINVAL; goto out_parent; } @@ -380,7 +380,7 @@ int of_get_dma_range(const struct device_node *dev, phys_addr_t *cpu, bus_node->count_cells(parent, &pna, &pns); if (!OF_CHECK_COUNTS(pna, pns)) { printf("Bad cell count for %s\n", of_node_full_name(parent)); - return -EINVAL; + ret = -EINVAL; goto out_parent; } -- 2.30.0

2 2