March 2021 - U-Boot

[PATCH v2 0/7] arm: cache: cp15: don't map reserved region with no-map property
by Patrick Delaunay 14 Apr '21

14 Apr '21

Hi, It it the v2 serie of [1]. This v2 serie is build/can be applied on top of 2 previous series - [2] for stm32mp parts and added dram_bank_mmu_setup - [3] for LMB impacts After V1 remarks, I propose this separate serie [2] for DACR support. On STM32MP15x platform we can use OP-TEE, loaded in DDR in a region protected by a firewall. This region is reserved in device with "no-map" property. Sometime the platform boot failed in U-boot on a Cortex A7 access to this region (depending of the binary and the issue can change with compiler version or with code alignment), then the firewall raise an error, for example: E/TC:0 tzc_it_handler:19 TZC permission failure E/TC:0 dump_fail_filter:420 Permission violation on filter 0 E/TC:0 dump_fail_filter:425 Violation @0xde5c6bf0, non-secure privileged read, AXI ID 5c0 E/TC:0 Panic After investigation, the forbidden access is a speculative request performed by the Cortex A7 because all the DDR is mapped as MEMORY with CACHEABLE property. The issue is solved only when the region reserved by OP-TEE is no more mapped in U-Boot as it is already done in Linux kernel. Tested on DK2 board with OP-TEE 3.12 / TF-A 2.4: With hard-coded address for OP-TEE reserved memory, the error doesn't occur. void dram_bank_mmu_setup(int bank) { .... for (i = start >> MMU_SECTION_SHIFT; i < (start >> MMU_SECTION_SHIFT) + (size >> MMU_SECTION_SHIFT); i++) { option = DCACHE_DEFAULT_OPTION; if (i >= 0xde0) option = INVALID_ENTRY; set_section_dcache(i, option); } } Just by modifying the test on 0xde0 to 0xdf0, the OP-TEE memory protected by firewall is mapped cacheable and the error occurs. I think that can be a general issue for ARM architecture: the no-map tag in device should be respected by U-boot, so I propose a generic solution in arm/lib/cache-cp15.c:dram_bank_mmu_setup(). This v2 serie is composed by 7 patches - 1..3/7: preliminary steps to support flags in library in lmb (as it is done in memblock.c in Linux) - 4/7: unitary test on the added feature in lmb lib - 5/7: save the no-map flags in lmb when the device tree is parsed - 6/7: update the stm32mp mmu support - 7/7: update the generic behavior for "no-map" region in arm/lib/cache-cp15.c::dram_bank_mmu_setup() I can drop this last patch if this feature is not required by other ARM architectures; the weak function is updated in patch 6 in STM32MP architecture (in arch/arm/mach-stm32mp/cpu.c) to correct the initial problem. See also [4] which handle same speculative access on armv8 for area with Executable attribute. [1] http://patchwork.ozlabs.org/project/uboot/list/?series=206296&state=* [2] http://patchwork.ozlabs.org/project/uboot/list/?series=228202&state=* [3] http://patchwork.ozlabs.org/project/uboot/list/?series=227570&state=* [4] http://patchwork.ozlabs.org/project/uboot/patch/20200903000106.5016-1-marek… Regards Patrick Changes in v2: - remove unnecessary comments in lmb.h - rebase on latest lmb patches - NEW: update in stm32mp specific MMU setup functions Patrick Delaunay (7): lmb: Add support of flags for no-map properties lmb: add lmb_is_reserved_flags lmb: add lmb_dump_region() function test: lmb: add test for lmb_reserve_flags image-fdt: save no-map parameter of reserve-memory stm32mp: don't map the reserved region with no-map property arm: cache: cp15: don't map the reserved region with no-map property arch/arm/include/asm/system.h | 3 ++ arch/arm/lib/cache-cp15.c | 19 ++++++- arch/arm/mach-stm32mp/cpu.c | 16 +++++- common/image-fdt.c | 23 ++++++--- include/lmb.h | 21 ++++++++ lib/lmb.c | 94 +++++++++++++++++++++++++---------- test/lib/lmb.c | 89 +++++++++++++++++++++++++++++++++ 7 files changed, 226 insertions(+), 39 deletions(-) -- 2.17.1

2 8

[PATCH v2] arm: mach-rmobile: Add CPU info support for RZ/G2
by Biju Das 14 Apr '21

14 Apr '21

Add CPU info support for RZ/G2 SoC's. Signed-off-by: Biju Das <biju.das.jz(a)bp.renesas.com> --- V1-->V2 * Added support to make CPU info based on tfa is available only when CONFIG_RZ_G2 is enabled. --- arch/arm/mach-rmobile/Kconfig.64 | 5 +++ arch/arm/mach-rmobile/Makefile | 1 + arch/arm/mach-rmobile/cpu_info-rzg.c | 41 ++++++++++++++++++++ arch/arm/mach-rmobile/cpu_info.c | 21 ++++++++-- arch/arm/mach-rmobile/include/mach/rmobile.h | 1 + 5 files changed, 65 insertions(+), 4 deletions(-) create mode 100644 arch/arm/mach-rmobile/cpu_info-rzg.c diff --git a/arch/arm/mach-rmobile/Kconfig.64 b/arch/arm/mach-rmobile/Kconfig.64 index 8127d33f2d..3f7ec05379 100644 --- a/arch/arm/mach-rmobile/Kconfig.64 +++ b/arch/arm/mach-rmobile/Kconfig.64 @@ -57,6 +57,9 @@ config R8A77995 imply CLK_R8A77995 imply PINCTRL_PFC_R8A77995 +config RZ_G2 + bool "Renesas ARM SoCs RZ/G2 (64bit)" + endmenu choice @@ -107,6 +110,7 @@ config TARGET_HIHOPE_RZG2 imply R8A774A1 imply R8A774B1 imply R8A774E1 + imply RZ_G2 imply SYS_MALLOC_F imply MULTI_DTB_FIT imply MULTI_DTB_FIT_USER_DEFINED_AREA @@ -116,6 +120,7 @@ config TARGET_HIHOPE_RZG2 config TARGET_SILINUX_EK874 bool "Silicon Linux EK874 board" imply R8A774C0 + imply RZ_G2 help Support for Silicon Linux EK874 platform diff --git a/arch/arm/mach-rmobile/Makefile b/arch/arm/mach-rmobile/Makefile index 9f56af465e..81a0dedb41 100644 --- a/arch/arm/mach-rmobile/Makefile +++ b/arch/arm/mach-rmobile/Makefile @@ -13,6 +13,7 @@ obj-$(CONFIG_SH73A0) += lowlevel_init.o cpu_info-sh73a0.o pfc-sh73a0.o obj-$(CONFIG_R8A7740) += lowlevel_init.o cpu_info-r8a7740.o pfc-r8a7740.o obj-$(CONFIG_RCAR_GEN2) += lowlevel_init_ca15.o cpu_info-rcar.o obj-$(CONFIG_RCAR_GEN3) += lowlevel_init_gen3.o cpu_info-rcar.o memmap-gen3.o +obj-$(CONFIG_RZ_G2) += cpu_info-rzg.o OBJCOPYFLAGS_u-boot-spl.srec := -O srec quiet_cmd_objcopy = OBJCOPY $@ diff --git a/arch/arm/mach-rmobile/cpu_info-rzg.c b/arch/arm/mach-rmobile/cpu_info-rzg.c new file mode 100644 index 0000000000..1c18fd06f0 --- /dev/null +++ b/arch/arm/mach-rmobile/cpu_info-rzg.c @@ -0,0 +1,41 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2021 Renesas Electronics Corporation + * + */ +#include <common.h> +#include <linux/libfdt.h> + +/* If the firmware passed a device tree, use it for soc identification. */ +extern u64 rcar_atf_boot_args[]; + +/* CPU information table */ +static const struct { + char *soc_name; + u8 cpu_name[10]; +} tfa_info[] = { + { "renesas,r8a774a1", "R8A774A1" }, + { "renesas,r8a774b1", "R8A774B1" }, + { "renesas,r8a774c0", "R8A774C0" }, + { "renesas,r8a774e1", "R8A774E1" } +}; + +const u8 *rzg_get_cpu_name(void) +{ + void *atf_fdt_blob = (void *)(rcar_atf_boot_args[1]); + bool ret = false; + int i; + + if (fdt_magic(atf_fdt_blob) != FDT_MAGIC) + return NULL; + + for (i = 0; i < ARRAY_SIZE(tfa_info); i++) { + if (fdt_node_check_compatible(atf_fdt_blob, 0, + tfa_info[i].soc_name) == 0) { + ret = true; + break; + } + } + + return ret ? tfa_info[i].cpu_name : NULL; +} diff --git a/arch/arm/mach-rmobile/cpu_info.c b/arch/arm/mach-rmobile/cpu_info.c index fdbbd72e28..9ec622bdb5 100644 --- a/arch/arm/mach-rmobile/cpu_info.c +++ b/arch/arm/mach-rmobile/cpu_info.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0+ /* * (C) Copyright 2012 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj(a)renesas.com> - * (C) Copyright 2012 Renesas Solutions Corp. + * (C) Copyright 2012-2021 Renesas Solutions Corp. */ #include <common.h> #include <cpu_func.h> @@ -31,6 +31,11 @@ void enable_caches(void) #ifdef CONFIG_DISPLAY_CPUINFO #ifndef CONFIG_RZA1 +__weak const u8 *rzg_get_cpu_name(void) +{ + return 0; +} + static u32 __rmobile_get_cpu_type(void) { return 0x0; @@ -52,7 +57,7 @@ static u32 __rmobile_get_cpu_rev_fraction(void) u32 rmobile_get_cpu_rev_fraction(void) __attribute__((weak, alias("__rmobile_get_cpu_rev_fraction"))); -/* CPU infomation table */ +/* CPU information table */ static const struct { u16 cpu_type; u8 cpu_name[10]; @@ -86,14 +91,22 @@ static int rmobile_cpuinfo_idx(void) return i; } +static const u8 *get_cpu_name(int idx) +{ + const u8 *cpu_name = rzg_get_cpu_name(); + + return cpu_name ? cpu_name : rmobile_cpuinfo[idx].cpu_name; +} + #ifdef CONFIG_ARCH_MISC_INIT int arch_misc_init(void) { int i, idx = rmobile_cpuinfo_idx(); + const u8 *cpu_name = get_cpu_name(idx); char cpu[10] = { 0 }; for (i = 0; i < sizeof(cpu); i++) - cpu[i] = tolower(rmobile_cpuinfo[idx].cpu_name[i]); + cpu[i] = tolower(cpu_name[i]); env_set("platform", cpu); @@ -106,7 +119,7 @@ int print_cpuinfo(void) int i = rmobile_cpuinfo_idx(); printf("CPU: Renesas Electronics %s rev %d.%d\n", - rmobile_cpuinfo[i].cpu_name, rmobile_get_cpu_rev_integer(), + get_cpu_name(i), rmobile_get_cpu_rev_integer(), rmobile_get_cpu_rev_fraction()); return 0; diff --git a/arch/arm/mach-rmobile/include/mach/rmobile.h b/arch/arm/mach-rmobile/include/mach/rmobile.h index a50249dc96..a688636141 100644 --- a/arch/arm/mach-rmobile/include/mach/rmobile.h +++ b/arch/arm/mach-rmobile/include/mach/rmobile.h @@ -41,6 +41,7 @@ #define RMOBILE_CPU_TYPE_R8A77995 0x58 #ifndef __ASSEMBLY__ +const u8 *rzg_get_cpu_name(void); u32 rmobile_get_cpu_type(void); u32 rmobile_get_cpu_rev_integer(void); u32 rmobile_get_cpu_rev_fraction(void); -- 2.17.1

2 1

[PATCH] scmi: translate the resource only when livetree is not activated
by Patrick Delaunay 13 Apr '21

13 Apr '21

Call the translation function on the ofnode_read_resource result only when the livetree is not activated. Today of_address_to_resource() calls ofnode_read_resource() for livetree support and fdt_get_resource() when livetree is not supported. The fdt_get_resource() doesn't do the address translation so when it is required when livetree is activated but this address translation is already done by ofnode_read_resource(). Fixes: 240720e9052f ("firmware: scmi: mailbox/smt agent device") Signed-off-by: Patrick Delaunay <patrick.delaunay(a)foss.st.com> --- Hi, This patch is a short-term workaround for ofnode_read_resource translation issue on stm32mp15 boards when scmi is used and OF_LIVE is activated. A full solution is a patch in core to have the same behavior of the API ofnode_read_resource() when livretree is activated or not: fdt_get_resource() ... while (ptr + na + ns <= end) { if (i == index) { - res->start = fdtdec_get_number(ptr, na); + if (CONFIG_IS_ENABLED(OF_TRANSLATE)) + res->start = fdt_translate_address(fdt, node, ptr); + else + res->start = fdtdec_get_number(ptr, na); + I will propose it soon but it is more aggressive and impacts all the user of fdt_get_resource() or fdt_get_named_resource() function; this correct patch need more tests. So I think it will take many time to be integrated so I prefer to propose the current patch for a short term integration on v2021.07. Patrick drivers/firmware/scmi/smt.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/scmi/smt.c b/drivers/firmware/scmi/smt.c index 4954355c1a..f1915c0074 100644 --- a/drivers/firmware/scmi/smt.c +++ b/drivers/firmware/scmi/smt.c @@ -41,8 +41,13 @@ int scmi_dt_get_smt_buffer(struct udevice *dev, struct scmi_smt *smt) if (ret) return ret; - faddr = cpu_to_fdt32(resource.start); - paddr = ofnode_translate_address(args.node, &faddr); + /* TEMP workaround for ofnode_read_resource translation issue */ + if (of_live_active()) { + paddr = resource.start; + } else { + faddr = cpu_to_fdt32(resource.start); + paddr = ofnode_translate_address(args.node, &faddr); + } smt->size = resource_size(&resource); if (smt->size < sizeof(struct scmi_smt_header)) { -- 2.17.1

3 2

[PATCH v7 0/2] gpio: Update and simplify the uclass API
by Simon Glass 13 Apr '21

13 Apr '21

At present the GPIO uclass mirrors what was in U-Boot before driver model. It works well in most cases but is becoming cumbersome with things like pull-up/down and drive strength. In those cases it is easier for the driver to deal with all the flags at one, rather than piece by piece. In fact the current API does not officially have a method for adjusting anything other than the direction flags. While set_dir_flags() and get_dir_flags() do in fact support changing other flags, this is not documented. Secondly, set_dir_flags actually ORs the current flags with the new ones so it is not possible to clear flags. It seems better to use a clr/set interface (bit clear followed by OR) to provide more flexibility. Finally, direction_input() and direction_output() are really just the same thing as set_dir_flags(), with a different name. We currently use the latter if available, failing back to the former. But it makes sense to deprecate the old methods. This series makes the above changes. Existing drivers are mostly left alone, since they should continue to operate as is. The sandbox driver is updated to add the required new tests and the x86 driver is switched over to the new API. The STM32 driver should be checked to make sure the open source/open drain features still work as intended. Changes in v7: - Update commit message to mention dm_gpio_clrset_flags() Changes in v6: - Use dm_gpio_clrset_flags() so that direction can be changed - Simplify the code since masking is not needed Changes in v5: - Drop patches previously applied Simon Glass (2): gpio: i2c-gpio: Drop use of dm_gpio_set_dir() gpio: Drop dm_gpio_set_dir() drivers/gpio/gpio-uclass.c | 11 ----------- drivers/i2c/i2c-gpio.c | 19 +++++++++---------- include/asm-generic/gpio.h | 11 ----------- 3 files changed, 9 insertions(+), 32 deletions(-) -- 2.31.0.rc2.261.g7f71774620-goog

2 4

[PATCH v8 0/4] Move qfw to DM, add Arm support
by Asherah Connor 13 Apr '21

13 Apr '21

This series moves the QFW driver into a uclass, UCLASS_QFW, and splits the driver into qfw_pio and qfw_mmio. Each driver is selected on the appropriate QEMU board. A sandbox driver is also added, and a DM unit test against that driver. The qfw command is tested in QEMU, and documentation added. Version 7 ensures the qfw test assertions work both against real QEMU instances and the sandbox and removes CMD_QFW from the sandbox_spl config. Version 8 removes some extraneous whitespace. To view the changes online, see: https://git.src.kameliya.ee/~kameliya/u-boot/log/qfw-priv Changes in v8: * Removed extraneous newlines at EOF. Changes in v7: * Make the qfw tests agnostic to running against a real QEMU instance or in the sandbox. * Remove CONFIG_CMD_QFW=y from sandbox_spl_defconfig, per trini's request. Changes in v6: * Sandbox driver and tests are split into own commit. Changes in v5: * Split conversion of existing x86-only QFW to DM into its own patch. * Split MMIO driver into its own commit. * Split adding MMIO driver to QEMU arm/64 into own commit. Asherah Connor (4): x86: qemu: move QFW to its own uclass test: qemu: add qfw sandbox driver, dm tests, qemu tests qemu: add MMIO driver for QFW qemu: arm: select QFW, MMIO on qemu-arm arch/x86/cpu/qemu/cpu.c | 9 +- arch/x86/cpu/qemu/qemu.c | 49 +------ arch/x86/cpu/qfw_cpu.c | 11 +- board/emulation/qemu-arm/Kconfig | 2 + board/emulation/qemu-x86/Kconfig | 1 + cmd/qfw.c | 56 ++++--- common/Makefile | 2 + common/qfw.c | 104 +++++++++++++ configs/sandbox_spl_defconfig | 1 - drivers/misc/Kconfig | 18 ++- drivers/misc/Makefile | 7 +- drivers/misc/qfw.c | 243 +++++++++++-------------------- drivers/misc/qfw_mmio.c | 119 +++++++++++++++ drivers/misc/qfw_pio.c | 69 +++++++++ drivers/misc/qfw_sandbox.c | 127 ++++++++++++++++ include/dm/uclass-id.h | 1 + include/qfw.h | 200 +++++++++++++++++++++---- test/dm/Makefile | 1 + test/dm/qfw.c | 42 ++++++ test/py/tests/test_qfw.py | 26 ++++ 20 files changed, 815 insertions(+), 273 deletions(-) create mode 100644 common/qfw.c create mode 100644 drivers/misc/qfw_mmio.c create mode 100644 drivers/misc/qfw_pio.c create mode 100644 drivers/misc/qfw_sandbox.c create mode 100644 test/dm/qfw.c create mode 100644 test/py/tests/test_qfw.py -- 2.20.1

2 8

[PATCH] scmi: correctly configure MMU for SCMI buffer
by Patrick Delaunay 13 Apr '21

13 Apr '21

Align the MMU area for SCMI shared buffer on section size; use the ALIGN macro in mmu_set_region_dcache_behaviour call. Since commit d877f8fd0f09 ("arm: provide a function for boards init code to modify MMU virtual-physical map") the parameter of mmu_set_region_dcache_behaviour need to be MMU_SECTION_SIZE aligned. Fixes: 240720e9052f ("firmware: scmi: mailbox/smt agent device") Signed-off-by: Patrick Delaunay <patrick.delaunay(a)foss.st.com> --- drivers/firmware/scmi/smt.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/scmi/smt.c b/drivers/firmware/scmi/smt.c index d25478796a..3c41013bca 100644 --- a/drivers/firmware/scmi/smt.c +++ b/drivers/firmware/scmi/smt.c @@ -54,8 +54,10 @@ int scmi_dt_get_smt_buffer(struct udevice *dev, struct scmi_smt *smt) #ifdef CONFIG_ARM if (dcache_status()) - mmu_set_region_dcache_behaviour((uintptr_t)smt->buf, - smt->size, DCACHE_OFF); + mmu_set_region_dcache_behaviour(ALIGN_DOWN((uintptr_t)smt->buf, MMU_SECTION_SIZE), + ALIGN(smt->size, MMU_SECTION_SIZE), + DCACHE_OFF); + #endif return 0; -- 2.17.1

3 2

[PATCH 1/2] moveconfig.py: add try…except
by Trevor Woerner 13 Apr '21

13 Apr '21

I keep getting a UnicodeDecodeError from one of the header files while modifying the headers: Traceback (most recent call last): File "tools/moveconfig.py", line 1953, in <module> main() File "tools/moveconfig.py", line 1927, in main cleanup_headers(configs, options) File "tools/moveconfig.py", line 675, in cleanup_headers cleanup_one_header(header_path, patterns, options) File "tools/moveconfig.py", line 599, in cleanup_one_header lines = f.readlines() File "/usr/lib64/python3.6/codecs.py", line 321, in decode (result, consumed) = self._buffer_decode(data, self.errors, final) UnicodeDecodeError: 'utf-8' codec can't decode byte 0x83 in position 9: invalid start byte I'm curious to know which header file is causing the problem. Signed-off-by: Trevor Woerner <twoerner(a)gmail.com> --- tools/moveconfig.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/moveconfig.py b/tools/moveconfig.py index 9514d9a00c..dd92c00bb7 100755 --- a/tools/moveconfig.py +++ b/tools/moveconfig.py @@ -596,7 +596,12 @@ def cleanup_one_header(header_path, patterns, options): options: option flags. """ with open(header_path) as f: - lines = f.readlines() + try: + lines = f.readlines() + except: + print("caught exception: ", sys.exc_info()[0]) + print("header_path: ", header_path) + lines = "" matched = [] for i, line in enumerate(lines): -- 2.30.0.rc0

2 3

[PATCH v2 0/5] string: strl(cat|cpy)
by Sean Anderson 13 Apr '21

13 Apr '21

This series adds support for strl(cat|cpy), and brings their implementations in-line with what is documented in the Linux man pages. It also fixes some potential (actual) fastboot bugs. Lastly, it adds a patman check to suggest using these functions over strn(cat|cpy). I think these functions provide a much better interface, which removes some footguns from U-Boot. Changes in v2: - Fix strlcpy return value - Add implementation of strlcat - Add test for strlcat - Fix bug in fastboot - Move check to u_boot_line Sean Anderson (5): lib: string: Fix strlcpy return value lib: string: Implement strlcat test: Add test for strlcat fastboot: Fix possible buffer overrun checkpatch: Add warnings for using strn(cat|cpy) drivers/fastboot/fb_mmc.c | 6 +- drivers/usb/dwc3/linux-compat.h | 6 -- include/linux/string.h | 3 + lib/string.c | 31 +++++++- scripts/checkpatch.pl | 6 ++ test/lib/Makefile | 1 + test/lib/strlcat.c | 126 ++++++++++++++++++++++++++++++++ tools/patman/test_checkpatch.py | 14 +++- 8 files changed, 179 insertions(+), 14 deletions(-) create mode 100644 test/lib/strlcat.c -- 2.30.1

3 17

[PATCH v2] tee: optee: Change printing during optee_probe
by Ilias Apalodimas 13 Apr '21

13 Apr '21

Right now the error messages when optee has a version mismatch or shared memory is not configured are done with a debug(). That's not very convenient since you have to enable debugging to figure out what's going on, although this is an actual error. So let's switch the debug() -> dev_err() and report those explicitly. Signed-off-by: Ilias Apalodimas <ilias.apalodimas(a)linaro.org> Reviewed-by: Patrick Delaunay <patrick.delaunay(a)foss.st.com> --- drivers/tee/optee/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c index b898c32edc0b..73dbb22ba097 100644 --- a/drivers/tee/optee/core.c +++ b/drivers/tee/optee/core.c @@ -624,14 +624,14 @@ static int optee_probe(struct udevice *dev) u32 sec_caps; if (!is_optee_api(pdata->invoke_fn)) { - debug("%s: OP-TEE api uid mismatch\n", __func__); + dev_err(dev, "OP-TEE api uid mismatch\n"); return -ENOENT; } print_os_revision(dev, pdata->invoke_fn); if (!api_revision_is_compatible(pdata->invoke_fn)) { - debug("%s: OP-TEE api revision mismatch\n", __func__); + dev_err(dev, "OP-TEE api revision mismatch\n"); return -ENOENT; } @@ -642,7 +642,7 @@ static int optee_probe(struct udevice *dev) */ if (!exchange_capabilities(pdata->invoke_fn, &sec_caps) || !(sec_caps & OPTEE_SMC_SEC_CAP_DYNAMIC_SHM)) { - debug("%s: OP-TEE capabilities mismatch\n", __func__); + dev_err(dev, "OP-TEE capabilities mismatch\n"); return -ENOENT; } -- 2.30.1

3 4

[PATCH 0/2] terminal: get this compiling again
by Asherah Connor 13 Apr '21

13 Apr '21

`terminal' has not compiled in 7 years. We should fix it, per this series or something similar, or remove it. I've been trying to use it locally with a secondary UART on a RISC-V dev board (to no avail, but that's my own problem). P.S. Let me know if I'm sending too many patches, I realise I already have several outstanding. Asherah Connor (2): terminal: correct stdio_dev invocations terminal: only serial_reinit_all if available cmd/terminal.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) -- 2.20.1

3 6