May 2020 - U-Boot

[PATCH 1/2] arm: mvebu: armada-370-xp.dtsi: add u-boot, dm-pre-reloc to spi0
by Ezra Buehler 09 May '20

09 May '20

Without this U-Boot-specific property, the Synology DS414/DS214+ fails in SPL. As the spi0 node was not scanned the SPI flash cannot be found. Signed-off-by: Ezra Buehler <ezra(a)easyb.ch> --- arch/arm/dts/armada-370-xp.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/dts/armada-370-xp.dtsi b/arch/arm/dts/armada-370-xp.dtsi index 50fc0be9f7..21c38cf3f3 100644 --- a/arch/arm/dts/armada-370-xp.dtsi +++ b/arch/arm/dts/armada-370-xp.dtsi @@ -284,6 +284,7 @@ interrupts = <30>; clocks = <&coreclk 0>; status = "disabled"; + u-boot,dm-pre-reloc; }; spi1: spi@10680 { -- 2.26.2

3 7

[PATCH 1/1] test: unit test for u16_strsize()
by Heinrich Schuchardt 09 May '20

09 May '20

Provide a test for new Unicode library function u16_strsize(). Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- test/unicode_ut.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/test/unicode_ut.c b/test/unicode_ut.c index 4d99c20bc0..d8b4aa9b44 100644 --- a/test/unicode_ut.c +++ b/test/unicode_ut.c @@ -581,6 +581,16 @@ static int unicode_test_u16_strncmp(struct unit_test_state *uts) } UNICODE_TEST(unicode_test_u16_strncmp); +static int unicode_test_u16_strsize(struct unit_test_state *uts) +{ + ut_asserteq_64(u16_strsize(c1), 14); + ut_asserteq_64(u16_strsize(c2), 18); + ut_asserteq_64(u16_strsize(c3), 8); + ut_asserteq_64(u16_strsize(c4), 14); + return 0; +} +UNICODE_TEST(unicode_test_u16_strsize); + int do_ut_unicode(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) { struct unit_test *tests = ll_entry_start(struct unit_test, unicode_test); -- 2.26.2

2 1

[PATCH v2 0/2] Calculate SDRAM size for Actions OWL SoCs
by Amit Singh Tomar 09 May '20

09 May '20

This small series allows us to calculate SDRAM size instead of guessing it. Patch (1/2) is re-worked to support S900 SoC along with S700. These changes have been tested on S700 based Cubieboard7-lite board, and it would be great if this can be tested on S900. Amit Singh Tomar (2): Actions: OWL: Calculate SDRAM size arm: actions: remove "CONFIG_SYS_SDRAM_SIZE" for Actions Owl Semi SoCs arch/arm/mach-owl/soc.c | 27 ++++++++++++++++++++++++++- include/configs/owl-common.h | 1 - 2 files changed, 26 insertions(+), 2 deletions(-) -- 2.7.4

3 4

[PATCH 0/2] lib: charset: function descriptions
by Heinrich Schuchardt 09 May '20

09 May '20

Fix the function descriptions in include/charset.h and add them to the generated HTML API documentation. Heinrich Schuchardt (2): lib: charset: correct function descriptions doc: add Unicode functions to API description doc/api/index.rst | 1 + doc/api/unicode.rst | 7 +++++++ include/charset.h | 39 +++++++++++++++++++++++++-------------- 3 files changed, 33 insertions(+), 14 deletions(-) create mode 100644 doc/api/unicode.rst -- 2.26.2

1 2

[PATCH v3 0/2] Calculate SDRAM size for Actions OWL SoCs
by Amit Singh Tomar 09 May '20

09 May '20

Realized that sent the wrong version(v2) that has typos and didn't get compile for S900. Just fixed this in v3. Sorry for the noise. ---------------------------------------------------------------------- This small series allows us to calculate SDRAM size instead of guessing it. Patch (1/2) is re-worked to support S900 SoC along with S700. These changes have been tested on S700 based Cubieboard7-lite board, and it would be great if this can be tested on S900. Amit Singh Tomar (2): Actions: OWL: Calculate SDRAM size arm: actions: remove "CONFIG_SYS_SDRAM_SIZE" for Actions Owl Semi SoCs arch/arm/mach-owl/soc.c | 27 ++++++++++++++++++++++++++- include/configs/owl-common.h | 1 - 2 files changed, 26 insertions(+), 2 deletions(-) -- 2.7.4

1 2

[PATCH 1/1] efi_selftest: add unit test functions to HTML documentation
by Heinrich Schuchardt 09 May '20

09 May '20

Add the UEFI unit test helper functions to the generated HTML documentation. Correct some documentation texts in include/efi_selftest.h. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- doc/api/efi.rst | 9 ++++ include/efi_selftest.h | 110 +++++++++++++++++++++++++++-------------- 2 files changed, 81 insertions(+), 38 deletions(-) diff --git a/doc/api/efi.rst b/doc/api/efi.rst index 0667c3aef7..d5114f05b3 100644 --- a/doc/api/efi.rst +++ b/doc/api/efi.rst @@ -163,3 +163,12 @@ Unicode Collation protocol .. kernel-doc:: lib/efi_loader/efi_unicode_collation.c :internal: + +Unit testing +------------ + +The following library functions are provided to support writing UEFI unit tests. +The should not be used elsewhere. + +.. kernel-doc:: include/efi_selftest.h + :internal: diff --git a/include/efi_selftest.h b/include/efi_selftest.h index eaee188de7..1515fdaa02 100644 --- a/include/efi_selftest.h +++ b/include/efi_selftest.h @@ -17,69 +17,89 @@ #define EFI_ST_SUCCESS 0 #define EFI_ST_FAILURE 1 #define EFI_ST_SUCCESS_STR L"SUCCESS" -/* - * Prints a message. + +/** + * efi_st_printf() - print a message + * + * @...: format string followed by fields to print */ #define efi_st_printf(...) \ (efi_st_printc(-1, __VA_ARGS__)) -/* - * Prints an error message. +/** + * efi_st_error() - prints an error message * - * @... format string followed by fields to print + * @...: format string followed by fields to print */ #define efi_st_error(...) \ (efi_st_printc(EFI_LIGHTRED, "%s(%u):\nERROR: ", __FILE__, __LINE__), \ efi_st_printc(EFI_LIGHTRED, __VA_ARGS__)) -/* - * Prints a TODO message. +/** + * efi_st_todo() - prints a TODO message * - * @... format string followed by fields to print + * @...: format string followed by fields to print */ #define efi_st_todo(...) \ (efi_st_printc(EFI_YELLOW, "%s(%u):\nTODO: ", __FILE__, __LINE__), \ efi_st_printc(EFI_YELLOW, __VA_ARGS__)) \ -/* +/** + * enum efi_test_phase - phase when test will be executed + * * A test may be setup and executed at boottime, * it may be setup at boottime and executed at runtime, * or it may be setup and executed at runtime. */ enum efi_test_phase { + /** + * @EFI_EXECUTE_BEFORE_BOOTTIME_EXIT: - execute before ExitBootServices + * + * Setup, execute, and teardown are executed before ExitBootServices(). + */ EFI_EXECUTE_BEFORE_BOOTTIME_EXIT = 1, + /** + * @EFI_SETUP_BEFORE_BOOTTIME_EXIT: - setup before ExitBootServices + * + * Setup is executed before ExitBootServices() while execute, and + * teardown are executed after ExitBootServices(). + */ EFI_SETUP_BEFORE_BOOTTIME_EXIT, + /** + * @EFI_SETUP_AFTER_BOOTTIME_EXIT: - setup after ExitBootServices + * + * Setup, execute, and teardown are executed after ExitBootServices(). + */ EFI_SETUP_AFTER_BOOTTIME_EXIT, }; extern struct efi_simple_text_output_protocol *con_out; extern struct efi_simple_text_input_protocol *con_in; -/* - * Exit the boot services. +/** + * efi_st_exit_boot_services() - exit the boot services * - * The size of the memory map is determined. - * Pool memory is allocated to copy the memory map. - * The memory amp is copied and the map key is obtained. - * The map key is used to exit the boot services. + * * The size of the memory map is determined. + * * Pool memory is allocated to copy the memory map. + * * The memory map is copied and the map key is obtained. + * * The map key is used to exit the boot services. */ void efi_st_exit_boot_services(void); -/* - * Print a colored message +/** + * efi_st_printc() - print a colored message * - * @color color, see constants in efi_api.h, use -1 for no color - * @fmt printf format - * @... arguments to be printed - * on return position of terminating zero word + * @color: color, see constants in efi_api.h, use -1 for no color + * @fmt: printf style format string + * @...: arguments to be printed */ void efi_st_printc(int color, const char *fmt, ...) __attribute__ ((format (__printf__, 2, 3))); /** - * efi_st_translate_char() - translate a unicode character to a string + * efi_st_translate_char() - translate a Unicode character to a string * - * @code: unicode character + * @code: Unicode character * Return: string */ u16 *efi_st_translate_char(u16 code); @@ -87,38 +107,44 @@ u16 *efi_st_translate_char(u16 code); /** * efi_st_translate_code() - translate a scan code to a human readable string * - * @code: unicode character - * Return: string + * This function translates the scan code returned by the simple text input + * protocol to a human readable string, e.g. 0x04 is translated to L"Left". + * + * @code: scan code + * Return: Unicode string */ u16 *efi_st_translate_code(u16 code); -/* - * Compare an u16 string to a char string. +/** + * efi_st_strcmp_16_8() - compare an u16 string to a char string + * + * This function compares each u16 value to the char value at the same + * position. This function is only useful for ANSI strings. * * @buf1: u16 string * @buf2: char string - * @return: 0 if both buffers contain the same bytes + * Return: 0 if both buffers contain equivalent strings */ int efi_st_strcmp_16_8(const u16 *buf1, const char *buf2); -/* - * Reads an Unicode character from the input device. +/** + * efi_st_get_key() - reads an Unicode character from the input device * - * @return: Unicode character + * Return: Unicode character */ u16 efi_st_get_key(void); /** * struct efi_unit_test - EFI unit test * - * An efi_unit_test provides a interface to an EFI unit test. + * The &struct efi_unit_test structure provides a interface to an EFI unit test. * - * @name: name of unit test + * @name: name of the unit test used in the user interface * @phase: specifies when setup and execute are executed - * @setup: set up the unit test - * @teardown: tear down the unit test - * @execute: execute the unit test - * @on_request: test is only executed on request + * @setup: set up function of the unit test + * @execute: execute function of the unit test + * @teardown: tear down function of the unit test + * @on_request: flag indicating that the test shall only be executed on request */ struct efi_unit_test { const char *name; @@ -130,7 +156,15 @@ struct efi_unit_test { bool on_request; }; -/* Declare a new EFI unit test */ +/** + * EFI_UNIT_TEST() - macro to declare a new EFI unit test + * + * The macro EFI_UNIT_TEST() declares an EFI unit test using the &struct + * efi_unit_test structure. The test is added to a linker generated list which + * is evaluated by the 'bootefi selftest' command. + * + * @__name: string identifying the unit test in the linker generated list + */ #define EFI_UNIT_TEST(__name) \ ll_entry_declare(struct efi_unit_test, __name, efi_unit_test) -- 2.26.2

1 0

[PATCH v3 0/7] Add Rockchip RK3399 USB3.0 Host support
by Frank Wang 09 May '20

09 May '20

This series add quirks for DWC3 and add Rockchip RK3399 USB3.0 host support. Tested on top of Jagan 'rockchip: PHY drivers (USB)' series [1]. For V3 update: - Fix compile error for [PATCH v2 1/9]. - Use Jagan's Type-C driver instead of [PATCH v2 5/9]. - Cleanup dts changes for [PATCH v2 7/9]. - Cleanup config changes for [PATCH v2 8/9] and [PATCH v2 9/9]. For V2 update: - Amend type-c driver followed Jagan's comments for [PATCH 5/8]. - Fix dts commit for [PATCH 7/8]. - Split RK3399 default config for [PATCH 8/8]. - Add 'Reviewed-by' tag for [PATCH 1/8], [PATCH 2/8] and [PATCH 3/8]. [1] https://patchwork.ozlabs.org/project/uboot/cover/20200506075025.1677-1-jaga… BR, Frank Frank Wang (7): usb: dwc3: add dis_enblslpm_quirk usb: dwc3: add dis_u2_freeclk_exists_quirk usb: dwc3: amend UTMI/UTMIW phy interface setup usb: dwc3: add make compatible for rockchip platform driver: usb: drop legacy rockchip xhci driver ARM: dts: rk3399-evb: usb3.0 host support configs: evb-rk3399: update support usb3.0 host arch/arm/dts/rk3399-evb.dts | 13 ++ configs/evb-rk3399_defconfig | 6 + drivers/usb/common/common.c | 25 ++++ drivers/usb/dwc3/core.c | 77 +++++++----- drivers/usb/dwc3/core.h | 9 ++ drivers/usb/dwc3/dwc3-generic.c | 33 +++++- drivers/usb/host/Kconfig | 9 -- drivers/usb/host/Makefile | 1 - drivers/usb/host/xhci-rockchip.c | 196 ------------------------------- include/dwc3-uboot.h | 2 + include/linux/usb/phy.h | 18 +++ 11 files changed, 146 insertions(+), 243 deletions(-) delete mode 100644 drivers/usb/host/xhci-rockchip.c -- 2.17.1

4 17

[PATCH 0/2] test: fix naming of test functions in the log test suite
by Heinrich Schuchardt 09 May '20

09 May '20

Some Python subtests executed via the 'ut' console command were not executed due to not following a required naming convention. Add a description of the naming convention. Fix the tests. Heinrich Schuchardt (2): test: describe naming conventions for macro UNIT_TEST test: fix naming of test functions in the log test suite include/test/test.h | 24 +++++++++++++++++++- test/log/nolog_test.c | 24 ++++++++++---------- test/log/syslog_test.c | 48 ++++++++++++++++++++-------------------- test/py/tests/test_ut.py | 17 +++++++++++++- 4 files changed, 75 insertions(+), 38 deletions(-) -- 2.26.2

4 6

[PATCH 1/4] sata: ahsata: Fix resource leak
by Peng Fan 09 May '20

09 May '20

From: Ye Li <ye.li(a)nxp.com> Fix coverity issue CID 3606684: Resource leak (RESOURCE_LEAK) leaked_storage: Variable uc_priv going out of scope leaks the storage it points to Signed-off-by: Ye Li <ye.li(a)nxp.com> Signed-off-by: Peng Fan <peng.fan(a)nxp.com> --- drivers/ata/dwc_ahsata.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/ata/dwc_ahsata.c b/drivers/ata/dwc_ahsata.c index c2e28fe518..a775214792 100644 --- a/drivers/ata/dwc_ahsata.c +++ b/drivers/ata/dwc_ahsata.c @@ -847,6 +847,9 @@ static int ahci_init_one(int pdev) struct ahci_uc_priv *uc_priv = NULL; uc_priv = malloc(sizeof(struct ahci_uc_priv)); + if (!uc_priv) + return -ENOMEM; + memset(uc_priv, 0, sizeof(struct ahci_uc_priv)); uc_priv->dev = pdev; @@ -871,6 +874,8 @@ static int ahci_init_one(int pdev) return 0; err_out: + if (uc_priv) + free(uc_priv); return rc; } -- 2.16.4

3 11

Pull request for UEFI sub-system for efi-2020-07-rc2 (3)
by Heinrich Schuchardt 08 May '20

08 May '20

The following changes since commit 69bf66ad8c0d53cc5e64d0f4f2e3bc9ad18e61aa: Merge branch '2020-05-06-master-imports' (2020-05-07 09:02:28 -0400) are available in the Git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-efi.git tags/efi-2020-07-rc2-3 for you to fetch changes up to d7ca3ce3d3b990503cb6e0bafad91aa2a7c96b9d: efi_loader: crypto/pkcs7_parser.h is not a local include (2020-05-07 18:23:18 +0200) ---------------------------------------------------------------- Pull request for UEFI sub-system for efi-2020-07-rc2-3 This series contains bug fixes and code simplifications. Following clarification in the discussion of the EBBR specification device trees will be passed as EfiACPIReclaimMemory to UEFI applications. No problems where reported by Gitlab and Travis: https://gitlab.denx.de/u-boot/custodians/u-boot-efi/pipelines/3131 https://travis-ci.org/github/xypron2/u-boot/builds/684346617 ---------------------------------------------------------------- Heinrich Schuchardt (6): efi_loader: remove redundant assignment in dp_fill() efi_loader: error handling in efi_set_variable_common(). efi_loader: do not unnecessarily use EFI_CALL() efi_loader: use logical and in do_env_print_efi() efi_loader: put device tree into EfiACPIReclaimMemory efi_loader: crypto/pkcs7_parser.h is not a local include Jan Kiszka (1): kbuild: efi: Avoid rebuilding efi targets Patrick Wildt (2): efi_loader: efi_variable_parse_signature() returns NULL on error efi_loader: pkcs7_parse_message() returns error pointer cmd/bootefi.c | 4 ++-- cmd/nvedit_efi.c | 2 +- lib/efi_loader/Makefile | 1 + lib/efi_loader/efi_device_path.c | 2 +- lib/efi_loader/efi_image_loader.c | 6 ++++-- lib/efi_loader/efi_variable.c | 39 ++++++++++++++++++---------------- lib/efi_selftest/efi_selftest_memory.c | 4 ++-- scripts/Makefile.lib | 2 ++ 8 files changed, 34 insertions(+), 26 deletions(-)

2 1