December 2019 - U-Boot

[PATCH] dfu: Add option to skip empty pages when flashing UBI images to NAND
by Guillermo Rodríguez 16 Dec '19

16 Dec '19

Add a new option to enable the DROP_FFS flag when flashing UBI images to NAND in order to drop trailing all-0xff pages. This is similar to the existing FASTBOOT_FLASH_NAND_TRIMFFS option. Signed-off-by: Guillermo Rodriguez <guille.rodriguez(a)gmail.com> Cc: Lukasz Majewski <lukma(a)denx.de> --- drivers/dfu/Kconfig | 7 +++++++ drivers/dfu/dfu_nand.c | 7 ++++++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig index 75fe0a12c6..5573f5e9cc 100644 --- a/drivers/dfu/Kconfig +++ b/drivers/dfu/Kconfig @@ -36,6 +36,13 @@ config DFU_NAND This option enables using DFU to read and write to NAND based storage. +config DFU_NAND_TRIMFFS + bool "Skip empty pages when flashing UBI images to NAND" + depends on DFU_NAND + help + When flashing UBI images to NAND, enable the DROP_FFS flag to drop + trailing all-0xff pages. + config DFU_RAM bool "RAM back end for DFU" help diff --git a/drivers/dfu/dfu_nand.c b/drivers/dfu/dfu_nand.c index b812a3dfb1..58b94348c9 100644 --- a/drivers/dfu/dfu_nand.c +++ b/drivers/dfu/dfu_nand.c @@ -50,6 +50,7 @@ static int nand_block_op(enum dfu_op op, struct dfu_entity *dfu, lim, buf); } else { nand_erase_options_t opts; + int write_flags = WITH_WR_VERIFY; memset(&opts, 0, sizeof(opts)); opts.offset = start; @@ -62,8 +63,12 @@ static int nand_block_op(enum dfu_op op, struct dfu_entity *dfu, if (ret) return ret; /* then write */ +#ifdef CONFIG_DFU_NAND_TRIMFFS + if (dfu->data.nand.ubi) + write_flags |= WITH_DROP_FFS; +#endif ret = nand_write_skip_bad(mtd, start, &count, &actual, - lim, buf, WITH_WR_VERIFY); + lim, buf, write_flags); } if (ret != 0) { -- 2.21.0

1 0

[RFC PATCH 0/2] Ethernet driver for GENET
by Amit Singh Tomar 16 Dec '19

16 Dec '19

Hi, This is the RFC version of Ethernet driver Andre and I have been working on for sometime now. MAC controller is based on Broadcom's GENETv5 IP.There is no documentation available for this controller Publicly and it's derived lookig at the Linux source[1]. At the moment, ping works from RPI to host machine and TFTP for small files succeed but TFTP bigger files is still an issue. We would be greatful to get some feedback and help to get it working properly. [1]: https://github.com/torvalds/linux/blob/master/drivers/net/ethernet/broadcom… Amit Singh Tomar (2): rpi: Update memory map to accommodate scb devices net: Add Support for GENET Ethernet controller arch/arm/mach-bcm283x/init.c | 6 +- configs/rpi_4_defconfig | 2 + drivers/net/Kconfig | 7 + drivers/net/Makefile | 1 + drivers/net/bcmgenet.c | 770 +++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 783 insertions(+), 3 deletions(-) create mode 100644 drivers/net/bcmgenet.c -- 2.7.4

4 7

[BUG] common/usb.c: taking address of packed member of ‘struct usb_device_descriptor’ may result in an unaligned pointer value
by Heinrich Schuchardt 16 Dec '19

16 Dec '19

Hello Marek, with powerpc64-linux-gnu-gcc, version 9.2.1, big endian I see the errors below. struct usb_device_descriptor is naturally packed. Why do we need the packed attribute in include/linux/usb/ch9.h? If it is needed, we should replace le16_to_cpus() by an alignment friendly implementation in common/usb.c, e.g. using u8* pointers. CC common/usb.o In file included from ./arch/powerpc/include/asm/byteorder.h:82, from ./arch/powerpc/include/asm/bitops.h:8, from include/linux/bitops.h:136, from include/common.h:26, from common/usb.c:28: common/usb.c: In function ‘usb_select_config’: common/usb.c:1081:15: error: taking address of packed member of ‘struct usb_device_descriptor’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 1081 | le16_to_cpus(&dev->descriptor.bcdUSB); include/linux/byteorder/big_endian.h:98:38: note: in definition of macro ‘__le16_to_cpus’ 98 | #define __le16_to_cpus(x) __swab16s((x)) | ^ common/usb.c:1081:2: note: in expansion of macro ‘le16_to_cpus’ 1081 | le16_to_cpus(&dev->descriptor.bcdUSB); | ^~~~~~~~~~~~ common/usb.c:1082:15: error: taking address of packed member of ‘struct usb_device_descriptor’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 1082 | le16_to_cpus(&dev->descriptor.idVendor); include/linux/byteorder/big_endian.h:98:38: note: in definition of macro ‘__le16_to_cpus’ 98 | #define __le16_to_cpus(x) __swab16s((x)) | ^ common/usb.c:1082:2: note: in expansion of macro ‘le16_to_cpus’ 1082 | le16_to_cpus(&dev->descriptor.idVendor); | ^~~~~~~~~~~~ common/usb.c:1083:15: error: taking address of packed member of ‘struct usb_device_descriptor’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 1083 | le16_to_cpus(&dev->descriptor.idProduct); include/linux/byteorder/big_endian.h:98:38: note: in definition of macro ‘__le16_to_cpus’ 98 | #define __le16_to_cpus(x) __swab16s((x)) | ^ common/usb.c:1083:2: note: in expansion of macro ‘le16_to_cpus’ 1083 | le16_to_cpus(&dev->descriptor.idProduct); | ^~~~~~~~~~~~ common/usb.c:1084:15: error: taking address of packed member of ‘struct usb_device_descriptor’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 1084 | le16_to_cpus(&dev->descriptor.bcdDevice); include/linux/byteorder/big_endian.h:98:38: note: in definition of macro ‘__le16_to_cpus’ 98 | #define __le16_to_cpus(x) __swab16s((x)) | ^ common/usb.c:1084:2: note: in expansion of macro ‘le16_to_cpus’ 1084 | le16_to_cpus(&dev->descriptor.bcdDevice); | ^~~~~~~~~~~~ Best regards Heinrich

2 1

Boot from different partitions based on some condition
by Mats Jansson 16 Dec '19

16 Dec '19

Hi, I want to set up for an upgrade of our embedded system, using a special kernel for the upgrade. The standard will be to load the system from mtd3 (kernel), mtd4 (devicetree) and mtd5 (rootfs). When an update is to take place I want to run the upgrade system from mtd0. So basically I need to have some sort of telling U-boot that it should launch the upgrade system instead of the standard system. Any ideas how I set this up? How to tell u-boot? How to get u-boot to boot from another partition based on a condition like that? Regards Mats mailto:matsmanhav@tele2.se

3 2

gtlab slow?
by Simon Glass 16 Dec '19

16 Dec '19

Hi, I sometimes find that gitlab.denx.de is very slow. Just now is is worse than usual - it has taken almost 10 minutes to push a branch and still not finished. I am getting a 503 error on the web site. Any ideas? Regards, Simon

5 4

[PATCH 1/1] efi_loader: git ignore helloworld_efi.S
by Heinrich Schuchardt 16 Dec '19

16 Dec '19

Add *.S to .gitignore. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- lib/efi_loader/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/efi_loader/.gitignore b/lib/efi_loader/.gitignore index 634a600f84..f2d7c14447 100644 --- a/lib/efi_loader/.gitignore +++ b/lib/efi_loader/.gitignore @@ -1,2 +1,3 @@ *.efi *.so +*.S -- 2.24.0

1 0

[PATCH v2 1/1] efi_selftest: Update .gitignore
by Heinrich Schuchardt 16 Dec '19

16 Dec '19

From: Sughosh Ganu <sughosh.ganu(a)linaro.org> Add the following file to .gitignore efi_miniapp_file_image_exception.h Signed-off-by: Sughosh Ganu <sughosh.ganu(a)linaro.org> Use efi_miniapp_*.h instead of file enumeration. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- v2 Use efi_miniapp_*.h instead of file enumeration. --- lib/efi_selftest/.gitignore | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/efi_selftest/.gitignore b/lib/efi_selftest/.gitignore index 293a17b818..5b25169e6e 100644 --- a/lib/efi_selftest/.gitignore +++ b/lib/efi_selftest/.gitignore @@ -1,4 +1,3 @@ -efi_miniapp_file_image_exit.h -efi_miniapp_file_image_return.h +efi_miniapp_*.h *.efi *.so -- 2.24.0

1 0

[U-Boot] [PATCH] mtd: spi-nor: ids: Add GigaDevice gd25q128
by Peter Robinson 16 Dec '19

16 Dec '19

Add gd25q128 128Mbit chip to spi-nor id table. Tested on Pinebook Pro Signed-off-by: Peter Robinson <pbrobinson(a)gmail.com> --- drivers/mtd/spi/spi-nor-ids.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c index d3b84574ac..973b6f86c9 100644 --- a/drivers/mtd/spi/spi-nor-ids.c +++ b/drivers/mtd/spi/spi-nor-ids.c @@ -107,6 +107,11 @@ const struct flash_info spi_nor_ids[] = { SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) }, + { + INFO("gd25q128", 0xc84018, 0, 64 * 1024, 256, + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) + }, { INFO("gd25lq128", 0xc86018, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | -- 2.23.0

2 2

[RFC] new board VoCore2
by Mauro Condarelli 16 Dec '19

16 Dec '19

I am trying to extend support to a new board "VoCore2" whose specs can be found here: https://vocore.io/v2.html Port is concerning the "ultimate" board which has all connectors in place for SD, USB and Ethernet. This board comes with a paleolithic (1.3.0) version of u-boot and I'm trying to upgrade to a recent one also because I need to implement "automatic upgrade" (possibly using RAUC, but that is another story). Port is working and able to boot Linuz, but it is not ready for inclusion for several reasons and I would like to have expert advice on how to tackle shortcomings, as advised by stefanro on IRC: > 6:49:14 AM - stefanro: mcon: Please submit the patches directly to the > list, with me (and other MIPS / MT7628/88 experts - Daniel etc) on Cc. > If you feel the patches are not ready for integration, then you can > mark them as "RFC" in the subject. Problematic areas I see (side from possible code style issues) are: 1) I added support for a new SPI NOR Flash and that should, probably, be a separate patch. 2) I added support for SPI NOR partitioning and I'm unsure if that should be in the "board definition". 3) SPI NOR partitioning is actually duplicated in ENV var (mtdparts) and in Device Tree; I didn't find how to read it directly from DT. 4) Board also has SD, handled via MTK_SD driver, but I've been unable to make it work. 5) Current binary is rather big and I would like to shrink it a bit, if possible. Any hint/criticism/advice would be VERY welcome. Thanks in Advance Mauro Condarelli

2 2

[Patch] Add support for GD25Q128C SPI NOR chip
by Mauro Condarelli 16 Dec '19

16 Dec '19

Trivial patch to add Support for GigaDevice GD25Q128C: diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c index d3b84574ac..fbb7dca30c 100644 --- a/drivers/mtd/spi/spi-nor-ids.c +++ b/drivers/mtd/spi/spi-nor-ids.c @@ -107,6 +107,11 @@ const struct flash_info spi_nor_ids[] = { SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) }, + { + INFO("gd25q128", 0xc84018, 0, 64 * 1024, 256, + SECT_4K | SPI_NOR_DUAL_READ | + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) + }, { INFO("gd25lq128", 0xc86018, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | Regards Mauro Condarelli

2 1