December 2019 - U-Boot

[U-Boot] [PATCH v4 0/5] of-platdata: Avoid building libfdt
by Simon Glass 02 Jan '20

02 Jan '20

The original patch of this series was sent in September but unfortunately caused build problems on some boards, since they don't comply with the of-platdata rules. With of-platdata, the idea is to compile the device tree into C structures to save space and avoid needing to use libfdt. But some boards use of-platdata while also using libfdt in a few areas, thus defeating the purpose of of-platdata. This series includes the original two patches http://patchwork.ozlabs.org/patch/1167420/ http://patchwork.ozlabs.org/patch/1167367/ as well as a few other patches to fix the build errors. Overall this reduces code size and provides better error messages when unavailable functions are used. Board maintainers should still take a look at the result, adjusting the of-platdata support as needed. Changes in v4: - Add new patch for rockchip build errors - Add new patch for omap MMC build errors - Add new patch for rockchip chromebook build errors - Pull out patches into a new series - Add new patches to handle build failures Changes in v3: - Fix eth_dev_get_mac_address() call dev_read...() only when available Simon Glass (5): rockchip: Avoid using libfdt with of-platdata omap: mmc: Avoid using libfdt with of-platdata rockchip: pinctrl: Disable full pinctrl for SPL dm: core: Don't include ofnode functions with of-platdata spl: Allow SPL/TPL to use of-platdata without libfdt configs/chromebit_mickey_defconfig | 1 + configs/chromebook_jerry_defconfig | 1 + configs/chromebook_minnie_defconfig | 1 + configs/chromebook_speedy_defconfig | 1 + drivers/clk/rockchip/clk_rk3328.c | 14 ++++++++++++-- drivers/core/Makefile | 4 +++- drivers/mmc/davinci_mmc.c | 6 ++++++ drivers/pinctrl/rockchip/pinctrl-rockchip-core.c | 6 ++++-- include/dm/read.h | 3 +-- lib/Kconfig | 4 ++-- net/eth-uclass.c | 2 +- 11 files changed, 33 insertions(+), 10 deletions(-) -- 2.24.0.rc1.363.gb1bccd3e3d-goog

5 12

[PATCH v3 0/3] Add support for efi_rng_protocol
by Sughosh Ganu 31 Dec '19

31 Dec '19

The patch series adds support for the EFI_RNG_PROTOCOL routines for qemu arm64 platform. The getrng routine, used to get the random bytes, uses the virtio-rng device found on the platform. The protocol, once installed, can be used by the efi stub in the kernel for getting random bytes needed for the kaslr feature. These patches apply on top of the patch series to add random number generator driver uclass[1] [1] - https://lists.denx.de/pipermail/u-boot/2019-December/394654.html Changes since V2: * Based on review comments from Heinrich Schuchardt, the rng drivers read all the bytes requested in the individual drivers. Corresponding changes made in getrng routine to remove the loop to read the bytes requested, since that would be handled in the drivers. Changes since V1: * Handle review comments from Heinrich Schuchardt. * Change the logic in the getrng routine to implement a loop to read the number of bytes requested. This change is needed to handle the change in the rng uclass's read function, which now returns the number of bytes read, which might be less than the number of bytes requested. Sughosh Ganu (3): efi_loader: Add guidcpy function efi: qemu: arm64: Add efi_rng_protocol implementation for the platform efi_rng_protocol: Install the efi_rng_protocol on the root node board/emulation/qemu-arm/qemu-arm.c | 41 +++++++++++++++++++ include/efi_loader.h | 9 ++++ include/efi_rng.h | 32 +++++++++++++++ lib/efi_loader/Kconfig | 8 ++++ lib/efi_loader/Makefile | 1 + lib/efi_loader/efi_boottime.c | 4 +- lib/efi_loader/efi_rng.c | 82 +++++++++++++++++++++++++++++++++++++ lib/efi_loader/efi_root_node.c | 4 ++ 8 files changed, 179 insertions(+), 2 deletions(-) create mode 100644 include/efi_rng.h create mode 100644 lib/efi_loader/efi_rng.c -- 2.7.4

3 11

CONFIG_AUTOBOOT_KEYED_CTRLC default yes?
by Zubair Lutfullah Kakakhel 31 Dec '19

31 Dec '19

Hi, I have a pi4 running u-boot 2019.01. When I use the following config options ``` CONFIG_AUTOBOOT=y # CONFIG_AUTOBOOT_KEYED is not set ``` CTRL-C would continue to interrupt autoboot. Was quite surprised to see that. Took a look at the code. https://github.com/u-boot/u-boot/blob/master/common/autoboot.c#L367-L375 ``` lock = IS_ENABLED(CONFIG_AUTOBOOT_KEYED) && !IS_ENABLED(CONFIG_AUTOBOOT_KEYED_CTRLC); if (lock) prev = disable_ctrlc(1); /* disable Ctrl-C checking */ ``` So if `CONFIG_AUTOBOOT_KEYED=y` and `CONFIG_AUTOBOOT_KEYED_CTRLC=N`, then disable ctrl-c checking. That means if we disable `CONFIG_AUTOBOOT_KEYED`, we can still end up with ctrl-c checking? Why is Ctrl-C checking default ON instead of being enabled only when `CONFIG_AUTOBOOT_KEYED_CTRLC=y` Am I missing something here? Thanks ZubairLK

1 0

[PATCH] arm: mach-k3: Enable WA for R5F deadlock
by Lokesh Vutla 31 Dec '19

31 Dec '19

On K3 devices there are 2 conditions where R5F can deadlock: 1.When software is performing series of store operations to cacheable write back/write allocate memory region and later on software execute barrier operation (DSB or DMB). R5F may hang at the barrier instruction. 2.When software is performing a mix of load and store operations within a tight loop and store operations are all writing to cacheable write back/write allocates memory regions, R5F may hang at one of the load instruction. To avoid the above two conditions disable linefill optimization inside Cortex R5F which will make R5F to only issue up to 2 cache line fills at any point of time. Signed-off-by: Lokesh Vutla <lokeshvutla(a)ti.com> --- arch/arm/mach-k3/am6_init.c | 1 + arch/arm/mach-k3/common.c | 25 +++++++++++++++++++++++++ arch/arm/mach-k3/common.h | 1 + arch/arm/mach-k3/j721e_init.c | 1 + 4 files changed, 28 insertions(+) diff --git a/arch/arm/mach-k3/am6_init.c b/arch/arm/mach-k3/am6_init.c index 99edcd9a24..a78ffbb674 100644 --- a/arch/arm/mach-k3/am6_init.c +++ b/arch/arm/mach-k3/am6_init.c @@ -82,6 +82,7 @@ void board_init_f(ulong dummy) ctrl_mmr_unlock(); #ifdef CONFIG_CPU_V7R + disable_linefill_optimization(); setup_k3_mpu_regions(); #endif diff --git a/arch/arm/mach-k3/common.c b/arch/arm/mach-k3/common.c index bf631b74f8..50f5b81dfe 100644 --- a/arch/arm/mach-k3/common.c +++ b/arch/arm/mach-k3/common.c @@ -244,3 +244,28 @@ void board_prep_linux(bootm_headers_t *images) CONFIG_SYS_CACHELINE_SIZE)); } #endif + +#ifdef CONFIG_CPU_V7R +void disable_linefill_optimization(void) +{ + u32 actlr; + + /* + * On K3 devices there are 2 conditions where R5F can deadlock: + * 1.When software is performing series of store operations to + * cacheable write back/write allocate memory region and later + * on software execute barrier operation (DSB or DMB). R5F may + * hang at the barrier instruction. + * 2.When software is performing a mix of load and store operations + * within a tight loop and store operations are all writing to + * cacheable write back/write allocates memory regions, R5F may + * hang at one of the load instruction. + * + * To avoid the above two conditions disable linefill optimization + * inside Cortex R5F. + */ + asm("mrc p15, 0, %0, c1, c0, 1" : "=r" (actlr)); + actlr |= (1 << 13); /* Set DLFO bit */ + asm("mcr p15, 0, %0, c1, c0, 1" : : "r" (actlr)); +} +#endif diff --git a/arch/arm/mach-k3/common.h b/arch/arm/mach-k3/common.h index 8f9a023921..35d1609cdc 100644 --- a/arch/arm/mach-k3/common.h +++ b/arch/arm/mach-k3/common.h @@ -16,3 +16,4 @@ void setup_k3_mpu_regions(void); int early_console_init(void); +void disable_linefill_optimization(void); diff --git a/arch/arm/mach-k3/j721e_init.c b/arch/arm/mach-k3/j721e_init.c index d0bf86abeb..4758739266 100644 --- a/arch/arm/mach-k3/j721e_init.c +++ b/arch/arm/mach-k3/j721e_init.c @@ -87,6 +87,7 @@ void board_init_f(ulong dummy) ctrl_mmr_unlock(); #ifdef CONFIG_CPU_V7R + disable_linefill_optimization(); setup_k3_mpu_regions(); #endif -- 2.23.0

1 0

[PATCH] arm: dts: k3-j721e: ddr: Update to 0.2 version of DDR config tool
by Lokesh Vutla 31 Dec '19

31 Dec '19

Update the ddr settings to use the DDR reg config tool rev 0.2.0. This reduces the aging count(in DDRSS_CTL_274_DATA reg) to 15 in-order to avoid DSS underflow errors. Signed-off-by: Lokesh Vutla <lokeshvutla(a)ti.com> Signed-off-by: Kevin Scholz <k-scholz(a)ti.com> --- arch/arm/dts/k3-j721e-ddr-evm-lp4-3733.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/dts/k3-j721e-ddr-evm-lp4-3733.dtsi b/arch/arm/dts/k3-j721e-ddr-evm-lp4-3733.dtsi index 135b6193a9..5ac32a0ffa 100644 --- a/arch/arm/dts/k3-j721e-ddr-evm-lp4-3733.dtsi +++ b/arch/arm/dts/k3-j721e-ddr-evm-lp4-3733.dtsi @@ -1,8 +1,8 @@ // SPDX-License-Identifier: GPL-2.0+ /* * Copyright (C) 2019 Texas Instruments Incorporated - http://www.ti.com/ - * This file was generated by the AM752x_DRA82x_TDA4x_DDRSS_RegConfigTool, Revision: 0.1.0 - * This file was generated on 09/06/2019 + * This file was generated by the AM752x_DRA82x_TDA4x_DDRSS_RegConfigTool, Revision: 0.2.0 + * This file was generated on 10/09/2019 */ #define DDRSS_PLL_FHS_CNT 10 @@ -283,7 +283,7 @@ #define DDRSS_CTL_271_DATA 0x1FFF1000 #define DDRSS_CTL_272_DATA 0x01FF0000 #define DDRSS_CTL_273_DATA 0x000101FF -#define DDRSS_CTL_274_DATA 0xFFFF0B00 +#define DDRSS_CTL_274_DATA 0x0FFF0B00 #define DDRSS_CTL_275_DATA 0x01010001 #define DDRSS_CTL_276_DATA 0x01010101 #define DDRSS_CTL_277_DATA 0x01180101 -- 2.23.0

1 0

[PATCH 1/3] rockchip: rk3328: add COUNTER_FREQUENCY definition
by Kever Yang 31 Dec '19

31 Dec '19

The arch timer needs COUNTER_FREQUENCY to get correct counter, add it to make the timer works correct. Signed-off-by: Kever Yang <kever.yang(a)rock-chips.com> --- include/configs/rk3328_common.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/configs/rk3328_common.h b/include/configs/rk3328_common.h index b14da3a626..407e5d2931 100644 --- a/include/configs/rk3328_common.h +++ b/include/configs/rk3328_common.h @@ -11,6 +11,7 @@ #define CONFIG_IRAM_BASE 0xff090000 #define CONFIG_ROCKCHIP_STIMER_BASE 0xff1d0020 +#define COUNTER_FREQUENCY 24000000 #define CONFIG_SYS_CBSIZE 1024 #define CONFIG_SKIP_LOWLEVEL_INIT -- 2.17.1

1 2

[PATCH v6 0/8] Add a random number generator uclass
by Sughosh Ganu 31 Dec '19

31 Dec '19

Add a random number generator(rng) uclass to facilitate adding drivers for rng devices. I plan to add an implementation of the EFI_RNG_PROTOCOL, which would get the random number from the rng uclass -- the protocol would be used by the efi stub for getting a random number for the kaslr feature. The patch series also adds a driver for the rng device found on the stm32mp1 and qemu platforms. A dummy rng driver for sandbox has also been added, along with the unit test for the rng uclass. Changes since V5: * Handle review comments from Heinrich Schuchardt to read all the bytes requested in the individual drivers. Changes since V4: * Get the read functions of individual drivers to return number of bytes read on successful read, and a -ve value on error. * Handle review comments from Heinrich Schuchardt. Changes since V3: * Handle review comments from Patrick Delaunay Changes since V2: * Add a driver for the virtio-rng device on qemu platform Changes since V1: * Add a SPDX header in rng.h * Change the UCLASS_DRIVER name from hwrng to rng, consistent with the rest of the naming convention * Handle review comment from Patrice Chotard Sughosh Ganu (8): dm: rng: Add random number generator(rng) uclass clk: stm32mp1: Add a clock entry for RNG1 device stm32mp1: rng: Add a driver for random number generator(rng) device configs: stm32mp15: Enable random number generator(rng) device sandbox: rng: Add a random number generator(rng) driver configs: sandbox: Enable random number generator(rng) device test: rng: Add basic test for random number generator(rng) uclass virtio: rng: Add a random number generator(rng) driver arch/sandbox/dts/test.dts | 4 + configs/sandbox64_defconfig | 2 + configs/sandbox_defconfig | 2 + configs/stm32mp15_basic_defconfig | 2 + configs/stm32mp15_optee_defconfig | 2 + configs/stm32mp15_trusted_defconfig | 2 + drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/clk/clk_stm32mp1.c | 1 + drivers/rng/Kconfig | 22 +++++ drivers/rng/Makefile | 8 ++ drivers/rng/rng-uclass.c | 23 ++++++ drivers/rng/sandbox_rng.c | 56 +++++++++++++ drivers/rng/stm32mp1_rng.c | 161 ++++++++++++++++++++++++++++++++++++ drivers/virtio/Kconfig | 6 ++ drivers/virtio/Makefile | 1 + drivers/virtio/virtio-uclass.c | 1 + drivers/virtio/virtio_rng.c | 87 +++++++++++++++++++ include/dm/uclass-id.h | 1 + include/rng.h | 33 ++++++++ include/virtio.h | 4 +- test/dm/Makefile | 1 + test/dm/rng.c | 26 ++++++ 23 files changed, 447 insertions(+), 1 deletion(-) create mode 100644 drivers/rng/Kconfig create mode 100644 drivers/rng/Makefile create mode 100644 drivers/rng/rng-uclass.c create mode 100644 drivers/rng/sandbox_rng.c create mode 100644 drivers/rng/stm32mp1_rng.c create mode 100644 drivers/virtio/virtio_rng.c create mode 100644 include/rng.h create mode 100644 test/dm/rng.c -- 2.7.4

3 22

[PATCH 1/1] usb: avoid -Werror=address-of-packed-member
by Heinrich Schuchardt 31 Dec '19

31 Dec '19

With GCC 9.2.1 errors of type -Werror=address-of-packed-member occur when passing a member of a packed structure to le16_to_cpus() on a big endian system (e.g. P2041RDB_defconfig). Replace le16_to_cpus() by get_unaligned_le16(). Check defined(__BIG_ENDIAN) to avoid the introduction of unnecessary instructions on little endian systems as seen on aarch64. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- common/usb.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/common/usb.c b/common/usb.c index d9bcb5a57e..de6f7a3bf4 100644 --- a/common/usb.c +++ b/common/usb.c @@ -1078,10 +1078,16 @@ int usb_select_config(struct usb_device *dev) return err; /* correct le values */ - le16_to_cpus(&dev->descriptor.bcdUSB); - le16_to_cpus(&dev->descriptor.idVendor); - le16_to_cpus(&dev->descriptor.idProduct); - le16_to_cpus(&dev->descriptor.bcdDevice); +#if defined(__BIG_ENDIAN) + dev->descriptor.bcdUSB = + get_unaligned_le16(&dev->descriptor.bcdUSB); + dev->descriptor.idVendor = + get_unaligned_le16(&dev->descriptor.idVendor); + dev->descriptor.idProduct = + get_unaligned_le16(&dev->descriptor.idProduct); + dev->descriptor.bcdDevice = + get_unaligned_le16(&dev->descriptor.bcdDevice); +#endif /* * Kingston DT Ultimate 32GB USB 3.0 seems to be extremely sensitive -- 2.24.0

4 9

Re: [PATCH v2] riscv: Add option to print registers on exception
by Rick Chen 31 Dec '19

31 Dec '19

> From: Sean Anderson [mailto:seanga2@gmail.com] > Sent: Wednesday, December 25, 2019 1:28 PM > To: U-Boot Mailing List > Cc: Rick Jian-Zhi Chen(陳建志) > Subject: [PATCH v2] riscv: Add option to print registers on exception > > When debugging, it can be helpful to see more information about an unhandled exception. This patch adds an option to view the registers at the time of the trap, similar to the linux output on a kernel panic. > > Signed-off-by: Sean Anderson <seanga2(a)gmail.com> > --- > Changes for v2: > - Renamed "PC" to "EPC" > > arch/riscv/Kconfig | 3 +++ > arch/riscv/cpu/mtrap.S | 3 ++- > arch/riscv/lib/interrupts.c | 50 +++++++++++++++++++++++++++++-------- > 3 files changed, 44 insertions(+), 12 deletions(-) > Reviewed-by: Rick Chen <rick(a)andestech.com>

1 0

Re: [PATCH] riscv: Fix breakage caused by linker relaxation
by Rick Chen 31 Dec '19

31 Dec '19

> > From: Sean Anderson [mailto:seanga2@gmail.com] > > Sent: Wednesday, December 18, 2019 10:36 AM > > To: u-boot(a)lists.denx.de; Rick Jian-Zhi Chen(陳建志) > > Subject: [PATCH] riscv: Fix breakage caused by linker relaxation > > > > Due to the two-instruction sequence needed to access arbitrary memory > > locations, the RISC-V linker aggressively optimises memory accesses and jumps > > at link-time. This is called "linker relaxation," and is discussed in this SiFive > > article > > <https://www.sifive.com/blog/all-aboard-part-3-linker-relaxation-in-riscv-to… > > chain>. > > One of the optimizations in place is to assume that the __global_pointer > > symbol is placed in the gp register. To quote the article: > > > > "...The magic __global_pointer$ symbol is defined to point 0x800 bytes past > > the start of the .sdata section. The 0x800 magic number allows signed 12-bit > > offsets from __global_pointer$ to address symbols at the start of the .sdata > > section. The linker assumes that if this symbol is defined, then the gp register > > contains that value, which it can then use to relax accesses to global symbols > > within that 12-bit range. The compiler treats the gp register as a constant so it > > doesn't need to be saved or restored, which means it is generally only written > > by _start, the ELF entry point." > > > > However, U-Boot instead keeps the global data pointer in gp. This causes > > memory accesses and jumps optimized to use the gp pointer to fail. To fix this > > problem, we undefine the __global_pointer symbol. > > > > Signed-off-by: Sean Anderson <seanga2(a)gmail.com> > > --- > > arch/riscv/cpu/u-boot.lds | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/riscv/cpu/u-boot.lds b/arch/riscv/cpu/u-boot.lds index > > 838a844399..c00d17c736 100644 > > --- a/arch/riscv/cpu/u-boot.lds > > +++ b/arch/riscv/cpu/u-boot.lds > > @@ -32,7 +32,6 @@ SECTIONS > > > > . = ALIGN(4); > > .data : { > > - __global_pointer$ = . + 0x800; > > *(.data*) > > } > > . = ALIGN(4); Reviewed-by: Rick Chen <rick(a)andestech.com>

1 0