August 2018 - U-Boot

[U-Boot] [PATCH] stm32f7: board: Fix memory init
by Patrice Chotard 03 Aug '18

03 Aug '18

Commit 1473b12ad0b3 ("lib: fdtdec: Update ram_base to store ram start adddress") brings regression on STM32F7 which can't boot. Use fdtdec_setup_mem_size_base() to setup memory base and size. Use fdtdec_setup_memory_banksize() to setup memory bank base and size. Reported-by: Mark Olsson <mark(a)markolsson.se> Signed-off-by: Patrice Chotard <patrice.chotard(a)st.com> Cc: Mark Olsson <mark(a)markolsson.se> --- board/st/stm32f746-disco/stm32f746-disco.c | 31 ++++-------------------------- 1 file changed, 4 insertions(+), 27 deletions(-) diff --git a/board/st/stm32f746-disco/stm32f746-disco.c b/board/st/stm32f746-disco/stm32f746-disco.c index e21cfc6e4955..a997e1825abf 100644 --- a/board/st/stm32f746-disco/stm32f746-disco.c +++ b/board/st/stm32f746-disco/stm32f746-disco.c @@ -21,23 +21,9 @@ DECLARE_GLOBAL_DATA_PTR; -int get_memory_base_size(fdt_addr_t *mr_base, fdt_addr_t *mr_size) -{ - int mr_node; - - mr_node = fdt_path_offset(gd->fdt_blob, "/memory"); - if (mr_node < 0) - return mr_node; - *mr_base = fdtdec_get_addr_size_auto_noparent(gd->fdt_blob, mr_node, - "reg", 0, mr_size, false); - debug("mr_base = %lx, mr_size= %lx\n", *mr_base, *mr_size); - - return 0; -} int dram_init(void) { - int rv; - fdt_addr_t mr_base, mr_size; + int rv = 0; #ifndef CONFIG_SUPPORT_SPL struct udevice *dev; @@ -48,24 +34,15 @@ int dram_init(void) } #endif - rv = get_memory_base_size(&mr_base, &mr_size); - if (rv) - return rv; - gd->ram_size = mr_size; - gd->ram_top = mr_base; + if (fdtdec_setup_mem_size_base() != 0) + rv = -EINVAL; return rv; } int dram_init_banksize(void) { - fdt_addr_t mr_base, mr_size; - get_memory_base_size(&mr_base, &mr_size); - /* - * Fill in global info with description of SRAM configuration - */ - gd->bd->bi_dram[0].start = mr_base; - gd->bd->bi_dram[0].size = mr_size; + fdtdec_setup_memory_banksize(); return 0; } -- 1.9.1

3 2

[U-Boot] [PATCH] net: fman: Support both new and legacy FMan Compatibles
by Zhao Qiang 03 Aug '18

03 Aug '18

Recently the FMan Port and MAC compatibles were changed. This patch aligns the FMan Port and MAC compatibles to the new FMan device tree binding document. The FMan device tree binding document can be found in the Linux kernel: ./Documentation/devicetree/bindings/net/fsl-fman.txt This patch doesn't affect legacy compatibles support. Signed-off-by: Zhao Qiang <qiang.zhao(a)nxp.com> --- drivers/net/fm/init.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/fm/init.c b/drivers/net/fm/init.c index 147d043..e3b1a50 100644 --- a/drivers/net/fm/init.c +++ b/drivers/net/fm/init.c @@ -328,7 +328,8 @@ void fdt_fixup_fman_ethernet(void *blob) ft_fixup_port(blob, &fm_info[i], "fsl,fman-1g-mac"); } else { - if (ft_fixup_port(blob, &fm_info[i], "fsl,fman-tgec")) + if (ft_fixup_port(blob, &fm_info[i], "fsl,fman-tgec") && + ft_fixup_port(blob, &fm_info[i], "fsl,fman-xgec")) ft_fixup_port(blob, &fm_info[i], "fsl,fman-10g-mac"); } -- 1.7.1

4 3

[U-Boot] [PATCH v3 01/13] test: regmap: Increase size of syscon0 memory
by Mario Six 03 Aug '18

03 Aug '18

The upcoming changes to the regmap interface will contain a proper check for plausibility when reading/writing from/to a register map. To still have the current tests pass, increase the size of the memory region for the syscon0 device, since one of the tests reads and writes beyond this range. Signed-off-by: Mario Six <mario.six(a)gdsys.cc> --- v2 -> v3: New in v3 --- arch/sandbox/dts/test.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts index e941cea3e5c..47cc961890f 100644 --- a/arch/sandbox/dts/test.dts +++ b/arch/sandbox/dts/test.dts @@ -406,7 +406,7 @@ syscon@0 { compatible = "sandbox,syscon0"; - reg = <0x10 4>; + reg = <0x10 16>; }; syscon@1 { -- 2.11.0

3 39

[U-Boot] bootelf and 64 bit elf application
by Siddharth Tuli 03 Aug '18

03 Aug '18

Hi, I am trying to use bootelf to load a 64-bit elf binary, but it appears to fail. I tried using the hello_world from U-Boot sources as well. My U-Boot is based 2015.01 and I have patches applied for 64elf support, and compiled as a 64 bit U-Boot. Any idea what is need to support bootelf for 64-bit? <snip> # file hello_world.bin hello_world.bin: ELF 64-bit LSB executable, version 1 (SYSV), statically linked, not stripped uboot# tftp 0x80300000 tsiddharth/hello_world.bin *****ethHw_checkPortSpeed setting speed: 5 Using bcmiproc_eth-0 device TFTP from server 10.204.96.200; our IP address is 10.216.67.182; sending through gateway 10.216.79.254 Filename 'tsiddharth/hello_world.bin'. Load address: 0x80300000 Loading: ##### 889.6 KiB/s done Bytes transferred = 68336 (10af0 hex) uboot# bootelf -p 0x80300000 <=== I looked at cmd/elf.c and I see that bootelf calls load_elf64_img_phdr() only with “-p” option. Loading phdr 0 to 0x000000000c100000 (794 bytes) Loading phdr 1 to 0x0000000000000000 (0 bytes) ## Starting application at 0x0c100000 ... "Synchronous Abort" handler, esr 0x86000210 ELR: c100000 LR: fff4197c x0 : 0000000000000002 x1 : 00000000feb3f058 x2 : 0000000000000020 x3 : 0000000000000001 x4 : 0000000000000020 x5 : 00000000015087ba x6 : 00000000ffffffd0 x7 : 0000000000000004 x8 : 0000000000000063 x9 : 000000007af38000 x10: 00000000feaf7678 x11: 00000000fff8c000 x12: 000000000000000f x13: 00000000fffa18c1 x14: 00000000fff99186 x15: 00000000fff99180 x16: 00000000fffa18c1 x17: 00000000fff99175 x18: 00000000feaf7e30 x19: 000000000c100000 x20: 0000000000000000 x21: 00000000feb3f058 x22: 0000000000000002 x23: 0000000000000002 x24: 0000000000000000 x25: 00000000fff912f9 x26: 0000000000000000 x27: 0000000000000000 x28: 0000000000000000 x29: 00000000feaf7b00 Resetting CPU ... resetting ... </snip> Patches applied - author Bin Meng <bmeng.cn(a)gmail.com<mailto:bmeng.cn@gmail.com>> Thu, 12 Apr 2018 10:32:14 +0530 (22:02 -0700) commit 839c4e9c5bb09ac1ef2c129c7082a15b9cbd3a8a elf: Add a very simple ELF64 loader This adds a very simple ELF64 loader via program headers, similar to load_elf_image_phdr() that we already have. author Bin Meng <bmeng.cn(a)gmail.com<mailto:bmeng.cn@gmail.com>> Thu, 12 Apr 2018 10:32:13 +0530 (22:02 -0700) commit 2bce3f595d224fc620b07449d47fa2b08151a890 elf: Add ELF64 related structure defines This adds ELF header, program header and section header structure defines for the 64-bit ELF image. Regards Siddharth

2 2

[U-Boot] [PATCH v2 00/21] dm: pci: Various fixes and test cases update
by Bin Meng 03 Aug '18

03 Aug '18

This fixes several bugs in dm pci driver, as well as updating test cases running on Sandbox to test dm pci. It turns out adding test cases for v1 (3 commits) reveals more design limitations/bugs of sandbox pci driver. Now the v2 series contains 20+ patches! This series is available for testing at u-boot-x86/pci branch. Changes in v2: - Mask header_type with 0x7f Bin Meng (21): pci: Remove 440ep specific macros dm: Correct typos in uclass_first/next_device_check() dm: core: Add ofnode function to read PCI vendor and device id dm: pci: Extract vendor/device id in child_post_bind() dm: pci: Fix scanning multi-function device test: dm: pci: Remove unnecessary steps in dm_test_pci_swapcase() test: dm: pci: Test more than one device on the same bus pci: sandbox: swap_case: Preserve space indicator bit in BAR registers test: dm: pci: Test more than one PCI host controller test: dm: pci: Add tests for configuration space access pci: sandbox: emul: Fix the call to pci_bus_find_devfn() dm: pci: Assign correct driver data when binding a driver pci: sandbox: Support dynamically binding device driver pci: sandbox: swap_case: Declare dynamic driver matching sandbox: Update test.dts for dynamic PCI device driver matching test: dm: pci: Test driver binding with driver data provided pci: sandbox: emul: Rename priv structure test: dm: pci: Add tests for mixed static and dynamic devices on the same bus pci: Add all known capability and extended capability ids dm: pci: Add APIs to find capability and extended capability test: dm: pci: Add cases for finding PCI capability APIs arch/sandbox/dts/test.dts | 41 +++++++++- arch/sandbox/include/asm/test.h | 12 +++ doc/driver-model/pci-info.txt | 23 ++++++ drivers/core/ofnode.c | 36 +++++++++ drivers/misc/swap_case.c | 36 ++++++++- drivers/pci/pci-emul-uclass.c | 24 +++--- drivers/pci/pci-uclass.c | 83 ++++++++++++++++++-- drivers/pci/pci_sandbox.c | 78 ++++++++++++++++-- include/dm/ofnode.h | 13 +++ include/dm/uclass.h | 4 +- include/pci.h | 84 ++++++++++++++++---- test/dm/pci.c | 170 ++++++++++++++++++++++++++++++++++++++-- 12 files changed, 551 insertions(+), 53 deletions(-) -- 2.7.4

2 42

[U-Boot] [PATCH] Revert "efi_loader: efi_allocate_pages is too restrictive"
by Stephen Warren 02 Aug '18

02 Aug '18

From: Stephen Warren <swarren(a)nvidia.com> This reverts commit aa909462d01866354f4cd4534db5f571c2cf1fbb. This change caused "dhcp filename" to crash the system on p2371-2180 (Jetson TX1), for example when running test/py. Reverting this change isn't optimal, but at least restores TX1 to a working state. In the future, we should: a) Fix whatever problem causes the crash with this patch applied. This needs further discussion, so isn't something we can immediately do. b) Undo the revert; re-apply the original patch to efi_allocate_pages. Cc: Heinrich Schuchardt <xypron.glpk(a)gmx.de> Cc: Alexander Graf <agraf(a)suse.de> Signed-off-by: Stephen Warren <swarren(a)nvidia.com> --- lib/efi_loader/efi_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c index 967c3f733e4c..4b6269f35e11 100644 --- a/lib/efi_loader/efi_memory.c +++ b/lib/efi_loader/efi_memory.c @@ -305,7 +305,7 @@ efi_status_t efi_allocate_pages(int type, int memory_type, switch (type) { case EFI_ALLOCATE_ANY_PAGES: /* Any page */ - addr = efi_find_free_memory(len, -1ULL); + addr = efi_find_free_memory(len, gd->start_addr_sp); if (!addr) { r = EFI_NOT_FOUND; break; -- 2.18.0

2 1

[U-Boot] U-Boot: Verified Boot: signed configuration and mix and match attack
by Johann Neuhauser 02 Aug '18

02 Aug '18

Dear U-Boot devs, I've setup verified boot on a imx6 board and want to protect my device against the "mix and match" attacks mentioned in "doc/uImage.FIT/signature.txt". That's why I have only implemented signed configurations and no signed images as in doc/uImage.FIT/signed-configs.its. My public key in my embedded fdt has the property required = "conf"; Booting a signed config with "bootm ${loadaddr}#conf@1" and an embedded public key required for configurations does work as expected and do fail to boot if I modify the config, image, hash, signature and so on. If I boot any fit image(signed and unsigned) for example with "bootm ${loadaddr}:kernel@1 - fdt@1" to select the subimages directly, I could boot every image combination without signature verification although a signature is enforced for a configuration. Is this the expected behavior? I thought if I had set the public key in in the embedded fdt as required for configurations, bootm does only boot signed configurations and no subimages directly... Best regards Johann Neuhauser DH electronics GmbH

2 3

[U-Boot] Talos Security Advisory (TALOS-2018-0633/CVE-2018-3968 )
by Regina Wilson (regiwils) 02 Aug '18

02 Aug '18

Hello, Cisco Talos team discovered a security issue impacting Cujo product using an outdated version of U-boot. We’ve assigned a CVE for this issue (CVE-2018-3968) and have attached a copy of the security advisory provided to Cujo.

1 0

[U-Boot] [PATCH] ARM: tegra: align carveout size
by Stephen Warren 02 Aug '18

02 Aug '18

From: Stephen Warren <swarren(a)nvidia.com> Align the size of the carveout region to 2M. This ensures that the size can be accurately represented by an LPAE page table that uses sections. This solves a bug (hang at boot time soon after printing the DRAM size) that only shows up when the following two commits are merged together: d32e86bde8a3 ARM: HYP/non-sec: enable ARMV7_LPAE if HYP mode is supported 6e584e633d10 ARM: tegra: avoid using secure carveout RAM Cc: Mark Kettenis <kettenis(a)openbsd.org> Cc: Alexander Graf <agraf(a)suse.de> Signed-off-by: Stephen Warren <swarren(a)nvidia.com> --- This should be applied quickly since it fixes a regression that causes all boots to fail, which in turn causes test/py to reset and "reflash" the target board for each test, which causes the test to take eons. arch/arm/mach-tegra/board2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-tegra/board2.c b/arch/arm/mach-tegra/board2.c index 5ecadf705e7e..421a71b3014d 100644 --- a/arch/arm/mach-tegra/board2.c +++ b/arch/arm/mach-tegra/board2.c @@ -252,7 +252,7 @@ static ulong carveout_size(void) #elif defined(CONFIG_ARMV7_SECURE_RESERVE_SIZE) // BASE+SIZE might not == 4GB. If so, we want the carveout to cover // from BASE to 4GB, not BASE to BASE+SIZE. - return (0 - CONFIG_ARMV7_SECURE_BASE); + return (0 - CONFIG_ARMV7_SECURE_BASE) & ~(SZ_2M - 1); #else return 0; #endif -- 2.18.0

3 5

[U-Boot] [PATCH 00/20] Add support for 1wire protocol and 1wire eeproms
by Eugen Hristev 02 Aug '18

02 Aug '18

This is a patch series originally written by Maxime Ripard, https://lists.denx.de/pipermail/u-boot/2016-November/272138.html titled: [U-Boot] [PATCH RESEND 0/9] sunxi: chip: Enable the DIP auto-detection and reworked to include support for the EEPROMs on the PDAs connected to the sama xplained boards. The patch series adds first a driver for onewire uclass, and onewire over gpio bitbanging driver. Then it adds a uclass for onewire EEPROMS, and specific driver for Maxim EEPROMs. I have added some sandbox support, configuration and device tree for it and for boards sama5d2_xplained and sama5d3_xplained. Also added common code for PDA detection, as the memory on the PDAs is connected to the SoC on the onewire bus. Thanks to everyone for the review and feedback. Below is a short summary of the commits: The series adds a w1-uclass driver for the onewire interface u-class. This is done in patch: [PATCH 01/20] w1: Add 1-Wire uclass Also, we add a driver for the w1-uclass specific to the onewire over bitbanged gpio, this is done in patch: [PATCH 02/20] w1: Add 1-Wire gpio driver Add the bindings documentation in: [PATCH 03/20] dt-bindings: W1: w1-gpio: added bindings for w1-gpio A uclass driver is added for one wire eeproms, in patch : [PATCH 04/20] W1-EEPROM: Add an W1-EEPROM uclass for 1 wire EEPROMs Specific driver for the DS24 Maxim EEPROMs is added in the patch: [PATCH 05/20] W1-EEPROM: add support for Maxim DS24 eeprom families A sandbox driver for a onewire EEPROM is added in patch: [PATCH 06/20] W1-EEPROM: add sandbox driver A command is added for the onewire protocol in patch: [PATCH 07/20] w1: add command for onewire protocol Pinctrl driver for sandbox was updated to add a new group and function for w1: [PATCH 08/20] pinctrl: sandbox: add gpio onewire w1 group Add a node in sandbox DT to have a test node for sandbox. [PATCH 09/20] sandbox: DTS: w1: add node for one wire interface on GPIO The defconfig for sandbox is updated to include the drivers: [PATCH 10/20] configs: sandbox: add onewire w1 and sandbox eeprom Modify the w1 class driver to add a sandbox device if sandbox is configured: [PATCH 11/20] w1: enumerate sandbox driver if configured Configuration for sama5d2 xplained is updated in patch: [PATCH 12/20] configs: sama5d2_xplained: add onewire and eeprom Configuration for sama5d3 xplained is updated in patch: [PATCH 13/20] configs: sama5d3_xplained: add onewire and eeprom Pda detection is added in the common part for atmel boards: [PATCH 14/20] board: atmel: add support for pda detection Specifically add it for Sama5d2 xplained board in patch: [PATCH 15/20] board: sama5d2_xplained: add pda detect call at init time Specifically add it for Sama5d3 xplained board in patch: [PATCH 16/20] board: sama5d3_xplained: add pda detect call at init time Add support for overlays for sama5d2 xplained config in patch: [PATCH 17/20] configs: sama5d2_xplained: add fdt overlay support Add support for overlays for sama5d3 xplained config in patch: [PATCH 18/20] configs: sama5d3_xplained: add fdt overlay support The DT for the SAMA5D2 Soc and xplained is updated to include a onewire node. This is done in patch: [PATCH 19/20] ARM: dts: at91: sama5d2_xplained: add onewire connector The DT for the SAMA5D3 Soc and xplained is updated to include a onewire node. This is done in patch: [PATCH 20/20] ARM: dts: at91: sama5d3_xplained: add onewire connector Eugen Hristev (16): dt-bindings: W1: w1-gpio: added bindings for w1-gpio W1-EEPROM: add sandbox driver w1: add command for onewire protocol pinctrl: sandbox: add gpio onewire w1 group sandbox: DTS: w1: add node for one wire interface on GPIO configs: sandbox: add onewire w1 and sandbox eeprom w1: enumerate sandbox driver if configured configs: sama5d2_xplained: add onewire and eeprom drivers configs: sama5d3_xplained: add onewire and eeprom drivers board: atmel: add support for pda detection board: sama5d2_xplained: add pda detect call at init time board: sama5d3_xplained: add pda detect call at init time configs: sama5d2_xplained: add fdt overlay support configs: sama5d3_xplained: add fdt overlay support ARM: dts: at91: sama5d2_xplained: add onewire connector for LCD eeprom ARM: dts: at91: sama5d3_xplained: add onewire connector for LCD eeprom Maxime Ripard (4): w1: Add 1-Wire uclass w1: Add 1-Wire gpio driver W1-EEPROM: Add an W1-EEPROM uclass for 1 wire EEPROMs W1-EEPROM: add support for Maxim DS24 eeprom families arch/arm/dts/at91-sama5d2_xplained.dts | 12 ++ arch/arm/dts/at91-sama5d3_xplained.dts | 12 ++ arch/arm/dts/sama5d2.dtsi | 6 + arch/arm/dts/sama5d3.dtsi | 6 + arch/arm/mach-at91/Kconfig | 1 + arch/sandbox/dts/sandbox.dts | 15 ++ board/atmel/common/board.c | 55 +++++ board/atmel/sama5d2_xplained/sama5d2_xplained.c | 3 + board/atmel/sama5d3_xplained/sama5d3_xplained.c | 10 + cmd/Kconfig | 7 + cmd/Makefile | 1 + cmd/w1.c | 121 +++++++++++ configs/sama5d2_xplained_mmc_defconfig | 5 + configs/sama5d2_xplained_spiflash_defconfig | 5 + configs/sama5d3_xplained_mmc_defconfig | 5 + configs/sama5d3_xplained_nandflash_defconfig | 5 + configs/sandbox_defconfig | 4 + doc/device-tree-bindings/w1/w1-gpio.txt | 26 +++ drivers/Kconfig | 4 + drivers/Makefile | 2 + drivers/pinctrl/pinctrl-sandbox.c | 3 + drivers/w1-eeprom/Kconfig | 29 +++ drivers/w1-eeprom/Makefile | 5 + drivers/w1-eeprom/ds24xxx.c | 46 ++++ drivers/w1-eeprom/eep_sandbox.c | 57 +++++ drivers/w1-eeprom/w1-eeprom-uclass.c | 56 +++++ drivers/w1/Kconfig | 25 +++ drivers/w1/Makefile | 3 + drivers/w1/w1-gpio.c | 158 ++++++++++++++ drivers/w1/w1-uclass.c | 273 ++++++++++++++++++++++++ include/dm/uclass-id.h | 2 + include/w1-eeprom.h | 28 +++ include/w1.h | 49 +++++ 33 files changed, 1039 insertions(+) create mode 100644 cmd/w1.c create mode 040000 doc/device-tree-bindings/w1 create mode 100644 doc/device-tree-bindings/w1/w1-gpio.txt create mode 040000 drivers/w1-eeprom create mode 100644 drivers/w1-eeprom/Kconfig create mode 100644 drivers/w1-eeprom/Makefile create mode 100644 drivers/w1-eeprom/ds24xxx.c create mode 100644 drivers/w1-eeprom/eep_sandbox.c create mode 100644 drivers/w1-eeprom/w1-eeprom-uclass.c create mode 040000 drivers/w1 create mode 100644 drivers/w1/Kconfig create mode 100644 drivers/w1/Makefile create mode 100644 drivers/w1/w1-gpio.c create mode 100644 drivers/w1/w1-uclass.c create mode 100644 include/w1-eeprom.h create mode 100644 include/w1.h -- 2.7.4

5 29