August 2018 - U-Boot

[U-Boot] [PATCH] sf: Add SPI_FLASH_4BYTE_MODE_ONLY option to support 4-byte mode
by Stefan Roese 06 Aug '18

06 Aug '18

Some SPI NOR chips only support 4-byte mode addressing. Here the default 3-byte mode does not work and leads to incorrect accesses. Setting this option enables the use of such SPI NOR chips, that only support this 4-byte mode. This was noticed on the LinkIt Smart 7688 modul, which is equipped with an Macronix MX25L25635F device. But this device does *NOT* support switching to 3-byte mode via the EX4B command. Signed-off-by: Stefan Roese <sr(a)denx.de> Cc: Jagan Teki <jagan(a)openedev.com> --- drivers/mtd/spi/Kconfig | 9 +++++++++ drivers/mtd/spi/sf_internal.h | 5 +++++ drivers/mtd/spi/spi_flash.c | 7 +++++++ 3 files changed, 21 insertions(+) diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig index 4484cf8195..5738cd66e8 100644 --- a/drivers/mtd/spi/Kconfig +++ b/drivers/mtd/spi/Kconfig @@ -49,6 +49,15 @@ config SF_DUAL_FLASH Enable this option to support two flash memories connected to a single controller. Currently Xilinx Zynq qspi supports this. +config SPI_FLASH_4BYTE_MODE_ONLY + bool "SPI 4-byte mode only supported" + depends on SPI_FLASH + help + Some SPI NOR chips only support 4-byte mode addressing. Here + the default 3-byte mode does not work and leads to incorrect + accesses. Setting this option enables the use of such SPI + NOR chips, that only support this 4-byte mode. + if SPI_FLASH config SPI_FLASH_ATMEL diff --git a/drivers/mtd/spi/sf_internal.h b/drivers/mtd/spi/sf_internal.h index 4f63cacc64..78be6e442f 100644 --- a/drivers/mtd/spi/sf_internal.h +++ b/drivers/mtd/spi/sf_internal.h @@ -26,7 +26,12 @@ enum spi_nor_option_flags { }; #define SPI_FLASH_3B_ADDR_LEN 3 +#define SPI_FLASH_4B_ADDR_LEN 4 +#ifdef CONFIG_SPI_FLASH_4BYTE_MODE_ONLY +#define SPI_FLASH_CMD_LEN (1 + SPI_FLASH_4B_ADDR_LEN) +#else #define SPI_FLASH_CMD_LEN (1 + SPI_FLASH_3B_ADDR_LEN) +#endif #define SPI_FLASH_16MB_BOUN 0x1000000 /* CFI Manufacture ID's */ diff --git a/drivers/mtd/spi/spi_flash.c b/drivers/mtd/spi/spi_flash.c index c159124259..3b26d8ca88 100644 --- a/drivers/mtd/spi/spi_flash.c +++ b/drivers/mtd/spi/spi_flash.c @@ -23,9 +23,16 @@ static void spi_flash_addr(u32 addr, u8 *cmd) { /* cmd[0] is actual command */ +#ifdef CONFIG_SPI_FLASH_4BYTE_MODE_ONLY + cmd[1] = addr >> 24; + cmd[2] = addr >> 16; + cmd[3] = addr >> 8; + cmd[4] = addr >> 0; +#else cmd[1] = addr >> 16; cmd[2] = addr >> 8; cmd[3] = addr >> 0; +#endif } static int read_sr(struct spi_flash *flash, u8 *rs) -- 2.18.0

2 7

[U-Boot] [PATCH] EMDK: Enable bootelf
by Alexey Brodkin 06 Aug '18

06 Aug '18

Signed-off-by: Alexey Brodkin <abrodkin(a)synopsys.com> --- configs/emdk_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/emdk_defconfig b/configs/emdk_defconfig index e3bccd234fcd..f283a9c9b3c6 100644 --- a/configs/emdk_defconfig +++ b/configs/emdk_defconfig @@ -10,7 +10,6 @@ CONFIG_VERSION_VARIABLE=y CONFIG_HUSH_PARSER=y CONFIG_SYS_PROMPT="emdk# " # CONFIG_CMD_BOOTD is not set -# CONFIG_CMD_ELF is not set # CONFIG_CMD_XIMG is not set CONFIG_CMD_MMC=y CONFIG_CMD_CACHE=y -- 2.17.1

1 0

[U-Boot] [PATCH u-boot 0/2] Add the VPU Power Domain support
by Neil Armstrong 06 Aug '18

06 Aug '18

The Amlogic Meson SoCs embeds a specific Power Domain dedicated to the Video Processing Unit. The first patch implements support for this power domain in preparation of the future support for the Video display support in U-Boot. The second patch adds changes in the clock driver to handle the setup of the VPU and VAPB clocks configured from DT using assigned-clocks entries. Neil Armstrong (2): power: domain: Add the VPU Power Domain driver clk: clk_meson: Add mux and div support for reparent and rate setting drivers/clk/clk_meson.c | 533 ++++++++++++++++++++++++++++++- drivers/power/domain/Kconfig | 7 + drivers/power/domain/Makefile | 1 + drivers/power/domain/meson-gx-pwrc-vpu.c | 198 ++++++++++++ 4 files changed, 734 insertions(+), 5 deletions(-) create mode 100644 drivers/power/domain/meson-gx-pwrc-vpu.c -- 2.7.4

3 7

[U-Boot] [PATCH 1/2] i2c-mux: pca954x: support pca9646 i2c switch
by Peng Fan 06 Aug '18

06 Aug '18

Add the PCA9646 support, which is 2-wire bus switch and buffered 4-channel. Signed-off-by: Peng Fan <peng.fan(a)nxp.com> --- drivers/i2c/muxes/pca954x.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/muxes/pca954x.c b/drivers/i2c/muxes/pca954x.c index 4debc03957..ab8b4000af 100644 --- a/drivers/i2c/muxes/pca954x.c +++ b/drivers/i2c/muxes/pca954x.c @@ -17,7 +17,8 @@ DECLARE_GLOBAL_DATA_PTR; enum pca_type { PCA9544, PCA9547, - PCA9548 + PCA9548, + PCA9646 }; struct chip_desc { @@ -51,6 +52,11 @@ static const struct chip_desc chips[] = { .muxtype = pca954x_isswi, .width = 8, }, + [PCA9646] = { + .enable = 0x0, + .muxtype = pca954x_isswi, + .width = 4, + }, }; static int pca954x_deselect(struct udevice *mux, struct udevice *bus, @@ -86,6 +92,7 @@ static const struct udevice_id pca954x_ids[] = { { .compatible = "nxp,pca9544", .data = PCA9544 }, { .compatible = "nxp,pca9547", .data = PCA9547 }, { .compatible = "nxp,pca9548", .data = PCA9548 }, + { .compatible = "nxp,pca9646", .data = PCA9646 }, { } }; -- 2.14.1

2 6

[U-Boot] [PATCH v3 1/4] power-domain: add dummy functions when CONFIG_POWER_DOMAIN not defined
by Anatolij Gustschin 06 Aug '18

06 Aug '18

From: Peng Fan <peng.fan(a)nxp.com> Add dummy functions when CONFIG_POWER_DOMAIN not defined. Signed-off-by: Peng Fan <peng.fan(a)nxp.com> Reviewed-by: Simon Glass <sjg(a)chromium.org> Signed-off-by: Anatolij Gustschin <agust(a)denx.de> --- V3: - add 'static inline' to fix build breakage - use -ENOSYS as we do elsewhere to indicate not implemented functionality V2: Use CONFIG_IS_ENABLED include/power-domain.h | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/include/power-domain.h b/include/power-domain.h index aba8c0f65c..a558fbbdb2 100644 --- a/include/power-domain.h +++ b/include/power-domain.h @@ -87,7 +87,15 @@ struct power_domain { * @power_domain A pointer to a power domain struct to initialize. * @return 0 if OK, or a negative error code. */ +#if CONFIG_IS_ENABLED(POWER_DOMAIN) int power_domain_get(struct udevice *dev, struct power_domain *power_domain); +#else +static inline +int power_domain_get(struct udevice *dev, struct power_domain *power_domain) +{ + return -ENOSYS; +} +#endif /** * power_domain_free - Free a previously requested power domain. @@ -96,7 +104,14 @@ int power_domain_get(struct udevice *dev, struct power_domain *power_domain); * requested by power_domain_get(). * @return 0 if OK, or a negative error code. */ +#if CONFIG_IS_ENABLED(POWER_DOMAIN) int power_domain_free(struct power_domain *power_domain); +#else +static inline int power_domain_free(struct power_domain *power_domain) +{ + return -ENOSYS; +} +#endif /** * power_domain_on - Enable power to a power domain. @@ -105,7 +120,14 @@ int power_domain_free(struct power_domain *power_domain); * requested by power_domain_get(). * @return 0 if OK, or a negative error code. */ +#if CONFIG_IS_ENABLED(POWER_DOMAIN) int power_domain_on(struct power_domain *power_domain); +#else +static inline int power_domain_on(struct power_domain *power_domain) +{ + return -ENOSYS; +} +#endif /** * power_domain_off - Disable power ot a power domain. @@ -114,6 +136,13 @@ int power_domain_on(struct power_domain *power_domain); * requested by power_domain_get(). * @return 0 if OK, or a negative error code. */ +#if CONFIG_IS_ENABLED(POWER_DOMAIN) int power_domain_off(struct power_domain *power_domain); +#else +static inline int power_domain_off(struct power_domain *power_domain) +{ + return -ENOSYS; +} +#endif #endif -- 2.14.1

1 1

[U-Boot] Unable to boot evb-ast2500
by Joel Stanley 06 Aug '18

06 Aug '18

Hello, I am attempting to boot evb-ast2500 in Qemu before flashing it to a system. It doesn't get past the DRAM step, due to getting stuck endlessly looping in some libfdt code. With some debugging turned on, I get this: OF: translating address: 0040781e OF: parent translation for: 00000000 OF: one level translation: 0040781e OF: parent translation for: 00000000 OF: one level translation: 0040781e OF: translating address: 00206e1e U-Boot 2018.09-rc1-00096-gbb694d4e898b-dirty (Aug 06 2018 - 12:27:22 +0930) Model: Aspeed BMC DRAM: OF: translating address: 00006e1e OF: translating address: 00026e1e OF: translating address: 0050781e OF: parent translation for: 00000000 OF: one level translation: 0050781e OF: parent translation for: 00000000 OF: one level translation: 0050781e Watchdog timer expired. And then the watchdog causes the system to reboot. The build is master as of gbb694d4e898b, with the addition of some #define DEBUG. I don't think this is a qemu issue. If it is, I can work on fixing qemu, but I need some help on understanding what u-boot is doing. There's a big pause before the U-Boot banner, and again after showing 'DRAM: 'before getting any of the OF messages. If I get gdb to show me a backtrace at this point: #0 0x0001e858 in __fswab32 (x=<optimised out>) at include/linux/byteorder/swab.h:114 #1 fdt_offset_ptr (fdt=fdt@entry=0x39370, offset=offset@entry=6444, len=len@entry=4) at lib/libfdt/../../scripts/dtc/libfdt/fdt.c:86 #2 0x0001e9b4 in fdt_next_tag (fdt=fdt@entry=0x39370, startoffset=startoffset@entry=6440, nextoffset=0x1e726d44, nextoffset@entry=0x1e726d3c) at lib/libfdt/../../scripts/dtc/libfdt/fdt.c:120 #3 0x0001eae4 in fdt_next_node (fdt=fdt@entry=0x39370, offset=6440, depth=0x1e726d5c, depth@entry=0x1e726d54) at lib/libfdt/../../scripts/dtc/libfdt/fdt.c:176 #4 0x000205cc in fdt_supernode_atdepth_offset (fdt=0x39370, nodeoffset=14748, supernodedepth=0, nodedepth=0x0 <_start>) at lib/libfdt/fdt_ro.c:443 #5 0x00011608 in ofnode_get_parent (node=..., node@entry=...) at include/dm/ofnode.h:94 #6 0x000113dc in regmap_init_mem (node=..., mapp=0x0 <_start>, mapp@entry=0x1e726dbc) at drivers/core/regmap.c:63 #7 0x000014e0 in ast2500_sdrammc_ofdata_to_platdata (dev=0x1e7273c4) at include/dm/read.h:38 #8 0x0000fc88 in device_probe (dev=dev@entry=0x1e7273c4) at drivers/core/device.c:399 #9 0x000108c0 in uclass_get_device_tail (dev=0x1e7273c4, ret=<optimised out>, devp=0x1e726e0c) at drivers/core/uclass.c:397 #10 0x00010900 in uclass_get_device (id=id@entry=UCLASS_RAM, index=index@entry=0, devp=0x1e726e0c, devp@entry=0x1e726e04) at drivers/core/uclass.c:413 #11 0x00001ab0 in dram_init () at arch/arm/mach-aspeed/ast2500-board.c:69 #12 0x0001b834 in initcall_run_list (init_sequence=init_sequence@entry=0x29344 <init_sequence_f>) at lib/initcall.c:30 #13 0x0000854c in board_init_f (boot_flags=<optimised out>) at common/board_f.c:900 #14 0x00000664 in _main () at arch/arm/lib/crt0.S:86 Cheers, Joel -- To reproduce in qemu, build qemu master for ARM: git://git.qemu-project.org/qemu && cd qemu ./configure --target-list=arm-softmmu make build a 32MB image from u-boot.bin: dd if=/dev/zero of=test.img bs=1M count=32 dd if=u-boot.bin of=test.img conv=notrunc boot it: arm-softmmu/qemu-system-arm -M ast2500-evb -m 512 -nographic -drive file=test.img,format=raw,if=mtd -serial stdio -monitor pty

2 3

[U-Boot] [PATCH V2 1/4] power-domain: add dummy functions when CONFIG_POWER_DOMAIN not defined
by Peng Fan 06 Aug '18

06 Aug '18

Add dummy functions when CONFIG_POWER_DOMAIN not defined. Signed-off-by: Peng Fan <peng.fan(a)nxp.com> --- V2: Use CONFIG_IS_ENABLED include/power-domain.h | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/include/power-domain.h b/include/power-domain.h index aba8c0f65c..2029b17c6f 100644 --- a/include/power-domain.h +++ b/include/power-domain.h @@ -87,7 +87,14 @@ struct power_domain { * @power_domain A pointer to a power domain struct to initialize. * @return 0 if OK, or a negative error code. */ +#if CONFIG_IS_ENABLED(POWER_DOMAIN) int power_domain_get(struct udevice *dev, struct power_domain *power_domain); +#else +int power_domain_get(struct udevice *dev, struct power_domain *power_domain) +{ + return -EINVAL; +} +#endif /** * power_domain_free - Free a previously requested power domain. @@ -96,7 +103,14 @@ int power_domain_get(struct udevice *dev, struct power_domain *power_domain); * requested by power_domain_get(). * @return 0 if OK, or a negative error code. */ +#if CONFIG_IS_ENABLED(POWER_DOMAIN) int power_domain_free(struct power_domain *power_domain); +#else +int power_domain_free(struct power_domain *power_domain) +{ + return -EINVAL; +} +#endif /** * power_domain_on - Enable power to a power domain. @@ -105,7 +119,14 @@ int power_domain_free(struct power_domain *power_domain); * requested by power_domain_get(). * @return 0 if OK, or a negative error code. */ +#if CONFIG_IS_ENABLED(POWER_DOMAIN) int power_domain_on(struct power_domain *power_domain); +#else +int power_domain_on(struct power_domain *power_domain) +{ + return -EINVAL; +} +#endif /** * power_domain_off - Disable power ot a power domain. @@ -114,6 +135,13 @@ int power_domain_on(struct power_domain *power_domain); * requested by power_domain_get(). * @return 0 if OK, or a negative error code. */ +#if CONFIG_IS_ENABLED(POWER_DOMAIN) int power_domain_off(struct power_domain *power_domain); +#else +int power_domain_off(struct power_domain *power_domain) +{ + return -EINVAL; +} +#endif #endif -- 2.14.1

3 11

[U-Boot] [PATCH v2 0/6] Add support for STM32 ADC
by Fabrice Gasnier 06 Aug '18

06 Aug '18

This series adds support for STM32 Analog to Digital Converter. STM32 ADC support is originally based on Linux kernel v4.18-rcs: - First two patches brings some changes in clk and adc uclass - Next two patches add STM32 ADC dt-bindings and driver for STM32MP1 and STM32H7 - Last patches add config and DT on stm32mp15 Changes in v2: - add test case for 'clk_valid()', e.g. in test/dm/clk.c and sandbox. - Update TRUE/FALSE comments to lower case: true/false - move device_get_supply_regulator() call to pre_probe() routine Fabrice Gasnier (6): clk: add clk_valid() dm: adc: uclass: get reference regulator once dt-bindings: Document STM32 ADC DT bindings adc: Add driver for STM32 ADC configs: stm32mp15: enable ADC ARM: dts: stm32mp157: Add ADC DT node arch/arm/dts/stm32mp157.dtsi | 32 ++++ arch/sandbox/include/asm/clk.h | 8 + configs/stm32mp15_basic_defconfig | 3 +- doc/device-tree-bindings/adc/st,stm32-adc.txt | 141 ++++++++++++++ drivers/adc/Kconfig | 16 ++ drivers/adc/Makefile | 1 + drivers/adc/adc-uclass.c | 35 ++-- drivers/adc/stm32-adc-core.c | 209 +++++++++++++++++++++ drivers/adc/stm32-adc-core.h | 51 +++++ drivers/adc/stm32-adc.c | 257 ++++++++++++++++++++++++++ drivers/clk/clk_sandbox_test.c | 13 ++ include/clk.h | 10 + test/dm/clk.c | 1 + 13 files changed, 758 insertions(+), 19 deletions(-) create mode 100644 doc/device-tree-bindings/adc/st,stm32-adc.txt create mode 100644 drivers/adc/stm32-adc-core.c create mode 100644 drivers/adc/stm32-adc-core.h create mode 100644 drivers/adc/stm32-adc.c -- 1.9.1

4 16

[U-Boot] [PATCH v4 0/9] Add support of CONFIG_BLK for STM32Fx platforms
by Patrice Chotard 06 Aug '18

06 Aug '18

This series : - adds support of CONFIG_BLK flag to STM32Fx platforms - enables CONFIG_BLK flag for STM32Fx based boards - adds missing clk_free() call in error path Changes in v4: - update board DTS files to remove cd_inverted property and update cd-gpios active level Changes in v3: - remove usage of "cd_inverted" DT property in dm_mmc_getcd() Changes in v2: - replace devfdt_get_addr() by dev_read_addr() - re-introduce arm_pl180_mmc_ofdata_to_platdata() Patrice Chotard (9): configs: stm32f429-evaluation: Enable CONFIG_BLK configs: stm32f746-disco: Enable CONFIG_BLK configs: stm32f469-disco: Enable CONFIG_BLK mmc: arm_pl180_mmci: Update to support CONFIG_BLK mmc: arm_pl180_mmci: Add missing clk_free mmc: arm_pl180_mmci: Remove cd_inverted host's struct field ARM: dts: stm32: remove cd-inverted for stm32429i-eval ARM: dts: stm32: remove cd-inverted for stm32f769-disco ARM: dts: stm32: remove cd-inverted for stm32f746-disco arch/arm/dts/stm32429i-eval.dts | 3 +- arch/arm/dts/stm32f746-disco.dts | 3 +- arch/arm/dts/stm32f769-disco.dts | 3 +- configs/stm32f429-evaluation_defconfig | 1 - configs/stm32f469-discovery_defconfig | 1 - configs/stm32f746-disco_defconfig | 1 - drivers/mmc/arm_pl180_mmci.c | 73 +++++++++++++++++++--------------- drivers/mmc/arm_pl180_mmci.h | 1 - 8 files changed, 45 insertions(+), 41 deletions(-) -- 1.9.1

3 18

[U-Boot] [PATCH v1 1/2] board: toradex: common: fail gracefully on missing NAND chip
by Stefan Agner 06 Aug '18

06 Aug '18

From: Stefan Agner <stefan.agner(a)toradex.com> If the NAND chip is missing get_nand_dev_by_index() returns NULL. Fail gracefully in this case. Signed-off-by: Stefan Agner <stefan.agner(a)toradex.com> --- board/toradex/common/tdx-cfg-block.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/board/toradex/common/tdx-cfg-block.c b/board/toradex/common/tdx-cfg-block.c index 57edb6c5c9..d4f5b1803a 100644 --- a/board/toradex/common/tdx-cfg-block.c +++ b/board/toradex/common/tdx-cfg-block.c @@ -156,10 +156,13 @@ out: static int read_tdx_cfg_block_from_nand(unsigned char *config_block) { size_t size = TDX_CFG_BLOCK_MAX_SIZE; + struct mtd_info *mtd = get_nand_dev_by_index(0); + + if (!mtd) + return -ENODEV; /* Read production parameter config block from NAND page */ - return nand_read_skip_bad(get_nand_dev_by_index(0), - CONFIG_TDX_CFG_BLOCK_OFFSET, + return nand_read_skip_bad(mtd, CONFIG_TDX_CFG_BLOCK_OFFSET, &size, NULL, TDX_CFG_BLOCK_MAX_SIZE, config_block); } -- 2.18.0

1 1