August 2018 - U-Boot

[U-Boot] [PATCH 0/3] efi_loader: Fix -fdata-section fallout with bss
by Alexander Graf 21 Aug '18

21 Aug '18

While trying to fix efi_loader problems that could only be resolved by enabling individual function and data sections (commit 7e21fbca26d18 "efi_loader: Rename sections to allow for implicit data") some cases where .bss was included in the linker scripts slipped through. This lead to random breakage when .bss contents were accessed, because the respective regions were not initialized properly. With this patch set, all those should be resolved now. Alex Alexander Graf (3): x86: Include bss subsections in linker script x86: Enable -fdata-sections always riscv: Include bss subsections in linker script arch/riscv/cpu/ax25/u-boot.lds | 2 +- arch/x86/config.mk | 4 +--- arch/x86/cpu/u-boot-64.lds | 2 +- arch/x86/cpu/u-boot.lds | 2 +- arch/x86/lib/elf_ia32_efi.lds | 2 +- arch/x86/lib/elf_x86_64_efi.lds | 2 +- 6 files changed, 6 insertions(+), 8 deletions(-) -- 2.12.3

2 5

[U-Boot] [PATCH v2 0/8] test/py: Fixes for python 3.x
by Paul Burton 21 Aug '18

21 Aug '18

This series allows test/py to run on python 3.x in addition to the already supported python 2.x. With it applied I currently see only one failure (test_ut[ut_dm_usb_flash]) which doesn't appear to be python related when running with: $ ./test/py/test.py --bd sandbox --build Thanks, Paul Paul Burton (8): test/py: Make print statements python 3.x safe test/py: Use range() rather than xrange() test/py: Import 'configparser' lower case to be python 3.x safe test/py: Import StringIO from io module for python 3.x test/py: Encode/decode strings for stdio test/py: fit: Open files as binary files test/py: hush_if_test: Use open() in place of file() test/py: vboot: Remove stderr redirect from openssl command test/py/conftest.py | 18 +++++++++++++----- test/py/multiplexed_log.py | 4 ++-- test/py/test.py | 6 ++++-- test/py/tests/test_fit.py | 14 ++++++++------ test/py/tests/test_hush_if_test.py | 2 +- test/py/tests/test_ut.py | 2 +- test/py/tests/test_vboot.py | 4 ++-- test/py/u_boot_console_sandbox.py | 4 ++-- test/py/u_boot_spawn.py | 12 ++++++------ test/py/u_boot_utils.py | 4 ++-- 10 files changed, 41 insertions(+), 29 deletions(-) -- 2.14.1

5 23

[U-Boot] Pull request: u-boot-sunxi/master
by Jagan Teki 21 Aug '18

21 Aug '18

Hi Tom, Please pull this PR. thanks, Jagan. The following changes since commit f05ebbf47a9dc863ff4bb084649ecb34d728b5f2: bcm968380gerg: Add MAINTAINERS file (2018-08-09 11:48:39 -0400) are available in the Git repository at: git://git.denx.de/u-boot-sunxi.git master for you to fetch changes up to d8024074e43c2a99ecf93d919544d82f69025521: board: sunxi: Remove unused local variables (2018-08-20 18:10:43 +0530) ---------------------------------------------------------------- Andre Przywara (1): sunxi: A64: fix default DRAM_ODT_EN symbol Icenowy Zheng (1): sunxi: fix sid base address macro name for H6 Jagan Teki (5): clk: Kconfig: Ascending order to sub directiory kconfigs ARM: dts: sun8i: Update A83T dts(i) files from Linux-v4.18-rc3 ARM: dts: sun8i: Update R40/V40 dts(i) files from Linux-v4.18-rc3 configs: sun7i: Fix to use emmc dts for OLinuXino_MICRO-eMMC board: sunxi: Remove unused local variables arch/arm/dts/axp81x.dtsi | 169 +++++ arch/arm/dts/sun8i-a83t-allwinner-h8homlet-v2.dts | 195 ++++- arch/arm/dts/sun8i-a83t-bananapi-m3.dts | 298 +++++++- arch/arm/dts/sun8i-a83t-cubietruck-plus.dts | 322 +++++++- arch/arm/dts/sun8i-a83t-tbs-a711.dts | 355 ++++++++- arch/arm/dts/sun8i-a83t.dtsi | 885 ++++++++++++++++++++-- arch/arm/dts/sun8i-r40-bananapi-m2-ultra.dts | 168 +++- arch/arm/dts/sun8i-r40.dtsi | 303 +++++++- arch/arm/dts/sun8i-v40-bananapi-m2-berry.dts | 50 ++ arch/arm/include/asm/arch-sunxi/cpu_sun50i_h6.h | 2 +- arch/arm/mach-sunxi/Kconfig | 1 - board/sunxi/board.c | 2 - configs/A20-OLinuXino_MICRO-eMMC_defconfig | 2 +- configs/Bananapi_M2_Ultra_defconfig | 1 - configs/amarula_a64_relic_defconfig | 1 - configs/bananapi_m2_berry_defconfig | 1 - configs/sopine_baseboard_defconfig | 1 - drivers/clk/Kconfig | 8 +- include/dt-bindings/clock/sun8i-a83t-ccu.h | 140 ++++ include/dt-bindings/reset/sun8i-a83t-ccu.h | 98 +++ 20 files changed, 2874 insertions(+), 128 deletions(-) create mode 100644 arch/arm/dts/axp81x.dtsi create mode 100644 include/dt-bindings/clock/sun8i-a83t-ccu.h create mode 100644 include/dt-bindings/reset/sun8i-a83t-ccu.h

2 1

[U-Boot] Please pull u-boot-x86
by Bin Meng 21 Aug '18

21 Aug '18

Hi Tom, The following changes since commit 9f8cf76be256a83643ee05de6cffaeb452ed0931: Convert CONFIG_SYS_I2C_DAVINCI to Kconfig (2018-08-17 15:43:38 -0400) are available in the git repository at: git://git.denx.de/u-boot-x86.git for you to fetch changes up to 7bdf39cfafd29fc1192dd1aa997b5937f92a3c74: x86: efi: payload: Add default TSC frequency in the device tree (2018-08-20 13:52:49 +0800) ---------------------------------------------------------------- Andy Shevchenko (1): Makefile: Don't generate position independent code Bin Meng (6): x86: coreboot: Add generic coreboot payload support x86: Remove support for Advantech SOM-6896 x86: dts: Remove coreboot_fb.dtsi x86: tsc: Try hardware calibration first x86: coreboot: Add default TSC frequency in the device tree x86: efi: payload: Add default TSC frequency in the device tree Makefile | 4 ++++ arch/x86/cpu/coreboot/Kconfig | 20 ++++++++++---------- arch/x86/cpu/coreboot/coreboot.c | 9 ++++----- arch/x86/dts/Makefile | 2 +- arch/x86/dts/bayleybay.dts | 1 - arch/x86/dts/broadwell_som-6896.dts | 52 ---------------------------------------------------- arch/x86/dts/chromebook_link.dts | 1 - arch/x86/dts/chromebook_samus.dts | 1 - arch/x86/dts/chromebox_panther.dts | 1 - arch/x86/dts/coreboot.dts | 45 +++++++++++++++++++++++++++++++++++++++++++++ arch/x86/dts/coreboot_fb.dtsi | 5 ----- arch/x86/dts/efi-x86_payload.dts | 4 ++++ arch/x86/dts/minnowmax.dts | 1 - board/coreboot/coreboot/Kconfig | 28 ++++------------------------ board/coreboot/coreboot/Makefile | 2 +- board/coreboot/coreboot/coreboot.c | 17 +++++++++++++++++ board/coreboot/coreboot/{coreboot_start.S => start.S} | 0 configs/coreboot_defconfig | 18 ++++++------------ doc/README.x86 | 22 ---------------------- drivers/timer/tsc_timer.c | 27 ++++++++++++++++----------- include/configs/coreboot.h | 32 ++++++++++++++++++++++++++++++++ include/configs/som-6896.h | 26 -------------------------- 22 files changed, 144 insertions(+), 174 deletions(-) delete mode 100644 arch/x86/dts/broadwell_som-6896.dts create mode 100644 arch/x86/dts/coreboot.dts delete mode 100644 arch/x86/dts/coreboot_fb.dtsi create mode 100644 board/coreboot/coreboot/coreboot.c rename board/coreboot/coreboot/{coreboot_start.S => start.S} (100%) create mode 100644 include/configs/coreboot.h delete mode 100644 include/configs/som-6896.h Regards, Bin

2 1

[U-Boot] [PATCH v2 1/3] efi: Fix truncation of constant value
by Eugeniu Rosca 21 Aug '18

21 Aug '18

Starting with commit 867a6ac86dd8 ("efi: Add start-up library code"), sparse constantly complains about truncated constant value in efi.h: include/efi.h:176:35: warning: cast truncates bits from constant value (8000000000000000 becomes 0) This can get quite noisy, preventing real issues to be noticed: $ make defconfig *** Default configuration is based on 'sandbox_defconfig' $ make C=2 -j12 2>&1 | grep truncates | wc -l 441 After the patch is applied: $ make C=2 -j12 2>&1 | grep truncates | wc -l 0 $ sparse --version v0.5.2 Following the suggestion of Heinrich Schuchardt, instead of only fixing the root-cause, I replaced the whole enum of _SHIFT values by ULL defines. This matches both the UEFI 2.7 spec and the Linux kernel implementation. Some ELF size comparison before and after the patch (gcc 7.3.0): efi-x86_payload64_defconfig: text data bss dec hex filename 407174 29432 278676 715282 aea12 u-boot.old 407152 29464 278676 715292 aea1c u-boot.new -22 +32 0 +10 efi-x86_payload32_defconfig: text data bss dec hex filename 447075 30308 280076 757459 b8ed3 u-boot.old 447053 30340 280076 757469 b8edd u-boot.new -22 +32 0 +10 Fixes: 867a6ac86dd8 ("efi: Add start-up library code") Suggested-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> Signed-off-by: Eugeniu Rosca <erosca(a)de.adit-jv.com> --- v2: - Replace _SHIFT enum values by ULL defines to match UEFI 2.7 spec - Add ELF size comparison to patch description cmd/efi.c | 22 +++++++++++----------- include/efi.h | 24 ++++++++++-------------- lib/efi_loader/efi_memory.c | 7 +++---- 3 files changed, 24 insertions(+), 29 deletions(-) diff --git a/cmd/efi.c b/cmd/efi.c index 6c1eb88424be..92a565f71373 100644 --- a/cmd/efi.c +++ b/cmd/efi.c @@ -28,18 +28,18 @@ static const char *const type_name[] = { }; static struct attr_info { - int shift; + u64 val; const char *name; } mem_attr[] = { - { EFI_MEMORY_UC_SHIFT, "uncached" }, - { EFI_MEMORY_WC_SHIFT, "write-coalescing" }, - { EFI_MEMORY_WT_SHIFT, "write-through" }, - { EFI_MEMORY_WB_SHIFT, "write-back" }, - { EFI_MEMORY_UCE_SHIFT, "uncached & exported" }, - { EFI_MEMORY_WP_SHIFT, "write-protect" }, - { EFI_MEMORY_RP_SHIFT, "read-protect" }, - { EFI_MEMORY_XP_SHIFT, "execute-protect" }, - { EFI_MEMORY_RUNTIME_SHIFT, "needs runtime mapping" } + { EFI_MEMORY_UC, "uncached" }, + { EFI_MEMORY_WC, "write-coalescing" }, + { EFI_MEMORY_WT, "write-through" }, + { EFI_MEMORY_WB, "write-back" }, + { EFI_MEMORY_UCE, "uncached & exported" }, + { EFI_MEMORY_WP, "write-protect" }, + { EFI_MEMORY_RP, "read-protect" }, + { EFI_MEMORY_XP, "execute-protect" }, + { EFI_MEMORY_RUNTIME, "needs runtime mapping" } }; /* Maximum different attribute values we can track */ @@ -173,7 +173,7 @@ static void efi_print_mem_table(struct efi_entry_memmap *map, printf("%c%llx: ", attr & EFI_MEMORY_RUNTIME ? 'r' : ' ', attr & ~EFI_MEMORY_RUNTIME); for (j = 0, first = true; j < ARRAY_SIZE(mem_attr); j++) { - if (attr & (1ULL << mem_attr[j].shift)) { + if (attr & mem_attr[j].val) { if (first) first = false; else diff --git a/include/efi.h b/include/efi.h index 0fe15e65c06c..eb2a569fe010 100644 --- a/include/efi.h +++ b/include/efi.h @@ -162,20 +162,16 @@ enum efi_mem_type { }; /* Attribute values */ -enum { - EFI_MEMORY_UC_SHIFT = 0, /* uncached */ - EFI_MEMORY_WC_SHIFT = 1, /* write-coalescing */ - EFI_MEMORY_WT_SHIFT = 2, /* write-through */ - EFI_MEMORY_WB_SHIFT = 3, /* write-back */ - EFI_MEMORY_UCE_SHIFT = 4, /* uncached, exported */ - EFI_MEMORY_WP_SHIFT = 12, /* write-protect */ - EFI_MEMORY_RP_SHIFT = 13, /* read-protect */ - EFI_MEMORY_XP_SHIFT = 14, /* execute-protect */ - EFI_MEMORY_RUNTIME_SHIFT = 63, /* range requires runtime mapping */ - - EFI_MEMORY_RUNTIME = 1ULL << EFI_MEMORY_RUNTIME_SHIFT, - EFI_MEM_DESC_VERSION = 1, -}; +#define EFI_MEMORY_UC ((u64)0x0000000000000001ULL) /* uncached */ +#define EFI_MEMORY_WC ((u64)0x0000000000000002ULL) /* write-coalescing */ +#define EFI_MEMORY_WT ((u64)0x0000000000000004ULL) /* write-through */ +#define EFI_MEMORY_WB ((u64)0x0000000000000008ULL) /* write-back */ +#define EFI_MEMORY_UCE ((u64)0x0000000000000010ULL) /* uncached, exported */ +#define EFI_MEMORY_WP ((u64)0x0000000000001000ULL) /* write-protect */ +#define EFI_MEMORY_RP ((u64)0x0000000000002000ULL) /* read-protect */ +#define EFI_MEMORY_XP ((u64)0x0000000000004000ULL) /* execute-protect */ +#define EFI_MEMORY_RUNTIME ((u64)0x8000000000000000ULL) /* range requires runtime mapping */ +#define EFI_MEM_DESC_VERSION 1 #define EFI_PAGE_SHIFT 12 #define EFI_PAGE_SIZE (1UL << EFI_PAGE_SHIFT) diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c index ec66af98ea8f..233333bf6b18 100644 --- a/lib/efi_loader/efi_memory.c +++ b/lib/efi_loader/efi_memory.c @@ -171,14 +171,13 @@ uint64_t efi_add_memory_map(uint64_t start, uint64_t pages, int memory_type, switch (memory_type) { case EFI_RUNTIME_SERVICES_CODE: case EFI_RUNTIME_SERVICES_DATA: - newlist->desc.attribute = (1 << EFI_MEMORY_WB_SHIFT) | - (1ULL << EFI_MEMORY_RUNTIME_SHIFT); + newlist->desc.attribute = EFI_MEMORY_WB | EFI_MEMORY_RUNTIME; break; case EFI_MMAP_IO: - newlist->desc.attribute = 1ULL << EFI_MEMORY_RUNTIME_SHIFT; + newlist->desc.attribute = EFI_MEMORY_RUNTIME; break; default: - newlist->desc.attribute = 1 << EFI_MEMORY_WB_SHIFT; + newlist->desc.attribute = EFI_MEMORY_WB; break; } -- 2.18.0

5 15

[U-Boot] [PATCH v4 0/7] Fixes/Addition to use the USB Ethernet gadget with the DWC3 gadget controller
by Jean-Jacques Hiblot 20 Aug '18

20 Aug '18

This series implements 2 fixes to be able to use USB Ethernet gadget with the dwc3 driver. It also adds new commands to bind/unbind a device to/from a driver and update the 'dm tree' command to make it easier to use those new commands. The bind/unbind commands can be used to bind the DWC3 USB gadget to the usb_ether driver from the command line instead of relying on platform code. Changes in v4: - Fixed compiler warning: "cmd/bind.c:236:5: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]" Changes in v3: - update commit log - fixed problem with the function name - update commit log - new commit - new - factorize code based on comments from ML - remove the devices before unbinding them - use device_find_global_by_ofnode() to get a device by its node. Changes in v2: - Make the bind/unbind command generic, not specific to usb device. - Update the API to be able to bind/unbind based on DTS node path - Add a Kconfig option to select the bind/unbind commands Jean-Jacques Hiblot (7): usb: gadget: Add bcdDevice for the DWC3 USB Gadget Controller net: eth-uclass: Fix for DM USB ethernet support uclass: Add dev_get_uclass_index() to get the uclass/index of a device dm: print the index of the device when dumping the dm tree dm: convert device_get_global_by_of_offset() to device_get_global_by_ofnode() device: expose the functions used to remove and unbind children of a device cmd: Add bind/unbind commands to bind a device to a driver from the command line arch/arm/mach-rockchip/rk3188-board-spl.c | 2 +- arch/arm/mach-rockchip/rk3288-board-spl.c | 2 +- arch/sandbox/dts/test.dts | 11 ++ cmd/Kconfig | 9 ++ cmd/Makefile | 1 + cmd/bind.c | 255 ++++++++++++++++++++++++++++++ configs/sandbox_defconfig | 1 + drivers/core/device-remove.c | 30 ++-- drivers/core/device.c | 19 ++- drivers/core/dump.c | 16 +- drivers/core/uclass.c | 21 +++ drivers/usb/gadget/gadget_chips.h | 2 + include/dm/device-internal.h | 38 +++++ include/dm/device.h | 23 ++- include/dm/uclass-internal.h | 11 ++ net/eth-uclass.c | 3 +- test/py/tests/test_bind.py | 178 +++++++++++++++++++++ 17 files changed, 584 insertions(+), 38 deletions(-) create mode 100644 cmd/bind.c create mode 100644 test/py/tests/test_bind.py -- 2.7.4

4 14

[U-Boot] [PATCH 0/8] Import Undefined Behavior Sanitizer
by Eugeniu Rosca 20 Aug '18

20 Aug '18

While certain classes of bugs (e.g. locking related) are totally irrelevant for U-Boot, undefined behavior is something U-Boot may experience all over the place and this certainly can lead to hidden and difficult to debug issues. As of v4.18, Linux kernel contains roughly 119 UBSAN fixes [1]. Hence the sanity checker has been quite a productive and useful tool to play with during development. Thanks to UBSAN, this series proposes 7 (+1 in [2]) UB fixes, revealed by a simple cold boot of sandbox and arm64 R-Car Gen3 U-Boot. There could be more issues in arch/platform/board-specific code, whose reproduction needs specific hardware. A certain class of UBs [3] is reported regularly at runtime and looks to be related to the implementation of U-Boot linker-generated arrays. I believe some feedback from the authors/maintainers of those is required to assess if this is a UBSAN false positive or a real bug. This series collects the low-hanging fruit and leaves others to experiment with UBSAN themselves. Best regards, Eugeniu. [1] git log --oneline --no-merges --grep UBSAN v4.18 | wc -l 119 [2] https://patchwork.ozlabs.org/patch/957323/ [3] Either a false-positive or a bug in "include/linker_lists.h": ================================================================= UBSAN: Undefined behaviour in drivers/core/lists.c:28:26 load of address 000000000075f180 with insufficient space for an object of type 'char *' ================================================================= Eugeniu Rosca (8): UBSAN: run-time undefined behavior sanity checker mmc: Fix "left shift in type int" undefined behavior armv8: mmu: Fix "left shift in type int" undefined behavior pinctrl: renesas: Fix "left shift in type int" undefined behavior net: phy: Fix "left shift in type int" undefined behavior net: ravb: Fix "left shift in type int" undefined behavior mmc: Fix read-past-end-of-array undefined behavior hashtable: Fix zero-sized array undefined behavior Makefile | 3 +- arch/Kconfig | 1 + arch/arm/Kconfig | 1 + arch/arm/include/asm/armv8/mmu.h | 8 +- drivers/mmc/mmc.c | 4 +- drivers/net/phy/phy.c | 4 +- drivers/net/ravb.c | 16 +- drivers/pinctrl/renesas/sh_pfc.h | 14 +- examples/standalone/Makefile | 2 + include/linux/compat.h | 3 + include/search.h | 2 +- lib/Kconfig | 1 + lib/Kconfig.ubsan | 29 ++ lib/Makefile | 3 + lib/hashtable.c | 4 +- lib/linux_compat.c | 3 + lib/ubsan.c | 461 +++++++++++++++++++++++++++++++ lib/ubsan.h | 94 +++++++ scripts/Makefile.lib | 6 + scripts/Makefile.ubsan | 20 ++ 20 files changed, 652 insertions(+), 27 deletions(-) create mode 100644 lib/Kconfig.ubsan create mode 100644 lib/ubsan.c create mode 100644 lib/ubsan.h create mode 100644 scripts/Makefile.ubsan -- 2.18.0

5 20

[U-Boot] [PATCH] ARM: display5: config: Replace hardcoded size of kernel (0x2000) with variable (fitImg_fw_sz)
by Lukasz Majewski 20 Aug '18

20 Aug '18

This cosmetic change allow easy adjustment of the to-load kernel size if needed. Signed-off-by: Lukasz Majewski <lukma(a)denx.de> --- include/configs/display5.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/configs/display5.h b/include/configs/display5.h index fc8261373a..514638f684 100644 --- a/include/configs/display5.h +++ b/include/configs/display5.h @@ -166,7 +166,7 @@ "rootwait rootfstype=ext4 rw; " \ "run set_kernel_part;" \ "part start mmc ${mmcdev} ${kernel_part} lba_start; " \ - "mmc read ${loadaddr} ${lba_start} 0x2000; " \ + "mmc read ${loadaddr} ${lba_start} ${fitImg_fw_sz}; " \ "setenv fdt_conf imx6q-${board}-${display}.dtb; " /* All the numbers are in LBAs */ @@ -273,6 +273,7 @@ "fdt_high=0xffffffff\0" \ "initrd_high=0xffffffff\0" \ "kernel_file=fitImage\0" \ + "fitImg_fw_sz=0x2200\0" \ "up=run tftp_sf_SPL; run tftp_sf_uboot\0" \ "download_kernel=" \ "tftpboot ${loadaddr} ${kernel_file};\0" \ -- 2.11.0

3 3

[U-Boot] [PATCH] doc: FIT image: fix typo
by Pierre-Jean Texier 20 Aug '18

20 Aug '18

Fix typo in beaglebone verified boot documentation. Signed-off-by: Pierre-Jean Texier <texier.pj2(a)gmail.com> --- doc/uImage.FIT/beaglebone_vboot.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/uImage.FIT/beaglebone_vboot.txt b/doc/uImage.FIT/beaglebone_vboot.txt index f1862c2..685ec1f 100644 --- a/doc/uImage.FIT/beaglebone_vboot.txt +++ b/doc/uImage.FIT/beaglebone_vboot.txt @@ -462,7 +462,7 @@ you sign. cd $UBOOT make O=b/am335x_boneblack_vboot EXT_DTB=${WORK}/am335x-boneblack-pubkey.dtb -Here we are overrriding the normal device tree file with our one, which +Here we are overriding the normal device tree file with our one, which contains the public key. Now you have a special U-Boot image with the public key. It can verify can -- 2.7.4

2 1

[U-Boot] [PATCH] fs/fat: debug-print file read position during file_fat_read_at()
by Andreas Dannenberg 20 Aug '18

20 Aug '18

In order to make the debug print in file_fat_read_at() a tad more useful, show the offset the file is being read at alongside the filename. Suggested-by: Tero Kristo <t-kristo(a)ti.com> Signed-off-by: Andreas Dannenberg <dannenberg(a)ti.com> --- Small addition but helpful nevertheless as none of the other debug prints embedded into fat.c seems to output this info. Without that addition it would just tell you the same file name a couple of times when reading from an DTB/ITB file for example. With the offset being shown it's easier to correlate/debug the loading process. Oddly (and I haven't fully debugged this) but in order to really get _any_ of the debug() prints working in fat.c in my particulat setup, in addition to the usual '#define DEBUG' I also had to explicitly define _DEBUG to '1', something that should already be taken care of by log.c... fs/fat/fat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fat/fat.c b/fs/fat/fat.c index 4efe8a3eda..4b722fc5ca 100644 --- a/fs/fat/fat.c +++ b/fs/fat/fat.c @@ -1095,7 +1095,7 @@ int file_fat_read_at(const char *filename, loff_t pos, void *buffer, if (ret) goto out_free_both; - debug("reading %s\n", filename); + debug("reading %s at pos %llu\n", filename, pos); ret = get_contents(&fsdata, itr->dent, pos, buffer, maxsize, actread); out_free_both: -- 2.15.1

3 3