February 2018 - U-Boot

[U-Boot] [PATCH] mx8mqevk: Update README with additional info
by Diego Dorta 04 Feb '18

04 Feb '18

The main reason for this update is due the currently README has no enough info to boot the board. Add a few more steps that make the board bootable. Signed-off-by: Diego Dorta <diego.dorta(a)nxp.com> --- This patch depends on Peng Fan's patch series: https://patchwork.ozlabs.org/cover/857942/ board/freescale/mx8mq_evk/README | 92 +++++++++++++++++++++++++++------------- 1 file changed, 63 insertions(+), 29 deletions(-) diff --git a/board/freescale/mx8mq_evk/README b/board/freescale/mx8mq_evk/README index 5a6e8b84d7..cd7e67eec5 100644 --- a/board/freescale/mx8mq_evk/README +++ b/board/freescale/mx8mq_evk/README @@ -1,47 +1,81 @@ U-Boot for the NXP i.MX8MQ EVK board Quick Start -==================== -- Build the ARM Trusted firmware binary +=========== + - Build U-Boot -- Get ddr fimware and tools +- Build the ARM Trusted firmware binary +- Get DDR firmware and mkimage tool - Generate flash.bin using imx-mkimage +- Flash the binary into the SD card - Boot -Get and Build the ARM Trusted firmware -==================== -Get ATF from: https://source.codeaurora.org/external/imx/imx-atf -$ make PLAT=imx8mq bl31 - Build U-Boot -==================== -$ export ARCH=arm64 -$ export CROSS_COMPILE=aarch64-poky-linux- +============ + $ make mx8mq_evk_defconfig $ make -Get the ddr firmware and tools -==================== -Note: Better to use NXP released yocto to get the firmware in case - there is new releases. -https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-7.2.bin -imx-mkimage: https://source.codeaurora.org/external/imx/imx-mkimage/ +Get and Build the ARM Trusted firmware +====================================== + +$ git clone https://source.codeaurora.org/external/imx/imx-atf +$ cd imx-atf/ +$ git checkout origin/imx_4.9.51_imx8m_beta +$ make PLAT=imx8mq bl31 + +Get the DDR firmware and mkimage tool +============================== + +$ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-7.2.bin +$ chmod +x firmware-imx-7.2.bin +$ ./firmware-imx-7.2.bin + +Download the imx-mkimage tool: + +$ git clone https://source.codeaurora.org/external/imx/imx-mkimage/ +$ cd imx-mkimage/ +$ git checkout origin/imx_4.9.51_imx8m_beta + Generate flash.bin using imx-mkimage -==================== -Copy bl31.bin u-boot-nodtb.bin u-boot-spl.bin fsl-imx8mq-evk.dtb to - imx-mkimage/iMX8M -Copy lpddr4_pmu_train_1d_dmem.bin lpddr4_pmu_train_1d_imem.bin - lpddr4_pmu_train_2d_dmem.bin lpddr4_pmu_train_2d_imem.bin to - imx-mkimage/iMX8M -If you want to run with HDMI, copy signed_hdmi_imx8m.bin to imx-mkimage/iMX8M +==================================== + +Copy the following binaries to imx-mkimage/iMX8M folder: + +$ cp imx-atf/build/imx8mq/release/bl31.bin imx-mkimage/iMX8M/ +$ cp u-boot/u-boot-nodtb.bin imx-mkimage/iMX8M/ +$ cp u-boot/spl/u-boot-spl.bin imx-mkimage/iMX8M/ +$ cp u-boot/arch/arm/dts/fsl-imx8mq-evk.dtb imx-mkimage/iMX8M/ + +Copy the following firmwares to imx-mkimage/iMX8 folder : + +$ cp firmware-imx-7.2/firmware/ddr/synopsys/lpddr4_pmu_train_1d_dmem.bin imx-mkimage/iMX8M/ +$ cp firmware-imx-7.2/firmware/ddr/synopsys/lpddr4_pmu_train_1d_imem.bin imx-mkimage/iMX8M/ +$ cp firmware-imx-7.2/firmware/ddr/synopsys/lpddr4_pmu_train_2d_dmem.bin imx-mkimage/iMX8M/ +$ cp firmware-imx-7.2/firmware/ddr/synopsys/lpddr4_pmu_train_2d_imem.bin imx-mkimage/iMX8M/ + +If you want to run with HDMI, copy signed_hdmi_imx8m.bin to imx-mkimage/iMX8M. + +Before generating the flash.bin, transfer the mkimage generated by U-Boot to iMX8M folder: + +$ cp u-boot/tools/mkimage imx-mkimage/iMX8M/ +$ mv imx-mkimage/iMX8M/mkimage imx-mkimage/iMX8M/mkimage_uboot + +$ cd imx-mkimage/ +$ make SOC=iMX8M flash_spl_uboot + +Or for using HDMI: + +$ make SOC=iMX8M flash_hdmi_spl_uboot + +Flash the binary into the SD card +================================= -make SOC=iMX8M flash_hdmi_spl_uboot or make SOC=iMX8M flash_spl_uboot to -generate flash.bin. +Burn the flash.bin binary to SD card offset 33KB: -Burn the flash.bin to MicroSD card offset 33KB -$sudo dd if=iMX8M/flash.bin of=/dev/sd[x] bs=1024 seek=33 +$ sudo dd if=iMX8M/flash.bin of=/dev/sd[x] bs=1024 seek=33 Boot -==================== +==== Set Boot switch SW801: 1100 and Bmode: 10 to boot from Micro SD. -- 2.15.1

2 1

[U-Boot] [PATCH V2 1/4] mmc: fsl_esdhc: add strobe and tuning entry
by Peng Fan 04 Feb '18

04 Feb '18

Add entries that will be used for tuning control. The whole layout not changed, just expand reserved3[84] and rename other reservedx in sequence. Signed-off-by: Peng Fan <peng.fan(a)nxp.com> Cc: Stefano Babic <sbabic(a)denx.de> Cc: Fabio Estevam <fabio.estevam(a)nxp.com> Cc: Jaehoon Chung <jh80.chung(a)samsung.com> --- drivers/mmc/fsl_esdhc.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c index 71c62f4233..f6279307d8 100644 --- a/drivers/mmc/fsl_esdhc.c +++ b/drivers/mmc/fsl_esdhc.c @@ -61,23 +61,27 @@ struct fsl_esdhc { uint dllctrl; uint dllstat; uint clktunectrlstatus; - char reserved3[84]; + char reserved3[4]; + uint strobe_dllctrl; + uint strobe_dllstat; + char reserved4[72]; uint vendorspec; uint mmcboot; uint vendorspec2; - char reserved4[48]; + uint tuning_ctrl; /* on i.MX6/7/8 */ + char reserved5[44]; uint hostver; /* Host controller version register */ - char reserved5[4]; /* reserved */ - uint dmaerraddr; /* DMA error address register */ char reserved6[4]; /* reserved */ - uint dmaerrattr; /* DMA error attribute register */ + uint dmaerraddr; /* DMA error address register */ char reserved7[4]; /* reserved */ + uint dmaerrattr; /* DMA error attribute register */ + char reserved8[4]; /* reserved */ uint hostcapblt2; /* Host controller capabilities register 2 */ - char reserved8[8]; /* reserved */ + char reserved9[8]; /* reserved */ uint tcr; /* Tuning control register */ - char reserved9[28]; /* reserved */ + char reserved10[28]; /* reserved */ uint sddirctl; /* SD direction control register */ - char reserved10[712];/* reserved */ + char reserved11[712];/* reserved */ uint scr; /* eSDHC control register */ }; -- 2.14.1

3 9

[U-Boot] [PATCH] mx6memcal: fix comment in board header file
by Eric Nelson 04 Feb '18

04 Feb '18

The board header file included a reference to the starting point from nitrogen6x.h, but since so much changed, the file bears little resemblance to that file. Signed-off-by: Eric Nelson <eric(a)nelint.com> --- include/configs/mx6memcal.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/include/configs/mx6memcal.h b/include/configs/mx6memcal.h index 28c67c4..5be8ce4 100644 --- a/include/configs/mx6memcal.h +++ b/include/configs/mx6memcal.h @@ -1,8 +1,7 @@ /* - * Copyright (C) 2010-2011 Freescale Semiconductor, Inc. + * Copyright (C) 2010-2018 Freescale Semiconductor, Inc. * - * Configuration settings for the Boundary Devices Nitrogen6X - * and Freescale i.MX6Q Sabre Lite boards. + * Configuration settings for the virtual mx6memcal board. * * SPDX-License-Identifier: GPL-2.0+ */ -- 2.7.4

2 1

[U-Boot] [PATCH 1/2] mx6memcal: launder through savedefconfig
by Eric Nelson 04 Feb '18

04 Feb '18

This patch just changes the order of configuration items in mx6memcal_defconfig to match the Kconfig layout, making it easier to track changes made using menuconfig. Signed-off-by: Eric Nelson <eric(a)nelint.com> --- configs/mx6memcal_defconfig | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/configs/mx6memcal_defconfig b/configs/mx6memcal_defconfig index 9a3bb83..b27330c 100644 --- a/configs/mx6memcal_defconfig +++ b/configs/mx6memcal_defconfig @@ -9,25 +9,24 @@ CONFIG_SPL_WATCHDOG_SUPPORT=y CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg,SPL,MX6QDL" CONFIG_SPL=y CONFIG_HUSH_PARSER=y -# CONFIG_MMC is not set # CONFIG_CMD_BOOTD is not set # CONFIG_CMD_BOOTM is not set # CONFIG_CMD_ELF is not set # CONFIG_CMD_IMI is not set -# CONFIG_CMD_IMLS is not set # CONFIG_CMD_XIMG is not set # CONFIG_CMD_EXPORTENV is not set # CONFIG_CMD_IMPORTENV is not set # CONFIG_CMD_EDITENV is not set # CONFIG_CMD_SAVEENV is not set # CONFIG_CMD_ENV_EXISTS is not set -CONFIG_CMD_MEMTEST=y CONFIG_CMD_MEMINFO=y -# CONFIG_CMD_LOADB is not set -# CONFIG_CMD_LOADS is not set +CONFIG_CMD_MEMTEST=y # CONFIG_CMD_FLASH is not set # CONFIG_CMD_FPGA is not set +# CONFIG_CMD_LOADB is not set +# CONFIG_CMD_LOADS is not set # CONFIG_CMD_NET is not set # CONFIG_CMD_NFS is not set CONFIG_CMD_CACHE=y +# CONFIG_MMC is not set CONFIG_REGEX=y -- 2.7.4

3 5

[U-Boot] [PATCH v3 0/4] arm: imx53: remove usage of mx53_dram_size
by linux-kernel-dev＠beckhoff.com 04 Feb '18

04 Feb '18

From: Patrick Bruenn <p.bruenn(a)beckhoff.com> Global variables are not available during board_init_f(). The i.MX53 boards m53evk, mx53cx9020 and mx53loco are using the exact same dram initialization code, which uses 'static uint32_t mx53_dram_size[2];' in dram_init(), dram_init_banksize() and get_effective_memsize() to avoid multiple calls to get_ram_size(). This series replaces the static variable with multiple calls to get_ram_size() and moves the shared code into arch/arm/mach-imx/mx5/. The first patch is required to let cx9020 boot again. Please include at least this one. Without that patch u-boot on cx9020 is broken. The second patch moves that code to a common place to be reused by m53evk and mx53loco. Pick it only if you think this change is useful for one of these boards and you are willing to include the third and/or last patch. Pick the third patch if you want to use the changed code for m53evk. Pick the last patch if you want to use the changed code for mx53loco. Changes in v3: - rebase to v2018.01 - fix the cover-letter to make it more clear that the first patch is required to make the cx9020 boot again. All other patches are optional. Changes in v2: - move dram initialization into common location - reuse fixed dram initialization for m53evk and mx53loco Patrick Bruenn (4): arm: imx: cx9020: remove usage of mx53_dram_size arm: imx: cx9020: move dram init into common place arm: imx: m53evk: remove usage of mx53_dram_size arm: imx: mx53loco: remove usage of mx53_dram_size arch/arm/mach-imx/mx5/Makefile | 5 ++++ arch/arm/mach-imx/mx5/mx53_dram.c | 45 ++++++++++++++++++++++++++++++++++ board/aries/m53evk/m53evk.c | 39 ----------------------------- board/beckhoff/mx53cx9020/mx53cx9020.c | 39 ----------------------------- board/freescale/mx53loco/mx53loco.c | 39 ----------------------------- 5 files changed, 50 insertions(+), 117 deletions(-) create mode 100644 arch/arm/mach-imx/mx5/mx53_dram.c -- 2.11.0

2 5

[U-Boot] [PATCHv2 00/15] Updates / improvements to bx50v3 support
by Sebastian Reichel 04 Feb '18

04 Feb '18

This series improves the support on the bx50v3 devices (b540v3, b650v3 and b850v3). Changes outside of the bx50v3 specific areas: - Added driver for RX8010SJ RTC. - Added functionality to e1000 driver to enable wrting of EEPROM/MAC address. Changes since PATCHv1: * Rebased to v2018.01 * Fixed compiler warning for qemu amd64 target -- Sebastian Hannu Lounento (5): net: e1000: add support for writing to EEPROM net: e1000: split e1000_read_mac_addr net: e1000: implement eth_write_hwaddr board: ge: bx50v3: program MAC address to I210 board: ge: bx50v3: mount rootfs read-only Ian Ray (5): configs: Add network device support for bx50v3 products board: ge: bx50v3: Support FIT and select configuration based on VPD config: ge_bx50v3: read boot script configs: ge_bx50v3: enable bootcount configs: ge_bx50v3: automatic partition selection and video output failure message Martyn Welch (3): board: ge: Enable access to i2c bus 1 and 2 board: ge: bx50v3: move FEC MAC address programming to driver board: ge: bx50v3: Enable hardware watchdog Nandor Han (2): rtc: adding RX8010SJ rtc driver board,ge,bx50v3 - rtc time validation board/ge/bx50v3/bx50v3.c | 130 ++++++++++----- configs/ge_b450v3_defconfig | 7 +- configs/ge_b650v3_defconfig | 7 +- configs/ge_b850v3_defconfig | 8 +- drivers/net/e1000.c | 294 +++++++++++++++++++++++++++++++--- drivers/net/e1000.h | 3 + drivers/rtc/Kconfig | 6 + drivers/rtc/Makefile | 1 + drivers/rtc/rx8010sj.c | 378 ++++++++++++++++++++++++++++++++++++++++++++ include/configs/ge_bx50v3.h | 190 +++++++++------------- 10 files changed, 849 insertions(+), 175 deletions(-) create mode 100644 drivers/rtc/rx8010sj.c -- 2.15.1

2 16

[U-Boot] [PATCH 1/3] configs: enable spl support wrt env device
by Jagan Teki 04 Feb '18

04 Feb '18

nand device needed for mmc config to access nand for write and update so enabling SPL_SUPPORT to mmc or nand is wrt to env device rather nand driver check. Signed-off-by: Jagan Teki <jagan(a)amarulasolutions.com> --- include/configs/imx6-engicam.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/imx6-engicam.h b/include/configs/imx6-engicam.h index 0c45e06..5f43dfb 100644 --- a/include/configs/imx6-engicam.h +++ b/include/configs/imx6-engicam.h @@ -208,7 +208,7 @@ /* SPL */ #ifdef CONFIG_SPL -# ifdef CONFIG_NAND_MXS +# ifdef CONFIG_ENV_IS_IN_NAND # define CONFIG_SPL_NAND_SUPPORT # else # define CONFIG_SPL_MMC_SUPPORT -- 2.7.4

3 6

[U-Boot] [PATCH V3 1/3] mx7_common: use psci 1.0 instead of 0.1
by Anson Huang 04 Feb '18

04 Feb '18

Use PSCI 1.0 instead of 0.1 to support more power management feature like system reset, power off etc.. Signed-off-by: Anson Huang <Anson.Huang(a)nxp.com> --- include/configs/mx7_common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/configs/mx7_common.h b/include/configs/mx7_common.h index 16e4d95..7861712 100644 --- a/include/configs/mx7_common.h +++ b/include/configs/mx7_common.h @@ -62,6 +62,8 @@ #define CONFIG_ARMV7_SECURE_BASE 0x00900000 +#define CONFIG_ARMV7_PSCI_1_0 + /* Secure boot (HAB) support */ #ifdef CONFIG_SECURE_BOOT #define CONFIG_CSF_SIZE 0x2000 -- 1.9.1

2 4

[U-Boot] [PATCH] board: i.MX6QDL: add Engicam i.CoreM6 1.5 QDL MIPI starter kit
by Jagan Teki 04 Feb '18

04 Feb '18

i.CoreM6 1.5 is an another i.CoreM6 QDL cpu modules which can be connected to EDIMM starter kit design with eMMC and MIPI-CSI interfaces suitable for Android and video capture application. notable features: CPU NXP i.MX6 S/DL/D/Q, Up to 4 x Cortex-A9@800MHz Memory Up to 2 GB DDR3-1066 Video Interfaces Up to 1 Parallel Up to 2 LVDS HDMI 1.4 port 8 bit CSI INPUT MIPI-CSI INPUT 1 x 10/100 Ethernet interface, 2 x USB, 1 x PCIe, 1 x I2S etc This patch adds support for Quad/Dual and DualLite/Solo SOM's on MIPI starter kit with boot from SD and eMMC. Signed-off-by: Jagan Teki <jagan(a)amarulasolutions.com> --- arch/arm/dts/Makefile | 2 ++ arch/arm/dts/imx6dl-icore-mipi.dts | 21 ++++++++++++++++ arch/arm/dts/imx6q-icore-mipi.dts | 21 ++++++++++++++++ arch/arm/dts/imx6qdl-icore.dtsi | 28 +++++++++++++++++++++ board/engicam/common/board.c | 5 ++++ configs/imx6qdl_icore_mipi_defconfig | 49 ++++++++++++++++++++++++++++++++++++ 6 files changed, 126 insertions(+) create mode 100644 arch/arm/dts/imx6dl-icore-mipi.dts create mode 100644 arch/arm/dts/imx6q-icore-mipi.dts create mode 100644 configs/imx6qdl_icore_mipi_defconfig diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index a895c70..8515645 100644 --- a/arch/arm/dts/Makefile +++ b/arch/arm/dts/Makefile @@ -374,9 +374,11 @@ dtb-$(CONFIG_MX6) += imx6ull-14x14-evk.dtb \ imx6sl-evk.dtb \ imx6sll-evk.dtb \ imx6dl-icore.dtb \ + imx6dl-icore-mipi.dtb \ imx6dl-icore-rqs.dtb \ imx6q-cm-fx6.dtb \ imx6q-icore.dtb \ + imx6q-icore-mipi.dtb \ imx6q-icore-rqs.dtb \ imx6q-logicpd.dtb \ imx6sx-sabreauto.dtb \ diff --git a/arch/arm/dts/imx6dl-icore-mipi.dts b/arch/arm/dts/imx6dl-icore-mipi.dts new file mode 100644 index 0000000..3a444c0 --- /dev/null +++ b/arch/arm/dts/imx6dl-icore-mipi.dts @@ -0,0 +1,21 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (C) 2017 Engicam S.r.l. + * Copyright (C) 2017 Amarula Solutions B.V. + * Author: Jagan Teki <jagan(a)amarulasolutions.com> + */ + +/dts-v1/; + +#include "imx6dl.dtsi" +#include "imx6qdl-icore.dtsi" + +/ { + model = "Engicam i.CoreM6 DualLite/Solo MIPI Starter Kit"; + compatible = "engicam,imx6-icore", "fsl,imx6dl"; +}; + +&usdhc3 { + u-boot,dm-spl; + status = "okay"; +}; diff --git a/arch/arm/dts/imx6q-icore-mipi.dts b/arch/arm/dts/imx6q-icore-mipi.dts new file mode 100644 index 0000000..527f52c --- /dev/null +++ b/arch/arm/dts/imx6q-icore-mipi.dts @@ -0,0 +1,21 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (C) 2017 Engicam S.r.l. + * Copyright (C) 2017 Amarula Solutions B.V. + * Author: Jagan Teki <jagan(a)amarulasolutions.com> + */ + +/dts-v1/; + +#include "imx6q.dtsi" +#include "imx6qdl-icore.dtsi" + +/ { + model = "Engicam i.CoreM6 Quad/Dual MIPI Starter Kit"; + compatible = "engicam,imx6-icore", "fsl,imx6q"; +}; + +&usdhc3 { + u-boot,dm-spl; + status = "okay"; +}; diff --git a/arch/arm/dts/imx6qdl-icore.dtsi b/arch/arm/dts/imx6qdl-icore.dtsi index 06d9bc3..913dc99 100644 --- a/arch/arm/dts/imx6qdl-icore.dtsi +++ b/arch/arm/dts/imx6qdl-icore.dtsi @@ -44,6 +44,10 @@ #include <dt-bindings/input/input.h> / { + aliases { + mmc1 = &usdhc3; + }; + memory { reg = <0x10000000 0x80000000>; }; @@ -126,6 +130,14 @@ status = "okay"; }; +&usdhc3 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usdhc3>; + no-1-8-v; + non-removable; + status = "disabled"; +}; + &iomuxc { pinctrl_enet: enetgrp { fsl,pins = < @@ -219,4 +231,20 @@ MX6QDL_PAD_SD1_DAT3__SD1_DATA3 0x17070 >; }; + + pinctrl_usdhc3: usdhc3grp { + u-boot,dm-spl; + fsl,pins = < + MX6QDL_PAD_SD3_CMD__SD3_CMD 0x17059 + MX6QDL_PAD_SD3_CLK__SD3_CLK 0x10059 + MX6QDL_PAD_SD3_DAT0__SD3_DATA0 0x17059 + MX6QDL_PAD_SD3_DAT1__SD3_DATA1 0x17059 + MX6QDL_PAD_SD3_DAT2__SD3_DATA2 0x17059 + MX6QDL_PAD_SD3_DAT3__SD3_DATA3 0x17059 + MX6QDL_PAD_SD3_DAT4__SD3_DATA4 0x17059 + MX6QDL_PAD_SD3_DAT5__SD3_DATA5 0x17059 + MX6QDL_PAD_SD3_DAT6__SD3_DATA6 0x17059 + MX6QDL_PAD_SD3_DAT7__SD3_DATA7 0x17059 + >; + }; }; diff --git a/board/engicam/common/board.c b/board/engicam/common/board.c index f633c71..0160418 100644 --- a/board/engicam/common/board.c +++ b/board/engicam/common/board.c @@ -41,6 +41,11 @@ static void setenv_fdt_file(void) env_set("fdt_file", "imx6q-icore.dtb"); else if(is_mx6dl() || is_mx6solo()) env_set("fdt_file", "imx6dl-icore.dtb"); + } else if (!strcmp(cmp_dtb, "imx6q-icore-mipi")) { + if (is_mx6dq()) + env_set("fdt_file", "imx6q-icore-mipi.dtb"); + else if(is_mx6dl() || is_mx6solo()) + env_set("fdt_file", "imx6dl-icore-mipi.dtb"); } else if (!strcmp(cmp_dtb, "imx6q-icore-rqs")) { if (is_mx6dq()) env_set("fdt_file", "imx6q-icore-rqs.dtb"); diff --git a/configs/imx6qdl_icore_mipi_defconfig b/configs/imx6qdl_icore_mipi_defconfig new file mode 100644 index 0000000..3bec7e2 --- /dev/null +++ b/configs/imx6qdl_icore_mipi_defconfig @@ -0,0 +1,49 @@ +CONFIG_ARM=y +CONFIG_ARCH_MX6=y +CONFIG_SPL_GPIO_SUPPORT=y +CONFIG_SPL_LIBCOMMON_SUPPORT=y +CONFIG_SPL_LIBGENERIC_SUPPORT=y +CONFIG_SYS_MALLOC_F_LEN=0x2000 +CONFIG_TARGET_MX6Q_ENGICAM=y +CONFIG_SPL_SERIAL_SUPPORT=y +CONFIG_SPL_LIBDISK_SUPPORT=y +CONFIG_SPL_WATCHDOG_SUPPORT=y +# CONFIG_CMD_BMODE is not set +CONFIG_DEFAULT_DEVICE_TREE="imx6q-icore-mipi" +CONFIG_DEBUG_UART=y +CONFIG_FIT=y +CONFIG_FIT_SIGNATURE=y +CONFIG_FIT_VERBOSE=y +CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg" +CONFIG_BOOTDELAY=3 +CONFIG_SPL=y +CONFIG_SPL_EXT_SUPPORT=y +CONFIG_SPL_OS_BOOT=y +CONFIG_HUSH_PARSER=y +CONFIG_SYS_PROMPT="icorem6qdl-mipi> " +CONFIG_CRC32_VERIFY=y +CONFIG_CMD_MEMTEST=y +CONFIG_CMD_GPIO=y +CONFIG_CMD_I2C=y +CONFIG_CMD_MMC=y +CONFIG_CMD_MII=y +CONFIG_CMD_PING=y +CONFIG_CMD_CACHE=y +CONFIG_CMD_EXT2=y +CONFIG_CMD_EXT4=y +CONFIG_CMD_EXT4_WRITE=y +CONFIG_CMD_FAT=y +CONFIG_CMD_FS_GENERIC=y +CONFIG_OF_LIST="imx6q-icore-mipi imx6dl-icore-mipi" +CONFIG_ENV_IS_IN_MMC=y +CONFIG_SYS_I2C_MXC=y +CONFIG_PHYLIB=y +CONFIG_PHY_SMSC=y +CONFIG_FEC_MXC=y +CONFIG_PINCTRL=y +CONFIG_PINCTRL_IMX6=y +CONFIG_DEBUG_UART_MXC=y +CONFIG_DEBUG_UART_BASE=0x021f0000 +CONFIG_DEBUG_UART_CLOCK=24000000 +CONFIG_MXC_UART=y +CONFIG_IMX_THERMAL=y -- 2.7.4

2 1

Re: [U-Boot] [PATCH] cmd: nvedit: env_get_f must check for env_get_char error codes
by Goldschmidt Simon 03 Feb '18

03 Feb '18

On 02/02/2018 21:04, York Sun wrote: > On 02/02/2018 10:51 AM, Maxime Ripard wrote: > > <snip> > >>>>> >>>> Simon, >>>> >>>> This patch looks correct. But it doesn't fix NOR flash. Do you have plan >>>> to add .get_char function to other drivers? Without that function, we >>>> cannot get env variables before relocation. >>> >>> Ehrm, sorry I don't plan to do that, no: my target seems to run fine >>> without this. >>> >>> Given that only the eeprom and nvram env drivers support the get_char >>> method, I don't know if this is widely used at all. Maybe a better fallback >>> would be to just remove that get_char code path totally and always load from >>> the internal (default) environment until the full environment is available >>> (after relocation). >>> >>> After all, the environment variables loaded via get_char are not CRC checked >>> at all. To me, this is another indication that this code is not really >>> useful and should probably be removed. >> >> To be honest, I'm not really sure what get_char was here for in the >> first place, so getting rid of it sounds like a good idea :) >> > > On almost all my boards, a variable hwconfig is read before relocation > to determine DDR configuration. This has been broken. I don't mind you > remove some dead code. But this is breaking almost all my boards booting > from NOR flash. When talking about removing a feature I meant the code that exists for 2 env drivers only where single characters are loaded from an external environment without checking its crc first. The thing you seem to need is reading from the default environment before relocation. This should not be removed, of course! I might prepare a patch to better show what I mean... Simon

1 0