February 2018 - U-Boot

[U-Boot] [PATCH v2 1/1] efi_loader: correct efi_disk_register
by Heinrich Schuchardt 09 Feb '18

09 Feb '18

efi_disk_register should return as status code (efi_status_t). Disks with zero blocks should be reported as 'not ready' without throwing an error. This patch solves a problem running OpenBSD on system configured with CONFIG_BLK=n (e.g. i.MX6). Reported-by: Jonathan Gray <jsg(a)jsg.id.au> Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- v2 remove superfluous check --- include/efi_loader.h | 2 +- lib/efi_loader/efi_disk.c | 71 +++++++++++++++++++++++++++++------------------ 2 files changed, 45 insertions(+), 28 deletions(-) diff --git a/include/efi_loader.h b/include/efi_loader.h index a2d82e1db73..07730c3f394 100644 --- a/include/efi_loader.h +++ b/include/efi_loader.h @@ -173,7 +173,7 @@ extern struct list_head efi_obj_list; /* Called by bootefi to make console interface available */ int efi_console_register(void); /* Called by bootefi to make all disk storage accessible as EFI objects */ -int efi_disk_register(void); +efi_status_t efi_disk_register(void); /* Create handles and protocols for the partitions of a block device */ int efi_disk_create_partitions(efi_handle_t parent, struct blk_desc *desc, const char *if_typename, int diskid, diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c index ac39a65ee89..825a6d86de8 100644 --- a/lib/efi_loader/efi_disk.c +++ b/lib/efi_loader/efi_disk.c @@ -226,25 +226,26 @@ efi_fs_from_path(struct efi_device_path *full_path) * @offset offset into disk for simple partitions * @return disk object */ -static struct efi_disk_obj *efi_disk_add_dev( +static efi_status_t efi_disk_add_dev( efi_handle_t parent, struct efi_device_path *dp_parent, const char *if_typename, struct blk_desc *desc, int dev_index, lbaint_t offset, - unsigned int part) + unsigned int part, + struct efi_disk_obj **disk) { struct efi_disk_obj *diskobj; efi_status_t ret; /* Don't add empty devices */ if (!desc->lba) - return NULL; + return EFI_NOT_READY; diskobj = calloc(1, sizeof(*diskobj)); if (!diskobj) - goto out_of_memory; + return EFI_OUT_OF_RESOURCES; /* Hook up to the device list */ efi_add_handle(&diskobj->parent); @@ -262,11 +263,11 @@ static struct efi_disk_obj *efi_disk_add_dev( ret = efi_add_protocol(diskobj->parent.handle, &efi_block_io_guid, &diskobj->ops); if (ret != EFI_SUCCESS) - goto out_of_memory; + return ret; ret = efi_add_protocol(diskobj->parent.handle, &efi_guid_device_path, diskobj->dp); if (ret != EFI_SUCCESS) - goto out_of_memory; + return ret; if (part >= 1) { diskobj->volume = efi_simple_file_system(desc, part, diskobj->dp); @@ -274,7 +275,7 @@ static struct efi_disk_obj *efi_disk_add_dev( &efi_simple_file_system_protocol_guid, diskobj->volume); if (ret != EFI_SUCCESS) - goto out_of_memory; + return ret; } diskobj->ops = block_io_disk_template; diskobj->ifname = if_typename; @@ -291,10 +292,9 @@ static struct efi_disk_obj *efi_disk_add_dev( if (part != 0) diskobj->media.logical_partition = 1; diskobj->ops.media = &diskobj->media; - return diskobj; -out_of_memory: - printf("ERROR: Out of memory\n"); - return NULL; + if (disk) + *disk = diskobj; + return EFI_SUCCESS; } /* @@ -330,8 +330,12 @@ int efi_disk_create_partitions(efi_handle_t parent, struct blk_desc *desc, continue; snprintf(devname, sizeof(devname), "%s:%d", pdevname, part); - efi_disk_add_dev(parent, dp, if_typename, desc, diskid, - info.start, part); + ret = efi_disk_add_dev(parent, dp, if_typename, desc, diskid, + info.start, part, NULL); + if (ret != EFI_SUCCESS) { + printf("Adding partition %s failed\n", pdevname); + continue; + } disks++; } @@ -349,26 +353,32 @@ int efi_disk_create_partitions(efi_handle_t parent, struct blk_desc *desc, * * This gets called from do_bootefi_exec(). */ -int efi_disk_register(void) +efi_status_t efi_disk_register(void) { struct efi_disk_obj *disk; int disks = 0; + efi_status_t ret; #ifdef CONFIG_BLK struct udevice *dev; - for (uclass_first_device_check(UCLASS_BLK, &dev); - dev; + for (uclass_first_device_check(UCLASS_BLK, &dev); dev; uclass_next_device_check(&dev)) { struct blk_desc *desc = dev_get_uclass_platdata(dev); const char *if_typename = blk_get_if_type_name(desc->if_type); - printf("Scanning disk %s...\n", dev->name); - /* Add block device for the full device */ - disk = efi_disk_add_dev(NULL, NULL, if_typename, - desc, desc->devnum, 0, 0); - if (!disk) - return -ENOMEM; + printf("Scanning disk %s...\n", dev->name); + ret = efi_disk_add_dev(NULL, NULL, if_typename, + desc, desc->devnum, 0, 0, &disk); + if (ret == EFI_NOT_READY) { + printf("Disk %s not ready\n", dev->name); + continue; + } + if (ret) { + printf("ERROR: failure to add disk device %s, r = %lu\n", + dev->name, ret & ~EFI_ERROR_MASK); + return ret; + } disks++; /* Partitions show up as block devices in EFI */ @@ -404,10 +414,17 @@ int efi_disk_register(void) if_typename, i); /* Add block device for the full device */ - disk = efi_disk_add_dev(NULL, NULL, if_typename, desc, - i, 0, 0); - if (!disk) - return -ENOMEM; + ret = efi_disk_add_dev(NULL, NULL, if_typename, desc, + i, 0, 0, &disk); + if (ret == EFI_NOT_READY) { + printf("Disk %s not ready\n", devname); + continue; + } + if (ret) { + printf("ERROR: failure to add disk device %s, r = %lu\n", + devname, ret & ~EFI_ERROR_MASK); + return ret; + } disks++; /* Partitions show up as block devices in EFI */ @@ -419,5 +436,5 @@ int efi_disk_register(void) #endif printf("Found %d disks\n", disks); - return 0; + return EFI_SUCCESS; } -- 2.14.2

2 1

Re: [U-Boot] TCP & Overrrun
by Duncan Hare 09 Feb '18

09 Feb '18

On Thu, 8 Feb 2018 22:15:44 +0000 (UTC) Duncan Hare <dh(a)synoia.com> wrote: > Duncan Hare > > 714 931 7952 > > > ----- Forwarded Message ----- > From: Joe Hershberger <joe.hershberger(a)ni.com> > To: Duncan Hare <dh(a)synoia.com> > Cc: u-boot <u-boot(a)lists.denx.de>; Joe Hershberger > <joe.hershberger(a)ni.com> Sent: Thursday, February 8, 2018 11:40 AM > Subject: Re: [U-Boot] TCP & Overrrun > > Hi Duncan, > > On Wed, Feb 7, 2018 at 8:40 PM, Duncan Hare <dh(a)synoia.com> wrote: > > I'm gettin overrun on the raspberry pi. > > > > Which ethernet drived does it use? > > You didn't specify which one you are talking about, but here's how to > find out... > > Assuming rpi3, find the config first... > > configs/rpi_3_defconfig says: > CONFIG_DEFAULT_DEVICE_TREE="bcm2837-rpi-3-b" > arch/arm/dts/bcm2837-rpi-3-b.dts says: #include > "bcm283x-rpi-smsc9514.dtsi" arch/arm/dts/bcm283x-rpi-smsc9514.dtsi > says: ethernet: usbether@1 { > compatible = "usb424,ec00"; grep -rn ec00 drivers/ says: > drivers/usb/eth/smsc95xx.c > > Cheers, > -Joe > > > I need to determine if it > > uses CONFIG_SYS_RX_ETH_BUFFER" from net.h and the "net_rx_packets" > > buffer pool defined in net/net.c > > > > grep suggests it is not using net_rx_packets. > > > > Thanks > > > > Duncan Hare > > _______________________________________________ > > U-Boot mailing list > > U-Boot(a)lists.denx.de > > https://lists.denx.de/listinfo/u-boot ___________________________________________________ Joe Two solutions: Option 1. drivers/usb/eth/smsc95xx.c pulls packet in from the device, single rx buffer, and runs the packet rx code in net.c. Assumption is packets are polled for, thus single rx buffer is acceptable. net_rx_packets exists, and can be use, if looking for rx packet call is called frequently though system. This would work for all existing drivers. net.c fills net_rx_packets and calls a routine to process packets, and and the tcp system system polls via smsc95xx_recv through the interface structure at places in the code to process fill net_rx_packets as a packet queue. A TCP window limits the number of packets in process. Option 2. The driver is changed to set an interrupt and the interrupt preempts the packet processing, as interrupts do. But, this requires driver changes to use TCP. And good hardware documentation.

2 1

[U-Boot] [PATCH v2 1/1] efi_loader: add missing runtime services stubs
by Heinrich Schuchardt 09 Feb '18

09 Feb '18

Add stubs for UpdateCapsule, QueryCapsuleCapabilities, and QueryVariableInfo. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- v2 add __efi_runtime --- include/efi_api.h | 28 +++++++++++++++++++++++++--- lib/efi_loader/efi_runtime.c | 29 +++++++++++++++++++++++++++++ 2 files changed, 54 insertions(+), 3 deletions(-) diff --git a/include/efi_api.h b/include/efi_api.h index 205f8f1f700..bc5bcd4a2b8 100644 --- a/include/efi_api.h +++ b/include/efi_api.h @@ -180,6 +180,17 @@ enum efi_reset_type { #define EFI_RUNTIME_SERVICES_SIGNATURE 0x5652453544e5552ULL #define EFI_RUNTIME_SERVICES_REVISION 0x00010000 +#define CAPSULE_FLAGS_PERSIST_ACROSS_RESET 0x00010000 +#define CAPSULE_FLAGS_POPULATE_SYSTEM_TABLE 0x00020000 +#define CAPSULE_FLAGS_INITIATE_RESET 0x00040000 + +struct efi_capsule_header { + efi_guid_t *capsule_guid; + u32 header_size; + u32 flags; + u32 capsule_image_size; +}; + struct efi_runtime_services { struct efi_table_hdr hdr; efi_status_t (EFIAPI *get_time)(struct efi_time *time, @@ -209,9 +220,20 @@ struct efi_runtime_services { void (EFIAPI *reset_system)(enum efi_reset_type reset_type, efi_status_t reset_status, unsigned long data_size, void *reset_data); - void *update_capsule; - void *query_capsule_caps; - void *query_variable_info; + efi_status_t (EFIAPI *update_capsule)( + struct efi_capsule_header **capsule_header_array, + efi_uintn_t capsule_count, + u64 scatter_gather_list); + efi_status_t (EFIAPI *query_capsule_caps)( + struct efi_capsule_header **capsule_header_array, + efi_uintn_t capsule_count, + u64 maximum_capsule_size, + u32 reset_type); + efi_status_t (EFIAPI *query_variable_info)( + u32 attributes, + u64 maximum_variable_storage_size, + u64 remaining_variable_storage_size, + u64 maximum_variable_size); }; /* EFI Configuration Table and GUID definitions */ diff --git a/lib/efi_loader/efi_runtime.c b/lib/efi_loader/efi_runtime.c index 8104e08c466..ccb4fc6141b 100644 --- a/lib/efi_loader/efi_runtime.c +++ b/lib/efi_loader/efi_runtime.c @@ -381,6 +381,32 @@ static efi_status_t __efi_runtime EFIAPI efi_invalid_parameter(void) return EFI_INVALID_PARAMETER; } +efi_status_t __efi_runtime EFIAPI efi_update_capsule( + struct efi_capsule_header **capsule_header_array, + efi_uintn_t capsule_count, + u64 scatter_gather_list) +{ + return EFI_UNSUPPORTED; +} + +efi_status_t __efi_runtime EFIAPI efi_query_capsule_caps( + struct efi_capsule_header **capsule_header_array, + efi_uintn_t capsule_count, + u64 maximum_capsule_size, + u32 reset_type) +{ + return EFI_UNSUPPORTED; +} + +efi_status_t __efi_runtime EFIAPI efi_query_variable_info( + u32 attributes, + u64 maximum_variable_storage_size, + u64 remaining_variable_storage_size, + u64 maximum_variable_size) +{ + return EFI_UNSUPPORTED; +} + struct efi_runtime_services __efi_runtime_data efi_runtime_services = { .hdr = { .signature = EFI_RUNTIME_SERVICES_SIGNATURE, @@ -398,4 +424,7 @@ struct efi_runtime_services __efi_runtime_data efi_runtime_services = { .set_variable = efi_set_variable, .get_next_high_mono_count = (void *)&efi_device_error, .reset_system = &efi_reset_system_boottime, + .update_capsule = efi_update_capsule, + .query_capsule_caps = efi_query_capsule_caps, + .query_variable_info = efi_query_variable_info, }; -- 2.14.2

1 0

[U-Boot] [PATCH 1/1][for v2018.03] efi_loader: correct efi_disk_register
by Heinrich Schuchardt 09 Feb '18

09 Feb '18

efi_disk_register should return as status code (efi_status_t). Disks with zero blocks should be reported as 'not ready' without throwing an error. This patch solves a problem running OpenBSD on system configured with CONFIG_BLK=n (e.g. i.MX6). Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- include/efi_loader.h | 2 +- lib/efi_loader/efi_disk.c | 71 ++++++++++++++++++++++++++++++----------------- 2 files changed, 46 insertions(+), 27 deletions(-) diff --git a/include/efi_loader.h b/include/efi_loader.h index 7caae97ea70..c70706955e6 100644 --- a/include/efi_loader.h +++ b/include/efi_loader.h @@ -173,7 +173,7 @@ extern struct list_head efi_obj_list; /* Called by bootefi to make console interface available */ int efi_console_register(void); /* Called by bootefi to make all disk storage accessible as EFI objects */ -int efi_disk_register(void); +efi_status_t efi_disk_register(void); /* Create handles and protocols for the partitions of a block device */ int efi_disk_create_partitions(efi_handle_t parent, struct blk_desc *desc, const char *if_typename, int diskid, diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c index ac39a65ee89..a33c819a8cc 100644 --- a/lib/efi_loader/efi_disk.c +++ b/lib/efi_loader/efi_disk.c @@ -226,25 +226,26 @@ efi_fs_from_path(struct efi_device_path *full_path) * @offset offset into disk for simple partitions * @return disk object */ -static struct efi_disk_obj *efi_disk_add_dev( +static efi_status_t efi_disk_add_dev( efi_handle_t parent, struct efi_device_path *dp_parent, const char *if_typename, struct blk_desc *desc, int dev_index, lbaint_t offset, - unsigned int part) + unsigned int part, + struct efi_disk_obj **disk) { struct efi_disk_obj *diskobj; efi_status_t ret; /* Don't add empty devices */ if (!desc->lba) - return NULL; + return EFI_NOT_READY; diskobj = calloc(1, sizeof(*diskobj)); if (!diskobj) - goto out_of_memory; + return EFI_OUT_OF_RESOURCES; /* Hook up to the device list */ efi_add_handle(&diskobj->parent); @@ -262,11 +263,11 @@ static struct efi_disk_obj *efi_disk_add_dev( ret = efi_add_protocol(diskobj->parent.handle, &efi_block_io_guid, &diskobj->ops); if (ret != EFI_SUCCESS) - goto out_of_memory; + return ret; ret = efi_add_protocol(diskobj->parent.handle, &efi_guid_device_path, diskobj->dp); if (ret != EFI_SUCCESS) - goto out_of_memory; + return ret; if (part >= 1) { diskobj->volume = efi_simple_file_system(desc, part, diskobj->dp); @@ -274,7 +275,7 @@ static struct efi_disk_obj *efi_disk_add_dev( &efi_simple_file_system_protocol_guid, diskobj->volume); if (ret != EFI_SUCCESS) - goto out_of_memory; + return ret; } diskobj->ops = block_io_disk_template; diskobj->ifname = if_typename; @@ -291,10 +292,9 @@ static struct efi_disk_obj *efi_disk_add_dev( if (part != 0) diskobj->media.logical_partition = 1; diskobj->ops.media = &diskobj->media; - return diskobj; -out_of_memory: - printf("ERROR: Out of memory\n"); - return NULL; + if (disk) + *disk = diskobj; + return EFI_SUCCESS; } /* @@ -330,8 +330,12 @@ int efi_disk_create_partitions(efi_handle_t parent, struct blk_desc *desc, continue; snprintf(devname, sizeof(devname), "%s:%d", pdevname, part); - efi_disk_add_dev(parent, dp, if_typename, desc, diskid, - info.start, part); + ret = efi_disk_add_dev(parent, dp, if_typename, desc, diskid, + info.start, part, NULL); + if (ret != EFI_SUCCESS) { + printf("Adding partition %s failed\n", pdevname); + continue; + } disks++; } @@ -349,26 +353,32 @@ int efi_disk_create_partitions(efi_handle_t parent, struct blk_desc *desc, * * This gets called from do_bootefi_exec(). */ -int efi_disk_register(void) +efi_status_t efi_disk_register(void) { struct efi_disk_obj *disk; int disks = 0; + efi_status_t ret; #ifdef CONFIG_BLK struct udevice *dev; - for (uclass_first_device_check(UCLASS_BLK, &dev); - dev; + for (uclass_first_device_check(UCLASS_BLK, &dev); dev; uclass_next_device_check(&dev)) { struct blk_desc *desc = dev_get_uclass_platdata(dev); const char *if_typename = blk_get_if_type_name(desc->if_type); - printf("Scanning disk %s...\n", dev->name); - /* Add block device for the full device */ - disk = efi_disk_add_dev(NULL, NULL, if_typename, - desc, desc->devnum, 0, 0); - if (!disk) - return -ENOMEM; + printf("Scanning disk %s...\n", dev->name); + ret = efi_disk_add_dev(NULL, NULL, if_typename, + desc, desc->devnum, 0, 0, &disk); + if (ret == EFI_NOT_READY) { + printf("Disk %s not ready\n", dev->name); + continue; + } + if (ret) { + printf("ERROR: failure to add disk device %s, r = %lu\n", + dev->name, ret & ~EFI_ERROR_MASK); + return ret; + } disks++; /* Partitions show up as block devices in EFI */ @@ -404,10 +414,19 @@ int efi_disk_register(void) if_typename, i); /* Add block device for the full device */ - disk = efi_disk_add_dev(NULL, NULL, if_typename, desc, - i, 0, 0); + ret = efi_disk_add_dev(NULL, NULL, if_typename, desc, + i, 0, 0, &disk); if (!disk) - return -ENOMEM; + continue; + if (ret == EFI_NOT_READY) { + printf("Disk %s not ready\n", devname); + continue; + } + if (ret) { + printf("ERROR: failure to add disk device %s, r = %lu\n", + devname, ret & ~EFI_ERROR_MASK); + return ret; + } disks++; /* Partitions show up as block devices in EFI */ @@ -419,5 +438,5 @@ int efi_disk_register(void) #endif printf("Found %d disks\n", disks); - return 0; + return EFI_SUCCESS; } -- 2.14.2

2 1

[U-Boot] [PATCH 1/1] efi_loader: add missing runtime services stubs
by Heinrich Schuchardt 09 Feb '18

09 Feb '18

Add stubs for UpdateCapsule, QueryCapsuleCapabilities, and QueryVariableInfo. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- include/efi_api.h | 28 +++++++++++++++++++++++++--- lib/efi_loader/efi_runtime.c | 29 +++++++++++++++++++++++++++++ 2 files changed, 54 insertions(+), 3 deletions(-) diff --git a/include/efi_api.h b/include/efi_api.h index 81e2fd204e..ec4ce8bd3a 100644 --- a/include/efi_api.h +++ b/include/efi_api.h @@ -181,6 +181,17 @@ enum efi_reset_type { #define EFI_RUNTIME_SERVICES_SIGNATURE 0x5652453544e5552ULL #define EFI_RUNTIME_SERVICES_REVISION 0x00010000 +#define CAPSULE_FLAGS_PERSIST_ACROSS_RESET 0x00010000 +#define CAPSULE_FLAGS_POPULATE_SYSTEM_TABLE 0x00020000 +#define CAPSULE_FLAGS_INITIATE_RESET 0x00040000 + +struct efi_capsule_header { + efi_guid_t *capsule_guid; + u32 header_size; + u32 flags; + u32 capsule_image_size; +}; + struct efi_runtime_services { struct efi_table_hdr hdr; efi_status_t (EFIAPI *get_time)(struct efi_time *time, @@ -210,9 +221,20 @@ struct efi_runtime_services { void (EFIAPI *reset_system)(enum efi_reset_type reset_type, efi_status_t reset_status, unsigned long data_size, void *reset_data); - void *update_capsule; - void *query_capsule_caps; - void *query_variable_info; + efi_status_t (EFIAPI *update_capsule)( + struct efi_capsule_header **capsule_header_array, + efi_uintn_t capsule_count, + u64 scatter_gather_list); + efi_status_t (EFIAPI *query_capsule_caps)( + struct efi_capsule_header **capsule_header_array, + efi_uintn_t capsule_count, + u64 maximum_capsule_size, + u32 reset_type); + efi_status_t (EFIAPI *query_variable_info)( + u32 attributes, + u64 maximum_variable_storage_size, + u64 remaining_variable_storage_size, + u64 maximum_variable_size); }; /* EFI Configuration Table and GUID definitions */ diff --git a/lib/efi_loader/efi_runtime.c b/lib/efi_loader/efi_runtime.c index 471ac29d60..d7c2c1e430 100644 --- a/lib/efi_loader/efi_runtime.c +++ b/lib/efi_loader/efi_runtime.c @@ -382,6 +382,32 @@ static efi_status_t __efi_runtime EFIAPI efi_invalid_parameter(void) return EFI_INVALID_PARAMETER; } +efi_status_t EFIAPI efi_update_capsule( + struct efi_capsule_header **capsule_header_array, + efi_uintn_t capsule_count, + u64 scatter_gather_list) +{ + return EFI_UNSUPPORTED; +} + +efi_status_t EFIAPI efi_query_capsule_caps( + struct efi_capsule_header **capsule_header_array, + efi_uintn_t capsule_count, + u64 maximum_capsule_size, + u32 reset_type) +{ + return EFI_UNSUPPORTED; +} + +efi_status_t EFIAPI efi_query_variable_info( + u32 attributes, + u64 maximum_variable_storage_size, + u64 remaining_variable_storage_size, + u64 maximum_variable_size) +{ + return EFI_UNSUPPORTED; +} + struct efi_runtime_services __efi_runtime_data efi_runtime_services = { .hdr = { .signature = EFI_RUNTIME_SERVICES_SIGNATURE, @@ -399,4 +425,7 @@ struct efi_runtime_services __efi_runtime_data efi_runtime_services = { .set_variable = efi_set_variable, .get_next_high_mono_count = (void *)&efi_device_error, .reset_system = &efi_reset_system_boottime, + .update_capsule = efi_update_capsule, + .query_capsule_caps = efi_query_capsule_caps, + .query_variable_info = efi_query_variable_info, }; -- 2.15.1

2 1

[U-Boot] [PATCH v3 00/18] efi_loader: enable EFI driver provided block device
by Heinrich Schuchardt 09 Feb '18

09 Feb '18

With this patch series an EFI application or driver can supply a block device which in turn can be used to download an image. E.g. we can load iPXE, connect iSCSI drives, download grub from the SAN and afterwards with grub download and run an EFI application. Booting Linux from an iSCSI drive was successful on arm64. v3: Provide two separate test cases for StartImage. Initialize EFI driver uclass from bootefi command. Add check_tpl parameter to efi_signal_event. Remove accepted patch for file2include. v2: Add an additional patch to fix ExitBootServices. Provide comments for EFI block driver. Avoid printing when not in debug mode Add product tools/file2include to .gitignore. Put the patch with the test for block io after the patch for the driver. Heinrich Schuchardt (18): efi_loader: return NULL from device path functions efi_loader: address of the simple file system protocol efi_loader: correct find simple file system protocol efi_loader: print device path when entering efi_load_image efi_loader: allocate correct memory type for EFI image efi_loader: check tables in helloworld.efi efi_loader: fix StartImage bootservice efi_loader: efi_disk_register: correctly determine if_type_name efi_loader: make efi_block_io_guid a global symbol efi_loader: provide a function to create a partition node efi_loader: make efi_disk_create_partitions a global symbol efi_loader: correct EFI_BLOCK_IO_PROTOCOL definitions efi_loader: provide function to get last node of a device path efi_loader: provide link between devices and EFI handles efi_loader: add check_tpl parameter to efi_signal_event efi_loader: fix ExitBootServices efi_driver: EFI block driver efi_selftest: provide a test for block io cmd/bootefi.c | 3 + drivers/block/blk-uclass.c | 4 +- include/blk.h | 1 + include/config_fallbacks.h | 1 + include/dm/uclass-id.h | 1 + include/efi_api.h | 18 +- include/efi_driver.h | 30 ++ include/efi_loader.h | 23 +- lib/Makefile | 1 + lib/efi_driver/Makefile | 13 + lib/efi_driver/efi_block_device.c | 175 ++++++++++++ lib/efi_driver/efi_uclass.c | 330 ++++++++++++++++++++++ lib/efi_loader/efi_boottime.c | 55 +++- lib/efi_loader/efi_console.c | 14 +- lib/efi_loader/efi_device_path.c | 168 +++++++++--- lib/efi_loader/efi_disk.c | 137 +++++++--- lib/efi_loader/efi_image_loader.c | 64 +++-- lib/efi_loader/helloworld.c | 26 ++ lib/efi_selftest/Makefile | 4 + lib/efi_selftest/efi_selftest_block_device.c | 395 +++++++++++++++++++++++++++ lib/efi_selftest/efi_selftest_disk_image.h | 69 +++++ 21 files changed, 1398 insertions(+), 134 deletions(-) create mode 100644 include/efi_driver.h create mode 100644 lib/efi_driver/Makefile create mode 100644 lib/efi_driver/efi_block_device.c create mode 100644 lib/efi_driver/efi_uclass.c create mode 100644 lib/efi_selftest/efi_selftest_block_device.c create mode 100644 lib/efi_selftest/efi_selftest_disk_image.h -- 2.14.2

4 26

[U-Boot] Allwinner H5 builds broken in master
by Andre Przywara 09 Feb '18

09 Feb '18

Hi, while testing the EMAC DT series yesterday, I realised that the current HEAD fails to build some H5 boards, due to breaking our infamous size limit: nanopi_neo_plus2: u-boot.itb exceeds file size limit: limit: 516096 bytes actual: 516188 bytes excess: 92 bytes orangepi_pc2: u-boot.itb exceeds file size limit: limit: 516096 bytes actual: 516120 bytes excess: 24 bytes orangepi_zero_plus2: u-boot.itb exceeds file size limit: limit: 516096 bytes actual: 516560 bytes excess: 464 bytes As you can see it's not much, but it gets slightly worse with the new EMAC bindings. I will try to shave a KB or so off tonight, but if anyone has ideas meanwhile, I am all ears. Cheers, Andre

2 1

Re: [U-Boot] [PATCH v2 4/9] mmc: reworked version lookup in mmc_startup_v4
by Jean-Jacques Hiblot 09 Feb '18

09 Feb '18

Hi Heribert, you're right I messed up with the indexes. Thanks for catching it. Next time you find something, please reply to all. It will help the maintainer, in this case Jaehoon. Jaheoon, The problem is that a version is missing in the table mmc_versions[] and it results in a shift of the indexes for all versions above or equal to MMC_VERSION_4_41. I'll send a patch that fixes it this way: static const u32 mmc_versions[] = { MMC_VERSION_4, MMC_VERSION_4_1, MMC_VERSION_4_2, MMC_VERSION_4_3, + MMC_VERSION_4_4, MMC_VERSION_4_41, MMC_VERSION_4_5, MMC_VERSION_5_0, MMC_VERSION_5_1 }; JJ On 09/02/2018 08:06, eil Eilmsteiner Heribert wrote: > Hello Jean-Jacques > > I have problems with your patch for u-boot. I lacks a table-entry for "4", so every mmc higher than version 4.3 report a version "off by 1" > The range check is also "off by 1", (it should be a >=), so (as in my case) MMC version 5.1 reports OK and complete nonsense (in my case this was lower than version 4.0 so it didn't work). > > if (ext_csd[EXT_CSD_REV] >= ARRAY_SIZE(mmc_versions)) > return -EINVAL; > > Freundliche Grüße/Best regards > Heribert Eilmsteiner > Senior Software Engineer > Development Center > > KEBA AG > A-4041 Linz, Austria > Gewerbepark Urfahr > Phone: +43 732 7090-27423 > Fax: +43 732 7090-61711 > Firmenbuchgericht Linz FN 184376 t > mailto:eil@keba.com > http://www.keba.com > > > > >

2 1

[U-Boot] [PATCH v6 00/25] Fix and extend i.MX HAB layer
by Bryan O'Donoghue 09 Feb '18

09 Feb '18

v6: - Added patch 21/25 return zero on open (unlocked) board when calling authenticate_image() - Breno - Added Tested-by: Breno Matheus Lima <brenomatheus(a)gmail.com> as indicated for remainder 24/25 patches - Added Reviewed-by: Fabio Estevam <fabio.estevam(a)nxp.com> as indicated for remainder 24/25 patches v5: - Drop dcache disable across HAB call. We can't replicate this error on the current codebase and the available images. We'll have to wait for the error to crop up again before pushing that patch any further. v4: - No change mixed extra patches @ v3 unnoticed with previous git-send v3: - Only call into ROM if headers are verified. - Bryan - Print HAB event log if and only if a call was made to HAB and a meaningful status code has been obtained. - Breno v2: - Fix compilation warnings and errors in SPL highlighted by Breno Matheus Lima - Add CC: Breno Matheus Lima <brenomatheus(a)gmail.com> to all patches v1: This patchset updates the i.MX HAB layer in u-boot to fix a list of identified issues and then to add and extend existing functionality. The first block of patches 0001-0006 deal with fixing existing code, - Fixes indentation - Fixes the treatment of input parameters to hab_auth_image. The second block of patches 0007-0013 are about tidying up the HAB code - Remove reliance on hard-coding to specific offsets - IVT header drives locating CSF - Continue to support existing boards Patches 0014 onwards extend out the HAB functionality. - hab_rvt_check_target is a recommended check in the NXP documents to perform prior to hab_rvt_authenticate_image - hab_rvt_failsafe is a useful function to set the board into BootROM USB recovery mode. Bryan O'Donoghue (25): arm: imx: hab: Make authenticate_image return int arm: imx: hab: Fix authenticate_image result code arm: imx: hab: Optimise flow of authenticate_image on is_enabled fail arm: imx: hab: Optimise flow of authenticate_image on hab_entry fail arm: imx: hab: Move IVT_SIZE to hab.h arm: imx: hab: Move CSF_PAD_SIZE to hab.h arm: imx: hab: Fix authenticate_image input parameters arm: imx: hab: Add IVT header definitions arm: imx: hab: Add IVT header verification arm: imx: hab: Verify IVT self matches calculated address arm: imx: hab: Only call ROM once headers are verified arm: imx: hab: Print CSF based on IVT descriptor arm: imx: hab: Print additional IVT elements during debug arm: imx: hab: Define rvt_check_target() arm: imx: hab: Implement hab_rvt_check_target arm: imx: hab: Add a hab_rvt_check_target to image auth arm: imx: hab: Print HAB event log only after calling ROM arm: imx: hab: Make internal functions and data static arm: imx: hab: Prefix authenticate_image with imx_hab arm: imx: hab: Rename is_hab_enabled imx_hab_is_enabled arm: imx: hab: Make authenticate_image() return zero on open boards arm: imx: hab: Make imx_hab_is_enabled global arm: imx: hab: Define rvt_failsafe() arm: imx: hab: Implement hab_rvt_failsafe arm: imx: hab: Add hab_failsafe console command arch/arm/include/asm/mach-imx/hab.h | 46 +++- arch/arm/mach-imx/hab.c | 461 +++++++++++++++++++++--------------- arch/arm/mach-imx/spl.c | 38 ++- 3 files changed, 354 insertions(+), 191 deletions(-) -- 2.7.4

4 33

[U-Boot] [PATCH 0/5] STM32: Clean unused and factorize .h files in arch-stm32
by patrice.chotard＠st.com 09 Feb '18

09 Feb '18

From: Patrice Chotard <patrice.chotard(a)st.com> Removes unused .h files in arch/arm/include/asm/arch-stm32xx Factorize and clean some .h files to avoid to duplicate defines in separate .h files Patrice Chotard (5): arch-stm32f4: Remove fmc.h file arch-stm32: Move gpio.h for STM32 SoCs in include/asm/ arch-stm32: Factorize stm32.h for STM32F4 and F7 arch-stm32: Remove stm32_periph.h arch-stm32: Clean arch-stm32f7/syscfg.h arch/arm/include/asm/arch-stm32f4/fmc.h | 75 ------------ arch/arm/include/asm/arch-stm32f4/gpio.h | 146 +---------------------- arch/arm/include/asm/arch-stm32f4/stm32.h | 14 +-- arch/arm/include/asm/arch-stm32f4/stm32_periph.h | 38 ------ arch/arm/include/asm/arch-stm32f7/gpio.h | 116 +----------------- arch/arm/include/asm/arch-stm32f7/stm32.h | 45 +------ arch/arm/include/asm/arch-stm32f7/stm32_periph.h | 23 ---- arch/arm/include/asm/arch-stm32f7/syscfg.h | 9 -- arch/arm/include/asm/arch-stm32h7/gpio.h | 115 +----------------- arch/arm/include/asm/stm32_gpio.h | 115 ++++++++++++++++++ arch/arm/include/asm/stm32f.h | 22 ++++ board/st/stm32f746-disco/stm32f746-disco.c | 1 - drivers/mtd/stm32_flash.c | 2 +- 13 files changed, 144 insertions(+), 577 deletions(-) delete mode 100644 arch/arm/include/asm/arch-stm32f4/fmc.h delete mode 100644 arch/arm/include/asm/arch-stm32f4/stm32_periph.h delete mode 100644 arch/arm/include/asm/arch-stm32f7/stm32_periph.h create mode 100644 arch/arm/include/asm/stm32_gpio.h create mode 100644 arch/arm/include/asm/stm32f.h -- 1.9.1

3 10