October 2018 - U-Boot

[U-Boot] Compile error with CONFIG_MULTI_DTB_FIT and not SPL
by Lars Povlsen 23 Oct '18

23 Oct '18

When changing some MIPS configs from CONFIG_OF_EMBED to CONFIG_OF_SEPARATE, I ran into this compile issue since SPL is not enabled. The fix is to guard the <spl.h> header with the CONFIG_SPL_LIBCOMMON_SUPPORT preprocessor symbol. It seems that the <spl.h> is not needed even when SPL is enabled, but I'm not 100% sure on that. The code at lines 55..57 guarded by CONFIG_SPL_LIBCOMMON_SUPPORT does not require the <spl.h> header file. Signed-off-by: Lars Povlsen <lars.povlsen(a)microsemi.com> --- common/common_fit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/common_fit.c b/common/common_fit.c index 577b352..33e26cc 100644 --- a/common/common_fit.c +++ b/common/common_fit.c @@ -8,7 +8,9 @@ #include <errno.h> #include <image.h> #include <linux/libfdt.h> +#ifdef CONFIG_SPL_LIBCOMMON_SUPPORT #include <spl.h> +#endif ulong fdt_getprop_u32(const void *fdt, int node, const char *prop) { -- 2.7.4

3 2

[U-Boot] [U-Boot, BUG] snow: mmc: SD card access broken: unable to select a mode
by Paweł Jarosz 23 Oct '18

23 Oct '18

Hi Guillaume, <https://patchwork.ozlabs.org/project/uboot/list/?submitter=64683> Could you test this patch: https://patchwork.ozlabs.org/patch/986180/ and tell me how it goes? Cheers Paweł

2 1

Re: [U-Boot] [PATCH 19/30] riscv: fix inconsistent use of spaces and tabs in start.S
by Rick Chen 23 Oct '18

23 Oct '18

> > > Start.S uses both tabs and spaces after instructions. Fix this by only > > > > nits: start.S > > > > > using tabs after instructions. > > > > > > Signed-off-by: Lukas Auer <lukas.auer(a)aisec.fraunhofer.de> > > > --- > > > > > > arch/riscv/cpu/start.S | 322 > > > ++++++++++++++++++++--------------------- > > > 1 file changed, 161 insertions(+), 161 deletions(-) > > > > > > > Reviewed-by: Bin Meng <bmeng.cn(a)gmail.com> Reviewed-by: Rick Chen <rick(a)andestech.com> > > > > Regards, > > Bin

1 0

Re: [U-Boot] [PATCH 17/30] riscv: implement the invalidate_icache_* functions
by Rick Chen 23 Oct '18

23 Oct '18

> > > Implement the functions invalidate_icache_range() and > > > invalidate_icache_all(). > > > > > > RISC-V does not have instructions for explicit cache-control. The > > > functions in this patch are implemented with the memory ordering > > > instruction for synchronizing the instruction and data streams. This > > > may be implemented as a cache flush or invalidate on simple > > > processors, others may only invalidate the relevant cache lines. > > > > > > Signed-off-by: Lukas Auer <lukas.auer(a)aisec.fraunhofer.de> > > > --- > > > > > > arch/riscv/lib/cache.c | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > > Reviewed-by: Bin Meng <bmeng.cn(a)gmail.com> Reviewed-by: Rick Chen <rick(a)andestech.com>

1 0

Re: [U-Boot] [PATCH 16/30] riscv: hang on unhandled exceptions
by Rick Chen 23 Oct '18

23 Oct '18

> > > Hang on unhandled exceptions to prevent execution in a faulty state. > > > > > > Signed-off-by: Lukas Auer <lukas.auer(a)aisec.fraunhofer.de> > > > --- > > > > > > arch/riscv/lib/interrupts.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > > Reviewed-by: Bin Meng <bmeng.cn(a)gmail.com> Reviewed-by: Rick Chen <rick(a)andestech.com>

1 0

Re: [U-Boot] [PATCH 15/30] riscv: treat undefined exception codes as reserved
by Rick Chen 23 Oct '18

23 Oct '18

> > > Undefined exception codes currently lead to an out-of-bounds array > > > access. Prevent this by treating undefined exception codes as > > > "reserved". > > > > > > Signed-off-by: Lukas Auer <lukas.auer(a)aisec.fraunhofer.de> > > > --- > > > > > > arch/riscv/lib/interrupts.c | 8 ++++++-- > > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > > > > Reviewed-by: Bin Meng <bmeng.cn(a)gmail.com> Reviewed-by: Rick Chen <rick(a)andestech.com>

1 0

Re: [U-Boot] [PATCH 14/30] riscv: complete the list of exception codes
by Rick Chen 23 Oct '18

23 Oct '18

> > > Only the first four exception codes are defined. Add the missing > > > exception codes from the definition in RISC-V Privileged Architecture > > > Version 1.10. > > > > > > Signed-off-by: Lukas Auer <lukas.auer(a)aisec.fraunhofer.de> > > > --- > > > > > > arch/riscv/lib/interrupts.c | 13 ++++++++++++- > > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > > > > Reviewed-by: Bin Meng <bmeng.cn(a)gmail.com> Reviewed-by: Rick Chen <rick(a)andestech.com>

1 0

Re: [U-Boot] [PATCH 13/30] riscv: do not reimplement generic io functions
by Rick Chen 23 Oct '18

23 Oct '18

> > Hi Lukas, > > > > On Sat, Oct 20, 2018 at 6:10 AM Lukas Auer <lukas.auer(a)aisec.fraunhofer.de> > > wrote: > > > > > > RISC-V u-boot reimplements the generic io functions from > > > > nits: U-Boot > > > > > asm-generic/io.h. Remove the redundant implementation and include the > > > generic io.h instead. > > > > > > Signed-off-by: Lukas Auer <lukas.auer(a)aisec.fraunhofer.de> > > > --- > > > > > > arch/riscv/include/asm/io.h | 31 +++---------------------------- > > > 1 file changed, 3 insertions(+), 28 deletions(-) > > > > > > > Reviewed-by: Bin Meng <bmeng.cn(a)gmail.com> Reviewed-by: Rick Chen <rick(a)andestech.com> > > > > Regards, > > Bin

1 0

Re: [U-Boot] [PATCH 12/30] riscv: make use of the barrier functions from Linux
by Rick Chen 23 Oct '18

23 Oct '18

> > Hi Lukas, > > > > On Sat, Oct 20, 2018 at 6:10 AM Lukas Auer <lukas.auer(a)aisec.fraunhofer.de> > > wrote: > > > > > > Replace the barrier functions in arch/riscv/include/asm/io.h with > > > those defined in barrier.h, which is imported from Linux. This version > > > is modified to remove the include statement of asm-generic/barrier.h, > > > which is not available in u-boot or required. > > > > nits: U-Boot > > > > > > > > Signed-off-by: Lukas Auer <lukas.auer(a)aisec.fraunhofer.de> > > > --- > > > Checkpatch reports style errors in barrier.h. I did not fix them, > > > because I imported the file from Linux. Is that the correct way to > > > handle this? > > > > > > > I think this is OK. > > > > > arch/riscv/include/asm/barrier.h | 67 ++++++++++++++++++++++++++++++++ > > > arch/riscv/include/asm/io.h | 11 ++---- > > > 2 files changed, 71 insertions(+), 7 deletions(-) create mode 100644 > > > arch/riscv/include/asm/barrier.h > > > > > > > Reviewed-by: Bin Meng <bmeng.cn(a)gmail.com> Reviewed-by: Rick Chen <rick(a)andestech.com> > > > > Regards, > > Bin

1 0

[U-Boot] [PATCH 0/6] efi: make efi and bootmgr more usable
by AKASHI Takahiro 23 Oct '18

23 Oct '18

This patch set is a collection of patches to enhance efi user interfaces /commands. It will help improve user experience on efi boot and make it more usable without edk2's shell utility. Patch#1 to #4 are for efishell. Patch#5 and #6 are for bootmgr. Let's see how it works: => efishell boot add 1 SHELL mmc 0:1 /Shell.efi "" => efishell boot add 2 HELLO mmc 0:1 /hello.efi "" => efishell boot dump Boot0001: attributes: A-- (0x00000001) label: SHELL file_path: /VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/SD(0)/SD(0)/HD(1,MBR,0x086246ba,0x800,0x40000)/\\Shell.efi data: Boot0002: attributes: A-- (0x00000001) label: HELLO file_path: /VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/SD(0)/SD(0)/HD(1,MBR,0x086246ba,0x800,0x40000)/\\hello.efi data: => efishell boot order 1 2 => efishell boot order 1: Boot0001: SHELL 2: Boot0002: HELLO => bootefi bootmgr -2 WARNING: booting without device tree Booting: HELLO ## Starting EFI application at 000000007db8b040 ... Hello, world! ## Application terminated, r = 0 => efishell setvar PlatformLang en <--- important! => efishell bootmgr -1 or efishell bootmgr (shell ...) # The only drawback is that it can be confusing to type "bootefi ..." and "efi(shell) boot ..." :) Enjoy! -Takahiro Akashi AKASHI Takahiro (6): fs: update fs_dev_part in fs_set_blk_dev_with_part() efi_loader: add efi_dp_from_name() efi_loader: bootmgr: add load option helper functions cmd: add efishell command bootefi: carve out fdt parameter handling efi_loader: bootmgr: run an EFI application of a given load option cmd/Makefile | 2 +- cmd/bootefi.c | 112 +++---- cmd/efishell.c | 531 +++++++++++++++++++++++++++++++ fs/fs.c | 1 + include/efi_loader.h | 32 +- lib/efi_loader/efi_bootmgr.c | 76 +++-- lib/efi_loader/efi_device_path.c | 47 +++ 7 files changed, 721 insertions(+), 80 deletions(-) create mode 100644 cmd/efishell.c -- 2.19.0

3 21