October 2018 - U-Boot

[U-Boot] [PATCH] core: ofnode: Fix mem leak in error path
by Mario Six 15 Oct '18

15 Oct '18

A newly created property is currently not freed if a name could not be allocated. This patch fixes the resulting memory leak in the error patch. Reported-by: Coverity (CID: 184085) Fixes: e369e58df79c ("core: Add functions to set properties in live-tree") Signed-off-by: Mario Six <mario.six(a)gdsys.cc> --- drivers/core/ofnode.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/core/ofnode.c b/drivers/core/ofnode.c index 1e354803b0..5182eb7149 100644 --- a/drivers/core/ofnode.c +++ b/drivers/core/ofnode.c @@ -825,8 +825,10 @@ int ofnode_write_prop(ofnode node, const char *propname, int len, return -ENOMEM; new->name = strdup(propname); - if (!new->name) + if (!new->name) { + free(new); return -ENOMEM; + } new->value = (void *)value; new->length = len; -- 2.16.4

2 1

[U-Boot] [PATCH v2] socfpga: clean up sfp generation
by Dalon Westergreen 15 Oct '18

15 Oct '18

From: Dalon Westergreen <dalon.westergreen(a)intel.com> Move the sfp file generation entirely to the root Makefile. This means that the u-boot-spl.sfp will only be generated when required and only for the socfpga variants that require it. sfp generation is now entirely controlled by CONFIG_BUILD_TARGET being set to either spl/u-boot-spl.sfp or more likely u-boot-with-spl.sfp Signed-off-by: Dalon Westergreen <dalon.westergreen(a)intel.com> --- v2: -> condense changes to 1 patch to avoid breaking git bisect --- Makefile | 11 ++++++++--- scripts/Makefile.spl | 12 ------------ 2 files changed, 8 insertions(+), 15 deletions(-) diff --git a/Makefile b/Makefile index aadd1ec8c6..16ce14d071 100644 --- a/Makefile +++ b/Makefile @@ -1207,6 +1207,14 @@ u-boot.spr: spl/u-boot-spl.img u-boot.img FORCE $(call if_changed,pad_cat) ifneq ($(CONFIG_ARCH_SOCFPGA),) +ifdef CONFIG_TARGET_SOCFPGA_ARRIA10 +MKIMAGEFLAGS_$(SPL_BIN).sfp = -T socfpgaimage_v1 +else +MKIMAGEFLAGS_$(SPL_BIN).sfp = -T socfpgaimage +endif +spl/u-boot-spl.sfp: spl/u-boot-spl.bin FORCE + $(call if_changed,mkimage) + quiet_cmd_socboot = SOCBOOT $@ cmd_socboot = cat spl/u-boot-spl.sfp spl/u-boot-spl.sfp \ spl/u-boot-spl.sfp spl/u-boot-spl.sfp \ @@ -1542,9 +1550,6 @@ spl/sunxi-spl.bin: spl/u-boot-spl spl/sunxi-spl-with-ecc.bin: spl/sunxi-spl.bin @: -spl/u-boot-spl.sfp: spl/u-boot-spl - @: - spl/boot.bin: spl/u-boot-spl @: diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl index 7416abec62..a58113cee2 100644 --- a/scripts/Makefile.spl +++ b/scripts/Makefile.spl @@ -198,10 +198,6 @@ ifdef CONFIG_SAMSUNG ALL-y += $(obj)/$(BOARD)-spl.bin endif -ifdef CONFIG_ARCH_SOCFPGA -ALL-y += $(obj)/$(SPL_BIN).sfp -endif - ifdef CONFIG_ARCH_SUNXI ALL-y += $(obj)/sunxi-spl.bin @@ -324,14 +320,6 @@ LDFLAGS_$(SPL_BIN) += -Ttext $(CONFIG_SPL_TEXT_BASE) endif endif -ifdef CONFIG_TARGET_SOCFPGA_ARRIA10 -MKIMAGEFLAGS_$(SPL_BIN).sfp = -T socfpgaimage_v1 -else -MKIMAGEFLAGS_$(SPL_BIN).sfp = -T socfpgaimage -endif -$(obj)/$(SPL_BIN).sfp: $(obj)/$(SPL_BIN).bin FORCE - $(call if_changed,mkimage) - quiet_cmd_mksunxiboot = MKSUNXI $@ cmd_mksunxiboot = $(objtree)/tools/mksunxiboot \ --default-dt $(CONFIG_DEFAULT_DEVICE_TREE) $< $@ -- 2.17.2

3 3

[U-Boot] Please pull ARC changes (fixed re-send)
by Alexey Brodkin 15 Oct '18

15 Oct '18

Hi Tom, This pull-request overrides the one sent last Friday: https://lists.denx.de/pipermail/u-boot/2018-October/344211.html as well as its duplicate sent for some reason today: https://lists.denx.de/pipermail/u-boot/2018-October/344435.html The following changes since commit 3d5ced9e22d32112a20f9dc0f5fb1f22ef088079: Merge tag 'dm-9oct18' of git://git.denx.de/u-boot-dm (2018-10-10 13:35:17 -0400) are available in the Git repository at: git://git.denx.de/u-boot-arc.git tags/arc-more-updates-for-2018.11-rc2-2 for you to fetch changes up to 6e63314f432d32d2ce12a51dafa78129e81fe9cf: ARC: Don't use COMMON section for global not-initialized variables (2018-10-15 13:35:17 +0300) ---------------------------------------------------------------- More fixes and improvements for ARC here: Fixes (this time included for real): * Take care of global uninitialized variables They used to be put right after .bss section and were never zeroed as they should be. Now merged with normal .bss Improvements: * Print more verbose CPU info for boards built on real silicon * Add support for SD-card detection on all ARC boards * Quite a few fixes for IoT DK - Support reset by command - Print of CPU freq on boot - Link for eFlash etc ---------------------------------------------------------------- Alexey Brodkin (10): iot_dk: Add localversion string iot_dk: Disable networking support ARC: make generic print_cpuinfo() weak iot_dk/hsdk: Implement its own print_cpuinfo() iot_dk: Implement board reset iot_dk: Add support of 136 MHz clock iot_dk: Save CPU clock value to gd->cpu_clk axs10x/emdk/hsdk/iot_dk: Implement board_mmc_getcd() iot_dk: Link for eFlash ARC: Don't use COMMON section for global not-initialized variables arch/arc/config.mk | 2 +- arch/arc/lib/cpu.c | 2 +- board/synopsys/axs10x/axs10x.c | 7 +++++++ board/synopsys/emdk/emdk.c | 7 +++++++ board/synopsys/hsdk/hsdk.c | 15 +++++++++++++++ board/synopsys/iot_devkit/iot_devkit.c | 43 ++++++++++++++++++++++++++++++++++++++----- configs/iot_devkit_defconfig | 5 +++-- 7 files changed, 72 insertions(+), 9 deletions(-) -Alexey

2 1

[U-Boot] Pull request: u-boot-sunxi/master
by Jagan Teki 15 Oct '18

15 Oct '18

Hi Tom, Please pull this PR. thanks, Jagan. The following changes since commit 0a60a81ba3860946551cb79aa6486aa076e357f3: Kconfig: sandbox: enable cmd_avb and dependencies (2018-10-07 13:34:19 -0400) are available in the Git repository at: git://git.denx.de/u-boot-sunxi.git sunxi for you to fetch changes up to 90de3969be48924114f2d725923e12f32bf7796e: sunxi: fix DRAM gate/reset sequence of H6 (2018-10-10 12:04:07 +0530) ---------------------------------------------------------------- Icenowy Zheng (1): sunxi: fix DRAM gate/reset sequence of H6 arch/arm/mach-sunxi/dram_sun50i_h6.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)

2 1

[U-Boot] Pull request: u-boot-spi/master
by Jagan Teki 15 Oct '18

15 Oct '18

Hi Tom, Please pull this PR. thanks, Jagan. The following changes since commit 0a60a81ba3860946551cb79aa6486aa076e357f3: Kconfig: sandbox: enable cmd_avb and dependencies (2018-10-07 13:34:19 -0400) are available in the Git repository at: git://git.denx.de/u-boot-spi.git master for you to fetch changes up to 5c391486b411025785e064f160d248bef31b3d28: sf: Add MICRON manufacturer id (2018-10-12 11:37:49 +0530) ---------------------------------------------------------------- Adam Ford (1): mtd: uboot: Fix hanging during mtd list command Ashish Kumar (1): sf: Add MICRON manufacturer id Jagan Teki (2): spi: davinci: Add platdata support board: da8xxevm: Add SPL DM for serial, spi board/davinci/da8xxevm/da850evm.c | 27 +++++++++++++++++++ configs/da850_am18xxevm_defconfig | 3 +++ configs/da850evm_defconfig | 3 +++ drivers/mtd/mtd_uboot.c | 9 ++++++- drivers/mtd/spi/sf_internal.h | 1 + drivers/mtd/spi/spi_flash.c | 2 ++ drivers/spi/davinci_spi.c | 47 ++++++++++++++++++++-------------- include/configs/da850evm.h | 3 --- include/dm/platform_data/spi_davinci.h | 15 +++++++++++ 9 files changed, 87 insertions(+), 23 deletions(-) create mode 100644 include/dm/platform_data/spi_davinci.h

2 1

[U-Boot] [BUG] snow: mmc: SD card access broken: unable to select a mode
by Guillaume Gardet 15 Oct '18

15 Oct '18

Hi Jaehoon, There are problems with SD card access on Samsung Chromebook (snow) with latest master (and also 2018.05-rc1 and 2018.03). eMMC is ok, but SD card access leads to 'unable to select a mode' problem. If I disable HS mode, I can access the SD card without problem: ******************************************************************************** diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index 23f642980bf..28f4fa0f213 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_mmc.c @@ -508,7 +508,8 @@ void dwmci_setup_cfg(struct mmc_config *cfg, struct dwmci_host *host, cfg->host_caps |= MMC_MODE_4BIT; cfg->host_caps &= ~MMC_MODE_8BIT; } - cfg->host_caps |= MMC_MODE_HS | MMC_MODE_HS_52MHz; + /* Temp workaround for Chromebook snow to avoid the 'unable to select a mode' error */ +// cfg->host_caps |= MMC_MODE_HS | MMC_MODE_HS_52MHz; cfg->b_max = CONFIG_SYS_MMC_MAX_BLK_COUNT; } ******************************************************************************** Once we try to select HS mode, all access to SD card result in failure, even when trying to setup a lower frequency mode, including SD legacy at 25 MHz. Any idea what is going? Maybe you have fixes pending? Guillaume

4 12

[U-Boot] Please pull ARC changes
by Alexey Brodkin 15 Oct '18

15 Oct '18

Hi Tom, The following changes since commit 3d5ced9e22d32112a20f9dc0f5fb1f22ef088079: Merge tag 'dm-9oct18' of git://git.denx.de/u-boot-dm (2018-10-10 13:35:17 -0400) are available in the Git repository at: git://git.denx.de/u-boot-arc.git tags/arc-more-updates-for-2018.11-rc2 for you to fetch changes up to a2110918559b34219721cf31bbe8bd94a843e1ac: iot_dk: Link for eFlash (2018-10-12 15:14:41 +0300) ---------------------------------------------------------------- More fixes and improvements for ARC here: Fixes: * Take care of global uninitialized variables They used to be put right after .bss section and were never zeroed as they should be. Now merged with normal .bss Improvements: * Print more verbose CPU info for boards built on real silicon * Add support for SD-card detection on all ARC boards * Quite a few fixes for IoT DK - Support reset by command - Print of CPU freq on boot - Link for eFlash etc ---------------------------------------------------------------- Alexey Brodkin (9): iot_dk: Add localversion string iot_dk: Disable networking support ARC: make generic print_cpuinfo() weak iot_dk/hsdk: Implement its own print_cpuinfo() iot_dk: Implement board reset iot_dk: Add support of 136 MHz clock iot_dk: Save CPU clock value to gd->cpu_clk axs10x/emdk/hsdk/iot_dk: Implement board_mmc_getcd() iot_dk: Link for eFlash arch/arc/lib/cpu.c | 2 +- board/synopsys/axs10x/axs10x.c | 7 +++++++ board/synopsys/emdk/emdk.c | 7 +++++++ board/synopsys/hsdk/hsdk.c | 15 +++++++++++++++ board/synopsys/iot_devkit/iot_devkit.c | 43 ++++++++++++++++++++++++++++++++++++++----- configs/iot_devkit_defconfig | 5 +++-- 6 files changed, 71 insertions(+), 8 deletions(-) Regards, Alexey

1 1

[U-Boot] [PATCH 1/1] board: ge: bx50v3: fix initialization of i2c bus0
by Fabien Lahoudere 15 Oct '18

15 Oct '18

From: Dan Cimpoca <dan.I.cimpoca(a)ge.com> I2C bus 0 was not initialized correctly. There is an offset between i2c index and the structure number of pad info. So i2c bus 0 can be in an inconsistent state. This problem become visible on B{4,6}50v3 with the CPUC HW watchdog enabled. Sometimes when the CPUC HW watchdog interrupted the boot process, U-Boot was not able to read VPD from I2C/EEPROM and the system failed to boot up again, because a device connected to that bus was stuck in data transfer state (from previous boot attempt) and there was no method to recover (struct mxc_i2c_bus::idle_bus_fn was not set) courtesy of incorrect initialization. Signed-off-by: Dan Cimpoca <dan.I.cimpoca(a)ge.com> Signed-off-by: Fabien Lahoudere <fabien.lahoudere(a)collabora.com> --- board/ge/bx50v3/bx50v3.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/board/ge/bx50v3/bx50v3.c b/board/ge/bx50v3/bx50v3.c index 2eb1b65..2458525 100644 --- a/board/ge/bx50v3/bx50v3.c +++ b/board/ge/bx50v3/bx50v3.c @@ -714,9 +714,9 @@ static void set_confidx(const struct vpd_cache* vpd) int board_init(void) { - setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info1); - setup_i2c(2, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info2); - setup_i2c(3, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info3); + setup_i2c(0, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info1); + setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info2); + setup_i2c(2, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info3); read_vpd(CONFIG_SYS_I2C_EEPROM_BUS); -- 1.8.3.1

1 0

[U-Boot] [PATCH 0/2] board: ge: bx50v3: Fix screen flickering
by Fabien Lahoudere 15 Oct '18

15 Oct '18

This patchset solves screen flickering observed at bootup on b650v3. Steps to reproduce: 1) Connect B650 to power. 2) Switch On the Monitor. 3) Observe the display. Ian Ray (2): board: ge: bx50v3: correct LDB clock board: ge: bx50v3: b{4,6}50v3 modeline board/ge/bx50v3/bx50v3.c | 32 +++++++++++++++++++------------- 1 file changed, 19 insertions(+), 13 deletions(-) -- 1.8.3.1

1 2

[U-Boot] [PATCH 1/1] board: ge: bx50v3: Change maintainer
by Fabien Lahoudere 15 Oct '18

15 Oct '18

While using ./scripts/get_maintainer.pl I detect that the Maintainer name and address for bx50v3 boards are not valid. The new maintainer for GE bx50v3 products must be Ian Ray. Signed-off-by: Fabien Lahoudere <fabien.lahoudere(a)collabora.com> --- board/ge/bx50v3/MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/ge/bx50v3/MAINTAINERS b/board/ge/bx50v3/MAINTAINERS index a44edd4..91d5c86 100644 --- a/board/ge/bx50v3/MAINTAINERS +++ b/board/ge/bx50v3/MAINTAINERS @@ -1,5 +1,5 @@ GE_BX50V3 BOARD -M: Martin Donnelly <martin.donnelly(a)ge.com> +M: Ian Ray <ian.ray(a)ge.com> S: Maintained F: board/ge/bx50v3/ F: include/configs/ge_bx50v3.h -- 1.8.3.1

1 0