October 2018 - U-Boot

[U-Boot] [GIT PULL] Xilinx changes for v2018.11-rc2 v2
by Michal Simek 17 Oct '18

17 Oct '18

Hi Tom, as we discussed here is the second PR without that problematic serial patch. My travis session hasn't finished yet on this rebased branch https://travis-ci.org/michalsimek/u-boot/builds/442217785 but on non rebased version it was ok https://travis-ci.org/michalsimek/u-boot/builds/442057723 Please run your tests and let me know if you see any issue. Thanks, Michal The following changes since commit 892f93de61c375e8c3aabf03493af32115f51880: Prepare v2018.11-rc2 (2018-10-15 20:26:22 -0400) are available in the git repository at: git://www.denx.de/git/u-boot-microblaze.git tags/xilinx-for-v2018.11-rc2-v2 for you to fetch changes up to b92055064e56207e284ae966dbd7bd407a7b0e8d: cmd: kgdb: Enable kgdb only for PPC (2018-10-16 16:53:25 +0200) ---------------------------------------------------------------- Xilinx changes for v2018.11-rc2-v2 FPGA: - Fix SPL fpga loading from FIT ARM64: - Fix gic accesses in EL2/EL1 Xilinx: - Add dlc20 board support - Add Versal board support - Sync defconfigs - Enable MP via Kconfig - Add missing efuse node - Enable CDC for zcu100 cmd: - Fix kgdb Kconfig dependency ---------------------------------------------------------------- Michal Simek (12): spl: fpga: Implement fpga bistream loading with fpga_load arm: zynq: Enable FIT fpga loading in SPL for zc706 arm: zynq: Add support for DLC20 board arm: zynq: Add efuse node for Zynq-7000S devices xilinx: Sync defconfigs with current Kconfig arm64: zynqmp: Enable CDC ethernet gadget for zcu100/Ultra96 arm64: gic: Do gicv3 secure initialization based on EL level arm64: versal: Add support for new Xilinx Versal ACAPs net: gem: Do not setup any clock for Xilinx SoC Versal arm64: versal: Add Xilinx Versal Virtual QEMU board arm64: zynqmp: Enable MP by default via Kconfig cmd: kgdb: Enable kgdb only for PPC Siva Durga Prasad Paladugu (2): arm64: zynqmp: Move TCM initialization to a separate routine arm64: zynqmp: Add new command for TCM initialization Kconfig | 2 +- MAINTAINERS | 6 ++++ arch/arm/Kconfig | 11 +++++++ arch/arm/Makefile | 1 + arch/arm/cpu/armv8/zynqmp/cpu.c | 12 +++++-- arch/arm/dts/Makefile | 1 + arch/arm/dts/zynq-7000.dtsi | 5 +++ arch/arm/dts/zynq-dlc20-rev1.0.dts | 103 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ arch/arm/include/asm/arch-zynqmp/sys_proto.h | 3 ++ arch/arm/lib/gic_64.S | 16 +++++---- arch/arm/mach-versal/Kconfig | 44 +++++++++++++++++++++++++ arch/arm/mach-versal/Makefile | 8 +++++ arch/arm/mach-versal/clk.c | 30 +++++++++++++++++ arch/arm/mach-versal/cpu.c | 83 ++++++++++++++++++++++++++++++++++++++++++++++ arch/arm/mach-versal/include/mach/gpio.h | 6 ++++ arch/arm/mach-versal/include/mach/hardware.h | 34 +++++++++++++++++++ arch/arm/mach-versal/include/mach/sys_proto.h | 6 ++++ board/xilinx/versal/MAINTAINERS | 7 ++++ board/xilinx/versal/Makefile | 7 ++++ board/xilinx/versal/board.c | 81 +++++++++++++++++++++++++++++++++++++++++++++ board/xilinx/zynq/zynq-dlc20-rev1.0/ps7_init_gpl.c | 280 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ board/xilinx/zynqmp/cmds.c | 37 ++++++++++++++++++++- cmd/Kconfig | 1 + common/spl/spl_fit.c | 34 +++++++++---------- configs/avnet_ultra96_rev1_defconfig | 8 +++-- configs/microblaze-generic_defconfig | 2 +- configs/xilinx_versal_virt_defconfig | 68 ++++++++++++++++++++++++++++++++++++++ configs/xilinx_zynqmp_mini_emmc0_defconfig | 1 + configs/xilinx_zynqmp_mini_emmc1_defconfig | 1 + configs/xilinx_zynqmp_mini_nand_defconfig | 1 + configs/xilinx_zynqmp_mini_qspi_defconfig | 1 - configs/xilinx_zynqmp_zc1232_revA_defconfig | 1 - configs/xilinx_zynqmp_zc1254_revA_defconfig | 1 - configs/xilinx_zynqmp_zc1275_revA_defconfig | 1 - configs/xilinx_zynqmp_zc1275_revB_defconfig | 1 - configs/xilinx_zynqmp_zc1751_xm015_dc1_defconfig | 1 - configs/xilinx_zynqmp_zc1751_xm016_dc2_defconfig | 1 - configs/xilinx_zynqmp_zc1751_xm017_dc3_defconfig | 1 - configs/xilinx_zynqmp_zc1751_xm018_dc4_defconfig | 1 - configs/xilinx_zynqmp_zc1751_xm019_dc5_defconfig | 1 - configs/xilinx_zynqmp_zcu100_revC_defconfig | 8 +++-- configs/xilinx_zynqmp_zcu102_rev1_0_defconfig | 1 - configs/xilinx_zynqmp_zcu102_revA_defconfig | 1 - configs/xilinx_zynqmp_zcu102_revB_defconfig | 1 - configs/xilinx_zynqmp_zcu104_revA_defconfig | 1 - configs/xilinx_zynqmp_zcu104_revC_defconfig | 1 - configs/xilinx_zynqmp_zcu106_revA_defconfig | 1 - configs/xilinx_zynqmp_zcu111_revA_defconfig | 1 - configs/zynq_dlc20_rev1_0_defconfig | 74 +++++++++++++++++++++++++++++++++++++++++ configs/zynq_zc706_defconfig | 4 +++ drivers/mmc/Kconfig | 2 +- drivers/net/Kconfig | 2 +- drivers/net/zynq_gem.c | 4 +++ drivers/spi/Kconfig | 4 +-- env/Kconfig | 4 +-- include/configs/xilinx_versal.h | 91 ++++++++++++++++++++++++++++++++++++++++++++++++++ 56 files changed, 1052 insertions(+), 57 deletions(-) create mode 100644 arch/arm/dts/zynq-dlc20-rev1.0.dts create mode 100644 arch/arm/mach-versal/Kconfig create mode 100644 arch/arm/mach-versal/Makefile create mode 100644 arch/arm/mach-versal/clk.c create mode 100644 arch/arm/mach-versal/cpu.c create mode 100644 arch/arm/mach-versal/include/mach/gpio.h create mode 100644 arch/arm/mach-versal/include/mach/hardware.h create mode 100644 arch/arm/mach-versal/include/mach/sys_proto.h create mode 100644 board/xilinx/versal/MAINTAINERS create mode 100644 board/xilinx/versal/Makefile create mode 100644 board/xilinx/versal/board.c create mode 100644 board/xilinx/zynq/zynq-dlc20-rev1.0/ps7_init_gpl.c create mode 100644 configs/xilinx_versal_virt_defconfig create mode 100644 configs/zynq_dlc20_rev1_0_defconfig create mode 100644 include/configs/xilinx_versal.h -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs

2 1

[U-Boot] [PATCH v2 1/6] efi_loader: Generate Microsoft PE format compliant images
by Bin Meng 16 Oct '18

16 Oct '18

Per Microsoft PE Format documentation [1], PointerToSymbolTable and NumberOfSymbols should be zero for an image in the COFF file header. Currently U-Boot is generating *.efi images (eg: helloworld.efi) in which these two members are not zero. This updates the build rules to tell linker to remove the symbol table completely so that we can generate compliant *.efi images. [1] https://docs.microsoft.com/zh-cn/windows/desktop/Debug/pe-format Reported-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> Signed-off-by: Bin Meng <bmeng.cn(a)gmail.com> Reviewed-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- Changes in v2: None scripts/Makefile.lib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 4dceb6d..a4f16bb 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -381,7 +381,7 @@ $(obj)/%.efi: $(obj)/%_efi.so quiet_cmd_efi_ld = LD $@ cmd_efi_ld = $(LD) -nostdlib -znocombreloc -T $(EFI_LDS_PATH) -shared \ - -Bsymbolic $^ -o $@ + -Bsymbolic -s $^ -o $@ EFI_LDS_PATH = $(srctree)/arch/$(ARCH)/lib/$(EFI_LDS) -- 2.7.4

3 21

[U-Boot] [PATCH 1/1] sandbox: dt: sandbox.dts set skip-localhost = <1>
by Heinrich Schuchardt 16 Oct '18

16 Oct '18

The local interface is not usable for many network operations. It has been disabled in all sandbox device trees except sandbox.dts. Let's disable it here too. 'bootefi selftest' tries to do execute DHCP. This fails on the lo device. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- arch/sandbox/dts/sandbox.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sandbox/dts/sandbox.dts b/arch/sandbox/dts/sandbox.dts index fb866e8807..e0990352fb 100644 --- a/arch/sandbox/dts/sandbox.dts +++ b/arch/sandbox/dts/sandbox.dts @@ -49,7 +49,7 @@ ethrawbus { compatible = "sandbox,eth-raw-bus"; - skip-localhost = <0>; + skip-localhost = <1>; }; eth@10002000 { -- 2.19.1

2 5

[U-Boot] [PATCH] arm: socfpga: fpga: fix type of local variable
by Simon Goldschmidt 16 Oct '18

16 Oct '18

The 'status' variable in 'socfpga_load()' for both gen5 and arria10 is of type 'unsigned long' while it is always used as 'int' only. Change it to 'int'. Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt(a)gmail.com> --- drivers/fpga/socfpga_arria10.c | 2 +- drivers/fpga/socfpga_gen5.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/fpga/socfpga_arria10.c b/drivers/fpga/socfpga_arria10.c index d6b59498e5..114dd910ab 100644 --- a/drivers/fpga/socfpga_arria10.c +++ b/drivers/fpga/socfpga_arria10.c @@ -453,7 +453,7 @@ int fpgamgr_program_finish(void) */ int socfpga_load(Altera_desc *desc, const void *rbf_data, size_t rbf_size) { - unsigned long status; + int status; /* disable all signals from hps peripheral controller to fpga */ writel(0, &system_manager_base->fpgaintf_en_global); diff --git a/drivers/fpga/socfpga_gen5.c b/drivers/fpga/socfpga_gen5.c index 184de743fd..6d16e0b37f 100644 --- a/drivers/fpga/socfpga_gen5.c +++ b/drivers/fpga/socfpga_gen5.c @@ -204,7 +204,7 @@ static int fpgamgr_program_poll_usermode(void) */ int socfpga_load(Altera_desc *desc, const void *rbf_data, size_t rbf_size) { - unsigned long status; + int status; if ((uint32_t)rbf_data & 0x3) { puts("FPGA: Unaligned data, realign to 32bit boundary.\n"); -- 2.17.1

2 1

[U-Boot] [PATCH 1/1] efi_loader: unset CONFIG_EFI_LOADER on vf610twr
by Heinrich Schuchardt 16 Oct '18

16 Oct '18

vf610twr_defconfig and vf610twr_nand_defconfig suffer from tight memory restrictions. Disable CONFIG_EFI_LOADER for these boards. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- As the growth in size comes with patches in the EFI subsystem we should pass this patch through Alex's efi-next tree. --- configs/vf610twr_defconfig | 2 +- configs/vf610twr_nand_defconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configs/vf610twr_defconfig b/configs/vf610twr_defconfig index 3f38c8813b..3ac61013d9 100644 --- a/configs/vf610twr_defconfig +++ b/configs/vf610twr_defconfig @@ -39,4 +39,4 @@ CONFIG_PHY_MICREL=y CONFIG_MII=y CONFIG_DM_SERIAL=y CONFIG_FSL_LPUART=y -# CONFIG_EFI_UNICODE_CAPITALIZATION is not set +# CONFIG_EFI_LOADER is not set diff --git a/configs/vf610twr_nand_defconfig b/configs/vf610twr_nand_defconfig index d6e318f58c..a8895a48f8 100644 --- a/configs/vf610twr_nand_defconfig +++ b/configs/vf610twr_nand_defconfig @@ -39,4 +39,4 @@ CONFIG_PHY_MICREL=y CONFIG_MII=y CONFIG_DM_SERIAL=y CONFIG_FSL_LPUART=y -# CONFIG_EFI_UNICODE_CAPITALIZATION is not set +# CONFIG_EFI_LOADER is not set -- 2.19.1

1 0

[U-Boot] Building U-Boot for Digilent Zybo Z7
by Stefan Theil 16 Oct '18

16 Oct '18

Hello, I am currently trying to build and run a current U-Boot on my Zybo Z7 board. From the existence of a defconfig for it and going through the changelog it is seems to be supported. However, if I put the generated boot.bin and u-boot.img on an SD card and turn the board on all I see on the serial port is several garbled characters and then nothing happens. I have not changed any configuration settings so I expected to get a bootable image. Have I missed something or is the Zybo Z7 not supported after all? Regards, Stefan Theil

1 0

[U-Boot] [PATCH] serial: pl01x: Get clock from clock node if no clock property found
by Michal Simek 16 Oct '18

16 Oct '18

From: Siva Durga Prasad Paladugu <siva.durga.paladugu(a)xilinx.com> This patch gets clock from clock nodes if no clock property found in serial node. Signed-off-by: Siva Durga Prasad Paladugu <sivadur(a)xilinx.com> Signed-off-by: Michal Simek <michal.simek(a)xilinx.com> --- drivers/serial/serial_pl01x.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/serial/serial_pl01x.c b/drivers/serial/serial_pl01x.c index 2a5f256184f2..f4f33b13ff33 100644 --- a/drivers/serial/serial_pl01x.c +++ b/drivers/serial/serial_pl01x.c @@ -10,6 +10,7 @@ /* Simple U-Boot driver for the PrimeCell PL010/PL011 UARTs */ +#include <clk.h> #include <common.h> #include <dm.h> #include <errno.h> @@ -341,6 +342,9 @@ int pl01x_serial_ofdata_to_platdata(struct udevice *dev) { struct pl01x_serial_platdata *plat = dev_get_platdata(dev); fdt_addr_t addr; + unsigned long clock; + int ret; + struct clk clk; addr = devfdt_get_addr(dev); if (addr == FDT_ADDR_T_NONE) @@ -348,6 +352,28 @@ int pl01x_serial_ofdata_to_platdata(struct udevice *dev) plat->base = addr; plat->clock = dev_read_u32_default(dev, "clock", 1); + if (plat->clock == 1) { + ret = clk_get_by_index(dev, 0, &clk); + if (ret < 0) { + dev_err(dev, "failed to get clock\n"); + return ret; + } + + clock = clk_get_rate(&clk); + if (IS_ERR_VALUE(clock)) { + dev_err(dev, "failed to get rate\n"); + return clock; + } + debug("%s: CLK %ld\n", __func__, clock); + + ret = clk_enable(&clk); + if (ret && ret != -ENOSYS) { + dev_err(dev, "failed to enable clock\n"); + return ret; + } + plat->clock = clock; + } + plat->type = dev_get_driver_data(dev); plat->skip_init = dev_read_bool(dev, "skip-init"); -- 1.9.1

2 4

[U-Boot] [PATCH 1/1] efi_selftest: fix typos
by Heinrich Schuchardt 16 Oct '18

16 Oct '18

fix typos correct the header comment of efi_selftest_variables.c Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- lib/efi_selftest/efi_selftest_config_table.c | 12 ++++++------ lib/efi_selftest/efi_selftest_controllers.c | 2 +- lib/efi_selftest/efi_selftest_crc32.c | 4 ++-- lib/efi_selftest/efi_selftest_event_groups.c | 4 ++-- lib/efi_selftest/efi_selftest_events.c | 2 +- lib/efi_selftest/efi_selftest_exception.c | 4 ++-- lib/efi_selftest/efi_selftest_fdt.c | 2 +- lib/efi_selftest/efi_selftest_textinput.c | 2 +- lib/efi_selftest/efi_selftest_tpl.c | 2 +- lib/efi_selftest/efi_selftest_variables.c | 6 ++---- lib/efi_selftest/efi_selftest_watchdog.c | 2 +- 11 files changed, 20 insertions(+), 22 deletions(-) diff --git a/lib/efi_selftest/efi_selftest_config_table.c b/lib/efi_selftest/efi_selftest_config_table.c index 2aa3fc7284..0bc5da6b0c 100644 --- a/lib/efi_selftest/efi_selftest_config_table.c +++ b/lib/efi_selftest/efi_selftest_config_table.c @@ -18,7 +18,7 @@ static efi_guid_t table_guid = 0x17, 0x2e, 0x51, 0x6b, 0x49, 0x75); /* - * Notification function, increments the notfication count if parameter + * Notification function, increments the notification count if parameter * context is provided. * * @event notified event @@ -33,23 +33,23 @@ static void EFIAPI notify(struct efi_event *event, void *context) } /* - * Check crc32 of a table. + * Check CRC32 of a table. */ static int check_table(const void *table) { efi_status_t ret; u32 crc32, res; - /* Casting from const to not const */ + /* Casting from constant to not constant */ struct efi_table_hdr *hdr = (struct efi_table_hdr *)table; crc32 = hdr->crc32; /* - * Setting the crc32 of the 'const' table to zero is easier than + * Setting the CRC32 of the 'const' table to zero is easier than * copying */ hdr->crc32 = 0; ret = boottime->calculate_crc32(table, hdr->headersize, &res); - /* Reset table crc32 so it stays constant */ + /* Reset table CRC32 so it stays constant */ hdr->crc32 = crc32; if (ret != EFI_ST_SUCCESS) { efi_st_error("CalculateCrc32 failed\n"); @@ -203,7 +203,7 @@ static int execute(void) return EFI_ST_FAILURE; } if (tabcnt > 1) { - efi_st_error("Duplicate table guid\n"); + efi_st_error("Duplicate table GUID\n"); return EFI_ST_FAILURE; } if (table != &tables[1]) { diff --git a/lib/efi_selftest/efi_selftest_controllers.c b/lib/efi_selftest/efi_selftest_controllers.c index ceefa03444..e8a80d778d 100644 --- a/lib/efi_selftest/efi_selftest_controllers.c +++ b/lib/efi_selftest/efi_selftest_controllers.c @@ -33,7 +33,7 @@ static efi_handle_t handle_driver; * Count child controllers * * @handle handle on which child controllers are installed - * @protocol protocol for which the child controlles where installed + * @protocol protocol for which the child controllers were installed * @count number of child controllers * @return status code */ diff --git a/lib/efi_selftest/efi_selftest_crc32.c b/lib/efi_selftest/efi_selftest_crc32.c index 8555b8f114..4881e8ac6f 100644 --- a/lib/efi_selftest/efi_selftest_crc32.c +++ b/lib/efi_selftest/efi_selftest_crc32.c @@ -5,7 +5,7 @@ * Copyright (c) 2018 Heinrich Schuchardt <xypron.glpk(a)gmx.de> * * This unit test checks the CalculateCrc32 bootservice and checks the - * headers of the system table, the boot services tablle, and the runtime + * headers of the system table, the boot services table, and the runtime * services table before and after ExitBootServices(). */ @@ -19,7 +19,7 @@ static int check_table(const void *table) { efi_status_t ret; u32 crc32, res; - /* Casting from const to not const */ + /* Casting from constant to not constant */ struct efi_table_hdr *hdr = (struct efi_table_hdr *)table; if (!hdr->signature) { diff --git a/lib/efi_selftest/efi_selftest_event_groups.c b/lib/efi_selftest/efi_selftest_event_groups.c index 9b3c5132ef..5a7980c5d0 100644 --- a/lib/efi_selftest/efi_selftest_event_groups.c +++ b/lib/efi_selftest/efi_selftest_event_groups.c @@ -19,7 +19,7 @@ static efi_guid_t event_group = 0x0e, 0x5b, 0x45, 0xc0, 0x56, 0x91); /* - * Notification function, increments the notfication count if parameter + * Notification function, increments the notification count if parameter * context is provided. * * @event notified event @@ -114,7 +114,7 @@ static int execute(void) (unsigned int)i, (unsigned int)j, (unsigned int)counter[j]); efi_st_error( - "Nofification function not called\n"); + "Notification function not called\n"); return EFI_ST_FAILURE; } } diff --git a/lib/efi_selftest/efi_selftest_events.c b/lib/efi_selftest/efi_selftest_events.c index 47f9f99318..ed99a53804 100644 --- a/lib/efi_selftest/efi_selftest_events.c +++ b/lib/efi_selftest/efi_selftest_events.c @@ -17,7 +17,7 @@ static unsigned int timer_ticks; static struct efi_boot_services *boottime; /* - * Notification function, increments the notfication count if parameter + * Notification function, increments the notification count if parameter * context is provided. * * @event notified event diff --git a/lib/efi_selftest/efi_selftest_exception.c b/lib/efi_selftest/efi_selftest_exception.c index 2ac1796c3b..76cfb88d7c 100644 --- a/lib/efi_selftest/efi_selftest_exception.c +++ b/lib/efi_selftest/efi_selftest_exception.c @@ -4,7 +4,7 @@ * * Copyright (c) 2018 Heinrich Schuchardt <xypron.glpk(a)gmx.de> * - * Test the handling of execptions by trying to execute an undefined + * Test the handling of exceptions by trying to execute an undefined * instruction. */ @@ -37,7 +37,7 @@ static int execute(void) { undefined_instruction(); - efi_st_error("An undefined instruction exeption was not raised\n"); + efi_st_error("An undefined instruction exception was not raised\n"); return EFI_ST_FAILURE; } diff --git a/lib/efi_selftest/efi_selftest_fdt.c b/lib/efi_selftest/efi_selftest_fdt.c index c7bc242b5c..d545d51812 100644 --- a/lib/efi_selftest/efi_selftest_fdt.c +++ b/lib/efi_selftest/efi_selftest_fdt.c @@ -16,7 +16,7 @@ static struct efi_boot_services *boottime; static const char *fdt; -/* This should be sufficent for */ +/* This should be sufficient for */ #define BUFFERSIZE 0x100000 static efi_guid_t fdt_guid = EFI_FDT_GUID; diff --git a/lib/efi_selftest/efi_selftest_textinput.c b/lib/efi_selftest/efi_selftest_textinput.c index 164fbffe6c..b90671cdd2 100644 --- a/lib/efi_selftest/efi_selftest_textinput.c +++ b/lib/efi_selftest/efi_selftest_textinput.c @@ -5,7 +5,7 @@ * Copyright (c) 2018 Heinrich Schuchardt <xypron.glpk(a)gmx.de> * * Provides a unit test for the EFI_SIMPLE_TEXT_INPUT_PROTOCOL. - * The unicode character and the scan code are printed for text + * The Unicode character and the scan code are printed for text * input. To run the test: * * setenv efi_selftest text input diff --git a/lib/efi_selftest/efi_selftest_tpl.c b/lib/efi_selftest/efi_selftest_tpl.c index 61ae46b797..97d256abe4 100644 --- a/lib/efi_selftest/efi_selftest_tpl.c +++ b/lib/efi_selftest/efi_selftest_tpl.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0+ /* - * efi_selftest_events + * efi_selftest_tpl * * Copyright (c) 2017 Heinrich Schuchardt <xypron.glpk(a)gmx.de> * diff --git a/lib/efi_selftest/efi_selftest_variables.c b/lib/efi_selftest/efi_selftest_variables.c index 146378fb9a..e4c389a872 100644 --- a/lib/efi_selftest/efi_selftest_variables.c +++ b/lib/efi_selftest/efi_selftest_variables.c @@ -4,10 +4,8 @@ * * Copyright (c) 2018 Heinrich Schuchardt <xypron.glpk(a)gmx.de> * - * This unit test checks the following protocol services: - * ConnectController, DisconnectController, - * InstallProtocol, ReinstallProtocol, UninstallProtocol, - * OpenProtocol, CloseProtcol, OpenProtocolInformation + * This unit test checks the runtime services for variables: + * GetVariable, GetNextVariableName, SetVariable, QueryVariableInfo. */ #include <efi_selftest.h> diff --git a/lib/efi_selftest/efi_selftest_watchdog.c b/lib/efi_selftest/efi_selftest_watchdog.c index bff2330918..cbc6761721 100644 --- a/lib/efi_selftest/efi_selftest_watchdog.c +++ b/lib/efi_selftest/efi_selftest_watchdog.c @@ -35,7 +35,7 @@ static struct notify_context notification_context; static bool watchdog_reset; /* - * Notification function, increments the notfication count if parameter + * Notification function, increments the notification count if parameter * context is provided. * * @event notified event -- 2.19.0

2 1

[U-Boot] [PATCH] efi_loader: Fix warning in efi_load_image()
by Tom Rini 16 Oct '18

16 Oct '18

As observed with clang: lib/efi_loader/efi_boottime.c:1624:7: warning: variable 'info' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (ret != EFI_SUCCESS) ^~~~~~~~~~~~~~~~~~ lib/efi_loader/efi_boottime.c:1653:7: note: uninitialized use occurs here free(info); ^~~~ lib/efi_loader/efi_boottime.c:1624:3: note: remove the 'if' if its condition is always false if (ret != EFI_SUCCESS) ^~~~~~~~~~~~~~~~~~~~~~~ lib/efi_loader/efi_boottime.c:1602:31: note: initialize the variable 'info' to silence this warning struct efi_loaded_image *info; ^ = NULL Rather than change how we unwind the function it makes the most sense to initialize info to NULL so that we can continue to pass it to free(). Fixes: c982874e930d ("efi_loader: refactor efi_setup_loaded_image()") Cc: Heinrich Schuchardt <xypron.glpk(a)gmx.de> Cc: Alexander Graf <agraf(a)suse.de> Signed-off-by: Tom Rini <trini(a)konsulko.com> --- lib/efi_loader/efi_boottime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c index 97eb19cd14d2..ddf857ff267d 100644 --- a/lib/efi_loader/efi_boottime.c +++ b/lib/efi_loader/efi_boottime.c @@ -1599,7 +1599,7 @@ static efi_status_t EFIAPI efi_load_image(bool boot_policy, efi_uintn_t source_size, efi_handle_t *image_handle) { - struct efi_loaded_image *info; + struct efi_loaded_image *info = NULL; struct efi_loaded_image_obj **image_obj = (struct efi_loaded_image_obj **)image_handle; efi_status_t ret; -- 2.7.4

3 2

[U-Boot] [PATCH] fs: fat: Fix warning in normalize_longname()
by Tom Rini 16 Oct '18

16 Oct '18

As observed with clang: fs/fat/fat_write.c:1024:13: warning: comparison of constant 128 with expression of type 'char' is always false [-Wtautological-constant-out-of-range-compare] if ((0x80 <= c) && (c <= 0xff)) ~~~~ ^ ~ fs/fat/fat_write.c:1024:25: warning: comparison of constant 255 with expression of type 'char' is always true [-Wtautological-constant-out-of-range-compare] if ((0x80 <= c) && (c <= 0xff)) ~ ^ ~~~~ Fixes: 25bb9dab14f4 ("fs: fat: check and normalize file name") Cc: AKASHI Takahiro <takahiro.akashi(a)linaro.org> Cc: Alexander Graf <agraf(a)suse.de> Signed-off-by: Tom Rini <trini(a)konsulko.com> --- fs/fat/fat_write.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fat/fat_write.c b/fs/fat/fat_write.c index fc211e74bc69..98fe6b2b4ecc 100644 --- a/fs/fat/fat_write.c +++ b/fs/fat/fat_write.c @@ -1005,7 +1005,7 @@ again: static int normalize_longname(char *l_filename, const char *filename) { const char *p, legal[] = "!#$%&\'()-.@^`_{}~"; - char c; + unsigned char c; int name_len; /* Check that the filename is valid */ -- 2.7.4

2 1