July 2016 - U-Boot

[U-Boot] [RFC PATCH] sunxi: SPL: place BSS in SRAM if possible
by Andre Przywara 04 Jul '16

04 Jul '16

The SPL BSS is placed in DRAM for all sunxi boards at the moment, because the space in the A1 SRAM space, where the SPL is normally loaded, is limited. But this is problematic, because any BSS variable could be used before DRAM is initialised, eventually hanging the board. Many SoCs however have either a larger A1 region (H3: 64K) or have plenty of other SRAM space (A64: SRAM C with 108K) which can be used for those BSS variables. Put the BSS into an SRAM location for those boards. Signed-off-by: Andre Przywara <andre.przywara(a)arm.com> --- arch/arm/cpu/armv7/sunxi/u-boot-spl.lds | 4 ++-- include/configs/sunxi-common.h | 17 +++++++++++++---- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/arch/arm/cpu/armv7/sunxi/u-boot-spl.lds b/arch/arm/cpu/armv7/sunxi/u-boot-spl.lds index 53f0cbd..6576260 100644 --- a/arch/arm/cpu/armv7/sunxi/u-boot-spl.lds +++ b/arch/arm/cpu/armv7/sunxi/u-boot-spl.lds @@ -16,7 +16,7 @@ */ MEMORY { .sram : ORIGIN = CONFIG_SPL_TEXT_BASE,\ LENGTH = CONFIG_SPL_MAX_SIZE } -MEMORY { .sdram : ORIGIN = CONFIG_SPL_BSS_START_ADDR, \ +MEMORY { .bssmem : ORIGIN = CONFIG_SPL_BSS_START_ADDR, \ LENGTH = CONFIG_SPL_BSS_MAX_SIZE } OUTPUT_FORMAT("elf32-littlearm", "elf32-littlearm", "elf32-littlearm") @@ -54,5 +54,5 @@ SECTIONS *(.bss*) . = ALIGN(4); __bss_end = .; - } > .sdram + } > .bssmem } diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h index 94275a7..39cbcb4 100644 --- a/include/configs/sunxi-common.h +++ b/include/configs/sunxi-common.h @@ -75,7 +75,6 @@ * since it needs to fit in with the other values. By also #defining it * we get warnings if the Kconfig value mismatches. */ #define CONFIG_SPL_STACK_R_ADDR 0x2fe00000 -#define CONFIG_SPL_BSS_START_ADDR 0x2ff80000 #else #define SDRAM_OFFSET(x) 0x4##x #define CONFIG_SYS_SDRAM_BASE 0x40000000 @@ -86,11 +85,8 @@ * since it needs to fit in with the other values. By also #defining it * we get warnings if the Kconfig value mismatches. */ #define CONFIG_SPL_STACK_R_ADDR 0x4fe00000 -#define CONFIG_SPL_BSS_START_ADDR 0x4ff80000 #endif -#define CONFIG_SPL_BSS_MAX_SIZE 0x00080000 /* 512 KiB */ - #if defined(CONFIG_MACH_SUN9I) || defined(CONFIG_MACH_SUN50I) /* * The A80's A1 sram starts at 0x00010000 rather then at 0x00000000 and is @@ -221,6 +217,19 @@ #define CONFIG_SPL_STACK LOW_LEVEL_SRAM_STACK #endif +#if defined(CONFIG_MACH_SUN50I) || defined(CONFIG_MACH_SUN8I_H3) +/* Place BSS in SRAM, just above the stack. */ +#define CONFIG_SPL_BSS_START_ADDR LOW_LEVEL_SRAM_STACK +#define CONFIG_SPL_BSS_MAX_SIZE 0x00001000 /* 4 KiB */ +#else +/* + * Place BSS in SDRAM. This assumes that you don't use any BSS variables + * until after SDRAM has been initialised. + */ +#define CONFIG_SPL_BSS_START_ADDR SDRAM_OFFSET(ff80000) +#define CONFIG_SPL_BSS_MAX_SIZE 0x00080000 /* 512 KiB */ +#endif + /* I2C */ #if defined CONFIG_AXP152_POWER || defined CONFIG_AXP209_POWER || \ defined CONFIG_SY8106A_POWER -- 2.8.2

1 0

[U-Boot] [PATCH v2 0/5] tools: patman: Fixes to improve handling of various wrong usage
by Bin Meng 04 Jul '16

04 Jul '16

This fixes several issues when abnormal tags are given to patman. For example, when we forget to put an 'END' after 'Cover-letter', patman does not handle such cases very well. This adds several additional checking to let patman be a little more tolerant on handling such exceptional paths. This series is available at u-boot-x86/patman-working for testing. Changes in v2: - New patch to use cover_match for 'Cover-letter' - Update commit message to explain when such scenario is hit - Add cover_match to the test logic - Generate warning for missing 'END' case - Update commit message to explain when such case is hit - Reset in_section, skip_blank and section variables too - Geneate warning when blank line is not found in 'Series-changes' - New patch to handle missing 'END' in non-last commit of a series Bin Meng (5): tools: patman: Use cover_match for 'Cover-letter' tools: patman: Handle tag sections without an 'END' tools: patman: Generate cover letter correctly when 'END' is missing tools: patman: Handle missing blank line for 'Series-changes' tools: patman: Handle missing 'END' in non-last commit of a series tools/patman/patchstream.py | 38 +++++++++++++++++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-) -- 2.7.4

2 13

[U-Boot] [PATCH] dm: Sort the uclass id in alphabetical order
by Bin Meng 04 Jul '16

04 Jul '16

Some uclass ids are out of order. Per the comments, sort them in alphabetical order. Signed-off-by: Bin Meng <bmeng.cn(a)gmail.com> --- include/dm/uclass-id.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/dm/uclass-id.h b/include/dm/uclass-id.h index b768660..c5cdfc7 100644 --- a/include/dm/uclass-id.h +++ b/include/dm/uclass-id.h @@ -33,7 +33,6 @@ enum uclass_id { UCLASS_CROS_EC, /* Chrome OS EC */ UCLASS_DISPLAY, /* Display (e.g. DisplayPort, HDMI) */ UCLASS_DMA, /* Direct Memory Access */ - UCLASS_RAM, /* RAM controller */ UCLASS_ETH, /* Ethernet device */ UCLASS_GPIO, /* Bank of general-purpose I/O pins */ UCLASS_I2C, /* I2C bus */ @@ -56,11 +55,12 @@ enum uclass_id { UCLASS_PCH, /* x86 platform controller hub */ UCLASS_PCI, /* PCI bus */ UCLASS_PCI_GENERIC, /* Generic PCI bus device */ - UCLASS_PINCTRL, /* Pinctrl (pin muxing/configuration) device */ UCLASS_PINCONFIG, /* Pin configuration node device */ + UCLASS_PINCTRL, /* Pinctrl (pin muxing/configuration) device */ UCLASS_PMIC, /* PMIC I/O device */ UCLASS_PWM, /* Pulse-width modulator */ UCLASS_PWRSEQ, /* Power sequence device */ + UCLASS_RAM, /* RAM controller */ UCLASS_REGULATOR, /* Regulator device */ UCLASS_REMOTEPROC, /* Remote Processor device */ UCLASS_RESET, /* Reset controller device */ -- 2.7.4

2 2

[U-Boot] [PATCH v3 1/5] x86: fdt: Drop the unused compatible strings in fdtdec
by Simon Glass 04 Jul '16

04 Jul '16

We have drivers for several more devices now, so drop the strings which are no-longer used. Signed-off-by: Simon Glass <sjg(a)chromium.org> Reviewed-by: Bin Meng <bmeng.cn(a)gmail.com> --- Changes in v3: - Rebase to master arch/x86/cpu/ivybridge/lpc.c | 6 ------ include/fdtdec.h | 5 ----- lib/fdtdec.c | 5 ----- 3 files changed, 16 deletions(-) diff --git a/arch/x86/cpu/ivybridge/lpc.c b/arch/x86/cpu/ivybridge/lpc.c index ff1faa5..4e0be2a 100644 --- a/arch/x86/cpu/ivybridge/lpc.c +++ b/arch/x86/cpu/ivybridge/lpc.c @@ -424,8 +424,6 @@ static void set_spi_speed(void) static int lpc_init_extra(struct udevice *dev) { struct udevice *pch = dev->parent; - const void *blob = gd->fdt_blob; - int node; debug("pch: lpc_init\n"); dm_pci_write_bar32(pch, 0, 0); @@ -434,10 +432,6 @@ static int lpc_init_extra(struct udevice *dev) dm_pci_write_bar32(pch, 3, 0x800); dm_pci_write_bar32(pch, 4, 0x900); - node = fdtdec_next_compatible(blob, 0, COMPAT_INTEL_PCH); - if (node < 0) - return -ENOENT; - /* Set the value for PCI command register. */ dm_pci_write_config16(pch, PCI_COMMAND, 0x000f); diff --git a/include/fdtdec.h b/include/fdtdec.h index 54e3d81..ae30b8a 100644 --- a/include/fdtdec.h +++ b/include/fdtdec.h @@ -153,14 +153,9 @@ enum fdt_compat_id { COMPAT_SAMSUNG_EXYNOS5_I2C, /* Exynos5 High Speed I2C Controller */ COMPAT_SAMSUNG_EXYNOS_SYSMMU, /* Exynos sysmmu */ COMPAT_INTEL_MICROCODE, /* Intel microcode update */ - COMPAT_INTEL_PANTHERPOINT_AHCI, /* Intel Pantherpoint AHCI */ - COMPAT_INTEL_MODEL_206AX, /* Intel Model 206AX CPU */ - COMPAT_INTEL_GMA, /* Intel Graphics Media Accelerator */ COMPAT_AMS_AS3722, /* AMS AS3722 PMIC */ - COMPAT_INTEL_ICH_SPI, /* Intel ICH7/9 SPI controller */ COMPAT_INTEL_QRK_MRC, /* Intel Quark MRC */ COMPAT_SOCIONEXT_XHCI, /* Socionext UniPhier xHCI */ - COMPAT_INTEL_PCH, /* Intel PCH */ COMPAT_ALTERA_SOCFPGA_DWMAC, /* SoCFPGA Ethernet controller */ COMPAT_ALTERA_SOCFPGA_DWMMC, /* SoCFPGA DWMMC controller */ COMPAT_ALTERA_SOCFPGA_DWC2USB, /* SoCFPGA DWC2 USB controller */ diff --git a/lib/fdtdec.c b/lib/fdtdec.c index 686b89d..2f54d71 100644 --- a/lib/fdtdec.c +++ b/lib/fdtdec.c @@ -58,14 +58,9 @@ static const char * const compat_names[COMPAT_COUNT] = { COMPAT(SAMSUNG_EXYNOS5_I2C, "samsung,exynos5-hsi2c"), COMPAT(SAMSUNG_EXYNOS_SYSMMU, "samsung,sysmmu-v3.3"), COMPAT(INTEL_MICROCODE, "intel,microcode"), - COMPAT(INTEL_PANTHERPOINT_AHCI, "intel,pantherpoint-ahci"), - COMPAT(INTEL_MODEL_206AX, "intel,model-206ax"), - COMPAT(INTEL_GMA, "intel,gma"), COMPAT(AMS_AS3722, "ams,as3722"), - COMPAT(INTEL_ICH_SPI, "intel,ich-spi"), COMPAT(INTEL_QRK_MRC, "intel,quark-mrc"), COMPAT(SOCIONEXT_XHCI, "socionext,uniphier-xhci"), - COMPAT(COMPAT_INTEL_PCH, "intel,bd82x6x"), COMPAT(ALTERA_SOCFPGA_DWMAC, "altr,socfpga-stmmac"), COMPAT(ALTERA_SOCFPGA_DWMMC, "altr,socfpga-dw-mshc"), COMPAT(ALTERA_SOCFPGA_DWC2USB, "snps,dwc2"), -- 2.8.0.rc3.226.g39d4020

3 12

[U-Boot] [PATCH] dm: gpio: MPC85XX GPIO platform data support
by Hamish Martin 04 Jul '16

04 Jul '16

Define a platform data structure for the MPC85XX GPIO driver to allow use of the driver without device tree. Users should define the GPIO blocks for their platform like this: struct mpc85xx_gpio_plat gpio_blocks[] = { { .addr = 0x130000, .ngpios = 32, }, { .addr = 0x131000, .ngpios = 32, }, }; U_BOOT_DEVICES(my_platform_gpios) = { { "gpio_mpc85xx", &gpio_blocks[0] }, { "gpio_mpc85xx", &gpio_blocks[1] }, }; This is intended to build upon the recent submission of the base MPC85XX driver from Mario Six. We need to use that new driver without dts support and this patch gives us that flexibility. This has been tested on a Freescale T2080 CPU, although only the first GPIO block. Signed-off-by: Hamish Martin <hamish.martin(a)alliedtelesis.co.nz> Reviewed-by: Mario Six <mario.six(a)gdsys.cc> Tested-by: Mario Six <mario.six(a)gdsys.cc> --- arch/powerpc/include/asm/arch-mpc85xx/gpio.h | 6 +++++ drivers/gpio/mpc85xx_gpio.c | 37 ++++++++++++++++++++++------ 2 files changed, 36 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/include/asm/arch-mpc85xx/gpio.h b/arch/powerpc/include/asm/arch-mpc85xx/gpio.h index 41b6677bba38..76faa22c8b43 100644 --- a/arch/powerpc/include/asm/arch-mpc85xx/gpio.h +++ b/arch/powerpc/include/asm/arch-mpc85xx/gpio.h @@ -18,4 +18,10 @@ #include <asm/mpc85xx_gpio.h> #endif +struct mpc85xx_gpio_plat { + ulong addr; + unsigned long size; + uint ngpios; +}; + #endif diff --git a/drivers/gpio/mpc85xx_gpio.c b/drivers/gpio/mpc85xx_gpio.c index 04773e2b31c3..3754a8215c36 100644 --- a/drivers/gpio/mpc85xx_gpio.c +++ b/drivers/gpio/mpc85xx_gpio.c @@ -163,23 +163,41 @@ static int mpc85xx_gpio_get_function(struct udevice *dev, unsigned gpio) return dir ? GPIOF_OUTPUT : GPIOF_INPUT; } +#if CONFIG_IS_ENABLED(OF_CONTROL) static int mpc85xx_gpio_ofdata_to_platdata(struct udevice *dev) { - struct mpc85xx_gpio_data *data = dev_get_priv(dev); + struct mpc85xx_gpio_plat *plat = dev_get_platdata(dev); fdt_addr_t addr; fdt_size_t size; addr = fdtdec_get_addr_size_auto_noparent(gd->fdt_blob, dev->of_offset, "reg", 0, &size); - data->addr = addr; - data->base = map_sysmem(CONFIG_SYS_IMMR + addr, size); + plat->addr = addr; + plat->size = size; + plat->ngpios = fdtdec_get_int(gd->fdt_blob, dev->of_offset, + "ngpios", 32); - if (!data->base) + return 0; +} +#endif + +static int mpc85xx_gpio_platdata_to_priv(struct udevice *dev) +{ + struct mpc85xx_gpio_data *priv = dev_get_priv(dev); + struct mpc85xx_gpio_plat *plat = dev_get_platdata(dev); + unsigned long size = plat->size; + + if (size == 0) + size = 0x100; + + priv->addr = plat->addr; + priv->base = map_sysmem(CONFIG_SYS_IMMR + plat->addr, size); + + if (!priv->base) return -ENOMEM; - data->gpio_count = fdtdec_get_int(gd->fdt_blob, dev->of_offset, - "ngpios", 32); - data->dat_shadow = 0; + priv->gpio_count = plat->ngpios; + priv->dat_shadow = 0; return 0; } @@ -190,6 +208,8 @@ static int mpc85xx_gpio_probe(struct udevice *dev) struct mpc85xx_gpio_data *data = dev_get_priv(dev); char name[32], *str; + mpc85xx_gpio_platdata_to_priv(dev); + snprintf(name, sizeof(name), "MPC@%lx_", data->addr); str = strdup(name); @@ -221,8 +241,11 @@ U_BOOT_DRIVER(gpio_mpc85xx) = { .name = "gpio_mpc85xx", .id = UCLASS_GPIO, .ops = &gpio_mpc85xx_ops, +#if CONFIG_IS_ENABLED(OF_CONTROL) .ofdata_to_platdata = mpc85xx_gpio_ofdata_to_platdata, + .platdata_auto_alloc_size = sizeof(struct mpc85xx_gpio_plat), .of_match = mpc85xx_gpio_ids, +#endif .probe = mpc85xx_gpio_probe, .priv_auto_alloc_size = sizeof(struct mpc85xx_gpio_data), }; -- 2.8.3

2 4

[U-Boot] [RESEND] common: block: fix compiler error with CONFIG_FASTBOOT_FLASH_MMC_DEV
by Ziyuan Xu 04 Jul '16

04 Jul '16

This fixes the following compiler error: common/fb_mmc.c: In function ‘fb_mmc_erase’: common/fb_mmc.c:209:17: error: ‘struct blk_desc’ has no member named ‘block_erase’ Signed-off-by: Ziyuan Xu <xzy.xu(a)rock-chips.com> --- common/fb_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/fb_mmc.c b/common/fb_mmc.c index e3abcc8..26025dc 100644 --- a/common/fb_mmc.c +++ b/common/fb_mmc.c @@ -206,7 +206,7 @@ void fb_mmc_erase(const char *cmd, char *response) printf("Erasing blocks " LBAFU " to " LBAFU " due to alignment\n", blks_start, blks_start + blks_size); - blks = dev_desc->block_erase(dev_desc, blks_start, blks_size); + blks = blk_derase(dev_desc, blks_start, blks_size); if (blks != blks_size) { error("failed erasing from device %d", dev_desc->devnum); fastboot_fail(response_str, "failed erasing from device"); -- 1.9.1

2 2

[U-Boot] usb: hub enumeration and potential NULL ptr dereference in usb_device_info()
by Bernhard Nortmann 04 Jul '16

04 Jul '16

Starting with commit b19236fd1c1ef289bab9e243ee5b50d658fcac3f I am observing a breakage of the "usb info" command on my BananaPi (Allwinner A20, sun7i), while "usb tree" and dm commands ("dm tree", "dm uclass") are fine. See attached usb-info-breakage.log Tracing back the error positon from pc and lr registers pointed me to the device_get_uclass_id() call within usb_device_info(), and suggested the problem is caused by trying to dereference a NULL struct udevice *hub. Therefore I added a diagnostic printf and a safeguard to this routine: diff --git a/cmd/usb.c b/cmd/usb.c index b83d323..a5e2463 100644 --- a/cmd/usb.c +++ b/cmd/usb.c @@ -610,6 +610,12 @@ static int usb_device_info(void) struct udevice *hub; device_find_first_child(bus, &hub); + printf("bus %p, uclass %d, hub %p: ", + bus, device_get_uclass_id(bus), hub); + if (!hub) { + printf("<no hub>\n"); + continue; + } if (device_get_uclass_id(hub) == UCLASS_USB_HUB && device_active(hub)) { show_info(hub); And it became apparent that hub actually receives NULL values during the device enumeration. The safeguard prevented the "data abort" error and got "usb info" working again - see attached usb-info-fixed.log I'm not sure why this particular problem didn't manifest earlier and only now became apparent with the change in SPL header size / CONFIG_SPL_TEXT_BASE. But it seems that accessing a NULL hub with device_get_uclass_id() is clearly wrong and should be avoided. Which brings me to two questions: 1. Is getting a NULL hub value legit when iterating UCLASS_USB devices the way that usb_device_info() does? If yes, the code seems to be lacking protection against passing it to device_get_uclass_id(). 2. Why does usb_device_info() choose to enumerate hubs this way at all? If the routine is aiming at UCLASS_USB_HUB - which seems to be the purpose of the subsequent device_get_uclass_id(hub) test - and the device tree already provides this information (as suggested by the output of "dm uclass"), then why not enumerate UCLASS_USB_HUB directly? Regards, B. Nortmann

4 8

Re: [U-Boot] [PATCH] SPL: sunxi: don't force .BSS into DRAM
by Hans de Goede 04 Jul '16

04 Jul '16

Hi, On 30-06-16 17:24, Simon Glass wrote: > Hi, > > On 30 June 2016 at 03:00, Hans de Goede <hdegoede(a)redhat.com> wrote: >> Hi Andre, >> >> On 30-06-16 02:25, Andre Przywara wrote: >>> >>> Probably due to some (ill-founded) fear of a large BSS all sunxi boards >>> forced their SPL BSS section into DRAM. >>> This only works if there is no usage of a .BSS variable before the DRAM >>> is initialised. >>> The recent inclusion of tiny-printf breaks this assumption (it has two >>> variables in .BSS), so any early printf (printing a number) hangs a board. >>> This in particular breaks the (WIP) Pine64 SPL, which at the moment links >>> Allwinner's libdram library, trying to print debug information: >>> DRAM:DRAM driver version: V1.0 >>> DRAM Type = <hangs> >> >> >> Hmm, although 256 bytes is not a lot I would prefer for BSS to stay in >> DRAM, esp. since the bss use may grow over time, and the SPL space is quite >> small. >> >> Moreover, given that tiny-printf is specifically meant for use in SPL / >> restricted environments and having BSS in DRAM is not unheard of for >> other boards, it seems to me like this is something which should really >> be fixed in tinyprintf instead. >> >> Have you tried looking into fixing this at the tinyprintf level ? > > Marek's fix is one option. Another is to make use of global_data, > which will be available from very early and it set to zero. I think Marek's fix is fine, we should go and merge that. As for the worries about not using BSS before DRAM is initialized coming back to bite us. Yes that may happen, but we are not the only board / mach / soc code to do this. I agree that documenting this somewhere would be good (patches welcome). As for just putting BSS in the sram, nack. Thanks to various efforts we currently have some free space for the SPL, but in the future we will likely add NAND support, and try to move the SPL to dm (with static device instantiation, no space for dt) so that we can get rid of the duplicate non-dm + dm gpio and uart code we currently have. These things combined will push things to their limit and may very well grow the BSS section too. Regards, Hans

3 2

Re: [U-Boot] sunxi: kernel crash on shutdown due to locked i2c bus depending on u-boot version
by Hans de Goede 03 Jul '16

03 Jul '16

Hi, On 03-07-16 16:04, Karsten Merker wrote: > Hello, > > I am experiencing a kernel panic on shutdown due to killing init > on various Allwinner A20-based systems (e.g. Cubietruck and > Lime2). Killing init in turn appears to be a result of a locked > i2c bus. This only happens on shutdown, but not on reboot. The > problem exists already for quite some time but I hadn't found > enough time to debug this properly before. > > Follwing is a log from shutting down a Cubietruck, running kernel > 4.6.2 (Debian/sid kernel package) and u-boot v2016.07-rc3 (plain > upstream build): > > systemd-shutdown[1]: Sending SIGTERM to remaining processes... > systemd-journald[522]: Received SIGTERM from PID 1 (systemd-shutdow). > systemd-shutdown[1]: Sending SIGKILL to remaining processes... > systemd-shutdown[1]: Unmounting file systems. > systemd-shutdown[1]: Remounting '/' read-only with options 'errors=remount-ro,data=ordered'. > EXT4-fs (sda2): re-mounted. Opts: errors=remount-ro,data=ordered > systemd-shutdown[1]: Remounting '/' read-only with options 'errors=remount-ro,data=ordered'. > EXT4-fs (sda2): re-mounted. Opts: errors=remount-ro,data=ordered > systemd-shutdown[1]: All filesystems unmounted. > systemd-shutdown[1]: Deactivating swaps. > systemd-shutdown[1]: All swaps deactivated. > systemd-shutdown[1]: Detaching loop devices. > systemd-shutdown[1]: All loop devices detached. > systemd-shutdown[1]: Detaching DM devices. > systemd-shutdown[1]: All DM devices detached. > systemd-shutdown[1]: Powering off. > kvm: exiting hardware virtualization > sd 0:0:0:0: [sda] Synchronizing SCSI cache > sd 0:0:0:0: [sda] Stopping disk > musb-hdrc musb-hdrc.1.auto: remove, state 4 > usb usb3: USB disconnect, device number 1 > musb-hdrc musb-hdrc.1.auto: USB bus 3 deregistered > reboot: Power down > i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0 > Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000000 > > CPU: 0 PID: 1 Comm: systemd-shutdow Tainted: G E 4.6.0-1-armmp-lpae #1 Debian 4.6.2-2 > Hardware name: Allwinner sun7i (A20) Family > [<c022efdc>] (unwind_backtrace) from [<c02290c8>] (show_stack+0x20/0x24) > [<c02290c8>] (show_stack) from [<c051a66c>] (dump_stack+0x98/0xac) > [<c051a66c>] (dump_stack) from [<c0374004>] (panic+0xfc/0x28c) > [<c0374004>] (panic) from [<c026bcb8>] (complete_and_exit+0x0/0x2c) > [<c026bcb8>] (complete_and_exit) from [<c028ac44>] (SyS_reboot+0x1c8/0x238) > [<c028ac44>] (SyS_reboot) from [<c0224aa0>] (ret_fast_syscall+0x0/0x34) > ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000000 > > What makes this kind of strange is that it appears to happen > depending on the u-boot version I use. Plain upstream > v2016.03, v2016.05 and v2016.07rc3 all cause a crash, while > the Debian version 2016.03+dfsg1-6 works without problems: > > systemd-shutdown[1]: Sending SIGTERM to remaining processes... > systemd-journald[534]: Received SIGTERM from PID 1 (systemd-shutdow). > systemd-shutdown[1]: Sending SIGKILL to remaining processes... > systemd-shutdown[1]: Unmounting file systems. > systemd-shutdown[1]: Remounting '/' read-only with options 'errors=remount-ro,data=ordered'. > EXT4-fs (sda2): re-mounted. Opts: errors=remount-ro,data=ordered > systemd-shutdown[1]: Remounting '/' read-only with options 'errors=remount-ro,data=ordered'. > EXT4-fs (sda2): re-mounted. Opts: errors=remount-ro,data=ordered > systemd-shutdown[1]: All filesystems unmounted. > systemd-shutdown[1]: Deactivating swaps. > systemd-shutdown[1]: All swaps deactivated. > systemd-shutdown[1]: Detaching loop devices. > systemd-shutdown[1]: All loop devices detached. > systemd-shutdown[1]: Detaching DM devices. > systemd-shutdown[1]: All DM devices detached. > systemd-shutdown[1]: Powering off. > kvm: exiting hardware virtualization > sd 0:0:0:0: [sda] Synchronizing SCSI cache > sd 0:0:0:0: [sda] Stopping disk > musb-hdrc musb-hdrc.1.auto: remove, state 4 > usb usb2: USB disconnect, device number 1 > musb-hdrc musb-hdrc.1.auto: USB bus 2 deregistered > reboot: Power down > > The only possibly relevant change in the Debian build compared to > upstream v2016.03 that I can see is cherry-picking commit > affa020559bca31d6531e19cb1f009c22705a73d from upstream u-boot > v2016.05 (which addresses an i2c-related hang on Lime/Lime2 > boards by setting certain regulator voltages, but doesn't touch > e.g. the Cubietruck at all): > > https://anonscm.debian.org/cgit/collab-maint/u-boot.git/tree/debian/patches… > > I have cross-checked that by building upstream v2016.03 with this > patch on top - no panic happens, while with plain upstream > v2016.03 the system does panic. > > So on a Cubietruck, plain upstream v2016.03 results in a panic; > plain upstream v2016.03 with the aforementioned commit > cherry-picked on top works fine, even though the commit is > completely irrelevant to the Cubietruck. Plain upstream v2016.05, > which contains this commit, crashes again, as does v2016.07-rc3. > > Can anybody reproduce this problem or does anybody have an idea > what could be happening here? You're likely being hit by the irq affinity problem I've been discussing upstream. Try disabling irqbalanced, it seems that the latest version ties the i2c controller irq to cpu-1, and before power down cpu-1 is shutdown leaving only cpu-0 resulting in the interrupts going nowhere and the bus seeming to be stuck to the kernel. Regards, Hans

1 0

[U-Boot] [PATCH 1/1] sunxi: Add support for A33-OLinuXino board
by stefan.mavrodiev＠gmail.com 02 Jul '16

02 Jul '16

From: Stefan Mavrodiev <stefan.mavrodiev(a)gmail.com> --- arch/arm/dts/Makefile | 3 +- arch/arm/dts/sun8i-a33-olinuxino.dts | 223 +++++++++++++++++++++++++++++++++++ configs/A33_OLinuXino_defconfig | 29 +++++ 3 files changed, 254 insertions(+), 1 deletion(-) create mode 100644 arch/arm/dts/sun8i-a33-olinuxino.dts create mode 100644 configs/A33_OLinuXino_defconfig diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index a827613..dbda275 100644 --- a/arch/arm/dts/Makefile +++ b/arch/arm/dts/Makefile @@ -221,7 +221,8 @@ dtb-$(CONFIG_MACH_SUN8I_A23) += \ dtb-$(CONFIG_MACH_SUN8I_A33) += \ sun8i-a33-ga10h-v1.1.dtb \ sun8i-a33-q8-tablet.dtb \ - sun8i-a33-sinlinx-sina33.dtb + sun8i-a33-sinlinx-sina33.dtb \ + sun8i-a33-olinuxino.dtb dtb-$(CONFIG_MACH_SUN8I_A83T) += \ sun8i-a83t-allwinner-h8homlet-v2.dtb \ sun8i-a83t-cubietruck-plus.dtb \ diff --git a/arch/arm/dts/sun8i-a33-olinuxino.dts b/arch/arm/dts/sun8i-a33-olinuxino.dts new file mode 100644 index 0000000..2eaeb55 --- /dev/null +++ b/arch/arm/dts/sun8i-a33-olinuxino.dts @@ -0,0 +1,223 @@ +/* + * Copyright 2016 - Stefan Mavrodiev <stefan.mavrodiev(a)gmail.com> + * Olimex LTD. <support(a)olimex.com> + * + * This file is dual-licensed: you can use it either under the terms + * of the GPL or the X11 license, at your option. Note that this dual + * licensing only applies to this file, and not this project as a + * whole. + * + * a) This file is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of the + * License, or (at your option) any later version. + * + * This file is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * Or, alternatively, + * + * b) Permission is hereby granted, free of charge, to any person + * obtaining a copy of this software and associated documentation + * files (the "Software"), to deal in the Software without + * restriction, including without limitation the rights to use, + * copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following + * conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. + */ + +/dts-v1/; +#include "sun8i-a33.dtsi" +#include "sunxi-common-regulators.dtsi" + +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> +#include <dt-bindings/pinctrl/sun4i-a10.h> + +/ { + model = "A33-OLinuXino"; + compatible = "allwinner,sun8i-a33"; + + aliases { + serial0 = &uart0; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; + + leds { + compatible = "gpio-leds"; + pinctrl-names = "default"; + pinctrl-0 = <&led_pin_olinuxino>; + + green { + label = "olinuxino:green:usr"; + gpios = <&pio 1 7 GPIO_ACTIVE_HIGH>; /* LED2 */ + linux,default-trigger = "heartbeat"; + }; + }; +}; + +&ehci0 { + status = "okay"; +}; + +&ohci0 { + status = "okay"; +}; + +&mmc0 { + pinctrl-names = "default"; + pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_olinuxino>; + vmmc-supply = <&reg_dcdc1>; + bus-width = <4>; + cd-gpios = <&pio 1 4 GPIO_ACTIVE_HIGH>; /* PB4 */ + cd-inverted; + status = "okay"; +}; + +&pio { + mmc0_cd_pin_olinuxino: mmc0_cd_pin@0 { + allwinner,pins = "PB4"; + allwinner,function = "gpio_in"; + allwinner,drive = <SUN4I_PINCTRL_10_MA>; + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>; + }; + + led_pin_olinuxino: led_pins@0 { + allwinner,pins = "PB7"; + allwinner,function = "gpio_out"; + allwinner,drive = <SUN4I_PINCTRL_10_MA>; + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>; + }; +}; + +&r_rsb { + status = "okay"; + + axp22x: pmic@3a3 { + compatible = "x-powers,axp223"; + reg = <0x3a3>; + interrupt-parent = <&nmi_intc>; + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; + eldoin-supply = <&reg_dcdc1>; + }; +}; + +#include "axp22x.dtsi" + +&reg_dcdc1 { + regulator-always-on; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-name = "vcc-dsi"; +}; + +&reg_dc1sw { + regulator-always-on; + regulator-name = "vcc-lcd"; +}; + +&reg_dcdc2 { + regulator-always-on; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <1400000>; + regulator-name = "vdd-sys"; +}; + +&reg_dcdc3 { + regulator-always-on; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <1400000>; + regulator-name = "vdd-cpu"; +}; + +&reg_dcdc5 { + regulator-always-on; + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <1500000>; + regulator-name = "vcc-dram"; +}; + +&reg_dc5ldo { + regulator-always-on; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <1400000>; + regulator-name = "vdd-cpus"; +}; + +&reg_aldo1 { + regulator-always-on; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-name = "vcc-io"; +}; + +&reg_aldo2 { + regulator-always-on; + regulator-min-microvolt = <2350000>; + regulator-max-microvolt = <2650000>; + regulator-name = "vdd-dll"; +}; + +&reg_aldo3 { + regulator-always-on; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-name = "vcc-avcc"; +}; + +&reg_dldo3 { + regulator-always-on; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + regulator-name = "vcc-csi"; +}; + +&reg_eldo2 { + regulator-always-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-name = "vcc-dvdd-csi"; +}; + +&reg_rtc_ldo { + regulator-name = "vcc-rtc"; +}; + +&uart0 { + pinctrl-names = "default"; + pinctrl-0 = <&uart0_pins_b>; + status = "okay"; +}; + +&usb_otg { + dr_mode = "host"; + status = "okay"; +}; + +&usbphy { + usb0_vbus-supply = <&reg_vcc5v0>; + status = "okay"; + +}; + +&simplefb_lcd { + vcc-lcd-supply = <&reg_dc1sw>; +}; diff --git a/configs/A33_OLinuXino_defconfig b/configs/A33_OLinuXino_defconfig new file mode 100644 index 0000000..d8fc110 --- /dev/null +++ b/configs/A33_OLinuXino_defconfig @@ -0,0 +1,29 @@ +CONFIG_ARM=y +CONFIG_ARCH_SUNXI=y +CONFIG_MACH_SUN8I_A33=y +CONFIG_DRAM_CLK=552 +CONFIG_DRAM_ZQ=15291 +CONFIG_MMC0_CD_PIN="PB4" +CONFIG_USB0_VBUS_PIN="AXP0-VBUS-ENABLE" +CONFIG_USB0_VBUS_DET="AXP0-VBUS-DETECT" +CONFIG_AXP_GPIO=y +CONFIG_USB0_ID_DET="PB3" +CONFIG_USB_MUSB_HOST=y +CONFIG_USB_MUSB_SUNXI=y +CONFIG_DEFAULT_DEVICE_TREE="sun8i-a33-olinuxino" +# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set +CONFIG_SPL=y +CONFIG_HUSH_PARSER=y +CONFIG_CMD_BOOTZ=y +# CONFIG_CMD_IMLS is not set +# CONFIG_CMD_FLASH is not set +CONFIG_CMD_MMC=y +# CONFIG_CMD_FPGA is not set +CONFIG_CMD_DHCP=y +CONFIG_CMD_MII=y +CONFIG_CMD_PING=y +CONFIG_CMD_EXT2=y +CONFIG_CMD_EXT4=y +CONFIG_CMD_FAT=y +CONFIG_CMD_FS_GENERIC=y +# CONFIG_VIDEO is not set -- 2.8.1

2 2