April 2016 - U-Boot

[U-Boot] same fail reported on two componet of DIMM , in Memtest
by sun 21 Apr '16

21 Apr '16

hi,there is fail reported with same error information on two different componet of one DIMM,it makes me confused,since i think it unreasonable ,wish you can help me to explain a bit. thank you so much! -- View this message in context: http://u-boot.10912.n7.nabble.com/same-fail-reported-on-two-componet-of-DIM… Sent from the U-Boot mailing list archive at Nabble.com.

1 1

[U-Boot] [PATCH 1/6] i2c: designware_i2c: Add ic_enable_status to ic_regs struct
by Stefan Roese 20 Apr '16

20 Apr '16

Add the ic_enable_status register to the ic_regs struct. Additionally the register offsets are added, to better check, if the offset matches the register description in the datasheet. Signed-off-by: Stefan Roese <sr(a)denx.de> Cc: Simon Glass <sjg(a)chromium.org> Cc: Bin Meng <bmeng.cn(a)gmail.com> Cc: Marek Vasut <marex(a)denx.de> Cc: Heiko Schocher <hs(a)denx.de> --- drivers/i2c/designware_i2c.h | 68 +++++++++++++++++++++++--------------------- 1 file changed, 35 insertions(+), 33 deletions(-) diff --git a/drivers/i2c/designware_i2c.h b/drivers/i2c/designware_i2c.h index 19b09df..270c29c 100644 --- a/drivers/i2c/designware_i2c.h +++ b/drivers/i2c/designware_i2c.h @@ -9,39 +9,41 @@ #define __DW_I2C_H_ struct i2c_regs { - u32 ic_con; - u32 ic_tar; - u32 ic_sar; - u32 ic_hs_maddr; - u32 ic_cmd_data; - u32 ic_ss_scl_hcnt; - u32 ic_ss_scl_lcnt; - u32 ic_fs_scl_hcnt; - u32 ic_fs_scl_lcnt; - u32 ic_hs_scl_hcnt; - u32 ic_hs_scl_lcnt; - u32 ic_intr_stat; - u32 ic_intr_mask; - u32 ic_raw_intr_stat; - u32 ic_rx_tl; - u32 ic_tx_tl; - u32 ic_clr_intr; - u32 ic_clr_rx_under; - u32 ic_clr_rx_over; - u32 ic_clr_tx_over; - u32 ic_clr_rd_req; - u32 ic_clr_tx_abrt; - u32 ic_clr_rx_done; - u32 ic_clr_activity; - u32 ic_clr_stop_det; - u32 ic_clr_start_det; - u32 ic_clr_gen_call; - u32 ic_enable; - u32 ic_status; - u32 ic_txflr; - u32 ix_rxflr; - u32 reserved_1; - u32 ic_tx_abrt_source; + u32 ic_con; /* 0x00 */ + u32 ic_tar; /* 0x04 */ + u32 ic_sar; /* 0x08 */ + u32 ic_hs_maddr; /* 0x0c */ + u32 ic_cmd_data; /* 0x10 */ + u32 ic_ss_scl_hcnt; /* 0x14 */ + u32 ic_ss_scl_lcnt; /* 0x18 */ + u32 ic_fs_scl_hcnt; /* 0x1c */ + u32 ic_fs_scl_lcnt; /* 0x20 */ + u32 ic_hs_scl_hcnt; /* 0x24 */ + u32 ic_hs_scl_lcnt; /* 0x28 */ + u32 ic_intr_stat; /* 0x2c */ + u32 ic_intr_mask; /* 0x30 */ + u32 ic_raw_intr_stat; /* 0x34 */ + u32 ic_rx_tl; /* 0x38 */ + u32 ic_tx_tl; /* 0x3c */ + u32 ic_clr_intr; /* 0x40 */ + u32 ic_clr_rx_under; /* 0x44 */ + u32 ic_clr_rx_over; /* 0x48 */ + u32 ic_clr_tx_over; /* 0x4c */ + u32 ic_clr_rd_req; /* 0x50 */ + u32 ic_clr_tx_abrt; /* 0x54 */ + u32 ic_clr_rx_done; /* 0x58 */ + u32 ic_clr_activity; /* 0x5c */ + u32 ic_clr_stop_det; /* 0x60 */ + u32 ic_clr_start_det; /* 0x64 */ + u32 ic_clr_gen_call; /* 0x68 */ + u32 ic_enable; /* 0x6c */ + u32 ic_status; /* 0x70 */ + u32 ic_txflr; /* 0x74 */ + u32 ic_rxflr; /* 0x78 */ + u32 ic_sda_hold; /* 0x7c */ + u32 ic_tx_abrt_source; /* 0x80 */ + u8 res1[0x18]; /* 0x84 */ + u32 ic_enable_status; /* 0x9c */ }; #if !defined(IC_CLK) -- 2.7.3

4 30

[U-Boot] [PATCH 2/4] ar933x: serial: Remove the explicit pinctrl setting
by Wills Wang 20 Apr '16

20 Apr '16

The correct pinctrl is handled automatically so we don't need to do it in the driver. Signed-off-by: Wills Wang <wills.wang(a)live.com> --- drivers/serial/serial_ar933x.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/serial/serial_ar933x.c b/drivers/serial/serial_ar933x.c index d43f9c9..aae66dc 100644 --- a/drivers/serial/serial_ar933x.c +++ b/drivers/serial/serial_ar933x.c @@ -38,6 +38,7 @@ struct ar933x_serial_priv { }; /* + * Baudrate algorithm come from Linux/drivers/tty/serial/ar933x_uart.c * baudrate = (clk / (scale + 1)) * (step * (1 / 2^17)) */ static u32 ar933x_serial_get_baud(u32 clk, u32 scale, u32 step) @@ -145,27 +146,14 @@ static int ar933x_serial_pending(struct udevice *dev, bool input) static int ar933x_serial_probe(struct udevice *dev) { struct ar933x_serial_priv *priv = dev_get_priv(dev); - struct udevice *pinctrl; fdt_addr_t addr; u32 val; - int ret; - - ret = uclass_get_device(UCLASS_PINCTRL, 0, &pinctrl); - if (ret) - return ret; - ret = pinctrl_get_periph_id(pinctrl, dev); - if (ret < 0) - return ret; - ret = pinctrl_request(pinctrl, ret, 0); - if (ret < 0) - return ret; addr = dev_get_addr(dev); if (addr == FDT_ADDR_T_NONE) return -EINVAL; - priv->regs = map_physmem(addr, - AR933X_UART_SIZE, + priv->regs = map_physmem(addr, AR933X_UART_SIZE, MAP_NOCACHE); /* -- 1.9.1

2 1

[U-Boot] [PATCH 1/4] ath79: spi: Remove the explicit pinctrl setting
by Wills Wang 20 Apr '16

20 Apr '16

The correct pinctrl is handled automatically so we don't need to do it in the driver. Signed-off-by: Wills Wang <wills.wang(a)live.com> --- drivers/spi/ath79_spi.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/spi/ath79_spi.c b/drivers/spi/ath79_spi.c index 0c1022d..b18c733 100644 --- a/drivers/spi/ath79_spi.c +++ b/drivers/spi/ath79_spi.c @@ -175,19 +175,7 @@ static int ath79_spi_set_mode(struct udevice *bus, uint mode) static int ath79_spi_probe(struct udevice *bus) { struct ath79_spi_priv *priv = dev_get_priv(bus); - struct udevice *pinctrl; fdt_addr_t addr; - int ret; - - ret = uclass_get_device(UCLASS_PINCTRL, 0, &pinctrl); - if (ret) - return ret; - ret = pinctrl_get_periph_id(pinctrl, bus); - if (ret < 0) - return ret; - ret = pinctrl_request(pinctrl, ret, 0); - if (ret < 0) - return ret; addr = dev_get_addr(bus); if (addr == FDT_ADDR_T_NONE) -- 1.9.1

2 1

[U-Boot] [PATCH] cmd: fdt: Use separate CMD_FDT Kconfig entry instead of OF_LIBFDT
by Michal Simek 20 Apr '16

20 Apr '16

Create CMD_FDT Kconfig entry to have an option to disable fdt command which is not required for small configuration which requires libfdt only. Enable it by default for all targets which enables OF_LIBFDT. Signed-off-by: Michal Simek <michal.simek(a)xilinx.com> --- cmd/Kconfig | 7 +++++++ cmd/Makefile | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index fe8b4f0510da..8703cdb4a9be 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -173,6 +173,13 @@ config CMD_ELF help Boot an ELF/vxWorks image from the memory. +config CMD_FDT + bool "Flattened Device Tree utility commands" + default y + depends on OF_LIBFDT + help + Do FDT related setup before booting into the Operating System. + config CMD_GO bool "go" default y diff --git a/cmd/Makefile b/cmd/Makefile index ba041973079c..f95759e67044 100644 --- a/cmd/Makefile +++ b/cmd/Makefile @@ -54,7 +54,7 @@ obj-$(CONFIG_CMD_EXT4) += ext4.o obj-$(CONFIG_CMD_EXT2) += ext2.o obj-$(CONFIG_CMD_FAT) += fat.o obj-$(CONFIG_CMD_FDC) += fdc.o -obj-$(CONFIG_OF_LIBFDT) += fdt.o +obj-$(CONFIG_CMD_FDT) += fdt.o obj-$(CONFIG_CMD_FITUPD) += fitupd.o obj-$(CONFIG_CMD_FLASH) += flash.o ifdef CONFIG_FPGA -- 1.9.1

3 12

[U-Boot] cli_simple_run_command results in an unknown reference to "do_bootd" or "parse_string_outer"
by Hugo Heutinck 20 Apr '16

20 Apr '16

Hello, I was attempting to create a custom u-boot command. But I am not able to get the "run_command" or "cli_simple_run_command" to work. I`m building u-boot: am335x_boneblack_defconfig Attempting to use the "run_command" function results in: | common/built-in.o: In function `run_command': | /home/xxxxx/Projects/Yocto/BeagleBoneBlack/build/tmp/work/beaglebone-poky-linux-gnueabi/u-boot/v2015.07+gitAUTOINC+33711bdd4a-r0/git/common/cli.c:43: undefined reference to `parse_string_outer' Attempting to use the cli_simple_run_command, see below. /home/xxxxx/Projects/Yocto/BeagleBoneBlack/build/tmp/work/beaglebone-poky-linux-gnueabi/u-boot/v2015.07+gitAUTOINC+33711bdd4a-r0/git/common/command.c:537: undefined reference to `do_bootd' scripts/Makefile.spl:214: recipe for target 'spl/u-boot-spl' failed make[2]: *** [spl/u-boot-spl] Error 1 Makefile:1263: recipe for target 'spl/u-boot-spl' failed make[1]: *** [spl/u-boot-spl] Error 2 Makefile:457: recipe for target '__build_one_by_one' failed make: *** [__build_one_by_one] Error 2 The small test code is added as cmd_mytestcmd.c in the common/ directory and in the common/Makefile "obj-y += cmd_mytestcmd.o" is added at the end of the file. #include <common.h> #include <command.h> #include <cli.h> #define MAX_CMD_LEN (255) static int do_mytest(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) { int ret = 0; char cmd[MAX_CMD_LEN] = "load mmc 0:1 ${loadaddr} my.env"; ret = cli_simple_run_command(cmd, 0); if (ret == 0) { printf("OK\n"); } else { printf("NOK\n"); } return ret; } U_BOOT_CMD( mytestcmd, 1, 0, do_mytest, "my test command", ""); What am I missing here ? - Is it possible to use the run_command like this ? - Do I need to configure any special CONFIG to enable this functionality ? - ???

2 1

[U-Boot] Saving u-boot.env to FAT partition of SDcard
by Adrian Mcgrath 20 Apr '16

20 Apr '16

Hello All I am in the process of changing U-Boot (v2015.04) to save its environment variables to the FAT partition of an SDcard instead of saving them to the boot sector. I have changed my board header file to: /* Include the below to write env to fat partition of mmc */ #define CONFIG_ENV_IS_IN_FAT #if defined(CONFIG_ENV_IS_IN_FAT) #define CONFIG_ENV_SIZE (8 * 1024) #define FAT_ENV_INTERFACE "mmc" #define FAT_ENV_DEVICE_AND_PART "0:1" #define FAT_ENV_FILE "uboot.env" #define CONFIG_FAT_WRITE #define FAT_ENV_DEVICE 0 #define FAT_ENV_PART 1 #define CONFIG_BOOT_PARTITION_ACCESS #endif /* Include the below to write env to mmc (raw) */ /*#define CONFIG_ENV_IS_IN_MMC*/ #if defined(CONFIG_ENV_IS_IN_MMC) #define CONFIG_ENV_SIZE (8 * 1024) #define CONFIG_ENV_OFFSET (8 * 64 * 1024) #endif U-Boot builds (using Yocto) and runs. I can save the environment and list the file on the card using "fatls": => saveenv Saving Environment to FAT... writing uboot.env done => reset resetting ... However, on the following boot the file is not read: U-Boot 2015.04+fslc+g5d9ffd2 (Apr 19 2016 - 11:38:28) CPU: Freescale i.MX6Q rev1.5 996 MHz (running at 792 MHz) CPU: Extended Commercial temperature grade (-20C to 105C) at 29C Reset cause: WDOG Board: Sw-one I2C: ready DRAM: 1 GiB Enabling i210 PMIC: PFUZE100 ID=0x10 NAND: 256 MiB MMC: FSL_SDHC: 0 reading uboot.env Invalid FAT entry *** Warning - bad CRC, using default environment 00:01.0 - 16c3:abcd - Bridge device 01:00.0 - 8086:157c - Network controller No panel detected: default to Hannstar-XGA Display: Hannstar-XGA (1024x768) In: serial Out: serial Err: serial Net: FEC [PRIME] Error: FEC address not set. Hit any key to stop autoboot: 0 => I saw a post reply by Wolfgang ( http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/16117) that suggested formatting the partition using the host machine and then copying the files back. I have done this (using a Linux host machine) and can copy/write all the files except u-boot.env which gives me an I/O error. Given that I can't copy u-boot.env I'm thinking that the binary has not been created correctly and thus fat_write.c:do_fat_write() needs patching. I'm sure many users out there have reading/writing the env to FAT partition working flawlessly, I would welcome any suggestions or a point towards a relevant patch. Many thanks Adrian

1 0

[U-Boot] [RFC PATCH] i2c/eeprom: Always define I2C_RXTX_LEN
by Mario Six 20 Apr '16

20 Apr '16

From: Mario Six <six(a)gdsys.de> I2C_RXTX_LEN from include/i2c.h is not defined if CONFIG_DM_I2C is enabled. This leads to a compilation error on boards that enable both CONFIG_CMD_EEPROM and CONFIG_DM_I2C. To avoid this, we define I2C_RXTX_LEN in cmd/eeprom.c if it is not already defined. Signed-off-by: Mario Six <mario.six(a)gdsys.cc> --- cmd/eeprom.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/cmd/eeprom.c b/cmd/eeprom.c index 571240a..e5457ba 100644 --- a/cmd/eeprom.c +++ b/cmd/eeprom.c @@ -37,6 +37,10 @@ #define CONFIG_SYS_EEPROM_PAGE_WRITE_BITS 8 #endif +#ifndef I2C_RXTX_LEN +#define I2C_RXTX_LEN 128 +#endif + #define EEPROM_PAGE_SIZE (1 << CONFIG_SYS_EEPROM_PAGE_WRITE_BITS) #define EEPROM_PAGE_OFFSET(x) ((x) & (EEPROM_PAGE_SIZE - 1)) -- 2.7.0.GIT

1 0

[U-Boot] [PATCH] x86: Correct typo of Miao Yan's email address
by Bin Meng 20 Apr '16

20 Apr '16

Miao Yan's email address is wrong in fw_cfg.c. Fix it. Signed-off-by: Bin Meng <bmeng.cn(a)gmail.com> --- arch/x86/cpu/qemu/fw_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/cpu/qemu/fw_cfg.c b/arch/x86/cpu/qemu/fw_cfg.c index a0a3d08..2e2794e 100644 --- a/arch/x86/cpu/qemu/fw_cfg.c +++ b/arch/x86/cpu/qemu/fw_cfg.c @@ -1,5 +1,5 @@ /* - * (C) Copyright 2015 Miao Yan <yanmiaoebst(a)gmail.com> + * (C) Copyright 2015 Miao Yan <yanmiaobest(a)gmail.com> * * SPDX-License-Identifier: GPL-2.0+ */ -- 1.8.2.1

2 2

[U-Boot] [PATCH] gpio: zynq: Add support for reading gpio pin state
by Michal Simek 20 Apr '16

20 Apr '16

Add zynq_gpio_get_function() which return status on gpio pin. This function enables gpio status command. Signed-off-by: Michal Simek <michal.simek(a)xilinx.com> --- drivers/gpio/zynq_gpio.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpio/zynq_gpio.c b/drivers/gpio/zynq_gpio.c index 3a995f610cb3..4ab235608104 100644 --- a/drivers/gpio/zynq_gpio.c +++ b/drivers/gpio/zynq_gpio.c @@ -299,11 +299,33 @@ static int zynq_gpio_direction_output(struct udevice *dev, unsigned gpio, return 0; } +static int zynq_gpio_get_function(struct udevice *dev, unsigned offset) +{ + u32 reg; + unsigned int bank_num, bank_pin_num; + struct zynq_gpio_privdata *priv = dev_get_priv(dev); + + if (check_gpio(offset, dev) < 0) + return -1; + + zynq_gpio_get_bank_pin(offset, &bank_num, &bank_pin_num, dev); + + /* set the GPIO pin as output */ + reg = readl(priv->base + ZYNQ_GPIO_DIRM_OFFSET(bank_num)); + reg &= BIT(bank_pin_num); + if (reg) + return GPIOF_OUTPUT; + else + return GPIOF_INPUT; +} + static const struct dm_gpio_ops gpio_zynq_ops = { .direction_input = zynq_gpio_direction_input, .direction_output = zynq_gpio_direction_output, .get_value = zynq_gpio_get_value, .set_value = zynq_gpio_set_value, + .get_function = zynq_gpio_get_function, + }; static const struct udevice_id zynq_gpio_ids[] = { -- 1.9.1

1 0