February 2008 - U-Boot

[U-Boot-Users] [PATCH] 85xx: Speed up get_ddr_freq() and get_bus_freq()
by Kumar Gala 28 Feb '08

28 Feb '08

From: James Yang get_ddr_freq() and get_bus_freq() used get_sys_info() each time they were called. However, get_sys_info() recalculates extraneous information when called each time. Have get_ddr_freq() and get_bus_freq() return memoized values from global_data instead. Signed-off-by: James Yang Signed-off-by: Kumar Gala <galak(a)kernel.crashing.org> --- in my git tree. cpu/mpc85xx/speed.c | 21 +++++---------------- include/asm-ppc/global_data.h | 2 -- 2 files changed, 5 insertions(+), 18 deletions(-) diff --git a/cpu/mpc85xx/speed.c b/cpu/mpc85xx/speed.c index 952f30c..343316e 100644 --- a/cpu/mpc85xx/speed.c +++ b/cpu/mpc85xx/speed.c @@ -48,6 +48,8 @@ void get_sys_info (sys_info_t * sysInfo) * overflow for processor speeds above 2GHz */ half_freqSystemBus = sysInfo->freqSystemBus/2; sysInfo->freqProcessor = e500_ratio*half_freqSystemBus; + + /* Note: freqDDRBus is the MCLK frequency, not the data rate. */ sysInfo->freqDDRBus = sysInfo->freqSystemBus; #ifdef CONFIG_DDR_CLK_FREQ @@ -75,6 +77,7 @@ int get_clocks (void) get_sys_info (&sys_info); gd->cpu_clk = sys_info.freqProcessor; gd->bus_clk = sys_info.freqSystemBus; + gd->mem_clk = sys_info.freqDDRBus; gd->i2c1_clk = sys_info.freqSystemBus; gd->i2c2_clk = sys_info.freqSystemBus; @@ -96,14 +99,7 @@ int get_clocks (void) *********************************************/ ulong get_bus_freq (ulong dummy) { - ulong val; - - sys_info_t sys_info; - - get_sys_info (&sys_info); - val = sys_info.freqSystemBus; - - return val; + return gd->bus_clk; } /******************************************** @@ -112,12 +108,5 @@ ulong get_bus_freq (ulong dummy) *********************************************/ ulong get_ddr_freq (ulong dummy) { - ulong val; - - sys_info_t sys_info; - - get_sys_info (&sys_info); - val = sys_info.freqDDRBus; - - return val; + return gd->mem_clk; } diff --git a/include/asm-ppc/global_data.h b/include/asm-ppc/global_data.h index 2319b27..4220c73 100644 --- a/include/asm-ppc/global_data.h +++ b/include/asm-ppc/global_data.h @@ -49,9 +49,7 @@ typedef struct global_data { unsigned long scc_clk; unsigned long brg_clk; #endif -#if defined(CONFIG_MPC7448HPC2) unsigned long mem_clk; -#endif #if defined(CONFIG_MPC83XX) /* There are other clocks in the MPC83XX */ u32 csb_clk; -- 1.5.3.8

2 1

[U-Boot-Users] [PATCH] 85xx: Show DDR memory data rate in addition to the memory clock frequency.
by Kumar Gala 28 Feb '08

28 Feb '08

From: James Yang Show the DDR memory data rate in addition to the memory clock frequency. For DDR/DDR2 memories the memory data rate is 2x the memory clock. Signed-off-by: James Yang Signed-off-by: Kumar Gala <galak(a)kernel.crashing.org> --- In my git tree as well. cpu/mpc85xx/cpu.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/cpu/mpc85xx/cpu.c b/cpu/mpc85xx/cpu.c index 558ab0c..31ccf06 100644 --- a/cpu/mpc85xx/cpu.c +++ b/cpu/mpc85xx/cpu.c @@ -110,13 +110,16 @@ int checkcpu (void) ddr_ratio = ((gur->porpllsr) & 0x00003e00) >> 9; switch (ddr_ratio) { case 0x0: - printf(" DDR:%4lu MHz, ", sysinfo.freqDDRBus / 2000000); + printf(" DDR:%4lu MHz (%lu MT/s data rate), ", + sysinfo.freqDDRBus / 2000000, sysinfo.freqDDRBus / 1000000); break; case 0x7: - printf(" DDR:%4lu MHz (Synchronous), ", sysinfo.freqDDRBus / 2000000); + printf(" DDR:%4lu MHz (%lu MT/s data rate) (Synchronous), ", + sysinfo.freqDDRBus / 2000000, sysinfo.freqDDRBus / 1000000); break; default: - printf(" DDR:%4lu MHz (Asynchronous), ", sysinfo.freqDDRBus / 2000000); + printf(" DDR:%4lu MHz (%lu MT/s data rate) (Asynchronous), ", + sysinfo.freqDDRBus / 2000000, sysinfo.freqDDRBus / 1000000); break; } -- 1.5.3.8

2 1

[U-Boot-Users] [PATCH] 85xx: get_tbclk() speed up and rounding fix
by Kumar Gala 28 Feb '08

28 Feb '08

From: James Yang Speed up get_tbclk() by referencing pre-computed bus clock frequency value from global data instead of sys_info_t. Fix rounding of result to nearest; previously it was rounding upwards. Signed-off-by: James Yang Signed-off-by: Kumar Gala <galak(a)kernel.crashing.org> --- In my git tree as well. cpu/mpc85xx/cpu.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/cpu/mpc85xx/cpu.c b/cpu/mpc85xx/cpu.c index ac8b018..558ab0c 100644 --- a/cpu/mpc85xx/cpu.c +++ b/cpu/mpc85xx/cpu.c @@ -30,6 +30,8 @@ #include <command.h> #include <asm/cache.h> +DECLARE_GLOBAL_DATA_PTR; + int checkcpu (void) { sys_info_t sysinfo; @@ -190,11 +192,7 @@ int do_reset (cmd_tbl_t *cmdtp, bd_t *bd, int flag, int argc, char *argv[]) */ unsigned long get_tbclk (void) { - - sys_info_t sys_info; - - get_sys_info(&sys_info); - return ((sys_info.freqSystemBus + 7L) / 8L); + return (gd->bus_clk + 4UL)/8UL; } -- 1.5.3.8

2 1

[U-Boot-Users] [PATCH] 85xx: Don't icbi when unlocking the cache
by Kumar Gala 28 Feb '08

28 Feb '08

There is no reason to icbi when invalidating the temporary stack in the d-cache. Its impossible on e500 to have the i-cache contain any addresses in the temp stack and it can be problematic in generating transactions on the bus to non-valid addresses. Signed-off-by: Kumar Gala <galak(a)kernel.crashing.org> --- in git://git.kernel.org/pub/scm/boot/u-boot/galak/u-boot.git mpc85xx cpu/mpc85xx/start.S | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/cpu/mpc85xx/start.S b/cpu/mpc85xx/start.S index eb24dbc..f4c17f8 100644 --- a/cpu/mpc85xx/start.S +++ b/cpu/mpc85xx/start.S @@ -992,7 +992,6 @@ trap_reloc: blr -#ifdef CFG_INIT_RAM_LOCK .globl unlock_ram_in_cache unlock_ram_in_cache: /* invalidate the INIT_RAM section */ @@ -1002,11 +1001,9 @@ unlock_ram_in_cache: andi. r4,r4,0x1ff slwi r4,r4,(10 - 1 - L1_CACHE_SHIFT) mtctr r4 -1: icbi r0,r3 - dcbi r0,r3 +1: dcbi r0,r3 addi r3,r3,CFG_CACHELINE_SIZE bdnz 1b - sync /* Wait for all icbi to complete on bus */ + sync isync blr -#endif -- 1.5.3.8

2 1

[U-Boot-Users] [PATCH] net: uec_phy: actually increment the timeout counter
by Kim Phillips 27 Feb '08

27 Feb '08

allow u-boot to recover (and, e.g., switch to another interface) in the case where a PHY does not report autonegotiation is complete within its two second timeout value. Signed-off-by: Kim Phillips <kim.phillips(a)freescale.com> --- almost forgot this one :). It also corrects a spelling mistake. This fixes a bug, so it's for 1.3.2. drivers/qe/uec_phy.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/qe/uec_phy.c b/drivers/qe/uec_phy.c index cf9921b..a42701c 100644 --- a/drivers/qe/uec_phy.c +++ b/drivers/qe/uec_phy.c @@ -290,6 +290,7 @@ static int genmii_update_link (struct uec_mii_info *mii_info) return 0; } + i++; udelay(1000); /* 1 ms */ status = phy_read(mii_info, PHY_BMSR); } @@ -577,7 +578,7 @@ void marvell_phy_interface_mode (struct eth_device *dev, u16 status; if (!uec->mii_info) { - printf ("%s: the PHY not intialized\n", __FUNCTION__); + printf ("%s: the PHY not initialized\n", __FUNCTION__); return; } mii_info = uec->mii_info; -- 1.5.4.23.gef5b9

1 0

[U-Boot-Users] Don't believe what people say about size doesn't matter - it means EVERYTHING.
by gurinder McArthur 27 Feb '08

27 Feb '08

Tired of your girl being unable to come when you have sex? Find out how to change that today.

1 0

[U-Boot-Users] [PATCH] Fix mpc8360emds board hang on second network operation
by Jerry Van Baren 27 Feb '08

27 Feb '08

The changeset that causes my problems is ee62ed32 The original code calls init_phy(dev) followed by phy_change(dev) *once* during PHY initialization. The part of changeset that appears to cause my problems is calling phy_change(dev) every time uec_init() is called. On my mpc8360emds board, without this change the second command that does a network operation hangs the board (requires a hard reset to recover). Example failure sequence is two "ping" commands: the first works, the second hangs the board. This also speeds up the network initialization and doesn't cause a packet error on the first TFTP packet. Signed-off-by: Gerald Van Baren <vanbaren(a)cideas.com> --- Kim: Does this make any sense? Any thoughts why it isn't causing problems for you? It makes all the difference in the world for me. One other interesting sequence difference with patch ee62ed32 is that the ethernet MAC address is set on every uec_init() call. The following code was inside the "if (uec->the_first_run == 0)" conditional, now it is outside the conditional and thus run on every uec_init() call. Functionally, it doesn't seem to matter for me either way, but seems unnecessary. + /* Set up the MAC address */ + if (dev->enetaddr[0] & 0x01) { + printf("%s: MacAddress is multcast address\n", + __FUNCTION__); + return -1; + } + uec_set_mac_address(uec, dev->enetaddr); Best regards, gvb P.S. What's the Guiness World Book record for number of words written to explain moving two lines of code? drivers/qe/uec.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/qe/uec.c b/drivers/qe/uec.c index 55f37cb..d447d96 100644 --- a/drivers/qe/uec.c +++ b/drivers/qe/uec.c @@ -1163,6 +1163,8 @@ static int uec_init(struct eth_device* dev, bd_t *bd) return err; } + phy_change(dev); + curphy = uec->mii_info->phyinfo; if (curphy->config_aneg) { @@ -1201,8 +1203,6 @@ static int uec_init(struct eth_device* dev, bd_t *bd) return -1; } - phy_change(dev); - return (uec->mii_info->link ? 0 : -1); } -- 1.5.4.1

2 1

[U-Boot-Users] update new-image branch of u-boot-testing
by Kumar Gala 27 Feb '08

27 Feb '08

Can we get 1.3.2-rc2 pulled into the 'new-image' branch of u-boot- testing. thanks - k

2 4

[U-Boot-Users] [PATCH v2] [new uImage] ppc: Re-order ramdisk/fdt handling sequence
by Kumar Gala 27 Feb '08

27 Feb '08

Doing the fdt before the ramdisk allows us to grow the fdt w/o concern however it does mean we have to go in and fixup the initrd info since we don't know where it will be. Signed-off-by: Kumar Gala <galak(a)kernel.crashing.org> --- Fixed up the error handling. The old code tried returning an error and should have called do_reset(). lib_ppc/bootm.c | 40 +++++++++++++++++++++++++++++++++++----- 1 files changed, 35 insertions(+), 5 deletions(-) diff --git a/lib_ppc/bootm.c b/lib_ppc/bootm.c index 5158ccc..09e349e 100644 --- a/lib_ppc/bootm.c +++ b/lib_ppc/bootm.c @@ -71,7 +71,7 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, bd_t *kbd; void (*kernel)(bd_t *, ulong, ulong, ulong, ulong); - int has_of = 0; + int ret, has_of = 0; #if defined(CONFIG_OF_LIBFDT) char *of_flat_tree; @@ -121,9 +121,6 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, rd_len = rd_data_end - rd_data_start; - alloc_current = ramdisk_high (alloc_current, rd_data_start, rd_len, - sp_limit, get_sp (), &initrd_start, &initrd_end); - #if defined(CONFIG_OF_LIBFDT) /* find flattened device tree */ alloc_current = get_fdt (alloc_current, @@ -134,7 +131,8 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, * if the user wants it (the logic is in the subroutines). */ if (of_flat_tree) { - if (fdt_chosen(of_flat_tree, initrd_start, initrd_end, 0) < 0) { + /* pass in dummy initrd info, we'll fix up later */ + if (fdt_chosen(of_flat_tree, rd_data_start, rd_data_end, 0) < 0) { fdt_error ("/chosen node create failed"); do_reset (cmdtp, flag, argc, argv); } @@ -157,6 +155,38 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, } #endif /* CONFIG_OF_LIBFDT */ + alloc_current = ramdisk_high (alloc_current, rd_data_start, rd_len, + sp_limit, get_sp (), &initrd_start, &initrd_end); + +#if defined(CONFIG_OF_LIBFDT) + /* fixup the initrd now that we know where it should be */ + if ((of_flat_tree) && (initrd_start && initrd_end)) { + uint64_t addr, size; + int total = fdt_num_mem_rsv(of_flat_tree); + int j; + + /* Look for the dummy entry and delete it */ + for (j = 0; j < total; j++) { + fdt_get_mem_rsv(of_flat_tree, j, &addr, &size); + if (addr == rd_data_start) { + fdt_del_mem_rsv(of_flat_tree, j); + break; + } + } + + ret = fdt_add_mem_rsv(of_flat_tree, initrd_start, + initrd_end - initrd_start + 1); + if (ret < 0) { + printf("fdt_chosen: %s\n", fdt_strerror(ret)); + do_reset (cmdtp, flag, argc, argv); + } + + do_fixup_by_path_u32(of_flat_tree, "/chosen", + "linux,initrd-start", initrd_start, 0); + do_fixup_by_path_u32(of_flat_tree, "/chosen", + "linux,initrd-end", initrd_end, 0); + } +#endif debug ("## Transferring control to Linux (at address %08lx) ...\n", (ulong)kernel); -- 1.5.3.8

5 19

[U-Boot-Users] kartvizitlerinizi ucretsiz hediye olarak yapiyoruz...
by YILMAZ MATBAA 27 Feb '08

27 Feb '08

Untitled Document YILMAZ MATBAA Baskı ve Tasarim Merkezi Aynı kalitede, aynı ödeme şartlarında, fakat daha hesaplı iş yaptırmak istiyorsanız lütfen bizi arayın.... Kağıt etiket Dokuma etiket Mıknatıslı etiket Çıkartma etiket Katalog El ilanı Brosür Antetli zarf ve kağıt Davetiye Fatura Irsaliye Makbuz çesitleri Sürekli form Poster Kutu Bloknot Küp blok Dosya Kartela Ajanda Takvim ve TÜM PROMOSYON İŞLERİNİZ için bir telefon açıp fiyat alabilirsiniz..... SINIRSIZ REKTE FOTOĞRAFLI 50 YAPRAKLI KAPAKLI 10*14 EBADINDA BLOKNOT 1000 ADET 450 ytl. SINIRSIZ RENKTE RESİMLİ 50,000 ETİKET 450 ytl. LOGO ÇİZİMLERİ GRAFİK ÇALIŞMALARI FOTOĞRAF ÇEKİMLERİ ÜCRETSİZDİR.. Bİ ZDEN F I YAT ALMADAN Şİ PAR İŞ VERMEY İ N İ Z BUYRUN: Mollafenari sk. no:34 Cagaloglu Sübe: Emintas san sit. Topkapi ARAYIN: (0212) 512 39 31 (0532) 606 86 08 TIKLAYIN:www.yilmaz-matbaa.com /mail lerinizi ( yilmazmatbaa34(a)hotmail.com ) adresine yollarsaniz size daha çabuk dönülecektir...

1 0