October 2008 - U-Boot

[U-Boot] [PATCH 2/3] Fix an overflow case in fdt_offset_ptr() detected by GCC 4.3.
by Jerry Van Baren 02 Oct '08

02 Oct '08

Using Gcc 4.3 detected this problem: ../dtc/libfdt/fdt.c: In function 'fdt_next_tag': ../dtc/libfdt/fdt.c:82: error: assuming signed overflow does not occur when assuming that (X + c) < X is always false To fix the problem, treat the offset as an unsigned int. The problem report and proposed fix were provided by Steve Papacharalambous <stevep(a)freescale.com>. Signed-off-by: Jon Loeliger <jdl(a)freescale.com> --- include/libfdt.h | 2 +- libfdt/fdt.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/libfdt.h b/include/libfdt.h index 94c35e3..5492a53 100644 --- a/include/libfdt.h +++ b/include/libfdt.h @@ -122,7 +122,7 @@ /* Low-level functions (you probably don't need these) */ /**********************************************************************/ -const void *fdt_offset_ptr(const void *fdt, int offset, int checklen); +const void *fdt_offset_ptr(const void *fdt, int offset, unsigned int checklen); static inline void *fdt_offset_ptr_w(void *fdt, int offset, int checklen) { return (void *)(uintptr_t)fdt_offset_ptr(fdt, offset, checklen); diff --git a/libfdt/fdt.c b/libfdt/fdt.c index 732103b..a59a518 100644 --- a/libfdt/fdt.c +++ b/libfdt/fdt.c @@ -78,7 +78,7 @@ int fdt_check_header(const void *fdt) return 0; } -const void *fdt_offset_ptr(const void *fdt, int offset, int len) +const void *fdt_offset_ptr(const void *fdt, int offset, unsigned int len) { const char *p; -- 1.5.6.5

1 1

[U-Boot] [PATCH 1/2] libfdt: Fix bugs in fdt_get_path()
by Jerry Van Baren 02 Oct '08

02 Oct '08

The current implementation of fdt_get_path() has a couple of bugs, fixed by this patch. First, contrary to its documentation, on success it returns the length of the node's path, rather than 0. The testcase is correspondingly wrong, and the patch fixes this as well. Second, in some circumstances, it will return -FDT_ERR_BADOFFSET instead of -FDT_ERR_NOSPACE when given insufficient buffer space. Specifically this happens when there is insufficient space even to hold the path's second last component. This behaviour is corrected, and the testcase updated to check it. Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au> --- This and the next patch are bugfixes from the dtc/libfdt project. gvb libfdt/fdt_ro.c | 23 +++++++++++------------ 1 files changed, 11 insertions(+), 12 deletions(-) diff --git a/libfdt/fdt_ro.c b/libfdt/fdt_ro.c index b09a6e9..f559eed 100644 --- a/libfdt/fdt_ro.c +++ b/libfdt/fdt_ro.c @@ -320,9 +320,6 @@ int fdt_get_path(const void *fdt, int nodeoffset, char *buf, int buflen) for (offset = 0, depth = 0; (offset >= 0) && (offset <= nodeoffset); offset = fdt_next_node(fdt, offset, &depth)) { - if (pdepth < depth) - continue; /* overflowed buffer */ - while (pdepth > depth) { do { p--; @@ -330,14 +327,16 @@ int fdt_get_path(const void *fdt, int nodeoffset, char *buf, int buflen) pdepth--; } - name = fdt_get_name(fdt, offset, &namelen); - if (!name) - return namelen; - if ((p + namelen + 1) <= buflen) { - memcpy(buf + p, name, namelen); - p += namelen; - buf[p++] = '/'; - pdepth++; + if (pdepth >= depth) { + name = fdt_get_name(fdt, offset, &namelen); + if (!name) + return namelen; + if ((p + namelen + 1) <= buflen) { + memcpy(buf + p, name, namelen); + p += namelen; + buf[p++] = '/'; + pdepth++; + } } if (offset == nodeoffset) { @@ -347,7 +346,7 @@ int fdt_get_path(const void *fdt, int nodeoffset, char *buf, int buflen) if (p > 1) /* special case so that root path is "/", not "" */ p--; buf[p] = '\0'; - return p; + return 0; } } -- 1.5.6.5

1 0

[U-Boot] [PATCH v3] Add support for KMC KZM-ARM11-01 board
by Atsuo Igarashi 01 Oct '08

01 Oct '08

This patch adds support for KMC KZM-ARM11-01 board. This board is configured with CFG_HZ=1000, so Signed-off-by: Atsuo Igarashi <atsuo_igarashi(a)tripeaks.co.jp>

2 2

Re: [U-Boot] Cannot enable interrupts Olimex SAM9-L9260
by Björn Saläng 01 Oct '08

01 Oct '08

Thank you for your help! This task might be to hard for us, so we will try to manage without interrupts. Regards Björn & Andreas 2008/10/1 Wolfgang Denk <wd(a)denx.de> > Dear "=?ISO-8859-1?Q?Bj=F6rn_Sal=E4ng?=", > > In message <aa37bd180810010632r113b3d48lda818664b1e84357(a)mail.gmail.com> > you wrote: > > > > Hi again! Thank You Wolfgang for spending time on us. > > YOu are welcome - but please keep the list on Cc: ! > > > So you are proposing we should rebuild U-boot and upload it on our board? > To > > No - that will probably not be sufficient. You have to add the code > first that implements interrupt support, it seems. > > > much about it. We hoped we only needed to change the binary file of our > > standalone program compiled on our host computer. > > Change U-boot or standalone binary? > > Extend the U-Boot code to add interrupt support, then rebuild and > install the new U-Boot. > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd(a)denx.de > "There are three principal ways to lose money: wine, women, and engi- > neers. While the first two are more pleasant, the third is by far the > more certain." - Baron Rothschild, ca. 1800 >

1 0

[U-Boot] Cannot enable interrupts Olimex SAM9-L9260
by Björn Saläng 01 Oct '08

01 Oct '08

Hi! We are running a standalone program via U-boot on our Olimex SAM9-L9260 board with a AT91SAM9260. Included with the board was a CD with U-boot including some board-specific files. We are able to compile and run a Hello-World example as well as starting timers and generating pwm-signals. But we seem unable to generate interrupts, we have tried both from the button on the board (IRQ1) and from a Timer-Counter. We think we are doing everything according to Atmels datacheet for AT91SAM9260 but it's just not working. We are kind of lost and not sure what's wrong or what we are supposed to ask, but we have made some obeservations. We have been searching through U-boot config-, header-, source- and makefiles. And found that in our sam9l9260.h it says: #undef CONFIG_USE_IRQ Does this mean we are not using interrupts? >From what we gather U-boot configures the processor-core before our code starts, is that something we want to look into? If you are not familiar with this board it is supposed to be very similar to the AT91SAM9260EK. Please help us figure this one out! Regards Björn Saläng & Andreas Gising

2 3

[U-Boot] [PATCH] TQM5200: enable support for ATAPI devices
by Wolfgang Denk 01 Oct '08

01 Oct '08

Signed-off-by: Wolfgang Denk <wd(a)denx.de> --- include/configs/TQM5200.h | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/include/configs/TQM5200.h b/include/configs/TQM5200.h index efc8da4..2cc215a 100644 --- a/include/configs/TQM5200.h +++ b/include/configs/TQM5200.h @@ -720,6 +720,9 @@ /* Interval between registers */ #define CFG_ATA_STRIDE 4 +/* Support ATAPI devices */ +#define CONFIG_ATAPI 1 + /*----------------------------------------------------------------------- * Open firmware flat tree support *----------------------------------------------------------------------- -- 1.5.6.1

1 0

Re: [U-Boot] U-BOOT and Marvell Feroceon 88f5181
by Prafulla Wadaskar 01 Oct '08

01 Oct '08

Hi Kurobox Pro (Marvell's 88F5182 based) board support is mainlined with u-boot project, you can get it from u-boot git. May be it is helpful since similar to 88F5181 Regards.. Prafulla... > -----Original Message----- > From: Yotam Admon > Sent: Sunday, September 28, 2008 11:25 AM > To: Prafulla Wadaskar > Subject: FW: [U-Boot] U-BOOT and Marvell Feroceon 88f5181 > > > Hi Prafulla, > Do you work on this issue? Can you help the guy? > Thanks, > Yotam > ________________________________ > > Yotam Admon - Software Engineer > Marvell Israel LTD Controllers and SoC Line > 6 Hamada Street > Mordot HaCarmel Industrial Park > Yokneam, 20692, Israel > Email: yotam(a)marvell.com > Office: +972.4.9091625 - OnNet: 704.1625 > Fax: +972.4.9091564 > Mobile: +972.54.2490423 > Web site: http://www.marvell.com > > This message may contain confidential, proprietary or legally privileged > information. The information is intended only for the use of the > individual or entity named above. If the reader of this message is not the > intended recipient, you are hereby notified that any dissemination, > distribution or copying of this communication is strictly prohibited. If > you have received this communication in error, please notify us > immediately by telephone or by e-mail and delete the message from your > computer. > ________________________________ > > -----Original Message----- > From: u-boot-bounces(a)lists.denx.de [mailto:u-boot-bounces@lists.denx.de] > On Behalf Of Uwe Ziegler > Sent: Friday, September 26, 2008 7:46 AM > To: u-boot(a)lists.denx.de > Subject: [U-Boot] U-BOOT and Marvell Feroceon 88f5181 > > Hello, > > is there an U-Boot available for the Marvell Feroceon 88f5181 ? > > > ________________________________________________________________________ _ > In 5 Schritten zur eigenen Homepage. Jetzt Domain sichern und gestalten! > Nur 3,99 EUR/Monat! http://www.maildomain.web.de/?mc=021114 > > _______________________________________________ > U-Boot mailing list > U-Boot(a)lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot

1 0