February 2007 - U-Boot

[U-Boot-Users] protest nullify
by Katharine 26 Feb '07

26 Feb '07

1 0

[U-Boot-Users] [DNX#2007022642000017] [PATCH v3] Add sync to ensure flash_write_cmd [...]
by U-Boot patch tracking system 26 Feb '07

26 Feb '07

Dear Mr. U. Boot, thank you for your contribution to the U-Boot project. Your e-mail was registered at our system under the ticket number [DNX#2007022642000017]. Please keep this ticket ID string in the subject line of any e-mail replies!!! Your U-Boot support team Powered by OTRS (http://otrs.org/)

1 0

[U-Boot-Users] [DNX#2007022642000017] [PATCH v3] Add sync to ensure flash [...]
by DENX Support System 26 Feb '07

26 Feb '07

Hello list, inside the automatic U-Boot patch tracking system a new ticket [DNX#2007022642000017] was created: <snip> > On Wednesday 21 February 2007 17:19, Haiying Wang wrote: > > Some CPUs like PPC, BLACKFIN need sync() to ensure cfi flash write command > > is fully finished. The sync() is defined in each CPU's io.h file. For those > > CPUs which do not need sync for now, a dummy sync() is defined in their > > io.h as well. > > > > Signed-off-by: Haiying Wang <Haiying.Wang(a)freescale.com> > > Applied. Thanks. > > Best regards, > Stefan > > ===================================================================== > DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk > Office: Kirchenstr. 5, D-82194 Groebenzell, Germany > ===================================================================== </snip> Your U-Boot support team

1 0

[U-Boot-Users] Second set of miscellaneous patches
by Grant Likely 26 Feb '07

26 Feb '07

Here is another set of miscellaneous patches from my queue. Please comment and/or merge. These patches can also be pulled from my git tree: git://git.secretlab.ca/srv/git-trees/public/git/u-boot.git#merge http://git.secretlab.ca/git/u-boot.git#merge Patches 1, 2 and 4 are the same as in my previous set, so I haven't resent them (hence the missing patch numbers) Patch #3 has been modified based on comments from the mailing list Patches 5-9 are new. board/esd/common/auto_update.c | 3 +- board/mcc200/auto_update.c | 3 +- board/mpl/mip405/mip405.c | 3 - board/trab/auto_update.c | 1 - board/xilinx/ml300/Makefile | 2 +- board/xilinx/ml300/ml300.c | 2 +- board/xilinx/ml300/serial.c | 3 +- board/xilinx/xilinx_enet/emac_adapter.c | 2 +- board/xilinx/xilinx_enet/xemac.h | 2 +- board/xilinx/xilinx_enet/xemac_g.c | 2 +- board/xilinx/xilinx_iic/iic_adapter.c | 2 +- common/Makefile | 3 +- common/cmd_ace.c | 267 ------------------------------- common/cmd_ext2.c | 40 +----- common/cmd_fat.c | 37 +---- common/cmd_ide.c | 16 ++- common/cmd_mem.c | 65 ++------ common/cmd_reiser.c | 40 +----- common/cmd_scsi.c | 6 +- common/cmd_usb.c | 1 + common/ft_build.c | 6 +- common/usb_storage.c | 7 +- cpu/pxa/mmc.c | 4 +- disk/part.c | 49 ++++++ drivers/Makefile | 2 +- drivers/systemace.c | 247 ++++++++++++++++++++++++++++ include/common.h | 2 + include/ide.h | 6 +- include/part.h | 15 ++- lib_generic/display_options.c | 70 ++++++++ 30 files changed, 439 insertions(+), 469 deletions(-)

2 7

[U-Boot-Users] [PATCH v3] Add sync to ensure flash_write_cmd is fully finished
by Haiying Wang 26 Feb '07

26 Feb '07

Some CPUs like PPC, BLACKFIN need sync() to ensure cfi flash write command is fully finished. The sync() is defined in each CPU's io.h file. For those CPUs which do not need sync for now, a dummy sync() is defined in their io.h as well. Signed-off-by: Haiying Wang <Haiying.Wang(a)freescale.com> --- drivers/cfi_flash.c | 16 ++++------------ include/asm-arm/io.h | 4 ++++ include/asm-avr32/io.h | 4 ++++ include/asm-blackfin/io.h | 5 +++++ include/asm-i386/io.h | 4 ++++ include/asm-m68k/io.h | 9 ++++++++- include/asm-microblaze/io.h | 4 ++++ include/asm-mips/io.h | 4 ++++ include/asm-nios/io.h | 4 ++++ include/asm-nios2/io.h | 5 ++++- include/asm-ppc/io.h | 11 +++++++++-- 11 files changed, 54 insertions(+), 16 deletions(-) diff --git a/drivers/cfi_flash.c b/drivers/cfi_flash.c index 696f9a4..5579a1e 100644 --- a/drivers/cfi_flash.c +++ b/drivers/cfi_flash.c @@ -36,6 +36,7 @@ #include <common.h> #include <asm/processor.h> +#include <asm/io.h> #include <asm/byteorder.h> #include <environment.h> #ifdef CFG_FLASH_CFI_DRIVER @@ -931,27 +932,18 @@ static void flash_write_cmd (flash_info_t * info, flash_sect_t sect, uint offset debug ("fwc addr %p cmd %x %x 8bit x %d bit\n", addr.cp, cmd, cword.c, info->chipwidth << CFI_FLASH_SHIFT_WIDTH); *addr.cp = cword.c; -#ifdef CONFIG_BLACKFIN - asm("ssync;"); -#endif break; case FLASH_CFI_16BIT: debug ("fwc addr %p cmd %x %4.4x 16bit x %d bit\n", addr.wp, cmd, cword.w, info->chipwidth << CFI_FLASH_SHIFT_WIDTH); *addr.wp = cword.w; -#ifdef CONFIG_BLACKFIN - asm("ssync;"); -#endif break; case FLASH_CFI_32BIT: debug ("fwc addr %p cmd %x %8.8lx 32bit x %d bit\n", addr.lp, cmd, cword.l, info->chipwidth << CFI_FLASH_SHIFT_WIDTH); *addr.lp = cword.l; -#ifdef CONFIG_BLACKFIN - asm("ssync;"); -#endif break; case FLASH_CFI_64BIT: #ifdef DEBUG @@ -966,11 +958,11 @@ static void flash_write_cmd (flash_info_t * info, flash_sect_t sect, uint offset } #endif *addr.llp = cword.ll; -#ifdef CONFIG_BLACKFIN - asm("ssync;"); -#endif break; } + + /* Ensure all the instructions are fully finished */ + sync(); } static void flash_unlock_seq (flash_info_t * info, flash_sect_t sect) diff --git a/include/asm-arm/io.h b/include/asm-arm/io.h index 648a10d..47c18e7 100644 --- a/include/asm-arm/io.h +++ b/include/asm-arm/io.h @@ -29,6 +29,10 @@ #include <asm/arch/hardware.h> #endif /* XXX###XXX */ +static inline void sync(void) +{ +} + /* * Generic virtual read/write. Note that we don't support half-word * read/writes. We define __arch_*[bl] here, and leave __arch_*w diff --git a/include/asm-avr32/io.h b/include/asm-avr32/io.h index e86c456..3c0d569 100644 --- a/include/asm-avr32/io.h +++ b/include/asm-avr32/io.h @@ -89,4 +89,8 @@ static __inline__ void * phys_to_virt(unsigned long address) #endif /* __KERNEL__ */ +static inline void sync(void) +{ +} + #endif /* __ASM_AVR32_IO_H */ diff --git a/include/asm-blackfin/io.h b/include/asm-blackfin/io.h index e5b388e..fc27194 100644 --- a/include/asm-blackfin/io.h +++ b/include/asm-blackfin/io.h @@ -25,6 +25,11 @@ #ifndef _BLACKFIN_IO_H #define _BLACKFIN_IO_H +static inline void sync(void) +{ + __asm__ __volatile__ asm("ssync" : : : "memory"); +} + #ifdef __KERNEL__ #include <linux/config.h> diff --git a/include/asm-i386/io.h b/include/asm-i386/io.h index 85d44aa..e64d788 100644 --- a/include/asm-i386/io.h +++ b/include/asm-i386/io.h @@ -201,4 +201,8 @@ __OUTS(b) __OUTS(w) __OUTS(l) +static inline void sync(void) +{ +} + #endif diff --git a/include/asm-m68k/io.h b/include/asm-m68k/io.h index 79a9626..7bbdefb 100644 --- a/include/asm-m68k/io.h +++ b/include/asm-m68k/io.h @@ -1 +1,8 @@ -/* */ +#ifndef __ASM_M68K_IO_H_ +#define __ASM_M68K_IO_H_ + +static inline void sync(void) +{ +} + +#endif /* __ASM_M68K_IO_H_ */ diff --git a/include/asm-microblaze/io.h b/include/asm-microblaze/io.h index 3359045..1c77ade 100644 --- a/include/asm-microblaze/io.h +++ b/include/asm-microblaze/io.h @@ -125,4 +125,8 @@ io_outsl (unsigned long port, const void *src, unsigned long count) #define ioremap_writethrough(physaddr, size) (physaddr) #define ioremap_fullcache(physaddr, size) (physaddr) +static inline void sync(void) +{ +} + #endif /* __MICROBLAZE_IO_H__ */ diff --git a/include/asm-mips/io.h b/include/asm-mips/io.h index 857fb03..cd4d5dc 100644 --- a/include/asm-mips/io.h +++ b/include/asm-mips/io.h @@ -447,4 +447,8 @@ extern void (*_dma_cache_inv)(unsigned long start, unsigned long size); #define dma_cache_wback(start,size) _dma_cache_wback(start,size) #define dma_cache_inv(start,size) _dma_cache_inv(start,size) +static inline void sync(void) +{ +} + #endif /* _ASM_IO_H */ diff --git a/include/asm-nios/io.h b/include/asm-nios/io.h index 07499d9..d77695a 100644 --- a/include/asm-nios/io.h +++ b/include/asm-nios/io.h @@ -97,4 +97,8 @@ static inline void outsl (unsigned long port, const void *src, unsigned long cou while (count--) outl (*p++, port); } +static inline void sync(void) +{ +} + #endif /* __ASM_NIOS_IO_H_ */ diff --git a/include/asm-nios2/io.h b/include/asm-nios2/io.h index 0fab53b..5bb5322 100644 --- a/include/asm-nios2/io.h +++ b/include/asm-nios2/io.h @@ -24,7 +24,10 @@ #ifndef __ASM_NIOS2_IO_H_ #define __ASM_NIOS2_IO_H_ -#define sync() asm volatile ("sync" : : : "memory"); +static inline void sync(void) +{ + __asm__ __volatile__ ("sync" : : : "memory"); +} extern unsigned char inb (unsigned char *port); extern unsigned short inw (unsigned short *port); diff --git a/include/asm-ppc/io.h b/include/asm-ppc/io.h index 8e5fe11..bbc9ba0 100644 --- a/include/asm-ppc/io.h +++ b/include/asm-ppc/io.h @@ -95,8 +95,15 @@ extern void _outsl_ns(volatile u32 *port, const void *buf, int nl); * Acts as a barrier to ensure all previous I/O accesses have * completed before any further ones are issued. */ -#define eieio() __asm__ __volatile__ ("eieio" : : : "memory"); -#define sync() __asm__ __volatile__ ("sync" : : : "memory"); +static inline void eieio(void) +{ + __asm__ __volatile__ ("eieio" : : : "memory"); +} + +static inline void sync(void) +{ + __asm__ __volatile__ ("sync" : : : "memory"); +} /* Enforce in-order execution of data I/O. * No distinction between read/write on PPC; use eieio for all three. -- 1.4.4.4

4 3

[U-Boot-Users] soft i2c I2C_INIT
by Andrew Dyer 25 Feb '07

25 Feb '07

I was looking at common/soft_i2c.c i2c_init(). The first (only) thing it does is call send_reset(). In send_reset() the I2C_INIT macro gets run after the I2C_SCL() and I2C_SDA() macros which seems backwards to me (and somewhat goes against what's in the README). i would expect the port setup to happen first in case there's any weird requirements (clocks to be enabled, weird protection schemes, etc). send_reset() only gets called from i2c_init() that I could see. Would there be any objections to a patch reversing the order of the calls ? -- Hardware, n.: The parts of a computer system that can be kicked.

1 0

[U-Boot-Users] [DNX#2007022542000028] [PATCH] fix combination of CONFIG_I2C_CMD_TREE and CONFIG_SOFT_I [...]
by U-Boot patch tracking system 25 Feb '07

25 Feb '07

Dear Mr. U. Boot, thank you for your contribution to the U-Boot project. Your e-mail was registered at our system under the ticket number [DNX#2007022542000028]. Please keep this ticket ID string in the subject line of any e-mail replies!!! Your U-Boot support team Powered by OTRS (http://otrs.org/)

1 0

[U-Boot-Users] [DNX#2007022542000028] [PATCH] fix combination of CONFIG_I2C_CMD_TREE and [...]
by DENX Support System 25 Feb '07

25 Feb '07

Hello list, inside the automatic U-Boot patch tracking system a new ticket [DNX#2007022542000028] was created: <snip> > If CONFIG_I2C_CMD_TREE and CONFIG_SOFT_I2C are both enabled (and > CFG_CMD_I2C) compilation will fail with not being able to find > i2c_get_bus_speed(). > > This patch changes the code to return CFG_I2C_SPEED on an 'i2c speed' > command and an error message on setting the speed. > > Signed-off-by: Andrew Dyer <amdyer(a)gmail.com> > > -- > Hardware, n.: > The parts of a computer system that can be kicked. </snip> Your U-Boot support team

1 0

[U-Boot-Users] [PATCH] fix combination of CONFIG_I2C_CMD_TREE and CONFIG_SOFT_I2C
by Andrew Dyer 25 Feb '07

25 Feb '07

If CONFIG_I2C_CMD_TREE and CONFIG_SOFT_I2C are both enabled (and CFG_CMD_I2C) compilation will fail with not being able to find i2c_get_bus_speed(). This patch changes the code to return CFG_I2C_SPEED on an 'i2c speed' command and an error message on setting the speed. Signed-off-by: Andrew Dyer <amdyer(a)gmail.com> -- Hardware, n.: The parts of a computer system that can be kicked.

1 0

[U-Boot-Users] scb9328 breakage (CONFIG_NET_MULTI and eth_get_dev)
by Andrew Dyer 24 Feb '07

24 Feb '07

I have a board similar to the scb9328 that I'm working on a port to. I tried compiling a recent version of u-boot for the scb9328 target and it fails with a linker error (see below). The source was pulled from git on Feb. 10, 2007. compiler is from arm ELDK-4.0 Adding a define for CONFIG_NET_MULTI in the board config file makes the compile succeed. I don't actually have an scb9328 (or my new board yet) so I can't test it. Is CONFIG_NET_MULTI pretty much mandatory? If so, why even have it as an option? here's the error message: make[1]: Leaving directory `/home/adyer/Projects/u-boot/common' UNDEF_SYM=`arm-linux-objdump -x lib_generic/libgeneric.a board/scb9328/libscb9328.a cpu/arm920t/libarm920t.a cpu/arm920t/imx/libimx.a lib_arm/libarm.a fs/cramfs/libcramfs.a fs/fat/libfat.a fs/fdos/libfdos.a fs/jffs2/libjffs2.a fs/reiserfs/libreiserfs.a fs/ext2/libext2fs.a net/libnet.a disk/libdisk.a rtc/librtc.a dtt/libdtt.a drivers/libdrivers.a drivers/nand/libnand.a drivers/nand_legacy/libnand_legacy.a drivers/sk98lin/libsk98lin.a post/libpost.a post/cpu/libcpu.a common/libcommon.a |sed -n -e 's/.*$__u_boot_cmd_.*$/-u\1/p'|sort|uniq`;\ cd /home/adyer/Projects/u-boot && arm-linux-ld -Bstatic -T /home/adyer/Projects/u-boot/board/scb9328/u-boot.lds -Ttext 0x08f00000 $UNDEF_SYM cpu/arm920t/start.o \ --start-group lib_generic/libgeneric.a board/scb9328/libscb9328.a cpu/arm920t/libarm920t.a cpu/arm920t/imx/libimx.a lib_arm/libarm.a fs/cramfs/libcramfs.a fs/fat/libfat.a fs/fdos/libfdos.a fs/jffs2/libjffs2.a fs/reiserfs/libreiserfs.a fs/ext2/libext2fs.a net/libnet.a disk/libdisk.a rtc/librtc.a dtt/libdtt.a drivers/libdrivers.a drivers/nand/libnand.a drivers/nand_legacy/libnand_legacy.a drivers/sk98lin/libsk98lin.a post/libpost.a post/cpu/libcpu.a common/libcommon.a --end-group -L /home/adyer/usr/bin/../lib/gcc/arm-linux/4.0.0 -lgcc \ -Map u-boot.map -o u-boot common/libcommon.a(cmd_net.o): In function `net_check_device': /home/adyer/Projects/u-boot/common/cmd_net.c:157: undefined reference to `eth_get_dev' make: *** [u-boot] Error 1 -- Hardware, n.: The parts of a computer system that can be kicked.

2 1