April 2006 - U-Boot

[U-Boot-Users] Re: [DNX#2006040542000037] [patch] Support IDE secondary disk without primary [...]
by DENX Support System 05 Apr '06

05 Apr '06

Hello list, inside the automatic U-Boot patch tracking system a new ticket [DNX#2006040542000037] was created: <snip> > Hello > > Current u-boot does not search disks on secondary port if there is no > disks > on primary port. > > this patch fixes this problem. > > Signed-off-by: Hiroshi Ito <ito(a)mlb.co.jp> > > CHANGELOG: > > * Support IDE secondary disk without primary disk. > Patch by Hiroshi Ito, 5 Apr 2006 </snip> Your U-Boot support team

1 0

[U-Boot-Users] Re: [DNX#2006040542000037] [patch] Support IDE [...]
by U-Boot patch tracking system 05 Apr '06

05 Apr '06

Dear Mr. U. Boot, thank you for your contribution to the U-Boot project. Your e-mail was registered at our system under the ticket number [DNX#2006040542000037]. Your U-Boot support team Powered by OTRS (http://otrs.org/)

1 0

[U-Boot-Users] [patch] Support IDE secondary disk without primary disk.
by ito＠mlb.co.jp 05 Apr '06

05 Apr '06

Hello Current u-boot does not search disks on secondary port if there is no disks on primary port. this patch fixes this problem. Signed-off-by: Hiroshi Ito <ito(a)mlb.co.jp> CHANGELOG: * Support IDE secondary disk without primary disk. Patch by Hiroshi Ito, 5 Apr 2006 diff --git a/common/cmd_ide.c b/common/cmd_ide.c index 41621ba..f37aa07 100644 --- a/common/cmd_ide.c +++ b/common/cmd_ide.c @@ -617,10 +617,11 @@ void ide_init (void) if (s) ata_reset_time = 2*simple_strtol(s, NULL, 10); #endif i = 0; - do { + for (;;) { udelay (10000); /* 10 ms */ c = ide_inb (dev, ATA_STATUS); + if (!(c & ATA_STAT_BUSY)) break; i++; #ifdef CONFIG_AMIGAONEG3SE if (i > (ata_reset_time * 100)) { @@ -636,12 +637,12 @@ void ide_init (void) goto skip_bus; } #endif - return; + break; } if ((i >= 100) && ((i%100)==0)) { putc ('.'); } - } while (c & ATA_STAT_BUSY); + } if (c & (ATA_STAT_BUSY | ATA_STAT_FAULT)) { puts ("not available ");

1 0

Re: [DNX#2006040142000964] [U-Boot-Users] WARNING: in ext2fs.c (fwd)
by DENX Support System 05 Apr '06

05 Apr '06

Hello list, inside the automatic U-Boot patch tracking system a follow up to [DNX#2006040142000964] was entered through the web interface: <snip> > Hello, > > the fix for this bug should be in GIT tree... > > Reinhard > > DENX Support System wrote: > > Hello list, > > > > inside the automatic U-Boot patch tracking system a follow up > > to [DNX#2006040142000964] was entered through the web interface: > > > > <snip> > > > >>------- Forwarded Message > >> > >>Date: Fri, 30 Sep 2005 00:22:57 +0200 > >>From: Reinhard Arlt <reinhard.arlt(a)t-online.de> > >>cc: "'u-boot-users(a)lists.sourceforge.net'" > >><u-boot-users(a)lists.sourceforge > >> .net> > >>Subject: Re: [U-Boot-Users] WARNING: in ext2fs.c > >> > >>Hello, > >> > >>this is a bug on bigendian machines, Who prepares a patch? > >> > >>Best regards > >> > >>Reinhard > >> > >>Roberts, John wrote: > >> > >>> In function: ext2fs_read_file(ext2fs_node_t node, int pos, unsigned > >>>int len, char *buf) > >>> > >>> You may not be getting all the bytes you requested in the 'len' > >>>parameter. Your requested length might be improperly adjusted. > >>> ----------------------- Code snippet ------------- > >>> unsigned int filesize = node->inode.size; > >>> > >>> /* Adjust len so it we can't read past the end of the file. */ > >>> if (len > filesize) { > >>> len = filesize; > >>> } > >>>----------------------------------------------------------- > >>> > >>>"len" is the native requested size, while "filesize" is the files real size, > >>>but byte-swapped and the two are being compared. As long as the byte-swapped > >>>length value is larger than the requested size value, then you'll never have > >>>a problem. > >>> > >>>Now assume the file is 2meg and you requested 2meg. > >>> > >>>IF( len=200000 (2meg) > filesize=2000(2meg byte-swapped) ) > >>>THEN len = filesize > >>> > >>>You end up getting only 2000 bytes. > >>> > >>> The initialization of filesize should be: > >>> unsigned int filesize = __le32_to_cpu (node->inode.size); > >>> Not: > >>> unsigned int filesize = node->inode.size; > >>> > >>> (440gx) > >>> -John Roberts > >>> > >>> > >>> > >>> > >>> > >>>------------------------------------------------------- > >>>This SF.Net email is sponsored by: > >>>Power Architecture Resource Center: Free content, downloads, discussions, > >>>and more. http://solutions.newsforge.com/ibmarch.tmpl > >>>_______________________________________________ > >>>U-Boot-Users mailing list > >>>U-Boot-Users(a)lists.sourceforge.net > >>>https://lists.sourceforge.net/lists/listinfo/u-boot-users > >>> > >> > >> > >> > >>------------------------------------------------------- > >>This SF.Net email is sponsored by: > >>Power Architecture Resource Center: Free content, downloads, > >>discussions, > >>and more. http://solutions.newsforge.com/ibmarch.tmpl > >>_______________________________________________ > >>U-Boot-Users mailing list > >>U-Boot-Users(a)lists.sourceforge.net > >>https://lists.sourceforge.net/lists/listinfo/u-boot-users > >> > >> > >>------- End of Forwarded Message > > > > </snip> > > > > Your U-Boot support team > > </snip> Your U-Boot support team

1 0

[U-Boot-Users] Help: flash driver for CFI complient flash
by s.maiti＠tcs.com 05 Apr '06

05 Apr '06

Hi all, I am using a flash of AMD make (Am29LV160B) in our custom board which is based on mpc8260ads board. This flash is CFI complient. So I want to use the cfi_flash.c as a driver for the flash. Can anyone tell me the procedure ie. what need to be done to use the driver? Please help. Thanks and regards, Souvik Maiti Tata Consultancy Services Limited Notice: The information contained in this e-mail message and/or attachments to it may contain confidential or privileged information. If you are not the intended recipient, any dissemination, use, review, distribution, printing or copying of the information contained in this e-mail message and/or attachments to it are strictly prohibited. If you have received this communication in error, please notify us by reply e-mail or telephone and immediately and permanently delete the message and any attachments. Thank you

4 7

[U-Boot-Users] look new
by Darrel Lowy 05 Apr '06

05 Apr '06

V t A G R A . $ 3,35 V A L t U M . $ 1,20 C t A L t S . $ 3,73 And many , many other interesting information Go to the Site <http://tyryw872.imoethadom.com>

1 0

[U-Boot-Users] [PATCH] Common code for detecting new mpc8xx core.
by David Ho 04 Apr '06

04 Apr '06

This refines the routine for detecting new mpc8xx core. This does however add a few bytes to the initial stack usage (Implemented as a function). Signed-off-by: David Ho <davidho(a)nanometrics.ca> --- cpu/mpc8xx/cpu.c | 11 ++++++++++- cpu/mpc8xx/cpu_init.c | 2 +- include/common.h | 3 +++ include/mpc8xx.h | 7 ++++--- 4 files changed, 18 insertions(+), 5 deletions(-) f04a287d9a8f2e26d0b08f69e0f4884c8b382b6b diff --git a/cpu/mpc8xx/cpu.c b/cpu/mpc8xx/cpu.c index 4a32986..2098256 100644 --- a/cpu/mpc8xx/cpu.c +++ b/cpu/mpc8xx/cpu.c @@ -357,6 +357,15 @@ int checkcpu (void) return check_CPU (clock, pvr, immr); } +int mpc8xx_new_core (void) +{ + uint partnum = get_immr (PARTNUM_MASK); + + return ((partnum == MPC866_FAMILY_PARTNUM) || + (partnum == MPC885_FAMILY_PARTNUM) + ); +} + /* ------------------------------------------------------------------------- */ /* L1 i-cache */ /* the standard 860 has 128 sets of 16 bytes in 2 ways (= 4 kB) */ @@ -560,7 +569,7 @@ unsigned long get_tbclk (void) * * For older chips, it's just MF field of PLPRCR plus one. */ - if ((immr & 0x0FFF) >= MPC8xx_NEW_CLK) { /* MPC866/87x/88x series */ + if (mpc8xx_new_core()) { /* MPC866/87x/88x series */ factor = (PLPRCR_val(MFI) + PLPRCR_val(MFN)/(PLPRCR_val(MFD)+1))/ (PLPRCR_val(PDF)+1) / (1<<PLPRCR_val(S)); } else { diff --git a/cpu/mpc8xx/cpu_init.c b/cpu/mpc8xx/cpu_init.c index b2c59c6..5cff8a6 100644 --- a/cpu/mpc8xx/cpu_init.c +++ b/cpu/mpc8xx/cpu_init.c @@ -95,7 +95,7 @@ void cpu_init_f (volatile immap_t * immr * For newer (starting MPC866) chips PLPRCR layout is different. */ #ifdef CFG_PLPRCR - if (get_immr(0xFFFF) >= MPC8xx_NEW_CLK) + if (mpc8xx_new_core()) mfmask = PLPRCR_MFACT_MSK; else mfmask = PLPRCR_MF_MSK; diff --git a/include/common.h b/include/common.h index d2570a8..00632e2 100644 --- a/include/common.h +++ b/include/common.h @@ -389,6 +389,9 @@ int checkdcache (void); void upmconfig (unsigned int, unsigned int *, unsigned int); ulong get_tbclk (void); void reset_cpu (ulong addr); +#if defined(CONFIG_8xx) +int mpc8xx_new_core (void); +#endif /* $(CPU)/serial.c */ int serial_init (void); diff --git a/include/mpc8xx.h b/include/mpc8xx.h index 2911758..2cff376 100644 --- a/include/mpc8xx.h +++ b/include/mpc8xx.h @@ -132,10 +132,11 @@ #define RSR_ALLBITS (RSR_JTRS|RSR_DBSRS|RSR_DBHRS|RSR_CSRS|RSR_SWRS|RSR_LLRS|RSR_ESRS|RSR_EHRS) /*----------------------------------------------------------------------- - * Newer chips (MPC866 family and MPC87x/88x family) have different - * clock distribution system. Their IMMR lower half is >= 0x0800 + * Newer chips (MPC866 family and MPC87x/88x family) */ -#define MPC8xx_NEW_CLK 0x0800 +#define PARTNUM_MASK 0xFF00 +#define MPC866_FAMILY_PARTNUM 0x0800 +#define MPC885_FAMILY_PARTNUM 0x0900 /*----------------------------------------------------------------------- * PLPRCR - PLL, Low-Power, and Reset Control Register 15-30 -- 1.2.4.g79f5-dirty

3 2

[U-Boot-Users] CONFIG_SKIP_LOWLEVEL_INIT is broken for at91rm9200dk
by Wang Jian 04 Apr '06

04 Apr '06

Hi, When CONFIG_SKIP_LOWLEVEL_INIT is defined, cpu/arm920t/at91rm9200/lowlevel_init.S is commented out and lowlevel_init() is undefined. But cpu/arm920t/start.S will still use lowlevel_init(). See the code --snip-- #ifndef CONFIG_SKIP_LOWLEVEL_INIT bl cpu_init_crit #endif --snip-- but cpu_init_crit() is still defined and use lowlevel_init(). cpu/arm920t/start.o(.text+0xec):/home/lark/arm-u-boot.git/cpu/arm920t/start.S:264: undefined reference to `lowlevel_init' make: *** [u-boot] Error 1 -- lark

5 8

[U-Boot-Users] nand legacy code problem
by Joe Culler 04 Apr '06

04 Apr '06

Hi, I modified u-boot-1.1.4 to booting from NAND flash on s3c2410 and it works fine. After applying my patches to u-boot current source(from git), then it doesn't work :( I added CFG_NAND_LEGACY in include/configs/smdk2410.h and added BOARDLIBS = drivers/nand_legacy/libnand_legacy.a in board/smdk2410/config.mk. Did I miss something else? Thanks. Regards, Joe.

2 1

Re: [DNX#2006040442000057] [U-Boot-Users] [PATCH] Fix itest endianess problem [...]
by DENX Support System 04 Apr '06

04 Apr '06

Hello list, inside the automatic U-Boot patch tracking system a new ticket [DNX#2006040442000057] was created: <snip> > Sorry I didn't Cc: to u-boot-patches(a)denx.de . > > Hello > > Command 'itest' has 2 bugs. > 1. It does not work on big endian machine. > and itest.b may cause unaligned access. > > 2. itest.l does not work on mips CPU. > on mips, > result of (1 << 32) -1 is 0. > (gcc 3.3.4 binutil 2.14.90.0.6 ) > I think, In C language, shifting more than 32bit is undefined. > > Please consider to merge > Patch is attched. > -------- > Hiroshi Ito > Media Lab. Inc., > URL http://www.mlb.co.jp ( Sorry, Japanese only. ) > TEL +81-3-5294-7255 FAX +81-3-5294-7256 </snip> Your U-Boot support team

1 0

Re: [DNX#2006040442000057] [U-Boot-Users] [PATC [...]
by U-Boot patch tracking system 04 Apr '06

04 Apr '06

Dear Mr. U. Boot, thank you for your contribution to the U-Boot project. Your e-mail was registered at our system under the ticket number [DNX#2006040442000057]. Your U-Boot support team Powered by OTRS (http://otrs.org/)

1 0

Re: [DNX#2006040442000048] [U-Boot-Users] [ [...]
by U-Boot patch tracking system 04 Apr '06

04 Apr '06

Dear Mr. U. Boot, thank you for your contribution to the U-Boot project. Your e-mail was registered at our system under the ticket number [DNX#2006040442000048]. Your U-Boot support team Powered by OTRS (http://otrs.org/)

1 0

Re: [DNX#2006040442000039] [U-Boot-Users] [PATC [...]
by U-Boot patch tracking system 04 Apr '06

04 Apr '06

Dear Mr. U. Boot, thank you for your contribution to the U-Boot project. Your e-mail was registered at our system under the ticket number [DNX#2006040442000039]. Your U-Boot support team Powered by OTRS (http://otrs.org/)

1 0

Re: [DNX#2006040442000048] [U-Boot-Users] [PATCH] Fix return value of ext2loa [...]
by DENX Support System 04 Apr '06

04 Apr '06

Hello list, inside the automatic U-Boot patch tracking system a new ticket [DNX#2006040442000048] was created: <snip> > Sorry I didn't Cc: to u-boot-patches(a)denx.de . > follwing are send to u-boot-users(a)lists.sourceforge.net > -------- > > Sorry, I attached wrong patch. > it should not apply. > > Here is a correct patch. > -------- > Hiroshi Ito > Media Lab. Inc., > URL http://www.mlb.co.jp ( Sorry, Japanese only. ) > TEL +81-3-5294-7255 FAX +81-3-5294-7256 > > From: ito(a)mlb.co.jp > Subject: [U-Boot-Users] [PATCH] Fix return value of ext2load > Date: Tue, 04 Apr 2006 16:05:45 +0900 (JST) > Message-Id: <20060404.160545.59656825.ito(a)mlb.co.jp> > > Hello > > > > I like to do > > > > if ext2load ide 0 80400000 $bootfile; then bootm; fi > > > > but the return value of ext2load is always false. > > > > Please consider to merge. > > Patch is attched. > > -------- > > Hiroshi Ito > > Media Lab. Inc., > > URL http://www.mlb.co.jp ( Sorry, Japanese only. ) > > TEL +81-3-5294-7255 FAX +81-3-5294-7256 </snip> Your U-Boot support team

1 0

Re: [DNX#2006040442000039] [U-Boot-Users] [PATCH] Fix fsload loads wrong file [...]
by DENX Support System 04 Apr '06

04 Apr '06

Hello list, inside the automatic U-Boot patch tracking system a new ticket [DNX#2006040442000039] was created: <snip> > Sorry I didn't Cc: to u-boot-patches(a)denx.de . > follwing are send to u-boot-users(a)lists.sourceforge.net > > Hello > > Command 'fsload' loads wrong file. > Example > # ls / > ...<snip>... > -rw-r--r-- 764267 uImage > -rw-r--r-- 764267 uImage2 > # fsload uImage2 > will load uImage. > > Please consider to merge. > Patch is attched. > -------- > Hiroshi Ito > Media Lab. Inc., > URL http://www.mlb.co.jp ( Sorry, Japanese only. ) > TEL +81-3-5294-7255 FAX +81-3-5294-7256 </snip> Your U-Boot support team

1 0

Re: [DNX#2006040442000021] [U-Boot-Users] [PATC [...]
by U-Boot patch tracking system 04 Apr '06

04 Apr '06

Dear Mr. U. Boot, thank you for your contribution to the U-Boot project. Your e-mail was registered at our system under the ticket number [DNX#2006040442000021]. Your U-Boot support team Powered by OTRS (http://otrs.org/)

1 0

Re: [DNX#2006040442000021] [U-Boot-Users] [PATCH] Fix return value of reiserl [...]
by DENX Support System 04 Apr '06

04 Apr '06

Hello list, inside the automatic U-Boot patch tracking system a new ticket [DNX#2006040442000021] was created: <snip> > Sorry I didn't Cc: to u-boot-patches(a)denx.de . > follwing are send to u-boot-users(a)lists.sourceforge.net > -------- > > From: ito(a)mlb.co.jp > Subject: [U-Boot-Users] [PATCH] Fix return value of ext2load > > I like to do > > > > if ext2load ide 0 80400000 $bootfile; then bootm; fi > > > > but the return value of ext2load is always false. > > same bug is in reiserload. > and default value of patition no is set to 1. > which value is same as ext2load. > -------- > Hiroshi Ito > Media Lab. Inc., > URL http://www.mlb.co.jp ( Sorry, Japanese only. ) > TEL +81-3-5294-7255 FAX +81-3-5294-7256 </snip> Your U-Boot support team

1 0

[U-Boot-Users] Re: [DNX#2006040442000011] [patch] Bugfix in I2 [...]
by U-Boot patch tracking system 04 Apr '06

04 Apr '06

Dear Mr. U. Boot, thank you for your contribution to the U-Boot project. Your e-mail was registered at our system under the ticket number [DNX#2006040442000011]. Your U-Boot support team Powered by OTRS (http://otrs.org/)

1 0

[U-Boot-Users] Re: [DNX#2006040442000011] [patch] Bugfix in I2C initialisation on S3C2400
by DENX Support System 04 Apr '06

04 Apr '06

Hello list, inside the automatic U-Boot patch tracking system a new ticket [DNX#2006040442000011] was created: <snip> > Bugfix in I2C initialisation on S3C2400. > > If the bus is blocked because of a previously interrupted transfer, on > the I2CSCL line up to eleven clocks are generated to complete the > transfer > and to cause the hanging device to free the bus. > > With this fix pin I2CSCL (PG6) is really configured as GPIO and the > clock > pulses are really generated. > > Signed-off-by: Martin Krause <martin.krause(a)tqs.de> > > CHANGELOG: > > * Bugfix in I2C initialisation on S3C2400 > Patch by Martin Krause, 4 Apr 2006 </snip> Your U-Boot support team

1 0

[U-Boot-Users] [PATCH] Fix return value of reiserload
by ito＠mlb.co.jp 04 Apr '06

04 Apr '06

From: ito(a)mlb.co.jp Subject: [U-Boot-Users] [PATCH] Fix return value of ext2load > I like to do > > if ext2load ide 0 80400000 $bootfile; then bootm; fi > > but the return value of ext2load is always false. same bug is in reiserload. and default value of patition no is set to 1. which value is same as ext2load. -------- Hiroshi Ito Media Lab. Inc., URL http://www.mlb.co.jp ( Sorry, Japanese only. ) TEL +81-3-5294-7255 FAX +81-3-5294-7256 diff --git a/common/cmd_reiser.c b/common/cmd_reiser.c index 508ffcb..048901f 100644 --- a/common/cmd_reiser.c +++ b/common/cmd_reiser.c @@ -150,7 +150,7 @@ int do_reiserload (cmd_tbl_t *cmdtp, int { char *filename = NULL; char *ep; - int dev, part = 0; + int dev, part = 1; ulong addr = 0, part_length, filelen; disk_partition_t info; block_dev_desc_t *dev_desc = NULL; @@ -263,7 +263,7 @@ int do_reiserload (cmd_tbl_t *cmdtp, int sprintf(buf, "%lX", filelen); setenv("filesize", buf); - return filelen; + return 0; } U_BOOT_CMD(

1 0

[U-Boot-Users] Patch Submission
by Zachary P. Landau 04 Apr '06

04 Apr '06

> Your mailer is not to blame here. There probably was no useful > reference field at all in these messages as you did not actually send > this message, but rather it was me who bounced the whole batch of > open patches. This is supposed to work better when you send a patch > directly to u-boot-patches(a)denx.de When posting patches to the mailing list, should we CC a copy to u-boot-patches(a)denx.de as well? If so, a mention of this should probably be added to the README. Thanks for setting up this patch system, by the way. It's definitely helpful to get some confirmation that patches were received. -- Zachary P. Landau <kapheine(a)gmail.com>

2 1

[U-Boot-Users] pci 1520-compact flash
by Rangaraju 04 Apr '06

04 Apr '06

Hi , in u-boot1.1.4 am using i82365.c driver which is compatible to PCI1520 to detect compact flash.. it detects PCI1520 & says no card...how it detects what type flash card inserted...any docs for further refering will be helpful.... Kind Regards, Rangaraju. -- View this message in context: http://www.nabble.com/pci-1520-compact-flash-t1390005.html#a3735532 Sent from the Uboot - Users forum at Nabble.com.

2 1

[U-Boot-Users] [PATCH] Fix return value of ext2load
by ito＠mlb.co.jp 04 Apr '06

04 Apr '06

Hello I like to do if ext2load ide 0 80400000 $bootfile; then bootm; fi but the return value of ext2load is always false. Please consider to merge. Patch is attched. -------- Hiroshi Ito Media Lab. Inc., URL http://www.mlb.co.jp ( Sorry, Japanese only. ) TEL +81-3-5294-7255 FAX +81-3-5294-7256 diff --git a/fs/ext2/ext2fs.c b/fs/ext2/ext2fs.c index 9cf2fb7..069f8ae 100644 --- a/fs/ext2/ext2fs.c +++ b/fs/ext2/ext2fs.c @@ -769,7 +769,7 @@ int ext2fs_open (char *filename) { int len; if (ext2fs_root == NULL) { - return (-1); + return (0); } ext2fs_file = NULL; status = ext2fs_find_file (filename, &ext2fs_root->diropen, &fdiro, @@ -786,7 +786,7 @@ int ext2fs_open (char *filename) { } len = __le32_to_cpu (fdiro->inode.size); ext2fs_file = fdiro; - return (len); + return (0); fail: ext2fs_free_node (fdiro, &ext2fs_root->diropen);

1 1

[U-Boot-Users] [PATCH] Fix fsload loads wrong file.
by ito＠mlb.co.jp 04 Apr '06

04 Apr '06

Hello Command 'fsload' loads wrong file. Example # ls / ...<snip>... -rw-r--r-- 764267 uImage -rw-r--r-- 764267 uImage2 # fsload uImage2 will load uImage. Please consider to merge. Patch is attched. -------- Hiroshi Ito Media Lab. Inc., URL http://www.mlb.co.jp ( Sorry, Japanese only. ) TEL +81-3-5294-7255 FAX +81-3-5294-7256 diff --git a/fs/cramfs/cramfs.c b/fs/cramfs/cramfs.c index 48e7f63..ab5b889 100644 --- a/fs/cramfs/cramfs.c +++ b/fs/cramfs/cramfs.c @@ -97,6 +97,7 @@ static unsigned long cramfs_resolve (uns char *filename) { unsigned long inodeoffset = 0, nextoffset; + int fnamelen=filename?strlen(filename):0; while (inodeoffset < size) { struct cramfs_inode *inode; @@ -125,7 +126,8 @@ static unsigned long cramfs_resolve (uns namelen--; } - if (!strncmp (filename, name, namelen)) { + if (namelen == fnamelen && + !strncmp (filename, name, namelen)) { char *p = strtok (NULL, "/"); if (raw && (p == NULL || *p == '\0'))

1 0

[U-Boot-Users] [PATCH] Fix itest endianess problem
by ito＠mlb.co.jp 04 Apr '06

04 Apr '06

Hello Command 'itest' has 2 bugs. 1. It does not work on big endian machine. and itest.b may cause unaligned access. 2. itest.l does not work on mips CPU. on mips, result of (1 << 32) -1 is 0. (gcc 3.3.4 binutil 2.14.90.0.6 ) I think, In C language, shifting more than 32bit is undefined. Please consider to merge Patch is attched. -------- Hiroshi Ito Media Lab. Inc., URL http://www.mlb.co.jp ( Sorry, Japanese only. ) TEL +81-3-5294-7255 FAX +81-3-5294-7256 diff --git a/common/cmd_itest.c b/common/cmd_itest.c index 8ad134f..20dada9 100644 --- a/common/cmd_itest.c +++ b/common/cmd_itest.c @@ -70,17 +70,37 @@ extern int cmd_get_data_size(char* arg, static long evalexp(char *s, int w) { - long l, *p; - + long l; + void *p; + switch (w) { + case 1: /* if the parameter starts with a * then assume is a pointer to the value we want */ - if (s[0] == '*') { - p = (long *)simple_strtoul(&s[1], NULL, 16); - l = *p; - } else { - l = simple_strtoul(s, NULL, 16); + if (s[0] == '*') { + p = (void *)simple_strtoul(&s[1], NULL, 16); + l = *(unsigned char*)p; + } else { + l = simple_strtoul(s, NULL, 16) & 0xFF; + } + break; + case 2: + if (s[0] == '*') { + p = (void *)simple_strtoul(&s[1], NULL, 16); + l = *(unsigned short*)p; + } else { + l = simple_strtoul(s, NULL, 16) & 0xFFFF; + } + break; + case 4: + default: + if (s[0] == '*') { + p = (void *)simple_strtoul(&s[1], NULL, 16); + l = *(unsigned int*)p; + } else { + l = simple_strtoul(s, NULL, 16); + } + break; } - - return (l & ((1 << (w * 8)) - 1)); + return l; } static char * evalstr(char *s)

1 0